[{"id":24614,"web_url":"https://patchwork.libcamera.org/comment/24614/","msgid":"","date":"2022-08-16T19:26:46","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: use const reference\n\tfor range loops","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Tue, Aug 16, 2022 at 08:38:25PM +0200, Christian Rauch via libcamera-devel wrote:\n> A const reference prevents unnecessary copies of the loop elements.\n\nThis should also mention that PipelineHandlerUVC::processControls()\nswitches to structured bindings. With that,\n\nReviewed-by: Laurent Pinchart \n\nYou can propose an updated commit message in a reply to this e-mail,\nthere's no need to resubmit the series.\n\n> Signed-off-by: Christian Rauch \n> ---\n> src/libcamera/camera_manager.cpp | 2 +-\n> src/libcamera/device_enumerator.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +-----\n> src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 5 files changed, 5 insertions(+), 9 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 70d73822..7ff4bc6f 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera,\n> {\n> \tMutexLocker locker(mutex_);\n> \n> -\tfor (std::shared_ptr c : cameras_) {\n> +\tfor (const std::shared_ptr &c : cameras_) {\n> \t\tif (c->id() == camera->id()) {\n> \t\t\tLOG(Camera, Fatal)\n> \t\t\t\t<< \"Trying to register a camera with a duplicated ID '\"\n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index d1258050..f2e055de 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create()\n> \n> DeviceEnumerator::~DeviceEnumerator()\n> {\n> -\tfor (std::shared_ptr media : devices_) {\n> +\tfor (const std::shared_ptr &media : devices_) {\n> \t\tif (media->busy())\n> \t\t\tLOG(DeviceEnumerator, Error)\n> \t\t\t\t<< \"Removing media device \" << media->deviceNode()\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index fbe02cdc..9cbf126a 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -340,12 +340,8 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request)\n> {\n> \tControlList controls(data->video_->controls());\n> \n> -\tfor (auto it : request->controls()) {\n> -\t\tunsigned int id = it.first;\n> -\t\tControlValue &value = it.second;\n> -\n> +\tfor (const auto &[id, value] : request->controls())\n> \t\tprocessControl(&controls, id, value);\n> -\t}\n> \n> \tfor (const auto &ctrl : controls)\n> \t\tLOG(UVC, Debug)\n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 153cf849..d2f2e460 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request)\n> {\n> \tControlList controls(data->sensor_->controls());\n> \n> -\tfor (auto it : request->controls()) {\n> +\tfor (const auto &it : request->controls()) {\n> \t\tunsigned int id = it.first;\n> \t\tunsigned int offset;\n> \t\tuint32_t cid;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 7d2d00ef..e5cb751c 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -616,7 +616,7 @@ void PipelineHandler::disconnect()\n> \t */\n> \tstd::vector> cameras{ std::move(cameras_) };\n> \n> -\tfor (std::weak_ptr ptr : cameras) {\n> +\tfor (const std::weak_ptr &ptr : cameras) {\n> \t\tstd::shared_ptr camera = ptr.lock();\n> \t\tif (!camera)\n> \t\t\tcontinue;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1DE8FBE173\n\tfor ;\n\tTue, 16 Aug 2022 19:27:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC18061FC0;\n\tTue, 16 Aug 2022 21:27:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 368AB61FA9\n\tfor ;\n\tTue, 16 Aug 2022 21:27:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6B1425B;\n\tTue, 16 Aug 2022 21:26:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660678021;\n\tbh=aqwI+JDN1+CdyIrAf7h0YcEb4kuBwXdGyXY8uQomuRo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=nic0nidH5yaLZImcgjWQbUirddbvloQk3gpYsTLMkznhFHf08VwGekuvXTG9oB57d\n\tax62uJ1aSJSMTyjwQXHPEISG4KDfgsSp1WYYlFXIyi0GpI6bh96PRoIzbSWOK6EzIF\n\tzbDAMKsh6D06VQWxDSyn9u5ZnDtVvZH5HCNAl/laGU/Y0vy6O9U5rB2I/lpMHBBTrs\n\tk9z3v6Z7+mgEPYlANhG1Gi0z0YqPutE/Vrc2/vz1d7YeVBxEEI8LQgHQz1pekDuTbl\n\tiV8n7Nf/l6/WrNZaNBw5RgRYowPJ7Pz4rnCqXytiB/twA8V/Eu/kM/dZlqxKXNS3RP\n\tNngXNICFDbCug==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660678020;\n\tbh=aqwI+JDN1+CdyIrAf7h0YcEb4kuBwXdGyXY8uQomuRo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Y4GhsHeXwCte+xSvtBFKjOupYsx2g4elJ7MKQ8/rm07IPF4iSHAQsEc+zocdrg6M3\n\tyYgk2COV/7zL+grah4ZrlOUiSaiFydMC3hNvewnO+7e56QN7T/2UqXYhsjg6bsnpFd\n\trjQMcpmTv0yKXLpp7FkYMv5zPCaJ9UGXtYEp7T+4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Y4GhsHeX\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 22:26:46 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220816183826.102989-1-Rauch.Christian@gmx.de>\n\t<20220816183826.102989-2-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220816183826.102989-2-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: use const reference\n\tfor range loops","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24624,"web_url":"https://patchwork.libcamera.org/comment/24624/","msgid":"","date":"2022-08-17T18:54:16","subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: use const reference\n\tfor range loops","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Laurent,\n\nI am not sure how to update the commit message via email :-) So I will\njust paste the new commit message here:\n\n libcamera: use const reference for range loops\n\n\n\n A const reference prevents unnecessary copies of the loop elements.\nAlso,\n\n this changes looping over controls in\nPipelineHandlerUVC::processControls\n\n to structured bindings.\n\n\n\n Signed-off-by: Christian Rauch \n\n Reviewed-by: Laurent Pinchart \n\n\nBest,\nChristian\n\n\nAm 16.08.22 um 21:26 schrieb Laurent Pinchart:\n> Hi Christian,\n>\n> Thank you for the patch.\n>\n> On Tue, Aug 16, 2022 at 08:38:25PM +0200, Christian Rauch via libcamera-devel wrote:\n>> A const reference prevents unnecessary copies of the loop elements.\n>\n> This should also mention that PipelineHandlerUVC::processControls()\n> switches to structured bindings. With that,\n>\n> Reviewed-by: Laurent Pinchart \n>\n> You can propose an updated commit message in a reply to this e-mail,\n> there's no need to resubmit the series.\n>\n>> Signed-off-by: Christian Rauch \n>> ---\n>> src/libcamera/camera_manager.cpp | 2 +-\n>> src/libcamera/device_enumerator.cpp | 2 +-\n>> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +-----\n>> src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n>> src/libcamera/pipeline_handler.cpp | 2 +-\n>> 5 files changed, 5 insertions(+), 9 deletions(-)\n>>\n>> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n>> index 70d73822..7ff4bc6f 100644\n>> --- a/src/libcamera/camera_manager.cpp\n>> +++ b/src/libcamera/camera_manager.cpp\n>> @@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera,\n>> {\n>> \tMutexLocker locker(mutex_);\n>>\n>> -\tfor (std::shared_ptr c : cameras_) {\n>> +\tfor (const std::shared_ptr &c : cameras_) {\n>> \t\tif (c->id() == camera->id()) {\n>> \t\t\tLOG(Camera, Fatal)\n>> \t\t\t\t<< \"Trying to register a camera with a duplicated ID '\"\n>> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n>> index d1258050..f2e055de 100644\n>> --- a/src/libcamera/device_enumerator.cpp\n>> +++ b/src/libcamera/device_enumerator.cpp\n>> @@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create()\n>>\n>> DeviceEnumerator::~DeviceEnumerator()\n>> {\n>> -\tfor (std::shared_ptr media : devices_) {\n>> +\tfor (const std::shared_ptr &media : devices_) {\n>> \t\tif (media->busy())\n>> \t\t\tLOG(DeviceEnumerator, Error)\n>> \t\t\t\t<< \"Removing media device \" << media->deviceNode()\n>> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> index fbe02cdc..9cbf126a 100644\n>> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n>> @@ -340,12 +340,8 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request)\n>> {\n>> \tControlList controls(data->video_->controls());\n>>\n>> -\tfor (auto it : request->controls()) {\n>> -\t\tunsigned int id = it.first;\n>> -\t\tControlValue &value = it.second;\n>> -\n>> +\tfor (const auto &[id, value] : request->controls())\n>> \t\tprocessControl(&controls, id, value);\n>> -\t}\n>>\n>> \tfor (const auto &ctrl : controls)\n>> \t\tLOG(UVC, Debug)\n>> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n>> index 153cf849..d2f2e460 100644\n>> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n>> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n>> @@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request)\n>> {\n>> \tControlList controls(data->sensor_->controls());\n>>\n>> -\tfor (auto it : request->controls()) {\n>> +\tfor (const auto &it : request->controls()) {\n>> \t\tunsigned int id = it.first;\n>> \t\tunsigned int offset;\n>> \t\tuint32_t cid;\n>> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n>> index 7d2d00ef..e5cb751c 100644\n>> --- a/src/libcamera/pipeline_handler.cpp\n>> +++ b/src/libcamera/pipeline_handler.cpp\n>> @@ -616,7 +616,7 @@ void PipelineHandler::disconnect()\n>> \t */\n>> \tstd::vector> cameras{ std::move(cameras_) };\n>>\n>> -\tfor (std::weak_ptr ptr : cameras) {\n>> +\tfor (const std::weak_ptr &ptr : cameras) {\n>> \t\tstd::shared_ptr camera = ptr.lock();\n>> \t\tif (!camera)\n>> \t\t\tcontinue;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CA715BE173\n\tfor ;\n\tWed, 17 Aug 2022 18:54:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1CE6961FC0;\n\tWed, 17 Aug 2022 20:54:18 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3C21A61FA8\n\tfor ;\n\tWed, 17 Aug 2022 20:54:17 +0200 (CEST)","from [192.168.0.158] ([88.152.184.103]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1MtOGU-1nV2yE2uvm-00urBR for\n\t; Wed, 17 Aug 2022 20:54:16 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660762458;\n\tbh=zHDgIKBU8GYffqUqh7El9p0FEPIShbnWcUBpaZE6jzs=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=BSJfinHS3/1DbLOrOckdnHnvpIUj3Q9p3q3VQawqoL6RCWYSfhWwEPvefehkwL546\n\tVCE7qyAp/RFkQo1CWgNZULCGOFmxYWLoFkYult19T7EIbuxPHMQQID/3YfbmzcICOW\n\tGmCZguK9N6daVzMGgRxocvLoMJhFSvthjDXoHRmoTujhK53Xhf/APUlMO/iK7Q7h2V\n\tg7LvRENT5hh9MYLLbNE5LTeUHvIFVKwvglT/PDNXIF4f6jgHrZay0gwWY6EKESlNz/\n\tO3xua1Nwv0lr/LeHPoE5umwD2xMjv0EvCUC6m7NpkISc9SmLFXuIN5bJg3Ql97rlqk\n\tWb2nX5VTzWo+w==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1660762456;\n\tbh=zHDgIKBU8GYffqUqh7El9p0FEPIShbnWcUBpaZE6jzs=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=gg4b8+dbaQBv8yW/jkjtr7uk5M03hI1TfJ0AU96KKXY8pU7oaeHzH8VbXUBhrff/2\n\tJDv6ZHvLMkEyrJxQyKYj15ZCCkPHQjlqqfiBL9G/B2WgpgxU40kscf/bZpva0CvWuH\n\tp4FtCk9Td7Nhxz7DT9DuUiu0cXzQdvlJejtftkUo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"gg4b8+db\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Message-ID":"","Date":"Wed, 17 Aug 2022 20:54:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.11.0","Content-Language":"en-GB","To":"libcamera-devel@lists.libcamera.org","References":"<20220816183826.102989-1-Rauch.Christian@gmx.de>\n\t<20220816183826.102989-2-Rauch.Christian@gmx.de>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:03mAWhZKmfgUHdkUzyqgopC4b/oPChjUMBrYv8Oi632khWS+qN5\n\t7sKUv7x3peFsvcbA5tjhBy3Fz5h1YNlSoWTM4x7x3Ouc5w4P/b29+pFLzQU1triaRMOI+kf\n\txAdgkjwGVujVy3OBL+BhEh5GUJWYpwXe3Kzn7R25kdomFwQMYm5D4+MDglKycpztq26eegr\n\t2VOnVqQzEe68iFZi3p4nQ==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:PcS+t/50GE8=:/X62w679KCqxojO2kRYQvN\n\tXvf0i/TckAa+hTRFMul3RbtMbp77oZW37TtO2qVjaxNlE4q5TFaRHq6/KM+I0SafKrOboucga\n\tYHbx5zsm8PCSKDmvh/BJuOuZNPWZOi7wAOqHsekU1yZ0YqGDzv+qxb5wa+XdKQ5e+tMRIQWx0\n\tnMoJ74iCh/eW/GLh8rf/1yem3WTKZkOgBTE67nA4mP0jXjaM/4Y6LwI4n6Wf19R2ESNWMcwJb\n\th+x0OEte90oF+rvGbPfKOY5UynD83GV8GUsyewiCXlf8i25tM8Q54QBa5ZrNU1CUHOgzGn4+L\n\tT6g1yaROkLJ2mXRraatBU9vgCdAz5Io2Fgf7h1e6VGT5BFtAuIwrIT8BrF1uX7GA9lsJuCSxd\n\t4k5puaI5BaAC8Bhc+o30fckGE8xKBTwp0jLspG6MBNuL1Mp1Eqo7mFU+IbMZnNsmexcN/H0iC\n\tOwA+F7urnssl/yqEAJZK3Lh6ECW3n6Y4DvzaklL0FJgR9O7hmLHzME3d554OxSsVg9ZfCW5YK\n\tYkwzmZsAnCMaa4XokjkhlBCbRjuJJ5umCwBL+wRqKNpJ03FCC25mSjOcuMp6NbZn60V64td8b\n\tVL0VK0PIIF6LbLpdz9/brlVaCuS03poBsOgowAWi/AUaKNQ/jdviP7z+E+lC89xVBaclW68Rd\n\twISIiR6Et9cuIA8r8wf4p6B4AQ9XWgZJocsQx6+drwn/PzfaG/8xxwYxpFS+dlnsrGEqzD11E\n\th1uXxOP46vYl4t3iReXWVDYOIx3aXXsJ9JI5m3k2g/4uSw8C+LthNHoaeyi+/GVniOKRGkkTk\n\tDhSuXbVzDjrpBmqW92q5bbljtIp3tnsBU/t1VwMkUTF9LmOso2JPi1cnmdMIBiHZVz7cpObCb\n\tUlVO1zLJtR8n5wTsxqWE9+nBZm4nBn+Bv/OMGxMhWX6EORIgLVbuNiJN+DODd7zjxZJ9EKICk\n\tJGEkaYjz+LNZ4AI6fQL8ty0c1XidFF0NaP79MbireMvMygsdPMCUx6U2ldv6f7mYCP8znkgP6\n\te/JG6dHjVqCq9/JtxSRK3heriybCkeD5v2CWXqlM19Gbr6LiL4j5oyUFc4EAKot4EWy2TezM/\n\tHq24kEn5fOZa4b+JU5IzU1o1fQo3xavA2zgGNoAv27/TxyIN3Cw4mzYzA==","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] libcamera: use const reference\n\tfor range loops","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]