{"id":17138,"url":"https://patchwork.libcamera.org/api/patches/17138/?format=json","web_url":"https://patchwork.libcamera.org/patch/17138/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220816183826.102989-2-Rauch.Christian@gmx.de>","date":"2022-08-16T18:38:25","name":"[libcamera-devel,v2,2/3] libcamera: use const reference for range loops","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"e540401673557cd88840afd4bb8285725da3a1ff","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/?format=json","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17138/mbox/","series":[{"id":3420,"url":"https://patchwork.libcamera.org/api/series/3420/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3420","date":"2022-08-16T18:38:25","name":"[libcamera-devel,v2,1/3] libcamera: remove unused headers","version":2,"mbox":"https://patchwork.libcamera.org/series/3420/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17138/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17138/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88A13BE173\n\tfor ;\n\tTue, 16 Aug 2022 18:38:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A25B661FBC;\n\tTue, 16 Aug 2022 20:38:32 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.17.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4BEA561FA9\n\tfor ;\n\tTue, 16 Aug 2022 20:38:30 +0200 (CEST)","from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id 1MmULx-1nfa1E2uqv-00iRXd;\n\tTue, 16 Aug 2022 20:38:29 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660675112;\n\tbh=TKl/bH6hDjXvaDwaz5+NOoWJGJVITPeq61cwGw1bAlU=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=AMA79q89Bxx7PtBXz7+QB01qnCyc7cOIWKi11pbAxxjvSvBFu8vmDZam5IWIdRYEX\n\t19Ba+FnXRuYBlUITF+umQmXN/mHM5a5p/t73BR711nDzBLqMBDJO6/bZpRvaF2kWvM\n\tXTx4dfY4bzTugdXrEK+7uJGxXX8u97odxEUyiFm7rCKDXxEN2qXmkkOXgs6oU0i9sA\n\tUZVIlYrxADU8mURaDOO94TuLsncPjP6LGa79qzpkUo4OYR/AHOfDXOyIrFCncOAyvC\n\tX1Gj8Hot0fH019HBcKbkwQbDyJ1+Hrj6pKurZxJBxf7AMVzNkRf27TH2VxEDaYwnef\n\tQ8FhL0YGu86wQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1660675109;\n\tbh=TKl/bH6hDjXvaDwaz5+NOoWJGJVITPeq61cwGw1bAlU=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=MBJFn9iIS3jrFdz2004J9Y49TSi5vuzMydPrsVjUb/nEyTCkV8+G/kJFnMytwt6DJ\n\t963S4tYAHAgIHBIG/H30D1xHKgeYRaKs9DzOCakrYtNQ0RiainMs51nfVF7AqP2nWD\n\t+BR70RMOGdldecJXoaRbPBSc8KLZ73yVWdIbV8x8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"MBJFn9iI\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Aug 2022 20:38:25 +0200","Message-Id":"<20220816183826.102989-2-Rauch.Christian@gmx.de>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20220816183826.102989-1-Rauch.Christian@gmx.de>","References":"<20220816183826.102989-1-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:UAMPlQkLVOQThs0PcChzpRQDYlJqy0SYVSqaYAjYTs776ipCNbJ\n\t/1RdM33LA75h4ou0wS1J9dU+qPBmZ5ALWqiQkIlekuOQNAEont+9EODngJ7ED11p8yVgmex\n\tnNEp3h18dJa5StoA+QFXAb4EFZ5gziBDNvvNl9ag0lwnVHnuVWEixtvG2lMK94n9cKbtbC6\n\tF6d3dTTwpRWHFjs3mg+TA==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:h71FcNWhDjs=:HXxCVR0nEeph6fKsGr3apH\n\t6kE6yRbbltxz3RUxw2pjA0xZDMaoMmB4e/gNDPDdT3l7DvcIAg7lwyB/hTq/oyw/L+8GuWL58\n\t7w0wtJ5pOaT3c5E+OGULtrZ8KvAtmR4Vrecyd8LLP8EBW5HjlzWDDrPexG+vk+w1nvaJ1NRkI\n\tCo2HmkhLghRN7wmJY+qiTr6HGHFdSNjWcwQtulyY145H2UQ+Ipq1ZFexV0HGemgzkNuQpN7Vz\n\tUFbfS3x3Vq9vsFWPQmN8pcnRNwwTcfgi2tBQowMHzwVPeTCblDU2dvlyvoRzCWq5nuStAB6kV\n\tDVXqJyxa8LJvCjSw+6d1C/KRPrWlNWdzVAeDZZDfmvPJOgXuaFaK8JKLs6lgi+6hCs3tR7uW7\n\tsFnksdb7/n+W6i71ME3rtMU6bJED9WyXIlmL7TE9aSrZYkBbOG82PRFTtInYLpQK1KEM0vzZ2\n\tPzH3PwiXkqU3txELbj+c93dg8asdnLtgUVGfsWSHw3KVO28v8A7954orFEA3IWXscQKMcUUK8\n\tmOwAvp4OaKebruqWsiw+78XQOMYCvbx5/mXMuYB9BdblQ9+3ucD7XnclVmpzw/E0eg+UzKaLT\n\tcAUGzMpq0YLWSxPZJFPEdAyGV5VCXHX3n5kdKrU/mT5DEKQZqCEPAEweUwQZcKm+2uYh2HRUg\n\tDnOQsO5ISukisYRyLOesN3QcqNZ+makugHkuYxC+voK9vYVbGUx2/eyv4sRSmJYYw8UZibXNT\n\tHJ8c0UQXoKqjuA8/5+au4ZKsuHbSVO7a5Mf6S6hTM5MiLCDF3WFY/0thUfepi+sOLYd0oXv9G\n\tcuNIxdfO07AwxRlRGayQ8rO0PTEqe242M4qgBthHq49rzNvdyEX+SvtrmkWfrsuRWRqQqenCg\n\tNKJ3TA5adzCYXpbSw8XfXb9j5zDr5mZUWB+6xEMBNPHsCXHi03go+T4L3g02ZgBYlf4vsSbwz\n\t35gAF9eL+aXMrx7s3UdGrAgHOvueS5YYpb/+oaVCgWuWKLxYr14H8PTbnJJrR0BHRnwVZKwFz\n\tchEWq5YQWqxnzpWCL2DvAUCLV/mi36EKwJAzz/SPUU/UXcBoDVQV5Fm1EjZEMxQC4ZP5FBGlq\n\tts/i25g61DyKhpXKfHCipPea3DQy40BGWwdQ4QWq2q/iEUMOKvMwYymOA==","Subject":"[libcamera-devel] [PATCH v2 2/3] libcamera: use const reference for\n\trange loops","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A const reference prevents unnecessary copies of the loop elements.\n\nSigned-off-by: Christian Rauch \n---\n src/libcamera/camera_manager.cpp | 2 +-\n src/libcamera/device_enumerator.cpp | 2 +-\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 6 +-----\n src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n src/libcamera/pipeline_handler.cpp | 2 +-\n 5 files changed, 5 insertions(+), 9 deletions(-)\n\n--\n2.34.1","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 70d73822..7ff4bc6f 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera,\n {\n \tMutexLocker locker(mutex_);\n\n-\tfor (std::shared_ptr c : cameras_) {\n+\tfor (const std::shared_ptr &c : cameras_) {\n \t\tif (c->id() == camera->id()) {\n \t\t\tLOG(Camera, Fatal)\n \t\t\t\t<< \"Trying to register a camera with a duplicated ID '\"\ndiff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\nindex d1258050..f2e055de 100644\n--- a/src/libcamera/device_enumerator.cpp\n+++ b/src/libcamera/device_enumerator.cpp\n@@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create()\n\n DeviceEnumerator::~DeviceEnumerator()\n {\n-\tfor (std::shared_ptr media : devices_) {\n+\tfor (const std::shared_ptr &media : devices_) {\n \t\tif (media->busy())\n \t\t\tLOG(DeviceEnumerator, Error)\n \t\t\t\t<< \"Removing media device \" << media->deviceNode()\ndiff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex fbe02cdc..9cbf126a 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -340,12 +340,8 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request)\n {\n \tControlList controls(data->video_->controls());\n\n-\tfor (auto it : request->controls()) {\n-\t\tunsigned int id = it.first;\n-\t\tControlValue &value = it.second;\n-\n+\tfor (const auto &[id, value] : request->controls())\n \t\tprocessControl(&controls, id, value);\n-\t}\n\n \tfor (const auto &ctrl : controls)\n \t\tLOG(UVC, Debug)\ndiff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\nindex 153cf849..d2f2e460 100644\n--- a/src/libcamera/pipeline/vimc/vimc.cpp\n+++ b/src/libcamera/pipeline/vimc/vimc.cpp\n@@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request)\n {\n \tControlList controls(data->sensor_->controls());\n\n-\tfor (auto it : request->controls()) {\n+\tfor (const auto &it : request->controls()) {\n \t\tunsigned int id = it.first;\n \t\tunsigned int offset;\n \t\tuint32_t cid;\ndiff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex 7d2d00ef..e5cb751c 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -616,7 +616,7 @@ void PipelineHandler::disconnect()\n \t */\n \tstd::vector> cameras{ std::move(cameras_) };\n\n-\tfor (std::weak_ptr ptr : cameras) {\n+\tfor (const std::weak_ptr &ptr : cameras) {\n \t\tstd::shared_ptr camera = ptr.lock();\n \t\tif (!camera)\n \t\t\tcontinue;\n","prefixes":["libcamera-devel","v2","2/3"]}