[{"id":24641,"web_url":"https://patchwork.libcamera.org/comment/24641/","msgid":"<20220818131803.GK2412817@pyrite.rasen.tech>","date":"2022-08-18T13:18:03","subject":"Re: [libcamera-devel] [PATCH v4 8/9] ipa: rkisp1: Add enable field\n\tfor LSC algorithm in IPA context","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Tue, Aug 16, 2022 at 04:54:13AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> From: Florian Sylvestre \n> \n> Add an enable variable in the lsc struct in IPASessionConfiguration which\n> indicates if the lsc algorithm has been configured. This will allow other\n> algorithms to retrieve this information.\n> \n> Signed-off-by: Florian Sylvestre \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Laurent Pinchart \n> Reviewed-by: Umang Jain \n> ---\n> Changes since v1:\n> \n> - Improve documentation\n> ---\n> src/ipa/rkisp1/algorithms/lsc.cpp | 10 ++++++++++\n> src/ipa/rkisp1/algorithms/lsc.h | 1 +\n> src/ipa/rkisp1/ipa_context.cpp | 8 ++++++++\n> src/ipa/rkisp1/ipa_context.h | 4 ++++\n> 4 files changed, 23 insertions(+)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> index 05c8c0dab5c8..da287ac7af75 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> @@ -119,6 +119,16 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> \treturn 0;\n> }\n> \n> +/**\n> + * \\copydoc libcamera::ipa::Algorithm::configure\n> + */\n> +int LensShadingCorrection::configure(IPAContext &context,\n> +\t\t\t\t [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> +{\n> +\tcontext.configuration.lsc.enabled = initialized_;\n> +\treturn 0;\n> +}\n> +\n> /**\n> * \\copydoc libcamera::ipa::Algorithm::prepare\n> */\n> diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> index fdb2ec1dd27d..f68602c005c4 100644\n> --- a/src/ipa/rkisp1/algorithms/lsc.h\n> +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> @@ -20,6 +20,7 @@ public:\n> \t~LensShadingCorrection() = default;\n> \n> \tint init(IPAContext &context, const YamlObject &tuningData) override;\n> +\tint configure(IPAContext &context, const IPACameraSensorInfo &configInfo) override;\n> \tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n> \n> private:\n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index 23a63f8c6e25..1a549c092d73 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -92,6 +92,14 @@ namespace libcamera::ipa::rkisp1 {\n> * \\brief Indicates if the AWB hardware is enabled to apply colour gains\n> */\n> \n> +/**\n> + * \\var IPASessionConfiguration::lsc\n> + * \\brief Lens Shading Correction configuration of the IPA\n> + *\n> + * \\var IPASessionConfiguration::lsc.enabled\n> + * \\brief Indicates if the LSC hardware is enabled\n\nimo this doesn't match the intent that's described in the changelog:\n\n\"Add an enable variable which indicates if the lsc algorithm has been configured\"\n\n\nPaul\n\n\n> + */\n> +\n> /**\n> * \\var IPASessionConfiguration::sensor\n> * \\brief Sensor-specific configuration of the IPA\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 7f7b3e4d88fa..0cd6aadb83ed 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -32,6 +32,10 @@ struct IPASessionConfiguration {\n> \t\tbool enabled;\n> \t} awb;\n> \n> +\tstruct {\n> +\t\tbool enabled;\n> +\t} lsc;\n> +\n> \tstruct {\n> \t\tutils::Duration lineDuration;\n> \t\tSize size;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CF8ADC3272\n\tfor ;\n\tThu, 18 Aug 2022 13:18:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 30A0261FC0;\n\tThu, 18 Aug 2022 15:18:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 871A561FA7\n\tfor ;\n\tThu, 18 Aug 2022 15:18:10 +0200 (CEST)","from pyrite.rasen.tech (KD027085204050.au-net.ne.jp [27.85.204.50])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 033FB8B;\n\tThu, 18 Aug 2022 15:18:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660828692;\n\tbh=m/sZToOk75CbbB4f826yQF0X5wO8JMKXYz2RkqC4mxU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ARLjTtzPq9GVgJCNlmN4nVHsz3Ldfe0tA1OIj077LcE0WZ5UH06va2DtyZpWkx4o1\n\t/+Wz237nn9kSQQF1YWa7eoPIeFE073BE5pxoQcT+mA4/YIunrkdgH9zvAgU21CiwW/\n\tHs/XiJ9IVrd2znLys6kuz0++s29YQjrKE1T6ABEqgFkQH5qVCh9k+8948Pe3c4PTOX\n\tfigg5B1pt7+vmVFYiQiM27mTufXRPiLtdouGpMlPwoxV8uaAHbndRPq4XJK2CHopmn\n\tLoJuVu1ek4634TxYe8h6Hym2SeQdieXnrdVtKcqEWQmcZYPklX3ng1fdtycHF+O5KO\n\tCzhwJstmbc8jg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660828690;\n\tbh=m/sZToOk75CbbB4f826yQF0X5wO8JMKXYz2RkqC4mxU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=G/nTXDummSlXsgNcv+Q/ypYLzsEfsRL042d3YZRpbykMjuJk/SIkrP1D7Mf5QPXXz\n\tVKlDGP7dibcsj4ty8n2oRCcpk40n2iwgR9X96C/ul5IpQGacoG3HlQvaBCLzwjwSWR\n\tw5E9JARwMGO3fksx85WwGiJF+CuNu7P3DiP7Anac="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"G/nTXDum\"; dkim-atps=neutral","Date":"Thu, 18 Aug 2022 22:18:03 +0900","To":"Laurent Pinchart ","Message-ID":"<20220818131803.GK2412817@pyrite.rasen.tech>","References":"<20220816015414.7462-1-laurent.pinchart@ideasonboard.com>\n\t<20220816015414.7462-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220816015414.7462-9-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH v4 8/9] ipa: rkisp1: Add enable field\n\tfor LSC algorithm in IPA context","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24679,"web_url":"https://patchwork.libcamera.org/comment/24679/","msgid":"","date":"2022-08-18T17:51:49","subject":"Re: [libcamera-devel] [PATCH v4 8/9] ipa: rkisp1: Add enable field\n\tfor LSC algorithm in IPA context","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nOn Thu, Aug 18, 2022 at 10:18:03PM +0900, paul.elder@ideasonboard.com wrote:\n> On Tue, Aug 16, 2022 at 04:54:13AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > From: Florian Sylvestre \n> > \n> > Add an enable variable in the lsc struct in IPASessionConfiguration which\n> > indicates if the lsc algorithm has been configured. This will allow other\n> > algorithms to retrieve this information.\n> > \n> > Signed-off-by: Florian Sylvestre \n> > Reviewed-by: Laurent Pinchart \n> > Signed-off-by: Laurent Pinchart \n> > Reviewed-by: Umang Jain \n> > ---\n> > Changes since v1:\n> > \n> > - Improve documentation\n> > ---\n> > src/ipa/rkisp1/algorithms/lsc.cpp | 10 ++++++++++\n> > src/ipa/rkisp1/algorithms/lsc.h | 1 +\n> > src/ipa/rkisp1/ipa_context.cpp | 8 ++++++++\n> > src/ipa/rkisp1/ipa_context.h | 4 ++++\n> > 4 files changed, 23 insertions(+)\n> > \n> > diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > index 05c8c0dab5c8..da287ac7af75 100644\n> > --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> > +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > @@ -119,6 +119,16 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> > \treturn 0;\n> > }\n> > \n> > +/**\n> > + * \\copydoc libcamera::ipa::Algorithm::configure\n> > + */\n> > +int LensShadingCorrection::configure(IPAContext &context,\n> > +\t\t\t\t [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> > +{\n> > +\tcontext.configuration.lsc.enabled = initialized_;\n> > +\treturn 0;\n> > +}\n> > +\n> > /**\n> > * \\copydoc libcamera::ipa::Algorithm::prepare\n> > */\n> > diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> > index fdb2ec1dd27d..f68602c005c4 100644\n> > --- a/src/ipa/rkisp1/algorithms/lsc.h\n> > +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> > @@ -20,6 +20,7 @@ public:\n> > \t~LensShadingCorrection() = default;\n> > \n> > \tint init(IPAContext &context, const YamlObject &tuningData) override;\n> > +\tint configure(IPAContext &context, const IPACameraSensorInfo &configInfo) override;\n> > \tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n> > \n> > private:\n> > diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> > index 23a63f8c6e25..1a549c092d73 100644\n> > --- a/src/ipa/rkisp1/ipa_context.cpp\n> > +++ b/src/ipa/rkisp1/ipa_context.cpp\n> > @@ -92,6 +92,14 @@ namespace libcamera::ipa::rkisp1 {\n> > * \\brief Indicates if the AWB hardware is enabled to apply colour gains\n> > */\n> > \n> > +/**\n> > + * \\var IPASessionConfiguration::lsc\n> > + * \\brief Lens Shading Correction configuration of the IPA\n> > + *\n> > + * \\var IPASessionConfiguration::lsc.enabled\n> > + * \\brief Indicates if the LSC hardware is enabled\n> \n> imo this doesn't match the intent that's described in the changelog:\n> \n> \"Add an enable variable which indicates if the lsc algorithm has been configured\"\n\nI'll update the commit message to \"[...] indicates if the LSC hardware\nmodule is enabled\".\n\n> > + */\n> > +\n> > /**\n> > * \\var IPASessionConfiguration::sensor\n> > * \\brief Sensor-specific configuration of the IPA\n> > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> > index 7f7b3e4d88fa..0cd6aadb83ed 100644\n> > --- a/src/ipa/rkisp1/ipa_context.h\n> > +++ b/src/ipa/rkisp1/ipa_context.h\n> > @@ -32,6 +32,10 @@ struct IPASessionConfiguration {\n> > \t\tbool enabled;\n> > \t} awb;\n> > \n> > +\tstruct {\n> > +\t\tbool enabled;\n> > +\t} lsc;\n> > +\n> > \tstruct {\n> > \t\tutils::Duration lineDuration;\n> > \t\tSize size;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3DFDDBE173\n\tfor ;\n\tThu, 18 Aug 2022 17:51:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BB8A061FC0;\n\tThu, 18 Aug 2022 19:51:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BD3EF61FA7\n\tfor ;\n\tThu, 18 Aug 2022 19:51:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E6FE8B;\n\tThu, 18 Aug 2022 19:51:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660845114;\n\tbh=BXbSect7Aya8O30rHkc/kP+e1TAUhtalgBvL1XYrfek=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Sh0vsOrk73R7iBs72B4o1wyB12x/32IBB7S4QeBNNaJItOEoZIb08iMxcls1TE9QM\n\tWk/IlOCi/ImI2c8obVi9Grk5B5HxFsNffSLKgDb7UkUyjBZJNJb8x0nmQStmHSyVvp\n\tmNYGGcmQsKK7XALyisOSUQ3yTlTQ0C+3mnbE6ijy49Pf9tBXtxpkXPEHOhgnkkQ0rq\n\t4yoGWSEbC4SEfiS8xBk5HYABOb8U2rnvakFGh30olw/ZoWB2GCF647N7HMEDRASm74\n\t7v1oAkV6sGWfaAu82+vWrqXTy6G53y9rmGh9ZbbGcmFL0bnLU3+5WxjlnE4Qa/+nTT\n\tEudreOVoy852w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660845112;\n\tbh=BXbSect7Aya8O30rHkc/kP+e1TAUhtalgBvL1XYrfek=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=LeYsxHVubnqaHcoD1geQgs9Raw/H5BFXWWsoL+d3SpuDiY3eie/poXRQn9P7jtf65\n\tcuihf4OEgzb1RpcRcej1WvNcT0qiOhpDArcxF/tXEo20e1qP0qBH1d2UJILqjAVJbx\n\twmht4yBIORUZDpvwxYGr3YsMoXG8dsl2CM4JCBho="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"LeYsxHVu\"; dkim-atps=neutral","Date":"Thu, 18 Aug 2022 20:51:49 +0300","To":"paul.elder@ideasonboard.com","Message-ID":"","References":"<20220816015414.7462-1-laurent.pinchart@ideasonboard.com>\n\t<20220816015414.7462-9-laurent.pinchart@ideasonboard.com>\n\t<20220818131803.GK2412817@pyrite.rasen.tech>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220818131803.GK2412817@pyrite.rasen.tech>","Subject":"Re: [libcamera-devel] [PATCH v4 8/9] ipa: rkisp1: Add enable field\n\tfor LSC algorithm in IPA context","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24719,"web_url":"https://patchwork.libcamera.org/comment/24719/","msgid":"<20220821101209.GD34241@pyrite.rasen.tech>","date":"2022-08-21T10:12:09","subject":"Re: [libcamera-devel] [PATCH v4 8/9] ipa: rkisp1: Add enable field\n\tfor LSC algorithm in IPA context","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"Hi Laurent,\n\nOn Thu, Aug 18, 2022 at 08:51:49PM +0300, Laurent Pinchart wrote:\n> Hi Paul,\n> \n> On Thu, Aug 18, 2022 at 10:18:03PM +0900, paul.elder@ideasonboard.com wrote:\n> > On Tue, Aug 16, 2022 at 04:54:13AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > > From: Florian Sylvestre \n> > > \n> > > Add an enable variable in the lsc struct in IPASessionConfiguration which\n> > > indicates if the lsc algorithm has been configured. This will allow other\n> > > algorithms to retrieve this information.\n> > > \n> > > Signed-off-by: Florian Sylvestre \n> > > Reviewed-by: Laurent Pinchart \n> > > Signed-off-by: Laurent Pinchart \n> > > Reviewed-by: Umang Jain \n> > > ---\n> > > Changes since v1:\n> > > \n> > > - Improve documentation\n> > > ---\n> > > src/ipa/rkisp1/algorithms/lsc.cpp | 10 ++++++++++\n> > > src/ipa/rkisp1/algorithms/lsc.h | 1 +\n> > > src/ipa/rkisp1/ipa_context.cpp | 8 ++++++++\n> > > src/ipa/rkisp1/ipa_context.h | 4 ++++\n> > > 4 files changed, 23 insertions(+)\n> > > \n> > > diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > > index 05c8c0dab5c8..da287ac7af75 100644\n> > > --- a/src/ipa/rkisp1/algorithms/lsc.cpp\n> > > +++ b/src/ipa/rkisp1/algorithms/lsc.cpp\n> > > @@ -119,6 +119,16 @@ int LensShadingCorrection::init([[maybe_unused]] IPAContext &context,\n> > > \treturn 0;\n> > > }\n> > > \n> > > +/**\n> > > + * \\copydoc libcamera::ipa::Algorithm::configure\n> > > + */\n> > > +int LensShadingCorrection::configure(IPAContext &context,\n> > > +\t\t\t\t [[maybe_unused]] const IPACameraSensorInfo &configInfo)\n> > > +{\n> > > +\tcontext.configuration.lsc.enabled = initialized_;\n> > > +\treturn 0;\n> > > +}\n> > > +\n> > > /**\n> > > * \\copydoc libcamera::ipa::Algorithm::prepare\n> > > */\n> > > diff --git a/src/ipa/rkisp1/algorithms/lsc.h b/src/ipa/rkisp1/algorithms/lsc.h\n> > > index fdb2ec1dd27d..f68602c005c4 100644\n> > > --- a/src/ipa/rkisp1/algorithms/lsc.h\n> > > +++ b/src/ipa/rkisp1/algorithms/lsc.h\n> > > @@ -20,6 +20,7 @@ public:\n> > > \t~LensShadingCorrection() = default;\n> > > \n> > > \tint init(IPAContext &context, const YamlObject &tuningData) override;\n> > > +\tint configure(IPAContext &context, const IPACameraSensorInfo &configInfo) override;\n> > > \tvoid prepare(IPAContext &context, rkisp1_params_cfg *params) override;\n> > > \n> > > private:\n> > > diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> > > index 23a63f8c6e25..1a549c092d73 100644\n> > > --- a/src/ipa/rkisp1/ipa_context.cpp\n> > > +++ b/src/ipa/rkisp1/ipa_context.cpp\n> > > @@ -92,6 +92,14 @@ namespace libcamera::ipa::rkisp1 {\n> > > * \\brief Indicates if the AWB hardware is enabled to apply colour gains\n> > > */\n> > > \n> > > +/**\n> > > + * \\var IPASessionConfiguration::lsc\n> > > + * \\brief Lens Shading Correction configuration of the IPA\n> > > + *\n> > > + * \\var IPASessionConfiguration::lsc.enabled\n> > > + * \\brief Indicates if the LSC hardware is enabled\n> > \n> > imo this doesn't match the intent that's described in the changelog:\n> > \n> > \"Add an enable variable which indicates if the lsc algorithm has been configured\"\n> \n> I'll update the commit message to \"[...] indicates if the LSC hardware\n> module is enabled\".\n\nSounds good.\n\nReviewed-by: Paul Elder \n\n> \n> > > + */\n> > > +\n> > > /**\n> > > * \\var IPASessionConfiguration::sensor\n> > > * \\brief Sensor-specific configuration of the IPA\n> > > diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> > > index 7f7b3e4d88fa..0cd6aadb83ed 100644\n> > > --- a/src/ipa/rkisp1/ipa_context.h\n> > > +++ b/src/ipa/rkisp1/ipa_context.h\n> > > @@ -32,6 +32,10 @@ struct IPASessionConfiguration {\n> > > \t\tbool enabled;\n> > > \t} awb;\n> > > \n> > > +\tstruct {\n> > > +\t\tbool enabled;\n> > > +\t} lsc;\n> > > +\n> > > \tstruct {\n> > > \t\tutils::Duration lineDuration;\n> > > \t\tSize size;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4DF49BE173\n\tfor ;\n\tSun, 21 Aug 2022 10:12:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 930B561FC0;\n\tSun, 21 Aug 2022 12:12:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F85C61FA3\n\tfor ;\n\tSun, 21 Aug 2022 12:12:17 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D4AD73F1;\n\tSun, 21 Aug 2022 12:12:15 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661076739;\n\tbh=qQD4+EnhSGeSxKpH8LQS6HkZGVeZxbxfHGNSjFH2zNM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Y+AOjcNcjANyqdBGj+kfqNdqC9ZazJZcUF3OFlRymxB0gyqOoSPw6zUGBjJ4XVN32\n\t3Z4AJangqpdH5mLAERAWnzJIKYnDIljv02FSQmv83cXpa1EUkwGaGiVz/7Xz+y1w4s\n\to+G+sXuksgSdO7fLsXzAyDRMGRYjKHdNLfDqL7uUJbBr/P+Z5qdHRQKipEswPvG7OA\n\tjyvqijGTPe6QD1fNbL9huSt/N/Z+Iy7+QO/EuDrejWJJ59dxPpeqqxUfHmemSwBrR9\n\tr8EUXgLIN2i/RqAMsxF751SG4vMHXwuapntM2jvQ1m7kie5qGfPSJr5QegdfnULq3M\n\t0r7e4J6eWCGRQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1661076737;\n\tbh=qQD4+EnhSGeSxKpH8LQS6HkZGVeZxbxfHGNSjFH2zNM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gaW+QO/3HntRguzqhYrqFJJxS1HKArjSUgclaevnTptz33XTzrSm0nG4LTNHruPm1\n\tz2mwbl67sTYTzb7MtMeVAfAUtbI33OMwjITfX7qR35VfwpnhAzt7ATi37eWqQPzPhm\n\tMI7WTRyy7xuaBnOkSYeAylRh3RVsNU7GXL7nf+Dg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gaW+QO/3\"; dkim-atps=neutral","Date":"Sun, 21 Aug 2022 19:12:09 +0900","To":"Laurent Pinchart ","Message-ID":"<20220821101209.GD34241@pyrite.rasen.tech>","References":"<20220816015414.7462-1-laurent.pinchart@ideasonboard.com>\n\t<20220816015414.7462-9-laurent.pinchart@ideasonboard.com>\n\t<20220818131803.GK2412817@pyrite.rasen.tech>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH v4 8/9] ipa: rkisp1: Add enable field\n\tfor LSC algorithm in IPA context","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]