[{"id":24839,"web_url":"https://patchwork.libcamera.org/comment/24839/","msgid":"<CAEmqJPqOUZ-V9AYaUm3TycoJ8stD97O5U+bVwTAAneKvz9C=HQ@mail.gmail.com>","date":"2022-08-30T11:44:06","subject":"Re: [libcamera-devel] [PATCH 1/1] pipeline: raspberrypi: Detect\n\tmonochrome \"R\" formats as being raw","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\nThank you for your work.\n\nOn Mon, 15 Aug 2022 at 15:16, David Plowman via libcamera-devel <\nlibcamera-devel@lists.libcamera.org> wrote:\n\n> The \"R\" pixel formats (R8, R10, R10_CSI2P etc.) record the associated\n> colour space as being YUV rather than RAW, meaning that the code was\n> not detecting them as being raw formats.\n>\n> In the case of Raspberry Pi, we deal only with raw formats, so the\n> revised test must work correctly for both these and the standard Bayer\n> formats.\n>\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n>\n\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\n\n\n> ---\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 14 ++------------\n>  1 file changed, 2 insertions(+), 12 deletions(-)\n>\n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index e895584d..fae8e45e 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -105,18 +105,8 @@ V4L2DeviceFormat toV4L2DeviceFormat(const\n> V4L2VideoDevice *dev,\n>\n>  bool isRaw(const PixelFormat &pixFmt)\n>  {\n> -       /*\n> -        * The isRaw test might be redundant right now the pipeline\n> handler only\n> -        * supports RAW sensors. Leave it in for now, just as a sanity\n> check.\n> -        */\n> -       if (!pixFmt.isValid())\n> -               return false;\n> -\n> -       const PixelFormatInfo &info = PixelFormatInfo::info(pixFmt);\n> -       if (!info.isValid())\n> -               return false;\n> -\n> -       return info.colourEncoding == PixelFormatInfo::ColourEncodingRAW;\n> +       /* This test works for both Bayer and raw mono formats. */\n> +       return BayerFormat::fromPixelFormat(pixFmt).isValid();\n>  }\n>\n>  double scoreFormat(double desired, double actual)\n> --\n> 2.30.2\n>\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2F4ECC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Aug 2022 11:44:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5822461FBD;\n\tTue, 30 Aug 2022 13:44:28 +0200 (CEST)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D643961F9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Aug 2022 13:44:25 +0200 (CEST)","by mail-lf1-x133.google.com with SMTP id bt10so15147657lfb.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Aug 2022 04:44:25 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661859868;\n\tbh=iEyY1yysaZVU47gLiqrpDlzq+e4xAFZKfDO5rZe0Xp4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=1qd10p9O/T9QCsTbFD4qCA9/6MSL5cryf3gwnrc05zX+DtMJbnP5Gt81uKIqNALkK\n\t8adQBroTNF8KFp8oFJv3az8PsFbI00eTbMVDj6ye3vY1+MvydR7GVwbWyCJ6W01m5r\n\t8RiaYLG0JpvRCzlaF/kEAbOnqctu3d56QIjJykEGwSM30x1lhmGzKpOwK3XhmzrtWv\n\tt9Rzp+HKnC70NJgQs62hALWzxI2O04f2x2QP/Xr1yamNFwtJpjDstQWP6kfUvIf3sj\n\ttSszWKjFITHY4HOP/yQot+jPtwoY3xfjoH52QFqA99gW6MbSRu9Wb110Pd0clkyAsM\n\t78ViFzNz+remA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc;\n\tbh=ELs9ckMxybPpHcLN/qRI31QuXgoPvJEGHNXLtWNJAew=;\n\tb=MFnLzJ2GDNFVEo6aWmSse+AXyrisffAnpd1zud1BTwc7Bjy6WK212n6wqxWJ3+EUOb\n\t8o3aQzBKFGHhdO8g9wws7z0AArEIrh7qTq8nEE1NvrSG6wFoQ/fyOVG5DDPMaLwHIb/o\n\tBtSjwJ2N0lIp5tKF/GvdlLtafkluJq/rZQRg0wtr3srrmNlMqjX1QK8hWAUUWZQkuKXq\n\tIHxvy6FwrdfNlkmUTT1yuG5NPAS0GA3te/3Ghs56T2n6IbVxAJu4RqGOd3MmQFsk+GUW\n\tWpatvjFBrZoyKiu/HNXKbVoorwmrA2gh1vqVAfNVQJTBtHmBWumR2Uteve3SaxGH24M+\n\tU7dw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"MFnLzJ2G\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc;\n\tbh=ELs9ckMxybPpHcLN/qRI31QuXgoPvJEGHNXLtWNJAew=;\n\tb=YX3WolpPE0Yh00PZZJgWL+fS2zciMF02zHZNxmUNNMBUDx3DwIszZgcvcEcRnL5tJ0\n\tSL07TfeS/GK+h2U7Sj+5Llpvjn8hLv9U+h3do5rsEO2MBfi46csvcIKppjDUU/DzOwEY\n\t0MKl0OExeJ96ljQkeL6mKuKhGEW9qUliuj5kwYBygfgzMX7hwzvaYsVI9TR60HQz7HyQ\n\tUIQPo4EsdJ+xKz8LY32n29/fI4sM2XgvAoPTZ8pcChE0k4PK+RiLaHNA2gzsVHTypRL9\n\tJwT9a0413xseUziMP9AtCJqF7ILy2W9RScUpVTk4loSGXu646bS0M/3JZS1wr7eFv0mO\n\tKaTQ==","X-Gm-Message-State":"ACgBeo2JMue+W0jFEyTvzH52DNR2iYZ3rZzq7ucRekd55cLq9tocRCZO\n\t6/bIiG1cFF9V/txsbgofLOVGLKGM7ATMVO/E9cghIw==","X-Google-Smtp-Source":"AA6agR5dzmhffBoXQKaxTZJxBLo3uFdKRr2XByeQZbasXDDxxJ596XyhMRDU8jxo32cAzkrN5bIzwhd1CiGXmLEQ+kY=","X-Received":"by 2002:ac2:4645:0:b0:494:6e87:3c88 with SMTP id\n\ts5-20020ac24645000000b004946e873c88mr2207300lfo.682.1661859864789;\n\tTue, 30 Aug 2022 04:44:24 -0700 (PDT)","MIME-Version":"1.0","References":"<20220815141637.4159-1-david.plowman@raspberrypi.com>\n\t<20220815141637.4159-2-david.plowman@raspberrypi.com>","In-Reply-To":"<20220815141637.4159-2-david.plowman@raspberrypi.com>","Date":"Tue, 30 Aug 2022 12:44:06 +0100","Message-ID":"<CAEmqJPqOUZ-V9AYaUm3TycoJ8stD97O5U+bVwTAAneKvz9C=HQ@mail.gmail.com>","To":"David Plowman <david.plowman@raspberrypi.com>","Content-Type":"multipart/alternative; boundary=\"000000000000e85d9205e773e650\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] pipeline: raspberrypi: Detect\n\tmonochrome \"R\" formats as being raw","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25257,"web_url":"https://patchwork.libcamera.org/comment/25257/","msgid":"<CAHW6GY+ZwrwXBYbRUHd7Gf_kr-dEiEXsGvj81_LwqN5YDszf3Q@mail.gmail.com>","date":"2022-10-04T11:44:42","subject":"Re: [libcamera-devel] [PATCH 1/1] pipeline: raspberrypi: Detect\n\tmonochrome \"R\" formats as being raw","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"content":"Hi\n\nJust wanted to remind everyone about this patch, could we progress it\nso that it can be merged?\n\nThanks\nDavid\n\nOn Tue, 30 Aug 2022 at 12:44, Naushir Patuck <naush@raspberrypi.com> wrote:\n>\n> Hi David,\n>\n> Thank you for your work.\n>\n> On Mon, 15 Aug 2022 at 15:16, David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org> wrote:\n>>\n>> The \"R\" pixel formats (R8, R10, R10_CSI2P etc.) record the associated\n>> colour space as being YUV rather than RAW, meaning that the code was\n>> not detecting them as being raw formats.\n>>\n>> In the case of Raspberry Pi, we deal only with raw formats, so the\n>> revised test must work correctly for both these and the standard Bayer\n>> formats.\n>>\n>> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n>\n>\n> Reviewed-by: Naushir Patuck <naush@raspberrypi.com>\n>\n>>\n>> ---\n>>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 14 ++------------\n>>  1 file changed, 2 insertions(+), 12 deletions(-)\n>>\n>> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>> index e895584d..fae8e45e 100644\n>> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n>> @@ -105,18 +105,8 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2VideoDevice *dev,\n>>\n>>  bool isRaw(const PixelFormat &pixFmt)\n>>  {\n>> -       /*\n>> -        * The isRaw test might be redundant right now the pipeline handler only\n>> -        * supports RAW sensors. Leave it in for now, just as a sanity check.\n>> -        */\n>> -       if (!pixFmt.isValid())\n>> -               return false;\n>> -\n>> -       const PixelFormatInfo &info = PixelFormatInfo::info(pixFmt);\n>> -       if (!info.isValid())\n>> -               return false;\n>> -\n>> -       return info.colourEncoding == PixelFormatInfo::ColourEncodingRAW;\n>> +       /* This test works for both Bayer and raw mono formats. */\n>> +       return BayerFormat::fromPixelFormat(pixFmt).isValid();\n>>  }\n>>\n>>  double scoreFormat(double desired, double actual)\n>> --\n>> 2.30.2\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A017EC0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Oct 2022 11:44:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 05A5960AA4;\n\tTue,  4 Oct 2022 13:44:57 +0200 (CEST)","from mail-pl1-x631.google.com (mail-pl1-x631.google.com\n\t[IPv6:2607:f8b0:4864:20::631])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9EDB0601C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Oct 2022 13:44:55 +0200 (CEST)","by mail-pl1-x631.google.com with SMTP id f21so4597157plb.13\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 04 Oct 2022 04:44:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664883897;\n\tbh=+mXOvKnzTI/sAK97jk1hm9Wv+T2GmNtsDNvA23G3Wek=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=KgUUhmTmkTlSoH4mkIgb5BfLoODguHyLBe0BFiOnLTgpkALAujXJYVtP/03uX3sce\n\t0GuwMDsLiu1bQ2L+DTb3XQDfMLjRx18j5iqK2i8ZBU0h3XpkJV+HpqP8C91oi5MoiW\n\tFK0mMV0HN3WM/oDK7JjWTo+yIm8AjEkP2j8ElfYODRdd+sr5VbTk1Wl+i/96nIlLcX\n\tsVd6pBpFH5rXSVJ6xec4V1r/Z0HKBoeW2n0j7D4z/VSk45NKfGVYOPndco2S+MImRO\n\tTFHeKC4utpTK4hmwG6T7mx/jq0vJDWlK7RZa0zqxrj1edwUopF2O0BqOnfVzcE/F9E\n\ty/QxoWNffjBAQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:from:to:cc:subject:date;\n\tbh=5V1K+3ftX+Dhp1wxQxX2kuV0Vr4jQTuvCkpl/pewdlo=;\n\tb=Iu4wNAJzfowigL0vR7GWGwXZgFQH3/tmu8/YNfrEyOQM4jdAaU2Rjne20+3FMSpRuu\n\tsuVpqCml61wljXDZNe9MQGXBYkbZySYxJK84gWvxKFURRUCi9eQ+rmythAe1wnoW2M6x\n\tNBDU4HESmNzOS7tHB8JeemrYndtBLbj+TLr1sCNV9Y30LneRg7BCBCBeJXLc+Z9oVK9T\n\tlUSNDUm+2cHB8w8fh5Z/kNnN97N+h8Xhfhfe74C0fQoXxcBYUt2/ZzeHi83NqDp34++5\n\tT1d3yaffikggyt9LtO//4PaXD9mfuSFM/Wv3lEEJ0PA85pDHygew7/DwCju4RjTFEiRT\n\t+wlg=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Iu4wNAJz\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=to:subject:message-id:date:from:in-reply-to:references:mime-version\n\t:x-gm-message-state:from:to:cc:subject:date;\n\tbh=5V1K+3ftX+Dhp1wxQxX2kuV0Vr4jQTuvCkpl/pewdlo=;\n\tb=obgut0J2/6Tr/nRCPSJAFb+gHoKDlgcfwlr33b5m3qLSDFaxf7HH14MQjuZk1F9t4p\n\tlqtwoenLlDpohNX+DuDYWEtpfx9MvKb9r7V8UVmAD4lXgs6RgnfBEzjD/6w6B1orp5IR\n\tl1JW11UWAU6MC/byGovfW/8gMNT+kKIzRA/chEOwseLQmUOFIWlogISCV7WHNJ9st1Qy\n\tfmD1+D0RIlpxLmsXqpmRcRUzDMZCxIq2BtxC/gF2tiSLAmp+sXOw/6iXf/Lo3Ch5ZX4X\n\t0QeV/4ad/IIeyMipqgtkdAvlzyXId9f3gyfOLdUNDPTsCzIFe1M0hhTgEEdfanJMVZOd\n\tBnwA==","X-Gm-Message-State":"ACrzQf1fDI4b4tSwJAb6+Yn1o6fFHM6mw+DO5QyQmOHEvBc8nSYd6fTd\n\tSmVtH3qbTP8M1TzhALSGhifbWsG/KBVb/f+vqRZI4XDBNrc=","X-Google-Smtp-Source":"AMsMyM4RenLFS61DVUeseClJJuPmImiKVW6VDt0eJ2poveHCMci5GMGNXjlqxY6zqKaETiUdbX4RJ1oZW2hrGtr3cDo=","X-Received":"by 2002:a17:902:f550:b0:178:5b6a:3a1c with SMTP id\n\th16-20020a170902f55000b001785b6a3a1cmr26279942plf.36.1664883893682;\n\tTue, 04 Oct 2022 04:44:53 -0700 (PDT)","MIME-Version":"1.0","References":"<20220815141637.4159-1-david.plowman@raspberrypi.com>\n\t<20220815141637.4159-2-david.plowman@raspberrypi.com>\n\t<CAEmqJPqOUZ-V9AYaUm3TycoJ8stD97O5U+bVwTAAneKvz9C=HQ@mail.gmail.com>","In-Reply-To":"<CAEmqJPqOUZ-V9AYaUm3TycoJ8stD97O5U+bVwTAAneKvz9C=HQ@mail.gmail.com>","Date":"Tue, 4 Oct 2022 12:44:42 +0100","Message-ID":"<CAHW6GY+ZwrwXBYbRUHd7Gf_kr-dEiEXsGvj81_LwqN5YDszf3Q@mail.gmail.com>","To":"libcamera devel <libcamera-devel@lists.libcamera.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/1] pipeline: raspberrypi: Detect\n\tmonochrome \"R\" formats as being raw","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>","Reply-To":"David Plowman <david.plowman@raspberrypi.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":25279,"web_url":"https://patchwork.libcamera.org/comment/25279/","msgid":"<YzyQohBiFItWtXsl@pendragon.ideasonboard.com>","date":"2022-10-04T19:59:30","subject":"Re: [libcamera-devel] [PATCH 1/1] pipeline: raspberrypi: Detect\n\tmonochrome \"R\" formats as being raw","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Mon, Aug 15, 2022 at 03:16:37PM +0100, David Plowman via libcamera-devel wrote:\n> The \"R\" pixel formats (R8, R10, R10_CSI2P etc.) record the associated\n> colour space as being YUV rather than RAW, meaning that the code was\n> not detecting them as being raw formats.\n> \n> In the case of Raspberry Pi, we deal only with raw formats, so the\n> revised test must work correctly for both these and the standard Bayer\n> formats.\n\nThat seems fine to me. We'll still need a more generic solution for\nplatforms that can capture processed greyscale images, but that's for\nlater.\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> Signed-off-by: David Plowman <david.plowman@raspberrypi.com>\n> ---\n>  src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 14 ++------------\n>  1 file changed, 2 insertions(+), 12 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> index e895584d..fae8e45e 100644\n> --- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> +++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n> @@ -105,18 +105,8 @@ V4L2DeviceFormat toV4L2DeviceFormat(const V4L2VideoDevice *dev,\n>  \n>  bool isRaw(const PixelFormat &pixFmt)\n>  {\n> -\t/*\n> -\t * The isRaw test might be redundant right now the pipeline handler only\n> -\t * supports RAW sensors. Leave it in for now, just as a sanity check.\n> -\t */\n> -\tif (!pixFmt.isValid())\n> -\t\treturn false;\n> -\n> -\tconst PixelFormatInfo &info = PixelFormatInfo::info(pixFmt);\n> -\tif (!info.isValid())\n> -\t\treturn false;\n> -\n> -\treturn info.colourEncoding == PixelFormatInfo::ColourEncodingRAW;\n> +\t/* This test works for both Bayer and raw mono formats. */\n> +\treturn BayerFormat::fromPixelFormat(pixFmt).isValid();\n>  }\n>  \n>  double scoreFormat(double desired, double actual)","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 000A7C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  4 Oct 2022 19:59:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54FEF601C7;\n\tTue,  4 Oct 2022 21:59:35 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 276E6601C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  4 Oct 2022 21:59:34 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FA302D9;\n\tTue,  4 Oct 2022 21:59:33 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664913575;\n\tbh=VHHxRI+FkvfP89KkDeJLSJm2/vtbXKlUEs6jjvo9BOo=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rplC9k2wmSN430z5SD/W5rn+f3csMgifSqylheBWgEZuDb8Qs9xWJLNsb19DUTPzq\n\toK5NZOR2l2DoPiSB16Qjbgy4bcFhbsSQw8HbOYOxB553+Hvh8nwPrTOnt81+8M5Iyb\n\tGAZLIKdbMTEBWvvE75FVj4Nhb7JVGSwUOJcK5kqIM75beVdC31KcSbjo0ubcMzbbWY\n\tFhM9DpoqYn19iZ1VEPcJctU5lWD7GFwdIo8IGsiI6O0rFFno9SLwIeduwrUZc9Y3io\n\t1HbmSo0IlVFxVNdKRCDp5rFwypUWNbj9Xl79JSoKEZhg0Bf08MnwozHDkyxeF03FV4\n\t0xxxN452klDSg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664913573;\n\tbh=VHHxRI+FkvfP89KkDeJLSJm2/vtbXKlUEs6jjvo9BOo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lH6hDKsJ0D2WG9qui/JbowcLyH1k5rYRMphkxnUMq23YjR7HtC0GTf4W494A8q1jF\n\tJSeyru+09E13fxhXh7nxQqctrDcOZawXV4e0L3p/lbXVVzYy1tupPgyh0qeofCIOa+\n\tnxNHcu/zPZ+s7KXF2J3dWJ8nvbi6FgmnCxltn6go="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lH6hDKsJ\"; dkim-atps=neutral","Date":"Tue, 4 Oct 2022 22:59:30 +0300","To":"David Plowman <david.plowman@raspberrypi.com>","Message-ID":"<YzyQohBiFItWtXsl@pendragon.ideasonboard.com>","References":"<20220815141637.4159-1-david.plowman@raspberrypi.com>\n\t<20220815141637.4159-2-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220815141637.4159-2-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 1/1] pipeline: raspberrypi: Detect\n\tmonochrome \"R\" formats as being raw","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]