[{"id":24565,"web_url":"https://patchwork.libcamera.org/comment/24565/","msgid":"<166049724493.15821.11815855788851453733@Monstersaurus>","date":"2022-08-14T17:14:04","subject":"Re: [libcamera-devel] [PATCH v3 6/6] Additions in meson.build files","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Kunal Agarwal via libcamera-devel (2022-08-14 17:07:47)\n> Adds files and dependencies required for GL Converter\n> to compile\n\nThese should be added by the patches that need them. Each patch should\nbe possible to compile fully by itself in the series.\n\n--\nKieran\n\n\n> \n> Signed-off-by: Kunal Agarwal \n> ---\n> src/libcamera/meson.build | 3 +++\n> src/libcamera/pipeline/simple/meson.build | 8 +++++++-\n> 2 files changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index b57bee7e..b14102f8 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -136,6 +136,9 @@ libcamera_deps = [\n> libcamera_base,\n> libcamera_base_private,\n> libdl,\n> + libegl,\n> + libgbm,\n> + libgl,\n> libgnutls,\n> liblttng,\n> libudev,\n> diff --git a/src/libcamera/pipeline/simple/meson.build b/src/libcamera/pipeline/simple/meson.build\n> index 9c99b32f..02929456 100644\n> --- a/src/libcamera/pipeline/simple/meson.build\n> +++ b/src/libcamera/pipeline/simple/meson.build\n> @@ -1,6 +1,12 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_sources += files([\n> - 'converter.cpp',\n> + 'converter_gl.cpp',\n> + 'shader.cpp',\n> 'simple.cpp',\n> + 'texture.cpp',\n> ])\n> +\n> +libegl = dependency('egl', required : true)\n> +libgbm = dependency('gbm', required : true)\n> +libgl = dependency('gl', required : true)\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 15C81BE173\n\tfor ;\n\tSun, 14 Aug 2022 17:14:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85A0661FBA;\n\tSun, 14 Aug 2022 19:14:09 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A45161FBA\n\tfor ;\n\tSun, 14 Aug 2022 19:14:07 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCFBB30A;\n\tSun, 14 Aug 2022 19:14:06 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660497249;\n\tbh=vI6fjiuoE4JQ0XiTMk7nYmVQqG9Tz7tOyMp7AzVQhPQ=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Xm3+98tQxDwQ0T1ji2iiK8QouNI+rLndpy/OpUUl4f1rp23VmyOUtJaM3ya4gc2oF\n\t/DbvNkrPd3i0NQNG53KX95HB7WhqCOxNw37QjTtDu/QNNxfYE8nEvJOO+3vy1Ndear\n\t+LBwpZeoqui6CmVmlhPVbYOa9P1iG7/48vrLmvfuKBJ0nx0+DYRSMMFTqYF8lTG2zy\n\tTlPCymk4j7BSrT+9a3FeBgIbqWf3CnYhSOUv9+XMVF1L4Ta0Z2vav9+0j7WZFg5WHd\n\t6OyenLre2hwDQx0xKbX3+Dq2rBH6r9bDuvvBP5AGix7vc/j1WoG4SWIc0lG/ft2ToY\n\tmbmc0RsQRabUg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660497246;\n\tbh=vI6fjiuoE4JQ0XiTMk7nYmVQqG9Tz7tOyMp7AzVQhPQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=gKOYOr3za5Zl+Nqn6KmflLQI275mIDfooqnIvlhX1Rst7/DuUo8Ux2z5wW/EsAy53\n\tGpdJc6Y7XPLDOd04BY6nb81qsPN5RHg2Nq67Fiqq9WiP40a5ML6SnpjfbmUFECu66F\n\tQix/ABOO4TaevcbY5MMHkwHsxerxOYajyqMAzNkU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gKOYOr3z\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220814160747.52093-6-kunalagarwal1072002@gmail.com>","References":"<20220814160747.52093-1-kunalagarwal1072002@gmail.com>\n\t<20220814160747.52093-6-kunalagarwal1072002@gmail.com>","To":"Kunal Agarwal ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 14 Aug 2022 18:14:04 +0100","Message-ID":"<166049724493.15821.11815855788851453733@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v3 6/6] Additions in meson.build files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24567,"web_url":"https://patchwork.libcamera.org/comment/24567/","msgid":"","date":"2022-08-14T19:24:25","subject":"Re: [libcamera-devel] [PATCH v3 6/6] Additions in meson.build files","submitter":{"id":116,"url":"https://patchwork.libcamera.org/api/people/116/","name":"Kunal Agarwal","email":"kunalagarwal1072002@gmail.com"},"content":"Hi Kieran,\n\n> Quoting Kunal Agarwal via libcamera-devel (2022-08-14 17:07:47)\n> > Adds files and dependencies required for GL Converter\n> > to compile\n>\n> These should be added by the patches that need them. Each patch should\n> be possible to compile fully by itself in the series.\n\nYes this makes sense.. I'll do it for the next version. Thanks\n\nRegards,\nKunal Agarwal\n\n\nOn Sun, Aug 14, 2022 at 10:44 PM Kieran Bingham\n wrote:\n>\n> Quoting Kunal Agarwal via libcamera-devel (2022-08-14 17:07:47)\n> > Adds files and dependencies required for GL Converter\n> > to compile\n>\n> These should be added by the patches that need them. Each patch should\n> be possible to compile fully by itself in the series.\n>\n> --\n> Kieran\n>\n>\n> >\n> > Signed-off-by: Kunal Agarwal \n> > ---\n> > src/libcamera/meson.build | 3 +++\n> > src/libcamera/pipeline/simple/meson.build | 8 +++++++-\n> > 2 files changed, 10 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index b57bee7e..b14102f8 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -136,6 +136,9 @@ libcamera_deps = [\n> > libcamera_base,\n> > libcamera_base_private,\n> > libdl,\n> > + libegl,\n> > + libgbm,\n> > + libgl,\n> > libgnutls,\n> > liblttng,\n> > libudev,\n> > diff --git a/src/libcamera/pipeline/simple/meson.build b/src/libcamera/pipeline/simple/meson.build\n> > index 9c99b32f..02929456 100644\n> > --- a/src/libcamera/pipeline/simple/meson.build\n> > +++ b/src/libcamera/pipeline/simple/meson.build\n> > @@ -1,6 +1,12 @@\n> > # SPDX-License-Identifier: CC0-1.0\n> >\n> > libcamera_sources += files([\n> > - 'converter.cpp',\n> > + 'converter_gl.cpp',\n> > + 'shader.cpp',\n> > 'simple.cpp',\n> > + 'texture.cpp',\n> > ])\n> > +\n> > +libegl = dependency('egl', required : true)\n> > +libgbm = dependency('gbm', required : true)\n> > +libgl = dependency('gl', required : true)\n> > --\n> > 2.25.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 17847BE173\n\tfor ;\n\tSun, 14 Aug 2022 19:24:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 861F961FBA;\n\tSun, 14 Aug 2022 21:24:39 +0200 (CEST)","from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com\n\t[IPv6:2607:f8b0:4864:20::e30])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CBA761FBA\n\tfor ;\n\tSun, 14 Aug 2022 21:24:37 +0200 (CEST)","by mail-vs1-xe30.google.com with SMTP id k2so5516868vsk.8\n\tfor ;\n\tSun, 14 Aug 2022 12:24:37 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660505079;\n\tbh=j+KyWz2VUR0Oz2Fag/xhA8g7RPL4yZezn//eCZf+Mb4=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=RV9CLzSiomwujM31PaZJj3qKXE3FSkzvD1YeyBvGdjkjwqdkKWlx4Bagf+LrQRJFw\n\tZQsOz0TE5ctBGenZRmiJF3e8cK9TsddxKzAhBzBzLiQjIqLfyr6tDyiRkYPOlKxDDr\n\tLM8CM0G0CQUf7BSZwATW1deub1CbHjotDBP2p2340M5nFSgiTtMnkD6jfaxuzjILSc\n\tIesdb5YBsfQ42UGwdZJlrWQLnRc4tXGi42bxVNhHhyTmvy0DFvliFMgtiWHRCxkd71\n\tF3uf5UTmGGCQg+jOqNLM6Mn7Z3h1P/GSZt0NMrYkoBulDMW72kAJ5pA6CpMHq6jlE3\n\t9mDuluhynf6CA==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc;\n\tbh=I/IEmvbJle0ajNCXMVKpgyQldgLr9NUjRmsCeNPny54=;\n\tb=PJF5NRjHMH956vt0zzVkRIfYTe4oGTC1OlppOaxfcLUP40cBMP7xL/fTZ3t+X9Qpzo\n\tCWzgxS1EL2w/JVSQzkTs/7pwzCkH2n7ksxBt3Xm8ZVED6yTO4JPU7qJfSfwEoosAGzSS\n\tgX2lPMXn9WptmzxCpeq57DHpNHjUTiirE5kt9ZtLig1b9UTtl3nT1SD0WH5T3KSwQDMo\n\tdP0FeOOiWtkE9AYtYp0+G/LdfR8CoytFsyjePX+FwImZKaojQt++FlEyMU1MDaXhPcYh\n\tkwOmBpVNx53BKMecBuKu4FfjUnrFIu4DNYE8T95jGX6PIWxaHRYLdROSQyr31OWqYZKe\n\tUTHA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"PJF5NRjH\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc;\n\tbh=I/IEmvbJle0ajNCXMVKpgyQldgLr9NUjRmsCeNPny54=;\n\tb=BfkXPMRZxHGLGjLo5OuPmeHSMHhO3t53ISt8cJNaOurefbsfojRyjxo93rqlQLWK5e\n\t8YaJcZhLY0wZaD3vBGvd9HJTbYDcIvQEWxFxkpFjl2ke81XZxl9gMD74dXk3ajTAYR6m\n\txbKZEyS8fzhhrwPiA+DoFjImEgPiMs7LZSp60KKbiXfqTW5v3s4Xpb/JHUCxq96kL1Gd\n\tTqS7kLHde1jMwFLr9wE1oJBl0w/oEShLGz9D8q06RywULIW5N6umEn7tCXzCAUMUz70Y\n\tXnD4HD1/+Eu8bNbmysXn5o2UiqspY2j2qF80SLChxg5fGY4GoGl2xanO3Alg0Q3aeo6s\n\tPzWA==","X-Gm-Message-State":"ACgBeo0uP86pPGFm3lB4475duJr5VEgghAmse3Iu/W71k6E2hRhy6HlF\n\t+VhX+QuYHmnvBxEawvcTjwiCwcem8RvMYI5m+L91+LA8","X-Google-Smtp-Source":"AA6agR6dZIK9svWBVsyqFsJA19/Xq/VB2OFDxeaP1Gzr7YJYRDO7wvaUrifdSq5jiwy9Rw6A3WKF2YMv47/3uWue51w=","X-Received":"by 2002:a05:6102:3a4b:b0:385:63bb:ca6b with SMTP id\n\tc11-20020a0561023a4b00b0038563bbca6bmr5276718vsu.36.1660505076228;\n\tSun, 14 Aug 2022 12:24:36 -0700 (PDT)","MIME-Version":"1.0","References":"<20220814160747.52093-1-kunalagarwal1072002@gmail.com>\n\t<20220814160747.52093-6-kunalagarwal1072002@gmail.com>\n\t<166049724493.15821.11815855788851453733@Monstersaurus>","In-Reply-To":"<166049724493.15821.11815855788851453733@Monstersaurus>","Date":"Mon, 15 Aug 2022 00:54:25 +0530","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v3 6/6] Additions in meson.build files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kunal Agarwal via libcamera-devel ","Reply-To":"Kunal Agarwal ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]