[{"id":24600,"web_url":"https://patchwork.libcamera.org/comment/24600/","msgid":"","date":"2022-08-16T03:50:43","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: remove\n\tunused assignment","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Sun, Aug 14, 2022 at 11:52:41AM +0200, Christian Rauch via libcamera-devel wrote:\n\nWith a commit message,\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Christian Rauch \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n> 1 file changed, 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 93287332..03bbe6b4 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \t\t/* \\todo Turn this into a hard failure. */\n> \t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n> \t\tsensorInfo = {};\n> -\t\tret = 0;\n> \t}\n> \n> \tstd::map entityControls;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 722B8BE173\n\tfor ;\n\tTue, 16 Aug 2022 03:50:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1FFF61FC0;\n\tTue, 16 Aug 2022 05:50:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B752603E3\n\tfor ;\n\tTue, 16 Aug 2022 05:50:57 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A8272496;\n\tTue, 16 Aug 2022 05:50:56 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660621858;\n\tbh=dmU46/jv+f1bhPB2sW7n+F3yL21sKfivbgicmYjFwRw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=4FkNje+T05PUcRagdmwOQb86RcJqjpqD/L+TE2Z4sJ0P+JUug2jNRSDOhAaLBNknv\n\tRO/xKAn/Rx13cOfbN02TbW0lSV6MDReIMdR9sc2NrV9xN+Rj4p0Rli9BDTzOqcBP+V\n\tIC7oP3z90Qb7flMuraOR33+OqXmAO6JvIeNjzWfrWGjUEgZ7490VQeiFYwMf9q5UG5\n\typOhpsfR6QThdv5771SUnDq2DuM+20QJp4Wx3tlgtM5pEiH35RwkwkaC5g4pCK9yk2\n\t/UvW6klSub5SrBtTUzdku0olEo8AZENe+gaNTqYcPKksW/+sV0s+CQ/FYezVh+Fz3Z\n\tYpBVnmuMbJXFA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660621856;\n\tbh=dmU46/jv+f1bhPB2sW7n+F3yL21sKfivbgicmYjFwRw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=uoIph64xRS/yICL5Iudv4ElUnnMWuOpyTUPaO8hAtUI8PpjwUk5840o6PGE+7kpbM\n\tdjkmQ3zs8swBo8GAwJp1diPsfrM1E1U7y8mCPz0bpa+Xw7uNxxDS0avsFV+0a8sZnM\n\tr3Yn8QSFhyfAhD51JV/t8nLMZelHp4JC+mgeYLo0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uoIph64x\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 06:50:43 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220814095241.137108-1-Rauch.Christian@gmx.de>\n\t<20220814095241.137108-3-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220814095241.137108-3-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: remove\n\tunused assignment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24612,"web_url":"https://patchwork.libcamera.org/comment/24612/","msgid":"<4dbfde7c-664b-5819-95ee-f969e7aaaf51@gmx.de>","date":"2022-08-16T18:42:01","subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: remove\n\tunused assignment","submitter":{"id":111,"url":"https://patchwork.libcamera.org/api/people/111/","name":"Christian Rauch","email":"Rauch.Christian@gmx.de"},"content":"Hi Laurent,\n\nI added short commit messages to those commits in v2. I was hoping that\nthose trivial changes do not need a dedicated message body :-)\n\nBest,\nChristian\n\n\nAm 16.08.22 um 05:50 schrieb Laurent Pinchart:\n> Hi Christian,\n>\n> Thank you for the patch.\n>\n> On Sun, Aug 14, 2022 at 11:52:41AM +0200, Christian Rauch via libcamera-devel wrote:\n>\n> With a commit message,\n>\n> Reviewed-by: Laurent Pinchart \n>\n>> Signed-off-by: Christian Rauch \n>> ---\n>> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -\n>> 1 file changed, 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> index 93287332..03bbe6b4 100644\n>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n>> @@ -688,7 +688,6 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n>> \t\t/* \\todo Turn this into a hard failure. */\n>> \t\tLOG(RkISP1, Warning) << \"Camera sensor information not available\";\n>> \t\tsensorInfo = {};\n>> -\t\tret = 0;\n>> \t}\n>>\n>> \tstd::map entityControls;\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0F40C3272\n\tfor ;\n\tTue, 16 Aug 2022 18:42:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EAE9C61FC0;\n\tTue, 16 Aug 2022 20:42:04 +0200 (CEST)","from mout.gmx.net (mout.gmx.net [212.227.17.20])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2185B61FA9\n\tfor ;\n\tTue, 16 Aug 2022 20:42:03 +0200 (CEST)","from [192.168.0.158] ([88.152.184.103]) by mail.gmx.net (mrgmx104\n\t[212.227.17.168]) with ESMTPSA (Nemesis) id\n\t1MVvPJ-1nyLLb2qRR-00RsxT for\n\t; Tue, 16 Aug 2022 20:42:02 +0200"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660675325;\n\tbh=NnIccRjsvg+DfU9VcGSrZ9UE/l0u7hKW98hAJOxixDk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FxlaCUx4xwl9U+F62NU9CmxdleHYYu1BBxAQdNkmGSdv4Pb6F0gKJd7PbAixnGMva\n\tjt+8/2TkqTUkXvF+p84TioYu3ODKvwIElFlj438FYVHeNYPaVNKsAHAtTFIKO8EQNT\n\tzIHfN3oQoNr6OyJE9RgQ6pA6pcZFeKfyEP+KW5Xh3d2l7gOA+1PPD5D2CEY/OxP7kK\n\tx7mapVoWHcb34h58m/rE2qCyYFR7L47gxgJfFs09NSOGj9/zopZptZ6ck15hl5hPli\n\t+oeklxfBNznxcFogDBQP8m1wXTv6IPQ1LLurq2u8QatJ6A47FQty/DDx94pMS1IT/3\n\tqzIbC0o3C9XAQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1660675322;\n\tbh=NnIccRjsvg+DfU9VcGSrZ9UE/l0u7hKW98hAJOxixDk=;\n\th=X-UI-Sender-Class:Date:Subject:To:References:From:In-Reply-To;\n\tb=iVJEaoHZpm1PHnobidPk/8JTCAndpvmRNsD1BSNRkHaYgLlHM3O8KJ8Ra5u7MAmT+\n\tuKwwdUUbcYGijHZxU1OK7KuqIPRBQ+KTXfndRgSTYJKWKrA5G7qHdj48pvNw2idLOj\n\tH3yRwEzRns3BEFQSOWc/Q8xP9oFi96ul1t5DGxU0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"iVJEaoHZ\"; dkim-atps=neutral","X-UI-Sender-Class":"01bb95c1-4bf8-414a-932a-4f6e2808ef9c","Message-ID":"<4dbfde7c-664b-5819-95ee-f969e7aaaf51@gmx.de>","Date":"Tue, 16 Aug 2022 20:42:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.11.0","Content-Language":"en-GB","To":"libcamera-devel@lists.libcamera.org","References":"<20220814095241.137108-1-Rauch.Christian@gmx.de>\n\t<20220814095241.137108-3-Rauch.Christian@gmx.de>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-Provags-ID":"V03:K1:7yR+YaUr0whLLrbaae/L5TWAhDrRln3QiooA0kc4jSS6BJ7UTx8\n\tHd/EOqfcYhcfGE3caBPmarzm559KEJ395XlqFDApE6mqms7A+Cd1VZ8VmzjZWZ1SYVJ+Wu0\n\tFghep81b8GHFIWT47W8mFnpgqohswcv12V5Qz7l+h4wXPN194aW2V1m2Y+xKNkX5gHi352/\n\tmbIOUomfMt+kQ+d/uDgSQ==","X-Spam-Flag":"NO","X-UI-Out-Filterresults":"notjunk:1; V03:K0:ZKwxd3L8X3M=:vlUrow3jcRUriemsnL5ni9\n\t0Hzg1KzOy+P05uPynQUOPOHJAchJqti/k0dD0nnl27T0tKYEyHMVEoC35R0gzAO+rrRRYHkjJ\n\tKbF44vZl4kh4QBK5/pZkQsUFSMccESCXgIPewa7PaCJes636yaYM9+fVZzyT6Wbfeob/uzRqY\n\tihG96wyfZPdSwqHzXwU2VpWqTnrwJgnx5HTo09Y8wIQnnTTKSBZBe0jDKexqd/spSGLCzO0KU\n\tnHhgdwX+2d7b0zQjz4eQEwTsV6bUDvvRy3sGh/V1xunISDRW/r5b95I44S45AFZLvQtVWzzbj\n\tckrL4o9YmTRGhT4FveNq77Fz8jmJYIXFIe+FOznXG4l26G73CFP+6Lr8NhnaPbuJhpJ2E6ylN\n\tDrjQBTKUXCFc6o75uIvuMNEd3HqjXxMgLJ8Cmp0e5+HkejKZQHaPSyG9mAzvkMLIZh5jMx0DG\n\tmPF3RavGLw7VdbRioeZsw9hNt8ThrJZ2Gq0vFLItdSfZspSDelCbMSVxrg9CL7wZLJdVh7s8X\n\teSeBJE7YTF5AHc5iD5rKJXgskoQG0JBE0TCyTgueStTXDU8FxqT2wBYzTJ+Vdl/dSLm3jEJP4\n\tmi3p+7K3CrqqgVjUJAxf9gJRCjYQQFHRWvM1L7sGPv8TOA42z+R0Vkts6kNGnbqAkUKCwLqQW\n\tqMf6ou4I0SxN++zdWUV5GQLyuFNPuUKVhzKTFTeFDV+a1dVKOFcC6wxCfa2oKyUi2FhO5ahDI\n\tBkpZUJXjxmBi83F/b7phNG5IQovLdwz/sX8oJ9821GqpS5o9sd5gsAZ9FicRbclshlQZG+/oC\n\th5phWmBPD5mP2ZPepKbumxqVDjvEPfgUeNZcIxDKqPQXiFTWnQKg/x2D/prAA0IK8EGkSMHo3\n\tYHn7rDFCKTxltc2J4uBuNrd2s6xgFsMDKs2Ohu5fMXrWBoW7BNFP0s0lmkKKRJ/RTVz+EfTXi\n\to/BMo72+oDB+1pLIkZe+snL7kTmSXkFuet6BRO3+LhdwON1MGcCIYzRtgP8ALbWupp5HO+QiN\n\tRBTqvMfgwmK73hos/k4RznLZtzLvhpB9XsV0dHWIQD6o7q4k1mvp2YrQAAqp3gVc6HfYGCH/a\n\tVUWnh0R+tgy2sAMVaap8V+OYOMpmvOOIOIp1kAsZ0mE99mUhorJIuseLA==","Subject":"Re: [libcamera-devel] [PATCH 3/3] libcamera: pipeline: remove\n\tunused assignment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Christian Rauch via libcamera-devel\n\t","Reply-To":"Christian Rauch ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]