[{"id":24599,"web_url":"https://patchwork.libcamera.org/comment/24599/","msgid":"","date":"2022-08-16T03:48:59","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: use const reference\n\tfor range loops","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Christian,\n\nThank you for the patch.\n\nOn Sun, Aug 14, 2022 at 11:52:40AM +0200, Christian Rauch via libcamera-devel wrote:\n> Signed-off-by: Christian Rauch \n\nAh, that's better, the SoB line is there, but the commit message is\nstill missing :-)\n\n> ---\n> src/libcamera/camera_manager.cpp | 2 +-\n> src/libcamera/device_enumerator.cpp | 2 +-\n> src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +----\n> src/libcamera/pipeline/vimc/vimc.cpp | 2 +-\n> src/libcamera/pipeline_handler.cpp | 2 +-\n> 5 files changed, 5 insertions(+), 8 deletions(-)\n> \n> diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\n> index 70d73822..7ff4bc6f 100644\n> --- a/src/libcamera/camera_manager.cpp\n> +++ b/src/libcamera/camera_manager.cpp\n> @@ -189,7 +189,7 @@ void CameraManager::Private::addCamera(std::shared_ptr camera,\n> {\n> \tMutexLocker locker(mutex_);\n> \n> -\tfor (std::shared_ptr c : cameras_) {\n> +\tfor (const std::shared_ptr &c : cameras_) {\n> \t\tif (c->id() == camera->id()) {\n> \t\t\tLOG(Camera, Fatal)\n> \t\t\t\t<< \"Trying to register a camera with a duplicated ID '\"\n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index d1258050..f2e055de 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -161,7 +161,7 @@ std::unique_ptr DeviceEnumerator::create()\n> \n> DeviceEnumerator::~DeviceEnumerator()\n> {\n> -\tfor (std::shared_ptr media : devices_) {\n> +\tfor (const std::shared_ptr &media : devices_) {\n> \t\tif (media->busy())\n> \t\t\tLOG(DeviceEnumerator, Error)\n> \t\t\t\t<< \"Removing media device \" << media->deviceNode()\n> diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> index fbe02cdc..0306f56c 100644\n> --- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> +++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n> @@ -340,10 +340,7 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request)\n> {\n> \tControlList controls(data->video_->controls());\n> \n> -\tfor (auto it : request->controls()) {\n> -\t\tunsigned int id = it.first;\n> -\t\tControlValue &value = it.second;\n> -\n> +\tfor (const auto &[id, value] : request->controls()) {\n\nTechnically speaking this does more than using a const reference. I\ndon't mind bundling it in this patch, but it should then be mentioned in\nthe commit message.\n\n> \t\tprocessControl(&controls, id, value);\n> \t}\n\nNo need for curly braces anymore.\n\n> \n> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp\n> index 153cf849..d2f2e460 100644\n> --- a/src/libcamera/pipeline/vimc/vimc.cpp\n> +++ b/src/libcamera/pipeline/vimc/vimc.cpp\n> @@ -378,7 +378,7 @@ int PipelineHandlerVimc::processControls(VimcCameraData *data, Request *request)\n> {\n> \tControlList controls(data->sensor_->controls());\n> \n> -\tfor (auto it : request->controls()) {\n> +\tfor (const auto &it : request->controls()) {\n> \t\tunsigned int id = it.first;\n> \t\tunsigned int offset;\n> \t\tuint32_t cid;\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 7d2d00ef..e5cb751c 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -616,7 +616,7 @@ void PipelineHandler::disconnect()\n> \t */\n> \tstd::vector> cameras{ std::move(cameras_) };\n> \n> -\tfor (std::weak_ptr ptr : cameras) {\n> +\tfor (const std::weak_ptr &ptr : cameras) {\n> \t\tstd::shared_ptr camera = ptr.lock();\n> \t\tif (!camera)\n> \t\t\tcontinue;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0F8A7C3272\n\tfor ;\n\tTue, 16 Aug 2022 03:49:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7099F603E3;\n\tTue, 16 Aug 2022 05:49:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3448B603E3\n\tfor ;\n\tTue, 16 Aug 2022 05:49:13 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 87B95496;\n\tTue, 16 Aug 2022 05:49:12 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660621755;\n\tbh=PDihBqGRsc+0dWukiSeVSy9Evml9mOu7aTputJLdGy4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=xc7WBR97QhyVr8LqdpkZHvSrJLjwuB6A6BINpdYzMvv6JHMIUjeWOCi8NIlCY49+x\n\t0n77oD0JUD/mOU/yMJUm7v882baK8uMLvuxFe1aChgQQAUFT8rAcgLmjlmdJbqd58G\n\tTMi6/PTzmHzFSarP7eLyP4xWu/rQ+nB77+6uwEXcRK2ST1IfckgMkpkAyfbVODo+qj\n\touzYw66gctrUCbVzVQ8x23Gxa0dagUSty8lSJBoAwl+AfwRjwyP/CEUJDJ2KCJmoY5\n\t/MlDaMxcBNKxETzUai/C40MD4YwazANoZ0tez3gF5ZEGceVvqQhEJEfkUjx3YKOkj2\n\tcBvGvd1zACdFA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660621752;\n\tbh=PDihBqGRsc+0dWukiSeVSy9Evml9mOu7aTputJLdGy4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hQrHhMSvGiqX5VdrvPq3HfRMmH7dPBWdzjQJnnem1JPAkzwF7tswuC+KTY6xa5PXA\n\tcPqpvw0y6PC3AUkiLyLMs3l8tOFKv2s4hp7/7sKjjnXiUTRroqkWldl+Wa4+WI2HP8\n\tDDfe0xqPUKredTn4HVwe37SzRtjSkG3w86w5yU+c="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hQrHhMSv\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 06:48:59 +0300","To":"Christian Rauch ","Message-ID":"","References":"<20220814095241.137108-1-Rauch.Christian@gmx.de>\n\t<20220814095241.137108-2-Rauch.Christian@gmx.de>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220814095241.137108-2-Rauch.Christian@gmx.de>","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: use const reference\n\tfor range loops","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]