[{"id":24579,"web_url":"https://patchwork.libcamera.org/comment/24579/","msgid":"<49e35b1f-7c4f-eecc-497f-51bc6ef364d3@ideasonboard.com>","date":"2022-08-15T15:53:39","subject":"Re: [libcamera-devel] [PATCH v3 1/3] ipa: rkisp1: Add enable field\n\tfor AWB algorithm in IPA context","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent, Florian\n\nThank you for the patch.\n\nOn 8/13/22 04:03, Laurent Pinchart via libcamera-devel wrote:\n> From: Florian Sylvestre \n>\n> Add an enable variable in the awb struct in IPASessionConfiguration which\n> indicates if the awb algorithm has been configured. This will allow other\n> algorithms to retrieve this information.\n>\n> Signed-off-by: Florian Sylvestre \n> Reviewed-by: Laurent Pinchart \n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n> ---\n> src/ipa/rkisp1/algorithms/awb.cpp | 2 ++\n> src/ipa/rkisp1/ipa_context.cpp | 3 +++\n> src/ipa/rkisp1/ipa_context.h | 1 +\n> 3 files changed, 6 insertions(+)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\n> index 9f00364d12b1..d1328f011081 100644\n> --- a/src/ipa/rkisp1/algorithms/awb.cpp\n> +++ b/src/ipa/rkisp1/algorithms/awb.cpp\n> @@ -48,6 +48,8 @@ int Awb::configure(IPAContext &context,\n> \tcontext.configuration.awb.measureWindow.h_size = 3 * configInfo.outputSize.width / 4;\n> \tcontext.configuration.awb.measureWindow.v_size = 3 * configInfo.outputSize.height / 4;\n> \n> +\tcontext.configuration.awb.enabled = true;\n> +\n> \treturn 0;\n> }\n> \n> diff --git a/src/ipa/rkisp1/ipa_context.cpp b/src/ipa/rkisp1/ipa_context.cpp\n> index ef8bb8e931c8..23a63f8c6e25 100644\n> --- a/src/ipa/rkisp1/ipa_context.cpp\n> +++ b/src/ipa/rkisp1/ipa_context.cpp\n> @@ -87,6 +87,9 @@ namespace libcamera::ipa::rkisp1 {\n> *\n> * \\var IPASessionConfiguration::awb.measureWindow\n> * \\brief AWB measure window\n> + *\n> + * \\var IPASessionConfiguration::awb.enabled\n> + * \\brief Indicates if the AWB hardware is enabled to apply colour gains\n> */\n> \n> /**\n> diff --git a/src/ipa/rkisp1/ipa_context.h b/src/ipa/rkisp1/ipa_context.h\n> index 2bdb6a81d7c9..7f7b3e4d88fa 100644\n> --- a/src/ipa/rkisp1/ipa_context.h\n> +++ b/src/ipa/rkisp1/ipa_context.h\n> @@ -29,6 +29,7 @@ struct IPASessionConfiguration {\n> \n> \tstruct {\n> \t\tstruct rkisp1_cif_isp_window measureWindow;\n> +\t\tbool enabled;\n> \t} awb;\n> \n> \tstruct {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A7F9FBE173\n\tfor ;\n\tMon, 15 Aug 2022 15:53:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E82B61FC0;\n\tMon, 15 Aug 2022 17:53:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7F0A61FB9\n\tfor ;\n\tMon, 15 Aug 2022 17:53:45 +0200 (CEST)","from [IPV6:2401:4900:1f3f:a731:6fd:fef1:9e01:7e0f] (unknown\n\t[IPv6:2401:4900:1f3f:a731:6fd:fef1:9e01:7e0f])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1264B4A8;\n\tMon, 15 Aug 2022 17:53:44 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660578827;\n\tbh=cSqCX26nyvQ0mm8aRgKDBfxC3wlFy9GMVJnr7r0Ksws=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=ButZV8FNtIwkCTDB9rUT1hC8W1tQ3mGZiZyQEa7eF9TRgCdzQUd2CN1/9gcujzfsp\n\tp8XaUVcOfze38O9RRtJoEbE8ySfOTE4WNgW8x5aWonWcD9w6bGUfsdBc2wX1K/2JbK\n\tHVOePbEM1Gaup2y0N1mwxNtnj68gZiT2bvajbLeOvzacrPEt3AuMEKDj8FzF+CrlI8\n\tj2OFBeejr9hOoQFvpU+v4eAqBCh7JoPWK9NVNHDO2nwoBeYBmGS2RD/RVTKSZPZ0X+\n\tRJT/HbAnWQnxvHx7vzsPhgZVYDzK6MAJF6c6W80E096uTVSo6I7ieDWu8KAGFZUfLr\n\tVtx49jIJibIbg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660578825;\n\tbh=cSqCX26nyvQ0mm8aRgKDBfxC3wlFy9GMVJnr7r0Ksws=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=wKt3We2YWfKOexpQHk3H4JB6OwZzUovTfbOelgofKJAHZDKU36zppnv5B0xOZ2ndF\n\tSNUQd7nDOxx0TFkr8J5wzKjmGIQvlmcvqOxQYdFkKhHmIm5D4YSlgUEHsxL/l0jot3\n\txBemMsFFXCUjnRpR1Oz++jFGfIrxEAdsQApRbFho="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"wKt3We2Y\"; dkim-atps=neutral","Message-ID":"<49e35b1f-7c4f-eecc-497f-51bc6ef364d3@ideasonboard.com>","Date":"Mon, 15 Aug 2022 21:23:39 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20220812223351.22609-1-laurent.pinchart@ideasonboard.com>\n\t<20220812223351.22609-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220812223351.22609-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v3 1/3] ipa: rkisp1: Add enable field\n\tfor AWB algorithm in IPA context","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]