[{"id":24603,"web_url":"https://patchwork.libcamera.org/comment/24603/","msgid":"<20220816053251.GX311202@pyrite.rasen.tech>","date":"2022-08-16T05:32:51","subject":"Re: [libcamera-devel] [PATCH v2 6/6] controls: Remove AeEnable and\n\tAeLocked","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Aug 11, 2022 at 05:02:19PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Now that the codebase has been ported to use the new AEGC controls\n> remove the definition of AeEnable and AeLocked.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/control_ids.yaml | 18 ------------------\n> 1 file changed, 18 deletions(-)\n> \n> diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\n> index 694659af4b7d..f7f8b2e525d8 100644\n> --- a/src/libcamera/control_ids.yaml\n> +++ b/src/libcamera/control_ids.yaml\n> @@ -7,24 +7,6 @@\n> # Unless otherwise stated, all controls are bi-directional, i.e. they can be\n> # set through Request::controls() and returned out through Request::metadata().\n> controls:\n> - - AeEnable:\n> - type: bool\n> - description: |\n> - Enable or disable the AE.\n> -\n> - \\sa ExposureTime AnalogueGain\n> -\n> - - AeLocked:\n> - type: bool\n> - description: |\n> - Report the lock status of a running AE algorithm.\n> -\n> - If the AE algorithm is locked the value shall be set to true, if it's\n> - converging it shall be set to false. If the AE algorithm is not\n> - running the control shall not be present in the metadata control list.\n> -\n> - \\sa AeEnable\n> -\n> - AeState:\n> type: int32_t\n> description: |\n> -- \n> 2.37.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA374C3272\n\tfor ;\n\tTue, 16 Aug 2022 05:33:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 977E161FC0;\n\tTue, 16 Aug 2022 07:33:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 520A9603E3\n\tfor ;\n\tTue, 16 Aug 2022 07:32:59 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B6F7496;\n\tTue, 16 Aug 2022 07:32:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660627980;\n\tbh=pZ18ZTf77ihGMVEkDnSr9plJhsSfuPWykMZcoaKt6dg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=KLVsKP9raqgCvVDVW0CKBnlM3LR4mqXprv6pkc+dRipxycJP96BidOsimz/UKnHTt\n\taj31v4vL4Eoc9sggyQQuXFyS9bnkf6GGuXE9I5L2+xZMPi7kDOYwOkjnmONCBEMVHk\n\tG9RjKXxl0RI8j6dVt2QXXSLBmyZ6JJQ/eZSUZJI8XyQae1NpQerU79IkcUPBt3H7/q\n\tYd8TxlzMAQkUx03K+ry4BFFRBcU1E2TlzBzexib9v5laVZirNnj72jt+v8WbT9lAMR\n\tb1RIcyf6idPH7Q5tJmijxeYoEn1z6dbkyFtj/f5D11yE26wWhpiY/XgdAFI7pRgD2x\n\tZX6UKcljWefAQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660627979;\n\tbh=pZ18ZTf77ihGMVEkDnSr9plJhsSfuPWykMZcoaKt6dg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=u16SmiDnqgHI1WdqtzuLIX6xtaZSyRC4YIJC+5uIVL7I7WdeinHYJjAAUmZhJ1wUY\n\tLWGDfcqIOJny6ZLp/3YgxErLnIRKlVdGc121fOqg3fojDjMoiOnqzafejhVnBehaF5\n\tQZzInUvyxNStEyYvufcPKF6HyqVhpMvMHaPJsJLg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"u16SmiDn\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 14:32:51 +0900","To":"Jacopo Mondi ","Message-ID":"<20220816053251.GX311202@pyrite.rasen.tech>","References":"<20220811150219.62066-1-jacopo@jmondi.org>\n\t<20220811150219.62066-7-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220811150219.62066-7-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 6/6] controls: Remove AeEnable and\n\tAeLocked","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]