[{"id":24602,"web_url":"https://patchwork.libcamera.org/comment/24602/","msgid":"<20220816053217.GW311202@pyrite.rasen.tech>","date":"2022-08-16T05:32:17","subject":"Re: [libcamera-devel] [PATCH v2 5/6] ipa: rkisp1: Remove AE-related\n\tcontrols","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Aug 11, 2022 at 05:02:18PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> The RkISP1 IPA registers the AeEnabled control as available but\n> does not handle it yet and returns the AeLocked control in\n> the prepareMetadata() function with a value currently hard-coded to 0.\n> \n> Remove the AEGC-related controls as they currently have no purpose and\n> both AeLocked and AeEnable will be removed in the next patch.\n> \n> A proper handling of the AEGC algorithm will have to be implemented\n> using the newly introduced AEGC controls.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 19 ++++---------------\n> 1 file changed, 4 insertions(+), 15 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 17d42d38eb45..dac3a43f803d 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -64,7 +64,6 @@ protected:\n> \n> private:\n> \tvoid setControls(unsigned int frame);\n> -\tvoid prepareMetadata(unsigned int frame, unsigned int aeState);\n> \n> \tstd::map buffers_;\n> \tstd::map mappedBuffers_;\n> @@ -91,7 +90,6 @@ namespace {\n> \n> /* List of controls handled by the RkISP1 IPA */\n> const ControlInfoMap::Map rkisp1Controls{\n> -\t{ &controls::AeEnable, ControlInfo(false, true) },\n> \t{ &controls::Brightness, ControlInfo(-1.0f, 0.993f) },\n> \t{ &controls::Contrast, ControlInfo(0.0f, 1.993f) },\n> \t{ &controls::Saturation, ControlInfo(0.0f, 1.993f) },\n> @@ -321,14 +319,15 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n> \tcontext_.frameContext.sensor.gain =\n> \t\tcamHelper_->gain(sensorControls.get(V4L2_CID_ANALOGUE_GAIN).get());\n> \n> -\tunsigned int aeState = 0;\n> -\n> \tfor (auto const &algo : algorithms())\n> \t\talgo->process(context_, nullptr, stats);\n> \n> \tsetControls(frame);\n> \n> -\tprepareMetadata(frame, aeState);\n> +\t/* \\todo: prepare metadata. */\n> +\n> +\tControlList ctrls(controls::controls);\n> +\tmetadataReady.emit(frame, ctrls);\n> }\n> \n> void IPARkISP1::setControls(unsigned int frame)\n> @@ -343,16 +342,6 @@ void IPARkISP1::setControls(unsigned int frame)\n> \tsetSensorControls.emit(frame, ctrls);\n> }\n> \n> -void IPARkISP1::prepareMetadata(unsigned int frame, unsigned int aeState)\n> -{\n> -\tControlList ctrls(controls::controls);\n> -\n> -\tif (aeState)\n> -\t\tctrls.set(controls::AeLocked, aeState == 2);\n> -\n> -\tmetadataReady.emit(frame, ctrls);\n> -}\n> -\n> } /* namespace ipa::rkisp1 */\n> \n> /*\n> -- \n> 2.37.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08F2CC3272\n\tfor ;\n\tTue, 16 Aug 2022 05:32:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B795A61FC0;\n\tTue, 16 Aug 2022 07:32:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C4CF603E3\n\tfor ;\n\tTue, 16 Aug 2022 07:32:24 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DE04C496;\n\tTue, 16 Aug 2022 07:32:22 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660627945;\n\tbh=c0xncSHF4q5izswdmQXcelUu+KOWdT8YYBrfQ2wFKC4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ujhLn14iCb47engO1IKxCB3ZSG5GAddTZoZzLcqCK/PKPiLgl2BlQ+NbMsh4+SRId\n\tE3pYiFfwmVtYAiFkOMpn9iHCsuf2nT7UrSzGm/00sf6Q99z3g8uu0+BZ1Bkg+ytBpM\n\tcM/RXJMkmIs8N9Ktu1dYktc6dyS6cCDmaVCVCo1i04uteXXvGJA84iAv0Omza1J8yo\n\tfKSLqB6TitTPliRz+TvxLRp0Ng8kMi6G6AkK5vCk9YXw1FjuNPfh7mU94u6998LsLH\n\tmZHUtnTVP4MJ7vRJ8doWgGGDSbeJq6rM63yqUYs9s+eW4I27VrN/6NpMSoZHm6E6Vd\n\tk4mywYjIstJoQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660627943;\n\tbh=c0xncSHF4q5izswdmQXcelUu+KOWdT8YYBrfQ2wFKC4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gFfFgqsI3jKYPiL6obGZndpwxqhTySPFCp2KqzSOTqt8wC+Vutc9YifoMW33Ek15r\n\tHNL578VcWmd/LEyPj1JjixoJ8LjjxPD3ZNvrG90MBsSPdJNBuTIL7MeXoL6j6AuXPi\n\tg40eGZ/V4we9flOwanVjuHALW8LEC1HvUam5yDpg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gFfFgqsI\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 14:32:17 +0900","To":"Jacopo Mondi ","Message-ID":"<20220816053217.GW311202@pyrite.rasen.tech>","References":"<20220811150219.62066-1-jacopo@jmondi.org>\n\t<20220811150219.62066-6-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220811150219.62066-6-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 5/6] ipa: rkisp1: Remove AE-related\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]