[{"id":24574,"web_url":"https://patchwork.libcamera.org/comment/24574/","msgid":"<20220815085457.GU311202@pyrite.rasen.tech>","date":"2022-08-15T08:54:57","subject":"Re: [libcamera-devel] [PATCH v2 3/6] test: ipa_data_serialization:\n\tUse ExposureTimeMode","submitter":{"id":97,"url":"https://patchwork.libcamera.org/api/people/97/","name":"Nicolas Dufresne via libcamera-devel","email":"libcamera-devel@lists.libcamera.org"},"content":"On Thu, Aug 11, 2022 at 05:02:16PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Replace the deprecated AeEnable control with ExposureTimeMode\n> in ipa_data_serialization test.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> test/serialization/ipa_data_serializer_test.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/test/serialization/ipa_data_serializer_test.cpp b/test/serialization/ipa_data_serializer_test.cpp\n> index d2050a868b38..f9b3e727127c 100644\n> --- a/test/serialization/ipa_data_serializer_test.cpp\n> +++ b/test/serialization/ipa_data_serializer_test.cpp\n> @@ -33,7 +33,7 @@ using namespace std;\n> using namespace libcamera;\n> \n> static const ControlInfoMap Controls = ControlInfoMap({\n> -\t\t{ &controls::AeEnable, ControlInfo(false, true) },\n> +\t\t{ &controls::ExposureTimeMode, ControlInfo(false, true) },\n> \t\t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n> \t\t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n> \t\t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n> -- \n> 2.37.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD7C0C3272\n\tfor ;\n\tMon, 15 Aug 2022 08:55:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED91261FC0;\n\tMon, 15 Aug 2022 10:55:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 963C861FA8\n\tfor ;\n\tMon, 15 Aug 2022 10:55:04 +0200 (CEST)","from pyrite.rasen.tech (h175-177-042-159.catv02.itscom.jp\n\t[175.177.42.159])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 261A248F;\n\tMon, 15 Aug 2022 10:55:02 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660553706;\n\tbh=TmT4Vdp8ynD65fNYCOZ9JMKDf70PnpXa0767unIlHQ8=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=efeCzQbIY8oSrQKnfHH61ZbfXs8Ko+379O4VUDU/Z/iri7iw29uNDkd+7tU31ksfx\n\tNpHTZNnX6Zv2oxWk7uIj/gWU2ZDleqfbP0Zibq/RVoUsnmXBYTa22bA3IJI/NkrD28\n\tLkzx3lcowZfNxVNYVsoKZvOuL4cWB17wGh7pSSV7MyX3mHoASaMSU2Ycnl0h6MCUQQ\n\tS1vF0+nsPr02al5EzKkIDYfBGlpg0KcTrv2aJ8/DJF6GIexRwLVYb9Pwo4+RK0chee\n\tgEIlI4fFApyYljWdnX3X2JIW1OKDqgAt1Q6GHAkT89sNVUcSeAE5sI28nu+ofwl3Gm\n\tMPjLgMGvc1czQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660553704;\n\tbh=TmT4Vdp8ynD65fNYCOZ9JMKDf70PnpXa0767unIlHQ8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=j9PbcLhJg5NbCVZn/LjHRtFr6MN7ICFLqwh0JrjovlDhH1MRwLk/EcAFRQJXrc6kG\n\tFCGPZx1rRrcb0LzjlBJANXQb8CX9Lw/JoDpr+ZoqnHMUnyKThHUxxpRHgyIK10Pmlm\n\tknFYc+UUy9qZFhQ3fO30bvAGJJYaa2DWDqC4SucE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"j9PbcLhJ\"; dkim-atps=neutral","Date":"Mon, 15 Aug 2022 17:54:57 +0900","To":"Jacopo Mondi ","Message-ID":"<20220815085457.GU311202@pyrite.rasen.tech>","References":"<20220811150219.62066-1-jacopo@jmondi.org>\n\t<20220811150219.62066-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20220811150219.62066-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 3/6] test: ipa_data_serialization:\n\tUse ExposureTimeMode","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Paul Elder via libcamera-devel ","Reply-To":"paul.elder@ideasonboard.com","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]