[{"id":24511,"web_url":"https://patchwork.libcamera.org/comment/24511/","msgid":"<20220810082254.bw2uv7edtdullyu5@uno.localdomain>","date":"2022-08-10T08:22:54","subject":"Re: [libcamera-devel] [PATCH 1/4] utils: gen-controls: Factor out\n\tYAML data handling in classes","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Wed, Aug 10, 2022 at 03:29:03AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> The gen-controls.py script handles the data structure produced by the\n> YAML parser manually through the whole code base. Clean this up by\n> encapsulating it in Control and ControlEnum classes to model a control\n> and its enum values respectively, to decouple YAML data handling from\n> generation.\n>\n> No functional change intended.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/gen-controls.py | 156 ++++++++++++++++++++++++++++--------------\n> 1 file changed, 106 insertions(+), 50 deletions(-)\n>\n> diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> index 46ba439439ec..f6a3ae39cc84 100755\n> --- a/utils/gen-controls.py\n> +++ b/utils/gen-controls.py\n> @@ -14,6 +14,90 @@ import sys\n> import yaml\n>\n>\n> +class ControlEnum(object):\n> + def __init__(self, data):\n> + self.__data = data\n> +\n> + @property\n> + def description(self):\n> + \"\"\"The enum description\"\"\"\n> + return self.__data.get('description')\n> +\n> + @property\n> + def name(self):\n> + \"\"\"The enum name\"\"\"\n> + return self.__data.get('name')\n> +\n> + @property\n> + def value(self):\n> + \"\"\"The enum value\"\"\"\n> + return self.__data.get('value')\n> +\n> +\n> +class Control(object):\n> + def __init__(self, name, data):\n> + self.__name = name\n> + self.__data = data\n> + self.__enum = None\n> +\n> + enum_values = data.get('enum')\n> + if enum_values is not None:\n> + self.__enum_values = [ControlEnum(enum) for enum in enum_values]\n> +\n> + @property\n> + def description(self):\n> + \"\"\"The control description\"\"\"\n> + return self.__data.get('description')\n> +\n> + @property\n> + def enum_values(self):\n> + \"\"\"The enum values, if the control is an enumeration\"\"\"\n> + if self.__enum_values is None:\n> + return\n> + for enum in self.__enum_values:\n> + yield enum\n> +\n> + @property\n> + def is_enum(self):\n> + \"\"\"Is the control an enumeration\"\"\"\n> + return self.__data.get('enum') is not None\n\nCan you use \"self.__enum_values is not None\" ?\n\n> +\n> + @property\n> + def is_draft(self):\n> + \"\"\"Is the control a draft control\"\"\"\n> + return self.__data.get('draft') is not None\n> +\n> + @property\n> + def name(self):\n> + \"\"\"The control name (CameCase)\"\"\"\n\n\"CamelCase\"\n\n> + return self.__name\n> +\n> + @property\n> + def q_name(self):\n> + \"\"\"The control name, qualified with a namespace\"\"\"\n> + ns = 'draft::' if self.is_draft else ''\n> + return ns + self.__name\n> +\n> + @property\n> + def type(self):\n> + typ = self.__data.get('type')\n> + size = self.__data.get('size')\n> +\n> + if typ == 'string':\n> + return 'std::string'\n> +\n> + if size is None:\n> + return typ\n> +\n> + if len(size) > 0:\n> + # fixed-sized Span\n> + span_size = reduce(operator.mul, size)\n> + return f\"Span\"\n> + else:\n> + # variable-sized Span\n> + return f\"Span\"\n> +\n> +\n> def snake_case(s):\n> return ''.join([c.isupper() and ('_' + c) or c for c in s]).strip('_')\n>\n> @@ -24,24 +108,6 @@ def format_description(description):\n> return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n>\n>\n> -def get_ctrl_type(ctrl):\n> - ctrl_type = ctrl['type']\n> - ctrl_size_arr = ctrl.get('size')\n> -\n> - if ctrl_type == 'string':\n> - return 'std::string'\n> - elif ctrl_size_arr is not None:\n> - if len(ctrl_size_arr) > 0:\n> - # fixed-sized Span\n> - ctrl_span_size = reduce(operator.mul, ctrl_size_arr)\n> - return f\"Span\"\n> - else:\n> - # variable-sized Span\n> - return f\"Span\"\n> - else:\n> - return ctrl_type\n> -\n> -\n> def generate_cpp(controls):\n> enum_doc_start_template = string.Template('''/**\n> * \\\\enum ${name}Enum\n> @@ -67,35 +133,31 @@ ${description}\n> ctrls_map = []\n>\n> for ctrl in controls:\n> - name, ctrl = ctrl.popitem()\n> - id_name = snake_case(name).upper()\n> -\n> - ctrl_type = get_ctrl_type(ctrl)\n> + id_name = snake_case(ctrl.name).upper()\n>\n> info = {\n> - 'name': name,\n> - 'type': ctrl_type,\n> - 'description': format_description(ctrl['description']),\n> + 'name': ctrl.name,\n> + 'type': ctrl.type,\n> + 'description': format_description(ctrl.description),\n> 'id_name': id_name,\n> }\n>\n> target_doc = ctrls_doc\n> target_def = ctrls_def\n> - if ctrl.get('draft'):\n> + if ctrl.is_draft:\n> target_doc = draft_ctrls_doc\n> target_def = draft_ctrls_def\n>\n> - enum = ctrl.get('enum')\n> - if enum:\n> + if ctrl.is_enum:\n> enum_doc = []\n> enum_doc.append(enum_doc_start_template.substitute(info))\n>\n> num_entries = 0\n> - for entry in enum:\n> + for enum in ctrl.enum_values:\n> value_info = {\n> - 'name': name,\n> - 'value': entry['name'],\n> - 'description': format_description(entry['description']),\n> + 'name': ctrl.name,\n> + 'value': enum.name,\n> + 'description': format_description(enum.description),\n> }\n> enum_doc.append(enum_doc_value_template.substitute(value_info))\n> num_entries += 1\n> @@ -110,9 +172,9 @@ ${description}\n> }\n> target_doc.append(enum_values_doc.substitute(values_info))\n> target_def.append(enum_values_start.substitute(values_info))\n> - for entry in enum:\n> + for enum in ctrl.enum_values:\n> value_info = {\n> - 'name': entry['name']\n> + 'name': enum.name\n> }\n> target_def.append(enum_values_values.substitute(value_info))\n> target_def.append(\"};\")\n> @@ -120,10 +182,7 @@ ${description}\n> target_doc.append(doc_template.substitute(info))\n> target_def.append(def_template.substitute(info))\n>\n> - if ctrl.get('draft'):\n> - name = 'draft::' + name\n> -\n> - ctrls_map.append('\\t{ ' + id_name + ', &' + name + ' },')\n> + ctrls_map.append('\\t{ ' + id_name + ', &' + ctrl.q_name + ' },')\n>\n> return {\n> 'controls_doc': '\\n\\n'.join(ctrls_doc),\n> @@ -146,31 +205,27 @@ def generate_h(controls):\n> id_value = 1\n>\n> for ctrl in controls:\n> - name, ctrl = ctrl.popitem()\n> - id_name = snake_case(name).upper()\n> + id_name = snake_case(ctrl.name).upper()\n>\n> ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n>\n> - ctrl_type = get_ctrl_type(ctrl)\n> -\n> info = {\n> - 'name': name,\n> - 'type': ctrl_type,\n> + 'name': ctrl.name,\n> + 'type': ctrl.type,\n> }\n>\n> target_ctrls = ctrls\n> - if ctrl.get('draft'):\n> + if ctrl.is_draft:\n> target_ctrls = draft_ctrls\n>\n> - enum = ctrl.get('enum')\n> - if enum:\n> + if ctrl.is_enum:\n> target_ctrls.append(enum_template_start.substitute(info))\n>\n> num_entries = 0\n> - for entry in enum:\n> + for enum in ctrl.enum_values:\n> value_info = {\n> - 'name': entry['name'],\n> - 'value': entry['value'],\n> + 'name': enum.name,\n> + 'value': enum.value,\n> }\n> target_ctrls.append(enum_value_template.substitute(value_info))\n> num_entries += 1\n> @@ -214,6 +269,7 @@ def main(argv):\n>\n> data = open(args.input, 'rb').read()\n> controls = yaml.safe_load(data)['controls']\n> + controls = [Control(*ctrl.popitem()) for ctrl in controls]\n\nVery nice!\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> if args.template.endswith('.cpp.in'):\n> data = generate_cpp(controls)\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21D07BE173\n\tfor ;\n\tWed, 10 Aug 2022 08:22:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 655F663328;\n\tWed, 10 Aug 2022 10:22:58 +0200 (CEST)","from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1649A61FAB\n\tfor ;\n\tWed, 10 Aug 2022 10:22:57 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 4A7521BF206;\n\tWed, 10 Aug 2022 08:22:55 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660119778;\n\tbh=KGkl3lBNDXteTRcIX6MrPlItXLebm8XtoRqT+kqQqw4=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=MfRuE86rTJ08n9r0/+S+l+9gv4cPZ/6O17nwfHQDTRGx/Abajkyg7PxMQRV/sLNvC\n\tWSGqQz6lrP+MKpWv3Bw5z3M83oAZYhZEGw+DHhUlisna1AtVTwc1ID0Aw16bL1xD18\n\tyHVIfndfxoKiOczTPq7qslI2BVmSmhycs/wMg3ViQ485zkV8cfzgooZhc+9fnRUHw0\n\t81ssKd/hqP8Ws/rpAqia34sKs1+TKlHqt3uHva499+JFG7t5M/MDqY++DedX6rEiCq\n\tvSxkkBgLsXg/5sLpjzTknOix5M4xTv9Z3/oKV1ZGPTLL78Fbf6SP8hHPrXa16Xsu5d\n\tCEKsuiamlc/Rg==","Date":"Wed, 10 Aug 2022 10:22:54 +0200","To":"Laurent Pinchart ","Message-ID":"<20220810082254.bw2uv7edtdullyu5@uno.localdomain>","References":"<20220810002906.5406-1-laurent.pinchart@ideasonboard.com>\n\t<20220810002906.5406-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220810002906.5406-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/4] utils: gen-controls: Factor out\n\tYAML data handling in classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24528,"web_url":"https://patchwork.libcamera.org/comment/24528/","msgid":"","date":"2022-08-10T22:28:48","subject":"Re: [libcamera-devel] [PATCH 1/4] utils: gen-controls: Factor out\n\tYAML data handling in classes","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Wed, Aug 10, 2022 at 10:22:54AM +0200, Jacopo Mondi wrote:\n> On Wed, Aug 10, 2022 at 03:29:03AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > The gen-controls.py script handles the data structure produced by the\n> > YAML parser manually through the whole code base. Clean this up by\n> > encapsulating it in Control and ControlEnum classes to model a control\n> > and its enum values respectively, to decouple YAML data handling from\n> > generation.\n> >\n> > No functional change intended.\n> >\n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > utils/gen-controls.py | 156 ++++++++++++++++++++++++++++--------------\n> > 1 file changed, 106 insertions(+), 50 deletions(-)\n> >\n> > diff --git a/utils/gen-controls.py b/utils/gen-controls.py\n> > index 46ba439439ec..f6a3ae39cc84 100755\n> > --- a/utils/gen-controls.py\n> > +++ b/utils/gen-controls.py\n> > @@ -14,6 +14,90 @@ import sys\n> > import yaml\n> >\n> >\n> > +class ControlEnum(object):\n> > + def __init__(self, data):\n> > + self.__data = data\n> > +\n> > + @property\n> > + def description(self):\n> > + \"\"\"The enum description\"\"\"\n> > + return self.__data.get('description')\n> > +\n> > + @property\n> > + def name(self):\n> > + \"\"\"The enum name\"\"\"\n> > + return self.__data.get('name')\n> > +\n> > + @property\n> > + def value(self):\n> > + \"\"\"The enum value\"\"\"\n> > + return self.__data.get('value')\n> > +\n> > +\n> > +class Control(object):\n> > + def __init__(self, name, data):\n> > + self.__name = name\n> > + self.__data = data\n> > + self.__enum = None\n> > +\n> > + enum_values = data.get('enum')\n> > + if enum_values is not None:\n> > + self.__enum_values = [ControlEnum(enum) for enum in enum_values]\n> > +\n> > + @property\n> > + def description(self):\n> > + \"\"\"The control description\"\"\"\n> > + return self.__data.get('description')\n> > +\n> > + @property\n> > + def enum_values(self):\n> > + \"\"\"The enum values, if the control is an enumeration\"\"\"\n> > + if self.__enum_values is None:\n> > + return\n> > + for enum in self.__enum_values:\n> > + yield enum\n> > +\n> > + @property\n> > + def is_enum(self):\n> > + \"\"\"Is the control an enumeration\"\"\"\n> > + return self.__data.get('enum') is not None\n> \n> Can you use \"self.__enum_values is not None\" ?\n\nGood idea. I'll address this and fix the typo below.\n\n> > +\n> > + @property\n> > + def is_draft(self):\n> > + \"\"\"Is the control a draft control\"\"\"\n> > + return self.__data.get('draft') is not None\n> > +\n> > + @property\n> > + def name(self):\n> > + \"\"\"The control name (CameCase)\"\"\"\n> \n> \"CamelCase\"\n> \n> > + return self.__name\n> > +\n> > + @property\n> > + def q_name(self):\n> > + \"\"\"The control name, qualified with a namespace\"\"\"\n> > + ns = 'draft::' if self.is_draft else ''\n> > + return ns + self.__name\n> > +\n> > + @property\n> > + def type(self):\n> > + typ = self.__data.get('type')\n> > + size = self.__data.get('size')\n> > +\n> > + if typ == 'string':\n> > + return 'std::string'\n> > +\n> > + if size is None:\n> > + return typ\n> > +\n> > + if len(size) > 0:\n> > + # fixed-sized Span\n> > + span_size = reduce(operator.mul, size)\n> > + return f\"Span\"\n> > + else:\n> > + # variable-sized Span\n> > + return f\"Span\"\n> > +\n> > +\n> > def snake_case(s):\n> > return ''.join([c.isupper() and ('_' + c) or c for c in s]).strip('_')\n> >\n> > @@ -24,24 +108,6 @@ def format_description(description):\n> > return '\\n'.join([(line and ' * ' or ' *') + line for line in description])\n> >\n> >\n> > -def get_ctrl_type(ctrl):\n> > - ctrl_type = ctrl['type']\n> > - ctrl_size_arr = ctrl.get('size')\n> > -\n> > - if ctrl_type == 'string':\n> > - return 'std::string'\n> > - elif ctrl_size_arr is not None:\n> > - if len(ctrl_size_arr) > 0:\n> > - # fixed-sized Span\n> > - ctrl_span_size = reduce(operator.mul, ctrl_size_arr)\n> > - return f\"Span\"\n> > - else:\n> > - # variable-sized Span\n> > - return f\"Span\"\n> > - else:\n> > - return ctrl_type\n> > -\n> > -\n> > def generate_cpp(controls):\n> > enum_doc_start_template = string.Template('''/**\n> > * \\\\enum ${name}Enum\n> > @@ -67,35 +133,31 @@ ${description}\n> > ctrls_map = []\n> >\n> > for ctrl in controls:\n> > - name, ctrl = ctrl.popitem()\n> > - id_name = snake_case(name).upper()\n> > -\n> > - ctrl_type = get_ctrl_type(ctrl)\n> > + id_name = snake_case(ctrl.name).upper()\n> >\n> > info = {\n> > - 'name': name,\n> > - 'type': ctrl_type,\n> > - 'description': format_description(ctrl['description']),\n> > + 'name': ctrl.name,\n> > + 'type': ctrl.type,\n> > + 'description': format_description(ctrl.description),\n> > 'id_name': id_name,\n> > }\n> >\n> > target_doc = ctrls_doc\n> > target_def = ctrls_def\n> > - if ctrl.get('draft'):\n> > + if ctrl.is_draft:\n> > target_doc = draft_ctrls_doc\n> > target_def = draft_ctrls_def\n> >\n> > - enum = ctrl.get('enum')\n> > - if enum:\n> > + if ctrl.is_enum:\n> > enum_doc = []\n> > enum_doc.append(enum_doc_start_template.substitute(info))\n> >\n> > num_entries = 0\n> > - for entry in enum:\n> > + for enum in ctrl.enum_values:\n> > value_info = {\n> > - 'name': name,\n> > - 'value': entry['name'],\n> > - 'description': format_description(entry['description']),\n> > + 'name': ctrl.name,\n> > + 'value': enum.name,\n> > + 'description': format_description(enum.description),\n> > }\n> > enum_doc.append(enum_doc_value_template.substitute(value_info))\n> > num_entries += 1\n> > @@ -110,9 +172,9 @@ ${description}\n> > }\n> > target_doc.append(enum_values_doc.substitute(values_info))\n> > target_def.append(enum_values_start.substitute(values_info))\n> > - for entry in enum:\n> > + for enum in ctrl.enum_values:\n> > value_info = {\n> > - 'name': entry['name']\n> > + 'name': enum.name\n> > }\n> > target_def.append(enum_values_values.substitute(value_info))\n> > target_def.append(\"};\")\n> > @@ -120,10 +182,7 @@ ${description}\n> > target_doc.append(doc_template.substitute(info))\n> > target_def.append(def_template.substitute(info))\n> >\n> > - if ctrl.get('draft'):\n> > - name = 'draft::' + name\n> > -\n> > - ctrls_map.append('\\t{ ' + id_name + ', &' + name + ' },')\n> > + ctrls_map.append('\\t{ ' + id_name + ', &' + ctrl.q_name + ' },')\n> >\n> > return {\n> > 'controls_doc': '\\n\\n'.join(ctrls_doc),\n> > @@ -146,31 +205,27 @@ def generate_h(controls):\n> > id_value = 1\n> >\n> > for ctrl in controls:\n> > - name, ctrl = ctrl.popitem()\n> > - id_name = snake_case(name).upper()\n> > + id_name = snake_case(ctrl.name).upper()\n> >\n> > ids.append('\\t' + id_name + ' = ' + str(id_value) + ',')\n> >\n> > - ctrl_type = get_ctrl_type(ctrl)\n> > -\n> > info = {\n> > - 'name': name,\n> > - 'type': ctrl_type,\n> > + 'name': ctrl.name,\n> > + 'type': ctrl.type,\n> > }\n> >\n> > target_ctrls = ctrls\n> > - if ctrl.get('draft'):\n> > + if ctrl.is_draft:\n> > target_ctrls = draft_ctrls\n> >\n> > - enum = ctrl.get('enum')\n> > - if enum:\n> > + if ctrl.is_enum:\n> > target_ctrls.append(enum_template_start.substitute(info))\n> >\n> > num_entries = 0\n> > - for entry in enum:\n> > + for enum in ctrl.enum_values:\n> > value_info = {\n> > - 'name': entry['name'],\n> > - 'value': entry['value'],\n> > + 'name': enum.name,\n> > + 'value': enum.value,\n> > }\n> > target_ctrls.append(enum_value_template.substitute(value_info))\n> > num_entries += 1\n> > @@ -214,6 +269,7 @@ def main(argv):\n> >\n> > data = open(args.input, 'rb').read()\n> > controls = yaml.safe_load(data)['controls']\n> > + controls = [Control(*ctrl.popitem()) for ctrl in controls]\n> \n> Very nice!\n> \n> Reviewed-by: Jacopo Mondi \n> \n> >\n> > if args.template.endswith('.cpp.in'):\n> > data = generate_cpp(controls)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DF248BE173\n\tfor ;\n\tWed, 10 Aug 2022 22:29:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 515346332B;\n\tThu, 11 Aug 2022 00:29:02 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 096BF61FAA\n\tfor ;\n\tThu, 11 Aug 2022 00:29:01 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6EBB23F1;\n\tThu, 11 Aug 2022 00:29:00 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660170542;\n\tbh=vm+dmjMuEkDUg9RGl0bS9Mh/EDRGO1RhV/Ah41zx90c=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=eXsq+LJ+gYboGacorlp0M8MYZc4paggy+3BE23M75jlf2TKxXEuG3JwpXhYYfAKQq\n\taLko+psY1k5yJbx5B5EgW7cbhgsDqEbclCkhU2WdgnkTBLvIJ/7xxfzdJUaLcc8vEc\n\twaCDZihweWkdFvbNk+j7t5luQYvI1VcJFd+b/urau8BUbf44yAQPnAOXcFRXW+rY8p\n\tx7jUN1gZyV8Btr4kfPD996CxO9tX2jcSTfOi9NqsAVQ//pEvkZCa6vXsGfLclivGLG\n\t+VVVObPf7xMtt8o+gGOrX2z8IA+1XOfJr3tQGU4QBOKkqtAWd/LYPbOOF7wYU3zoNz\n\t9zOanHLJXShKQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660170540;\n\tbh=vm+dmjMuEkDUg9RGl0bS9Mh/EDRGO1RhV/Ah41zx90c=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WqT92UiamC9gKaoK4I+rWW39KB8enKF0VA0Ei3n0Y1G9zIluSQJYj4G6tKvGG9C9R\n\t4MFW590yFCN0jUSOU1tnXMtO1DlZh/50E5Lkr0wlkLW/FxaU2jfuu3/JvqJV6t+ede\n\t98ElRZ9Mf/yAsD4oNYqIz6Iue303O3lbp2VpIXNs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WqT92Uia\"; dkim-atps=neutral","Date":"Thu, 11 Aug 2022 01:28:48 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220810002906.5406-1-laurent.pinchart@ideasonboard.com>\n\t<20220810002906.5406-2-laurent.pinchart@ideasonboard.com>\n\t<20220810082254.bw2uv7edtdullyu5@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220810082254.bw2uv7edtdullyu5@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 1/4] utils: gen-controls: Factor out\n\tYAML data handling in classes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]