[{"id":2279,"web_url":"https://patchwork.libcamera.org/comment/2279/","msgid":"<20190716061814.GF4384@wyvern>","date":"2019-07-16T06:18:14","subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Initialise\n\tpixelFormat in StreamConfiguration()","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-07-16 09:00:42 +0300, Laurent Pinchart wrote:\n> To avoid depending on unitialised values, set the pixelFormat field of\n> the StreamConfiguration class to 0 in the constructor.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/stream.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index de505d12c07a..c28b4cd669b2 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -289,7 +289,7 @@ SizeRange StreamFormats::range(unsigned int pixelformat) const\n> * handlers provied StreamFormats.\n> */\n> StreamConfiguration::StreamConfiguration()\n> -\t: memoryType(InternalMemory), stream_(nullptr)\n> +\t: pixelFormat(0), memoryType(InternalMemory), stream_(nullptr)\n> {\n> }\n> \n> @@ -297,7 +297,8 @@ StreamConfiguration::StreamConfiguration()\n> * \\brief Construct a configuration with stream formats\n> */\n> StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> -\t: memoryType(InternalMemory), stream_(nullptr), formats_(formats)\n> +\t: pixelFormat(0), memoryType(InternalMemory), stream_(nullptr),\n> +\t formats_(formats)\n> {\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-pg1-x543.google.com (mail-pg1-x543.google.com\n\t[IPv6:2607:f8b0:4864:20::543])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4EFB61572\n\tfor ;\n\tTue, 16 Jul 2019 08:18:21 +0200 (CEST)","by mail-pg1-x543.google.com with SMTP id g15so8894343pgi.4\n\tfor ;\n\tMon, 15 Jul 2019 23:18:21 -0700 (PDT)","from localhost ([2a00:79e1:abc:3602:7ede:6a18:219f:2025])\n\tby smtp.gmail.com with ESMTPSA id\n\t14sm30097324pfj.36.2019.07.15.23.18.18\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 15 Jul 2019 23:18:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=l2R94YBZQ3vM5uTL/P5ym4GrJK7P60iumBJ4kO5b1xc=;\n\tb=Z2y2+pL6JPSl6bsMHL6R/eHTLMdpjrTF7VxGc3/Q9aT1jzWCOmxs9TqCkdWyFn8a+Y\n\t2VDeTRrfmDuXpJKUvtNSJ4tGwBELhL4GmQRH3/O/nnClyJLaZWEx1GPqdFi1TE4Wq3F+\n\t2rwoWCSrqpNCjkzzexr9OxfyGewGnSDCd3/hwOsURO5VpaQcWWObmQCPxZgL9qSkWqHZ\n\tsIix/+OrUrvrBXRFMLGjsHVGP39WrvCXXFA/wKb2t+RHvrv2xkmtXtBwHMihnpgJeY5V\n\tYe0gKNR5e5UJtPzpVd6IYu4DyGx+Ykmk5HtNCYW3Hnd4Gai01NfRi03HLjsGwOQtsNTQ\n\tyMoQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=l2R94YBZQ3vM5uTL/P5ym4GrJK7P60iumBJ4kO5b1xc=;\n\tb=YKibsevRUwgog7Ytx4iQMYs3jrbqSRAlqsL+smxbFEXKu/ZiK+JacqpH+0zJX5ap5K\n\tB5hgeP4RgjAtZXGYhfc0Le+/ATezuzdbjmuzad5pttISsfUVlvhweEFABaHFcyCr+q98\n\thZz9tvgvdbR+r6DF2X/uJOuISigGmIP/x+vVr4cVPxlBYL2yW+TyEmrThyYyd6Pg/9eS\n\tgGSRrlRAD6EQQoI3mbDotz1a9pu0sscjAzKJY1cEmbRN+24sBc+5a2ePp91RbXt7/9S1\n\tGuB82N2GJDvE7azAtDX2jIZiX2g2L0co4aLi4pHrIL8C3QiPSoHPVmeDKVYfUG90F7j5\n\t412A==","X-Gm-Message-State":"APjAAAXVmU7zVudML3ZpesqYoA7NFSh1o7Q6bOrR7TYH48MSVwkrgUtS\n\tlg1tYOo3/oF2koFH7y2P7OcN8gbk/mQ=","X-Google-Smtp-Source":"APXvYqx2xBDkDZ/iS3Ihyh4N/dorHkqthTzijAZlmjrBbzEt3oiWGT2WjwrVQLby2hNztixIQgl2Zw==","X-Received":"by 2002:a63:b346:: with SMTP id\n\tx6mr31571079pgt.218.1563257899661; \n\tMon, 15 Jul 2019 23:18:19 -0700 (PDT)","Date":"Tue, 16 Jul 2019 15:18:14 +0900","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190716061814.GF4384@wyvern>","References":"<20190716060042.23035-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190716060042.23035-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Initialise\n\tpixelFormat in StreamConfiguration()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jul 2019 06:18:22 -0000"}},{"id":2281,"web_url":"https://patchwork.libcamera.org/comment/2281/","msgid":"<20190716072733.GA7030@emerald.amanokami.net>","date":"2019-07-16T07:27:33","subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Initialise\n\tpixelFormat in StreamConfiguration()","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn Tue, Jul 16, 2019 at 09:00:42AM +0300, Laurent Pinchart wrote:\n> To avoid depending on unitialised values, set the pixelFormat field of\n> the StreamConfiguration class to 0 in the constructor.\n> \n> Signed-off-by: Laurent Pinchart \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/stream.cpp | 5 +++--\n> 1 file changed, 3 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/stream.cpp b/src/libcamera/stream.cpp\n> index de505d12c07a..c28b4cd669b2 100644\n> --- a/src/libcamera/stream.cpp\n> +++ b/src/libcamera/stream.cpp\n> @@ -289,7 +289,7 @@ SizeRange StreamFormats::range(unsigned int pixelformat) const\n> * handlers provied StreamFormats.\n> */\n> StreamConfiguration::StreamConfiguration()\n> -\t: memoryType(InternalMemory), stream_(nullptr)\n> +\t: pixelFormat(0), memoryType(InternalMemory), stream_(nullptr)\n> {\n> }\n> \n> @@ -297,7 +297,8 @@ StreamConfiguration::StreamConfiguration()\n> * \\brief Construct a configuration with stream formats\n> */\n> StreamConfiguration::StreamConfiguration(const StreamFormats &formats)\n> -\t: memoryType(InternalMemory), stream_(nullptr), formats_(formats)\n> +\t: pixelFormat(0), memoryType(InternalMemory), stream_(nullptr),\n> +\t formats_(formats)\n> {\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7C7960C23\n\tfor ;\n\tTue, 16 Jul 2019 09:27:40 +0200 (CEST)","from emerald.amanokami.net (unknown\n\t[IPv6:2a00:79e1:abc:3602:b57a:2dda:be67:ac6e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9C098564;\n\tTue, 16 Jul 2019 09:27:39 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563262060;\n\tbh=lC0V6nKuiny09YAilg+TRRVRn5UD1RAT9vBcDu2d9tc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Wtmv+m4GMJ5nGgwsf29yLxgH58FF97WG9Q7N1X855zoKeFEWTQBZi6XfoH4+J1kjY\n\tuBwtIZ6fw1q7AMAcrkFBDVMVz9iCcAjlMsJIZOtMPViB/V1CImUASMb3RRQgkUH2xY\n\tVCKcEZFLZFN7eX9wkJxSYDfAK3lJ7/Sp6F/EetNA=","Date":"Tue, 16 Jul 2019 16:27:33 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190716072733.GA7030@emerald.amanokami.net>","References":"<20190716060042.23035-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190716060042.23035-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.9.4 (2018-02-28)","Subject":"Re: [libcamera-devel] [PATCH] libcamera: stream: Initialise\n\tpixelFormat in StreamConfiguration()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jul 2019 07:27:41 -0000"}}]