[{"id":24480,"web_url":"https://patchwork.libcamera.org/comment/24480/","msgid":"<20220809152034.64juajbbr2gdbmdx@uno.localdomain>","date":"2022-08-09T15:20:34","subject":"Re: [libcamera-devel] [PATCH v2 2/3] rkisp1: Add camera lens to PH\n\tand expose it to the IPA","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Daniel\n\nOn Tue, Aug 09, 2022 at 04:47:03PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> Check in pipeline handler if camera lens exists, add expose its controls\n> to the IPA.\n>\n> Signed-off-by: Daniel Semkowicz \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 7 +++++++\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index ee484845..9e4c48a2 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -7,6 +7,7 @@\n>\n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -70,6 +71,7 @@ private:\n> \tstd::map mappedBuffers_;\n>\n> \tControlInfoMap sensorCtrls_;\n> +\tstd::optional lensCtrls_;\n>\n> \t/* Camera sensor controls. */\n> \tbool autoExposure_;\n> @@ -201,6 +203,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n>\n> \tsensorCtrls_ = entityControls.at(0);\n>\n> +\tauto lensControls = entityControls.find(1);\n> +\tif (lensControls != entityControls.end()) {\n> +\t\tlensCtrls_ = lensControls->second;\n> +\t}\n\nno {} for single line statements..\n\nI can fix while applying.\n\nI would like to collect 1 and 2 asap as I'm reworking the RkISP IPA\ninterface and doing it on top of this would be easier\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\n> \tconst auto itExp = sensorCtrls_.find(V4L2_CID_EXPOSURE);\n> \tif (itExp == sensorCtrls_.end()) {\n> \t\tLOG(IPARkISP1, Error) << \"Can't find exposure control\";\n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 93287332..5f10c26b 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -28,6 +28,7 @@\n> #include \n>\n> #include \"libcamera/internal/camera.h\"\n> +#include \"libcamera/internal/camera_lens.h\"\n> #include \"libcamera/internal/camera_sensor.h\"\n> #include \"libcamera/internal/delayed_controls.h\"\n> #include \"libcamera/internal/device_enumerator.h\"\n> @@ -694,6 +695,10 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> \tstd::map entityControls;\n> \tentityControls.emplace(0, data->sensor_->controls());\n>\n> +\tCameraLens *lens = data->sensor_->focusLens();\n> +\tif (lens)\n> +\t\tentityControls.emplace(1, lens->controls());\n> +\n> \tret = data->ipa_->configure(sensorInfo, streamConfig, entityControls);\n> \tif (ret) {\n> \t\tLOG(RkISP1, Error) << \"failed configuring IPA (\" << ret << \")\";\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69CF0C3272\n\tfor ;\n\tTue, 9 Aug 2022 15:20:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C87366332B;\n\tTue, 9 Aug 2022 17:20:38 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::223])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8128761FAA\n\tfor ;\n\tTue, 9 Aug 2022 17:20:37 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id BD24860004;\n\tTue, 9 Aug 2022 15:20:36 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660058438;\n\tbh=pek0IkRimMK4P+WP22HzsXGtgseuvfEevLZhlh8TP8w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=GcVXAnJ9yeNWk1TBfad6enx9OhlbcvJj+3kUSxbXVTP9QKxZ+MptCgqDw6K30/AfP\n\t4f/tAMN9cYdnVv1CsBea7z1lBwfh37t6e8ay9c9HsZdKsIzSa3x9YVtf+1vfVpBX+t\n\tEvF3LWNUFiAeVnP/zJhV6Gxsi2XJ8fdQSTfbcfnf8D8CqkKgHb4H65OCTTfvF/OVxX\n\tAZ9J9qTd4lHYo3NIA5BZHhSuRPIwUAfS71/AE7q04IL3liPFz2y6NBdDYZl1PeGzdP\n\t04Bs/kDT2cDSb9JDf3toOoHz9NTPRQJuDW+XuIDgr1KwpwV+L763sD8h8X3QfT/Fu5\n\tgWviEIMRcfD7Q==","Date":"Tue, 9 Aug 2022 17:20:34 +0200","To":"Daniel Semkowicz ","Message-ID":"<20220809152034.64juajbbr2gdbmdx@uno.localdomain>","References":"<20220809144704.61682-1-dse@thaumatec.com>\n\t<20220809144704.61682-3-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220809144704.61682-3-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] rkisp1: Add camera lens to PH\n\tand expose it to the IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24484,"web_url":"https://patchwork.libcamera.org/comment/24484/","msgid":"<166005970286.15821.15453081744275967740@Monstersaurus>","date":"2022-08-09T15:41:42","subject":"Re: [libcamera-devel] [PATCH v2 2/3] rkisp1: Add camera lens to PH\n\tand expose it to the IPA","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi via libcamera-devel (2022-08-09 16:20:34)\n> Hi Daniel\n> \n> On Tue, Aug 09, 2022 at 04:47:03PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> > Check in pipeline handler if camera lens exists, add expose its controls\n> > to the IPA.\n> >\n> > Signed-off-by: Daniel Semkowicz \n> > ---\n> > src/ipa/rkisp1/rkisp1.cpp | 7 +++++++\n> > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> > 2 files changed, 12 insertions(+)\n> >\n> > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > index ee484845..9e4c48a2 100644\n> > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > @@ -7,6 +7,7 @@\n> >\n> > #include \n> > #include \n> > +#include \n> > #include \n> > #include \n> > #include \n> > @@ -70,6 +71,7 @@ private:\n> > std::map mappedBuffers_;\n> >\n> > ControlInfoMap sensorCtrls_;\n> > + std::optional lensCtrls_;\n> >\n> > /* Camera sensor controls. */\n> > bool autoExposure_;\n> > @@ -201,6 +203,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> >\n> > sensorCtrls_ = entityControls.at(0);\n> >\n> > + auto lensControls = entityControls.find(1);\n> > + if (lensControls != entityControls.end()) {\n> > + lensCtrls_ = lensControls->second;\n> > + }\n> \n> no {} for single line statements..\n> \n> I can fix while applying.\n> \n> I would like to collect 1 and 2 asap as I'm reworking the RkISP IPA\n> interface and doing it on top of this would be easier\n> \n> Reviewed-by: Jacopo Mondi \n\nWith the above sounds fine to me.\n\n\nReviewed-by: Kieran Bingham \n\n> \n> Thanks\n> j\n> \n> > +\n> > const auto itExp = sensorCtrls_.find(V4L2_CID_EXPOSURE);\n> > if (itExp == sensorCtrls_.end()) {\n> > LOG(IPARkISP1, Error) << \"Can't find exposure control\";\n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > index 93287332..5f10c26b 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > @@ -28,6 +28,7 @@\n> > #include \n> >\n> > #include \"libcamera/internal/camera.h\"\n> > +#include \"libcamera/internal/camera_lens.h\"\n> > #include \"libcamera/internal/camera_sensor.h\"\n> > #include \"libcamera/internal/delayed_controls.h\"\n> > #include \"libcamera/internal/device_enumerator.h\"\n> > @@ -694,6 +695,10 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> > std::map entityControls;\n> > entityControls.emplace(0, data->sensor_->controls());\n> >\n> > + CameraLens *lens = data->sensor_->focusLens();\n> > + if (lens)\n> > + entityControls.emplace(1, lens->controls());\n> > +\n> > ret = data->ipa_->configure(sensorInfo, streamConfig, entityControls);\n> > if (ret) {\n> > LOG(RkISP1, Error) << \"failed configuring IPA (\" << ret << \")\";\n> > --\n> > 2.34.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C00AC3272\n\tfor ;\n\tTue, 9 Aug 2022 15:41:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D0FB6332B;\n\tTue, 9 Aug 2022 17:41:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96E1661FAA\n\tfor ;\n\tTue, 9 Aug 2022 17:41:45 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 29A83481;\n\tTue, 9 Aug 2022 17:41:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660059707;\n\tbh=dKBhDNSp/S1Mu2Lj3Cs1UK/8jOY6Cd/xsjPArao3v9s=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rJtw1KOARtJK5GjMkp/iLdD7NnqJuas20tA5MCFrpw085sv2ea9F7FjGFLW9MGnXC\n\t7rVL0NhfEc3a0nFpv6j1CGmQjiT+BaWnxhy4igK84VM6WyaNa2QzlbfGZasc5061hA\n\teAbqzyHcJYh3vQWK8jKvSliIozBftjdtx3d6Sq91chz367kwEM9df2bH96lH+l5hrW\n\tuoZYziBAk7uZqvtpgHt1Nwq+Zxcez24B4zpcKsNV+oNDc22Tifjt6ICsdU9axG9ILz\n\t1c4Ob0veitrCbnzTT6ZjDMqgHiaIq/T6WarL8+eF/XPDLBbJDp1xjDP15Sco0SsEF1\n\tDO/nlLts47AYw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660059705;\n\tbh=dKBhDNSp/S1Mu2Lj3Cs1UK/8jOY6Cd/xsjPArao3v9s=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=j12QWOHAR96pMyYJmdtgLO1ePsPJc+0jkscaM6t3J3t10zLO918bquZ0fNu7QUwxJ\n\tAqvRate5qJ8zL4mb+vsdUaZ6e8XJcfxrnvIAR0NdOJf/ZU8Yv53E4qsmy7Ufldk1VV\n\tl5p+qJ8NT5JR4Cxiyq/qdgjvey8bsUFQsPuAfjTU="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"j12QWOHA\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220809152034.64juajbbr2gdbmdx@uno.localdomain>","References":"<20220809144704.61682-1-dse@thaumatec.com>\n\t<20220809144704.61682-3-dse@thaumatec.com>\n\t<20220809152034.64juajbbr2gdbmdx@uno.localdomain>","To":"Daniel Semkowicz , Jacopo Mondi , \n\tJacopo Mondi via libcamera-devel ","Date":"Tue, 09 Aug 2022 16:41:42 +0100","Message-ID":"<166005970286.15821.15453081744275967740@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] rkisp1: Add camera lens to PH\n\tand expose it to the IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24508,"web_url":"https://patchwork.libcamera.org/comment/24508/","msgid":"","date":"2022-08-10T07:02:25","subject":"Re: [libcamera-devel] [PATCH v2 2/3] rkisp1: Add camera lens to PH\n\tand expose it to the IPA","submitter":{"id":126,"url":"https://patchwork.libcamera.org/api/people/126/","name":"Daniel Semkowicz","email":"dse@thaumatec.com"},"content":"Hi!\n\nOn Tue, Aug 9, 2022 at 5:41 PM Kieran Bingham\n wrote:\n>\n> Quoting Jacopo Mondi via libcamera-devel (2022-08-09 16:20:34)\n> > Hi Daniel\n> >\n> > On Tue, Aug 09, 2022 at 04:47:03PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> > > Check in pipeline handler if camera lens exists, add expose its controls\n> > > to the IPA.\n> > >\n> > > Signed-off-by: Daniel Semkowicz \n> > > ---\n> > > src/ipa/rkisp1/rkisp1.cpp | 7 +++++++\n> > > src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> > > 2 files changed, 12 insertions(+)\n> > >\n> > > diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> > > index ee484845..9e4c48a2 100644\n> > > --- a/src/ipa/rkisp1/rkisp1.cpp\n> > > +++ b/src/ipa/rkisp1/rkisp1.cpp\n> > > @@ -7,6 +7,7 @@\n> > >\n> > > #include \n> > > #include \n> > > +#include \n> > > #include \n> > > #include \n> > > #include \n> > > @@ -70,6 +71,7 @@ private:\n> > > std::map mappedBuffers_;\n> > >\n> > > ControlInfoMap sensorCtrls_;\n> > > + std::optional lensCtrls_;\n> > >\n> > > /* Camera sensor controls. */\n> > > bool autoExposure_;\n> > > @@ -201,6 +203,11 @@ int IPARkISP1::configure([[maybe_unused]] const IPACameraSensorInfo &info,\n> > >\n> > > sensorCtrls_ = entityControls.at(0);\n> > >\n> > > + auto lensControls = entityControls.find(1);\n> > > + if (lensControls != entityControls.end()) {\n> > > + lensCtrls_ = lensControls->second;\n> > > + }\n> >\n> > no {} for single line statements..\n> >\n> > I can fix while applying.\n\nThanks!\nI am wondering if We could add this to the ./utils/checkstyle.py script.\nI see this is a common mistake for me, but the checheckstyle.py is\nblind for these types of mistakes.\n\nBest regards\nDaniel\n\n> >\n> > I would like to collect 1 and 2 asap as I'm reworking the RkISP IPA\n> > interface and doing it on top of this would be easier\n> >\n> > Reviewed-by: Jacopo Mondi \n>\n> With the above sounds fine to me.\n>\n>\n> Reviewed-by: Kieran Bingham \n>\n> >\n> > Thanks\n> > j\n> >\n> > > +\n> > > const auto itExp = sensorCtrls_.find(V4L2_CID_EXPOSURE);\n> > > if (itExp == sensorCtrls_.end()) {\n> > > LOG(IPARkISP1, Error) << \"Can't find exposure control\";\n> > > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > index 93287332..5f10c26b 100644\n> > > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> > > @@ -28,6 +28,7 @@\n> > > #include \n> > >\n> > > #include \"libcamera/internal/camera.h\"\n> > > +#include \"libcamera/internal/camera_lens.h\"\n> > > #include \"libcamera/internal/camera_sensor.h\"\n> > > #include \"libcamera/internal/delayed_controls.h\"\n> > > #include \"libcamera/internal/device_enumerator.h\"\n> > > @@ -694,6 +695,10 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> > > std::map entityControls;\n> > > entityControls.emplace(0, data->sensor_->controls());\n> > >\n> > > + CameraLens *lens = data->sensor_->focusLens();\n> > > + if (lens)\n> > > + entityControls.emplace(1, lens->controls());\n> > > +\n> > > ret = data->ipa_->configure(sensorInfo, streamConfig, entityControls);\n> > > if (ret) {\n> > > LOG(RkISP1, Error) << \"failed configuring IPA (\" << ret << \")\";\n> > > --\n> > > 2.34.1\n> > >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 81FB3BE173\n\tfor ;\n\tWed, 10 Aug 2022 07:02:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3EBB961FAB;\n\tWed, 10 Aug 2022 09:02:38 +0200 (CEST)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0E6D761FAB\n\tfor ;\n\tWed, 10 Aug 2022 09:02:37 +0200 (CEST)","by mail-lf1-x133.google.com with SMTP id x19so11704755lfq.7\n\tfor ;\n\tWed, 10 Aug 2022 00:02:37 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660114958;\n\tbh=hr3x3ug1WEca61j0u0OkNCx9Y8Fgcs4eAGc7DifGeXc=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=EWzGtEM8idsqYloF4sK3bKKOQWMA8ZdH5OcmFIDRAs67+PpfJKGTIDJ3RgfVl7muI\n\thWkg5vj5Vh/Qa3F9uuw8LsanQR1QweVwNG3YBYx/m+ppf5s/AXh3+PhzvaLu1UHWW8\n\tak0QiZSFNwkCV7/nBpHkAM2cXnav9CTNWvVS/HJJxow1KHfQpdvfYPzBbz1UAkhb4r\n\tdPQO8gvmXi1pYHbClHqcJy4Z1PTPPDnENfTgBld1DysMcmQIIXipuhbveLEfIxz9Cw\n\tTdUpV626Yc+VyAyKc+qr3oY4isWJYQQvvemcdFZUogk7KD6hyJnE5s6WplgSqTj/IY\n\tpRN4R895hhhEg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=thaumatec-com.20210112.gappssmtp.com; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc;\n\tbh=bmh9Y4rAv5vJ+XTgOKttXRt49IRlUBE+lvs0ECVQawk=;\n\tb=moAzDWFqAQetFPts9P3Ca9nmbdhc7Wcb5MZ1Q+qXQmBvAPQkq4Ek3oVKXut/h+Yn1Q\n\tVQAunsBWV3h37F4KTg8sA78ssuy1O/pt1JgxHucsvcE4o6BE/OnzX62MI4DO5dRbazPv\n\txdxUAFinW3SNmhFFht6mRb9PlSfJ7vzUdQD/G4SzmavNd/PlmG948ydMZCCyUIQy9G5Z\n\tu4Ah0GvaulieYaCCX7T5+Ahdnok4NZyXzu6rLf3MNiA5FyoNZmzCGvAK52sOKLQZJmka\n\tYlD3AUwUQyFfHpzV6EjqRkmSX3JZtwlHpYWrtiCWiq+jh7XRznMXYjPci+ncEzRFSxcd\n\t6AZA=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=thaumatec-com.20210112.gappssmtp.com\n\theader.i=@thaumatec-com.20210112.gappssmtp.com header.b=\"moAzDWFq\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc;\n\tbh=bmh9Y4rAv5vJ+XTgOKttXRt49IRlUBE+lvs0ECVQawk=;\n\tb=x89IxUcH9Wp/H2b1QzncePc6UYKWcIuu4daNPajWZ+4mLY8c01a2eBKs/kVrDUYEAA\n\tjJlP54o0t8uFqGSTRxh+BWUrwjetKhbm2R6AG5mIGUB+3uxHAg2erTOEIfBvMBacRJeA\n\tl8JPhrDlZFM/8TSUh0oq1sGhwxIkv9ZWKxTQf44Um7oBaXAzF0zGYS76h5PXx9iVzPio\n\tpuQtWnIalmL2rf7Mf+IelU1WuLGgCPqKdb3inNea/uN0wwZ2kiRK1gLmybZWzb52066+\n\tDTltdXLoz20VTDdB150uP6K9OpxB57OiBFJ6uyro3o0P/wSxytGj5yL8jEI1VYVmiA4o\n\tBOOA==","X-Gm-Message-State":"ACgBeo2HQf1qQs5l4rEnDDPO5Szdtmbx+suI8J/WVKugdR1CVlI9WtKw\n\tG3MrMmwXd/y+vI4mpeNu0sKtjoQwhjUh2m3nE3aIZw==","X-Google-Smtp-Source":"AA6agR6OPC10F4Aax5+KjirZ1gV05aVmc5wKWXuQdHtq1A7aR/J7Ce4bt2q+ymSubjI6+gz4cJKnBa7y1drfXTx+kyE=","X-Received":"by 2002:a05:6512:3054:b0:48a:f489:1d68 with SMTP id\n\tb20-20020a056512305400b0048af4891d68mr8234862lfb.260.1660114956367;\n\tWed, 10 Aug 2022 00:02:36 -0700 (PDT)","MIME-Version":"1.0","References":"<20220809144704.61682-1-dse@thaumatec.com>\n\t<20220809144704.61682-3-dse@thaumatec.com>\n\t<20220809152034.64juajbbr2gdbmdx@uno.localdomain>\n\t<166005970286.15821.15453081744275967740@Monstersaurus>","In-Reply-To":"<166005970286.15821.15453081744275967740@Monstersaurus>","Date":"Wed, 10 Aug 2022 09:02:25 +0200","Message-ID":"","To":"Kieran Bingham ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 2/3] rkisp1: Add camera lens to PH\n\tand expose it to the IPA","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Daniel Semkowicz via libcamera-devel\n\t","Reply-To":"Daniel Semkowicz ","Cc":"Jacopo Mondi via libcamera-devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]