[{"id":2277,"web_url":"https://patchwork.libcamera.org/comment/2277/","msgid":"<20190716054641.GD4384@wyvern>","date":"2019-07-16T05:46:41","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: ipu3:\n\tInitialise pixel format to NV12 in new config","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2019-07-16 08:42:17 +0300, Laurent Pinchart wrote:\n> To avoid printing debugging messages related to stream configuration\n> adjustement when generating a new configuration, set the pixel format\n> explicitly instead of relying on the internal validate() call to do so.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 22987dbf1460..febc867b4d7e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -402,6 +402,8 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\tStreamConfiguration cfg = {};\n> \t\tIPU3Stream *stream = nullptr;\n> \n> +\t\tcfg.pixelFormat = V4L2_PIX_FMT_NV12;\n> +\n> \t\tswitch (role) {\n> \t\tcase StreamRole::StillCapture:\n> \t\t\t/*\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-pg1-x544.google.com (mail-pg1-x544.google.com\n\t[IPv6:2607:f8b0:4864:20::544])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D831D60E3C\n\tfor ;\n\tTue, 16 Jul 2019 07:46:48 +0200 (CEST)","by mail-pg1-x544.google.com with SMTP id u17so8850079pgi.6\n\tfor ;\n\tMon, 15 Jul 2019 22:46:48 -0700 (PDT)","from localhost ([2a00:79e1:abc:3602:7ede:6a18:219f:2025])\n\tby smtp.gmail.com with ESMTPSA id\n\t85sm19856795pfv.130.2019.07.15.22.46.45\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tMon, 15 Jul 2019 22:46:45 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=GP4+d3qUjwFFbn90DdegFFotIZ8Ou32D+Yr8YiQfZd8=;\n\tb=MdeBWoWiRmdUzG8yhaS0Y4agzluZCkICZbVLxvr1n9AXSLTTodcAk/r1QBIPEFGp2Z\n\tfosT24HicE/zCSLY9O/QBuG5ZIQy8Me7wvaN/cVQ2tRA4rYwZQoQ/NSRvBMLgWB6XjVo\n\tr0WCcYV9pEdj6JSeQUcyDiZSR8pxDqSCFd7rDeTxn05SC2H1/IEppHpeW8gMYJVhBNsI\n\tltErnIx5Af79YcIG6YUx+kM7YdQSIBR2otNx4STffNJD3vssYDsp8rEWZaLeRMKZcL3z\n\tnOoxnr5LQ2G2X0RcGGRx+yc1VYSjBUqsjjE6LQk/3LhofjMnpyDQ09KzQLU5bxCv5YZM\n\thfZg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=GP4+d3qUjwFFbn90DdegFFotIZ8Ou32D+Yr8YiQfZd8=;\n\tb=YkyQqiiv1y6eEBXxBK1PAepIMAbumIIYH1GbVa/J9CXUOBYvW6rMqykQzwQhqt6mKb\n\t9eU7m5A6am1M0bX9az3p0R/NUzmnyze5HILu+iFMq+v12l/5cuV2MEJI9P3hrAd3vsnY\n\tnVgTcIWh8bQPfzbQYXtS1IpYTMcXc8O3WJEGooy8FUjzZVjgkD8xSp/o18dxxHn9yMch\n\ts2eY/6x3A+Z5X7RyHB1YL6CChvdXy4UaOLWVzEwLXRtXIrEulPbX/J2wryD9fZwOcwA8\n\t9pBXeiYAScFODo8Qd9dKiJb6cZQOR7olG5nAZngfqfgBv83De7PojJVjagc5JpMg5kHz\n\tPL6Q==","X-Gm-Message-State":"APjAAAWIRhuXBI1PP/4w1AOqwUXOiQgwbuAbUybzXAUJxQ4tgTWaNOvH\n\tSd74CGuxwrZ5C9T5+WWbsIFV5PgrfX8=","X-Google-Smtp-Source":"APXvYqzgaTlsGJY6YqSbk1D3iP6bH7L5to3uWdsLZL73thNpnU/L5hUSIr1ksCUO4P7eGnsS9nuoIA==","X-Received":"by 2002:a17:90a:ff17:: with SMTP id\n\tce23mr33728106pjb.47.1563256006926; \n\tMon, 15 Jul 2019 22:46:46 -0700 (PDT)","Date":"Tue, 16 Jul 2019 14:46:41 +0900","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190716054641.GD4384@wyvern>","References":"<20190716054218.22136-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190716054218.22136-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: ipu3:\n\tInitialise pixel format to NV12 in new config","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jul 2019 05:46:49 -0000"}},{"id":2282,"web_url":"https://patchwork.libcamera.org/comment/2282/","msgid":"<20190716073246.GB7030@emerald.amanokami.net>","date":"2019-07-16T07:32:46","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: ipu3:\n\tInitialise pixel format to NV12 in new config","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Laurent,\n\nThanks for the patch.\n\nOn Tue, Jul 16, 2019 at 08:42:17AM +0300, Laurent Pinchart wrote:\n> To avoid printing debugging messages related to stream configuration\n> adjustement when generating a new configuration, set the pixel format\n> explicitly instead of relying on the internal validate() call to do so.\n> \n> Signed-off-by: Laurent Pinchart \n\nLooks good to me.\n\nReviewed-by: Paul Elder \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 22987dbf1460..febc867b4d7e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -402,6 +402,8 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n> \t\tStreamConfiguration cfg = {};\n> \t\tIPU3Stream *stream = nullptr;\n> \n> +\t\tcfg.pixelFormat = V4L2_PIX_FMT_NV12;\n> +\n> \t\tswitch (role) {\n> \t\tcase StreamRole::StillCapture:\n> \t\t\t/*\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3AEF460C23\n\tfor ;\n\tTue, 16 Jul 2019 09:32:54 +0200 (CEST)","from emerald.amanokami.net (unknown\n\t[IPv6:2a00:79e1:abc:3602:b57a:2dda:be67:ac6e])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9363564;\n\tTue, 16 Jul 2019 09:32:52 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563262373;\n\tbh=Z51s4WIB/y19DLLE6LLJSf0SBDW3aqQGO+79R/j9JgE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EHmZUB0/oXb+cziXvSNvGAZvdhL2DBUIeRZX0vg19SCOKcFWB4IrPBpiXiTOjR2RE\n\tg/MPjeApcaklRm/146jatElnS7/ZCuxqaI7zjHbfQWka3S+Wbc8kw+eW3pvgP2Du1V\n\tagK0EET1pYSYlZDYK5YqKukSfwrHDjZUJlivQ7jM=","Date":"Tue, 16 Jul 2019 16:32:46 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190716073246.GB7030@emerald.amanokami.net>","References":"<20190716054218.22136-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20190716054218.22136-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.9.4 (2018-02-28)","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: pipeline: ipu3:\n\tInitialise pixel format to NV12 in new config","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 16 Jul 2019 07:32:54 -0000"}}]