{"id":1704,"url":"https://patchwork.libcamera.org/api/patches/1704/?format=json","web_url":"https://patchwork.libcamera.org/patch/1704/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190716054218.22136-1-laurent.pinchart@ideasonboard.com>","date":"2019-07-16T05:42:17","name":"[libcamera-devel,1/2] libcamera: pipeline: ipu3: Initialise pixel format to NV12 in new config","commit_ref":"d55c8018cdfe6a18aea1f761c8b3f0673d902aff","pull_url":null,"state":"accepted","archived":false,"hash":"65f804cf69b8dbbb78b68e4d6863b5a65ed08ba5","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1704/mbox/","series":[{"id":433,"url":"https://patchwork.libcamera.org/api/series/433/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=433","date":"2019-07-16T05:42:17","name":"[libcamera-devel,1/2] libcamera: pipeline: ipu3: Initialise pixel format to NV12 in new config","version":1,"mbox":"https://patchwork.libcamera.org/series/433/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1704/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1704/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0950860E3C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jul 2019 07:42:51 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a00:79e1:abc:3602:59ec:6c:1869:337])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B8174564\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jul 2019 07:42:49 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563255770;\n\tbh=7862GVobhQ9PFQYQACjt4VSEVZidDvcoDVsOoiH/0Pw=;\n\th=From:To:Subject:Date:From;\n\tb=AaN8yu6jQY1pvyP9KehGvwM1Xg9GrGqxFVR9wRXhqb2p9P+tFl4GGt1K9/IFrbL/L\n\tAr/bD4F2zbPrHMq1yxW8I3m+3RbdvuQdZy2WQ1XIkMMqd88gmmNoAjfF/l7dgrVMrN\n\tssdFIvJtRoTmr2kAEVK2B4/XdLF7zG5X2AliSRQ8=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 16 Jul 2019 08:42:17 +0300","Message-Id":"<20190716054218.22136-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 1/2] libcamera: pipeline: ipu3: Initialise\n\tpixel format to NV12 in new config","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 16 Jul 2019 05:42:51 -0000"},"content":"To avoid printing debugging messages related to stream configuration\nadjustement when generating a new configuration, set the pixel format\nexplicitly instead of relying on the internal validate() call to do so.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex 22987dbf1460..febc867b4d7e 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -402,6 +402,8 @@ CameraConfiguration *PipelineHandlerIPU3::generateConfiguration(Camera *camera,\n \t\tStreamConfiguration cfg = {};\n \t\tIPU3Stream *stream = nullptr;\n \n+\t\tcfg.pixelFormat = V4L2_PIX_FMT_NV12;\n+\n \t\tswitch (role) {\n \t\tcase StreamRole::StillCapture:\n \t\t\t/*\n","prefixes":["libcamera-devel","1/2"]}