[{"id":24475,"web_url":"https://patchwork.libcamera.org/comment/24475/","msgid":"<166005148810.2190824.3027031457381312087@Monstersaurus>","date":"2022-08-09T13:24:48","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove unused algorithms\n\tincludes from rkisp1.cpp","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Semkowicz via libcamera-devel (2022-08-09 14:08:06)\n> Algorithms are now created dynamically basing on tuning file, so there\n> is no longer dependency on specific algorithms.\n> \n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Daniel Semkowicz \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 6cf4d169..17d42d38 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -27,10 +27,7 @@\n> #include \"libcamera/internal/mapped_framebuffer.h\"\n> #include \"libcamera/internal/yaml_parser.h\"\n> \n> -#include \"algorithms/agc.h\"\n> #include \"algorithms/algorithm.h\"\n> -#include \"algorithms/awb.h\"\n> -#include \"algorithms/blc.h\"\n> #include \"libipa/camera_sensor_helper.h\"\n> \n> #include \"ipa_context.h\"\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0050C3272\n\tfor ;\n\tTue, 9 Aug 2022 13:24:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 482D66332B;\n\tTue, 9 Aug 2022 15:24:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E375561FAA\n\tfor ;\n\tTue, 9 Aug 2022 15:24:50 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 73C03481;\n\tTue, 9 Aug 2022 15:24:50 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660051492;\n\tbh=Pg2vZs8eeH9VYwE2MUYUa2Y82fQjTNs2EYIa9wEpdnI=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=FNU5g3of1NkDGYCQxYhJazaCC906W5W1Od1fqFg7nGsAJqJ/KuykKg8xJBrGSyxWF\n\txa34l1d2lGRkmyLjg9Ey0Q0advfH8XBXeNjF86pv+xgjqP9fdtdlVDa0u3K2vNOMWW\n\t0hHoD3RUJMB5MkApWA2TXZ2fK/u0n0JLXgCzmOy6TJeNlavREHqxeIErSpFLaqQxOT\n\tTIVhsgT7YB5oCsR9j7cgCFhJUxYac9hg8g6ZVy4mo3v8SSb/4RIg1GWwkLKSCHsjUB\n\tTRsXWPrN+vfILJMdC62HAWd7yHg+BSsQuUlSUgc5UbypOQr+MUMR8TekXD2nqcIuHi\n\tqvkEq3LYlh/TQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660051490;\n\tbh=Pg2vZs8eeH9VYwE2MUYUa2Y82fQjTNs2EYIa9wEpdnI=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=cSukOK2LTDNtDxdNDSRFDPNkLGrGo6p+EgLXMW9ftMBxmMALx1A/fOx6cHhnUWaW5\n\t/UjkJUU7RNjF1eDT4ClJz1raTT48h03qtQOSAMrC9AfU7nopTDVUuNYSkdFc/14/Gn\n\tWuVsS2StyOi3/PJOrbRl6X7ADsnL6uHvPg/qLr8A="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"cSukOK2L\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220809130806.46753-1-dse@thaumatec.com>","References":"<20220809130806.46753-1-dse@thaumatec.com>","To":"Daniel Semkowicz , libcamera-devel@lists.libcamera.org","Date":"Tue, 09 Aug 2022 14:24:48 +0100","Message-ID":"<166005148810.2190824.3027031457381312087@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove unused algorithms\n\tincludes from rkisp1.cpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24477,"web_url":"https://patchwork.libcamera.org/comment/24477/","msgid":"","date":"2022-08-09T13:28:46","subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove unused algorithms\n\tincludes from rkisp1.cpp","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Daniel,\n\nThank you for the patch.\n\nOn Tue, Aug 09, 2022 at 03:08:06PM +0200, Daniel Semkowicz via libcamera-devel wrote:\n> Algorithms are now created dynamically basing on tuning file, so there\n> is no longer dependency on specific algorithms.\n\nGood catch.\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Daniel Semkowicz \n> ---\n> src/ipa/rkisp1/rkisp1.cpp | 3 ---\n> 1 file changed, 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\n> index 6cf4d169..17d42d38 100644\n> --- a/src/ipa/rkisp1/rkisp1.cpp\n> +++ b/src/ipa/rkisp1/rkisp1.cpp\n> @@ -27,10 +27,7 @@\n> #include \"libcamera/internal/mapped_framebuffer.h\"\n> #include \"libcamera/internal/yaml_parser.h\"\n> \n> -#include \"algorithms/agc.h\"\n> #include \"algorithms/algorithm.h\"\n> -#include \"algorithms/awb.h\"\n> -#include \"algorithms/blc.h\"\n> #include \"libipa/camera_sensor_helper.h\"\n> \n> #include \"ipa_context.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB154BE173\n\tfor ;\n\tTue, 9 Aug 2022 13:29:00 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6253263326;\n\tTue, 9 Aug 2022 15:29:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4697E61FAA\n\tfor ;\n\tTue, 9 Aug 2022 15:28:58 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D3135481;\n\tTue, 9 Aug 2022 15:28:57 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660051740;\n\tbh=s1E9umY8x+2MSzd2YRAwvCXpYgWy47iH5NCjirDy+rU=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=SVqJBeowvteOaObAOc0MUUJz1dBYsnzGgQNal41QwZXLxEQK+oFbbJ4brkFPruRuR\n\t2arQirltpAueEI6dxUeHFrLNzmUjD6DnTY9eMlHnAWy2cN9twflTLLbpegHA6+gIQW\n\t2w24/eQ2+9sUcGdS2KITDkowvK875rI/+D0casJ7rqEBDN+18iWHBMOU2ZgO/lSGo7\n\tlvRhrzEbBtfRZ0tcTqem9LcvEEKZYxQVFvoVgjHH0T2NRW8f4GgEpX3Bjvg7x1MmZp\n\tYs5Xw+RoE36r4D41vXK20nUmTaBudhlCekoPqwdNBHcquf5f8487k3R3gXElC6yM9O\n\tk3QaFrzyUEAwQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660051738;\n\tbh=s1E9umY8x+2MSzd2YRAwvCXpYgWy47iH5NCjirDy+rU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=dPPazRD2Kvr5js+t/CmFb5JhgeEfeC4rkP5J6uPA2UMxhUl939voCWtb5lhNJc8SO\n\tjs2ALDjeLTItMkIsONNKMkk32vAOvNTjWbJLS73m50ClHojPIJ3bCDURDfQT1Yd6M8\n\tecTKDDMMF2+cN50JXvG6rvODEAMy2RjjwuczOOqg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"dPPazRD2\"; dkim-atps=neutral","Date":"Tue, 9 Aug 2022 16:28:46 +0300","To":"Daniel Semkowicz ","Message-ID":"","References":"<20220809130806.46753-1-dse@thaumatec.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220809130806.46753-1-dse@thaumatec.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: rkisp1: Remove unused algorithms\n\tincludes from rkisp1.cpp","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]