[{"id":24460,"web_url":"https://patchwork.libcamera.org/comment/24460/","msgid":"","date":"2022-08-09T10:42:16","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: meson: Use\n\tdependency() to find gnutls","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Tue, 9 Aug 2022 at 00:08, Laurent Pinchart\n wrote:\n>\n> The gnutls library ships a pkgconfig .pc file. Use the standard\n> dependency() method to locate it, instead of cc.find_library().\n>\n> Signed-off-by: Laurent Pinchart \n\nLGTM.\n\nReviewed-by: Eric Curtin \n\n> ---\n> src/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index b57bee7ef6ca..7cc06de4aedc 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -65,7 +65,7 @@ subdir('pipeline')\n> subdir('proxy')\n>\n> libdl = cc.find_library('dl')\n> -libgnutls = cc.find_library('gnutls', required : true)\n> +libgnutls = dependency('gnutls', required : true)\n> libudev = dependency('libudev', required : false)\n> libyaml = dependency('yaml-0.1', required : false)\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D78E6BE173\n\tfor ;\n\tTue, 9 Aug 2022 10:42:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9231F603EA;\n\tTue, 9 Aug 2022 12:42:36 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7E65600EA\n\tfor ;\n\tTue, 9 Aug 2022 12:42:34 +0200 (CEST)","from mail-qk1-f200.google.com (mail-qk1-f200.google.com\n\t[209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-449-bxJyEvR8PRiAloIIpFQchQ-1; Tue, 09 Aug 2022 06:42:32 -0400","by mail-qk1-f200.google.com with SMTP id\n\th8-20020a05620a284800b006b5c98f09fbso10046583qkp.21\n\tfor ;\n\tTue, 09 Aug 2022 03:42:32 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660041756;\n\tbh=WYI84ZczolC+hfdDbgyKPB0UGPlPTbCNX1gtxPTbM2s=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=cGsXWhWts72sELajtC+hjyqGNKn9s8fRqdqybOkqTxcoDAPSrYYlLdr59/XQxbeDS\n\tJWmV8Y6G9i4sspW4pnz4VP7CmqZVffkKrDtiC2HbZf5qxnCZJo7Y+VHNOrsX+GegpN\n\te805s2UrcQFveSEEAggUUB8Bt6MAmWfcYMk0U/lFy/wTUXcuUw5k2JlgzkzZtzUfq8\n\tM/nrxrqYZH4MK5Six4kIfPlINzPQuEkiOBwUaljl9ciRhgYMpewuyQZVq3W+j09Wxh\n\tV06zrEV1ny6N93soXiS6ek/vC2/pgzRS/8/+EaIEFT2QvnLhIqDVf8nDk6aGXuE3zm\n\tLoHV8joocYVyw==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1660041753;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ToU285eD7th3g83gobe2I0MwT27t67X/Sl/Unm4Xn4Y=;\n\tb=Ui4sRibLVdD01YS/1EhnGdIyCWJKGS9cEHFtPmLuaIekH8CLEgXFSENLW7NaV+j3y2O6LB\n\tSoGKc4bIXJeKcXIceQcJajo6InCWu3FbdQPbKM0Uwhk8tfTeGQ8y4EwELmdavo0VFbLE72\n\t0Dq45V8brXhYK2ZNzP6515csbvri5cQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"Ui4sRibL\"; \n\tdkim-atps=neutral","X-MC-Unique":"bxJyEvR8PRiAloIIpFQchQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ToU285eD7th3g83gobe2I0MwT27t67X/Sl/Unm4Xn4Y=;\n\tb=LbZJz0ao1P0kzPrHAn8jrB6l8clV1lqZ/UPPsG98jb2XcbJiFH35oZJ4iX0Scm5Byj\n\tTr4iPWWq66oxieUvIAlY3eSTy8ys0Z3buuoji9F5JSAHoj2Z5AYZOw9f7rvE5jZkspde\n\tvRpy1wj+JO0fD+4z084bUEg0hMHVhE/V1iF+WjmvcVKFTqkOiBWirLYFuPV1yRKpls0p\n\tSUPe1itpMYsdMfjqUitFYVVDjOpzAnTSvhBe7Vr4rMz/qrjosps7QFdq7cNxJHRaHj7n\n\tAG9c7Q9Y2xK9hRO8veEWqTGHgUDxgqWhpBrtaM8zLkfzhEttQwMc94Of4lkKL85pPZre\n\tzMag==","X-Gm-Message-State":"ACgBeo2QSyI8n+esOqvzfh9DGNth+uJr/f8X3rT8MAqoPwRywC550cQF\n\tV9MLpFJW2gGrQnTQeNxKD/G3H0DNMMYoNpGh/KYbnPD0DaBAlGnTd5FdejlKWyBGEE4zu6zwkrB\n\tHWTWLJ5L5s+ynI9ul7SiF4U/zQLnlYVYphQs6+CKMbUplxiSi/A==","X-Received":["by 2002:ac8:7d95:0:b0:31e:e0d3:60a4 with SMTP id\n\tc21-20020ac87d95000000b0031ee0d360a4mr19485960qtd.106.1660041752315; \n\tTue, 09 Aug 2022 03:42:32 -0700 (PDT)","by 2002:ac8:7d95:0:b0:31e:e0d3:60a4 with SMTP id\n\tc21-20020ac87d95000000b0031ee0d360a4mr19485956qtd.106.1660041752127;\n\tTue, 09 Aug 2022 03:42:32 -0700 (PDT)"],"X-Google-Smtp-Source":"AA6agR7nZARi0pkc/Z9jSka5gXl/nqxKdpybBw1NotjtEUVd18LdbOVJDMGErDTFWJxlmIpoz4vp1ltJwwuHzsmV/XY=","MIME-Version":"1.0","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>\n\t<20220808230833.16275-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220808230833.16275-2-laurent.pinchart@ideasonboard.com>","Date":"Tue, 9 Aug 2022 11:42:16 +0100","Message-ID":"","To":"Laurent Pinchart ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: meson: Use\n\tdependency() to find gnutls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24469,"web_url":"https://patchwork.libcamera.org/comment/24469/","msgid":"<166004759035.2190824.3345216459152428059@Monstersaurus>","date":"2022-08-09T12:19:50","subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: meson: Use\n\tdependency() to find gnutls","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-08-09 00:08:30)\n> The gnutls library ships a pkgconfig .pc file. Use the standard\n> dependency() method to locate it, instead of cc.find_library().\n> \n> Signed-off-by: Laurent Pinchart \n\nSeems reasonable\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/meson.build | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index b57bee7ef6ca..7cc06de4aedc 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -65,7 +65,7 @@ subdir('pipeline')\n> subdir('proxy')\n> \n> libdl = cc.find_library('dl')\n> -libgnutls = cc.find_library('gnutls', required : true)\n> +libgnutls = dependency('gnutls', required : true)\n> libudev = dependency('libudev', required : false)\n> libyaml = dependency('yaml-0.1', required : false)\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 277DFBE173\n\tfor ;\n\tTue, 9 Aug 2022 12:19:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D44406332B;\n\tTue, 9 Aug 2022 14:19:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1844E61FAA\n\tfor ;\n\tTue, 9 Aug 2022 14:19:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BDB7B481;\n\tTue, 9 Aug 2022 14:19:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660047594;\n\tbh=yRKf8V62wlP9IcrseyvttbUHJf+CtXWpliJbVIK6TZo=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=g7D2EC4Wu889V8LPTBRwvw3J0k6Mcs3EU4wjsogIZVde9xIgBDcF8rjYVgBd6FNi1\n\tCUB11DqBt0PgljaOpcIo4NW6q2tAWg8eU5NlibQpwUSeOr2yDiE9O/wlNJ2gtfGFfk\n\t0/ogkEiVviJGuE48zT40AAp1NxcLxtLGxhbqjsk1F/gQnUERWvfuZy0SaiEjBOBId6\n\tGH/FKCTK2LiKJGO5sR/PAx2MMJGclU+dJ+gStaYtSvVaPJwLV3PPkPEh9Sep05jHfO\n\tTh3pUzEgsq+cNa68UY10o/podQPbXqXJqNDyMgGBaZ/CKMZHOj48Fb1f7F6n4Q+O7e\n\tE/P1z4emxPlhw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660047592;\n\tbh=yRKf8V62wlP9IcrseyvttbUHJf+CtXWpliJbVIK6TZo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=R6ogwhKn1mB5j+m/D2BjneFna4O3VluSxvl32Q6uhRYTz9JNYB8z0V5OwEG3f7WXC\n\txk8G4dsckN4yOoV0GgMAnPbGOjTLuBU2J4rG90ZrQ5ebFqZ1x5IKpEoV1C/KwLKC/T\n\tNlCzVZIRw46IaY4n1rkIBUroQqP0yLX6oWPdLEEE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R6ogwhKn\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220808230833.16275-2-laurent.pinchart@ideasonboard.com>","References":"<20220808230833.16275-1-laurent.pinchart@ideasonboard.com>\n\t<20220808230833.16275-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Aug 2022 13:19:50 +0100","Message-ID":"<166004759035.2190824.3345216459152428059@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH v2 1/4] libcamera: meson: Use\n\tdependency() to find gnutls","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]