{"id":17025,"url":"https://patchwork.libcamera.org/api/patches/17025/?format=json","web_url":"https://patchwork.libcamera.org/patch/17025/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220808151918.25411-1-laurent.pinchart@ideasonboard.com>","date":"2022-08-08T15:19:18","name":"[libcamera-devel,RFC] libcamera: base: Make message.h and mutex.h private","commit_ref":"777b0e0a655cce258a2b11e98546c3fc5a5be031","pull_url":null,"state":"accepted","archived":false,"hash":"eb95d49da1b8f5cf3323d00ec32dc3e4445b2117","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17025/mbox/","series":[{"id":3388,"url":"https://patchwork.libcamera.org/api/series/3388/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3388","date":"2022-08-08T15:19:18","name":"[libcamera-devel,RFC] libcamera: base: Make message.h and mutex.h private","version":1,"mbox":"https://patchwork.libcamera.org/series/3388/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17025/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17025/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1FA2EC3272\n\tfor ;\n\tMon, 8 Aug 2022 15:19:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 49C9D6332B;\n\tMon, 8 Aug 2022 17:19:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2E2A063315\n\tfor ;\n\tMon, 8 Aug 2022 17:19:29 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FDAB481\n\tfor ;\n\tMon, 8 Aug 2022 17:19:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659971970;\n\tbh=cvRy7+V5wIPAWKnef4qBm0Cs9AYoHmxNurZWBb2QiUs=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=J7Q8rvp/Ur2YT72DPUDNmiLbFw6pUM7z6ZQo/vROkPEnK/8oU/Q0vVsdflryHe9tx\n\tbNz7AgvN5uDkPahKC3NlcAz+/oWWygS/Fo9ruHuJ8LcDqsLLuFD8o4/bZuk7YtP7RO\n\tOD1RVeW+oZn/uuzq7Fp2HvCRYnVrUOHSjMwAmHhMda/Az7l/QqLlluRDCvfUvm+7Bx\n\t25BjohEGaJSeQGnifROCJgiomD3zE7Ns/eN7VAMTbDnxqiuSnh9NxJapJl7ySupiZt\n\t+VRq2ETSzpWkAtB78vnKa6/ZsJSzBF+JyQ05fXwd/yZkJayK29w+5pNH9u6XcIPude\n\tDp8CI6rTW8Dkg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659971968;\n\tbh=cvRy7+V5wIPAWKnef4qBm0Cs9AYoHmxNurZWBb2QiUs=;\n\th=From:To:Subject:Date:From;\n\tb=DG7k4wTLuPhuwtaGQ9+jrj7HaQocHYfy7gdgqYX0k4SmCaa+jFz/3raWlLOxI4fdP\n\tpCAqVVnq0mTqGSWdnwnZbUJBG0iAzBwZVB8rDNIcBPtSZTxyysTqQBBRl3pkVAbw1V\n\tgbe8ez9dNkELj3UKJXpLipJd8GSIeejgRiFXyuKw="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"DG7k4wTL\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 8 Aug 2022 18:19:18 +0300","Message-Id":"<20220808151918.25411-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [RFC PATCH] libcamera: base: Make message.h and\n\tmutex.h private","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The message.h and mutex.h headers are not used in the libcamera public\nAPI. Make them private to avoid there usage in applications, and to\nprevent having to maintain them with a stable ABI.\n\nAs mutex.h is used by libcamerasrc, the GStreamer element must switch\nfrom the libcamera_public to the libcamera_private dependency.\n\nSigned-off-by: Laurent Pinchart \n---\n include/libcamera/base/message.h | 2 ++\n include/libcamera/base/mutex.h | 2 ++\n src/gstreamer/meson.build | 2 +-\n 3 files changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/base/message.h b/include/libcamera/base/message.h\nindex 65572c7470e9..b939af6f79bb 100644\n--- a/include/libcamera/base/message.h\n+++ b/include/libcamera/base/message.h\n@@ -9,6 +9,8 @@\n \n #include \n \n+#include \n+\n #include \n \n namespace libcamera {\ndiff --git a/include/libcamera/base/mutex.h b/include/libcamera/base/mutex.h\nindex 2d23e49e4546..52441c55287a 100644\n--- a/include/libcamera/base/mutex.h\n+++ b/include/libcamera/base/mutex.h\n@@ -10,6 +10,8 @@\n #include \n #include \n \n+#include \n+\n #include \n \n namespace libcamera {\ndiff --git a/src/gstreamer/meson.build b/src/gstreamer/meson.build\nindex 77c79140eb37..eda246d7ffc8 100644\n--- a/src/gstreamer/meson.build\n+++ b/src/gstreamer/meson.build\n@@ -42,7 +42,7 @@ endif\n libcamera_gst = shared_library('gstlibcamera',\n libcamera_gst_sources,\n cpp_args : libcamera_gst_cpp_args,\n- dependencies : [libcamera_public, gstvideo_dep, gstallocator_dep],\n+ dependencies : [libcamera_private, gstvideo_dep, gstallocator_dep],\n install: true,\n install_dir : '@0@/gstreamer-1.0'.format(get_option('libdir')),\n )\n","prefixes":["libcamera-devel","RFC"]}