[{"id":24497,"web_url":"https://patchwork.libcamera.org/comment/24497/","msgid":"","date":"2022-08-10T00:39:31","subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Search V4L2\n\tformat info on map","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Aug 08, 2022 at 02:48:48PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Commit f25ad4a2b16b (\"libcamera: formats: Reimplement V4L2\n> PixelFormatInfo::info()\") changed the PixelFormatInfo::info(const\n> V4L2PixelFormat &format) function overload to:\n> \n> \treturn info(format.toPixelFormat());\n> \n> After the series that contains such commit, the PixelFormatInfo for the\n> pixel format applied to a video device is retrieved at\n> V4L2VideoDevice::open() time. Some video devices register formats not\n> available to applications, for example metadata formats or, in the case\n> of ISP devices, formats to describe the ISP statistics and parameters.\n> \n> This causes the\n> \n> \tformat.toPixelFormat()\n> \n> call to output a WARN message, which spams the log and unnecessary alert\n\ns/unnecessary alert/unnecessarily alerts/\n\n> the users.\n> \n> Restore the behaviour preceding commit f25ad4a2b16b, which in the case\n> a V4L2 pixel format is not registered in the map of formats known to\n> libcamera, silently returns an invalid PixelFormatInfo without\n> outputting any unnecessary warning message.\n> \n> Fixes: f25ad4a2b16b (\"libcamera: formats: Reimplement V4L2 PixelFormatInfo::info()\")\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/formats.cpp | 11 ++++++++++-\n> 1 file changed, 10 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 0bd0e09ae44c..51eccdce064e 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -852,7 +852,16 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n> */\n> const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n> {\n> -\treturn info(format.toPixelFormat());\n> +\tconst auto &info = std::find_if(pixelFormatInfo.begin(), pixelFormatInfo.end(),\n> +\t\t\t\t\t[&format](auto &pair) {\n> +\t\t\t\t\t\tconst auto &formats = pair.second.v4l2Formats;\n> +\t\t\t\t\t\treturn std::find(formats.begin(), formats.end(), format)\n> +\t\t\t\t\t\t\t!= formats.end();\n> +\t\t\t\t\t});\n> +\tif (info == pixelFormatInfo.end())\n> +\t\treturn pixelFormatInfoInvalid;\n> +\n> +\treturn info->second;\n\nAs discussed separately, this isn't very efficient as it loops over the\nwhole map. You have posted a v2 that addresses this, and there are\nongoing discussions about which approach is best. In case this one gets\nselected, with the commit message fixed,\n\nReviewed-by: Laurent Pinchart \n\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78758BE173\n\tfor ;\n\tWed, 10 Aug 2022 00:39:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E520A63326;\n\tWed, 10 Aug 2022 02:39:45 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E77C761FA9\n\tfor ;\n\tWed, 10 Aug 2022 02:39:43 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C10D481;\n\tWed, 10 Aug 2022 02:39:43 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660091985;\n\tbh=sCgThrc3SSJmIECrlUyCVv+827Mom0oB24bDgytGWfg=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZXrd7HwIgEZRu2it4b9vQ20IiRKF2FscmRQibpFFEeTq9XY4hhlTD2IzPOwCtQHoT\n\tA8yGtAeDULJoHmYYq2QA32yxk/7zm9giCMjAHS64NdK4JioXtuZKwU8jMYi47mcSib\n\tjAy21nsWx4ygzBbOqArc7Zr+jAmusQjK3EdKfc16NyZc8IaT5DLvkgfO8H5fcE9edh\n\tQhHeMc+5NOT0UZVvnrX1rYxtD86fLEMo20oselov12/bAIWNS2mnDB63t0bEr527CC\n\tkO1+I1OrZAa9nT4LCt3QHL8o/Z0+lyaXHhyd3cVHqxy3zXkLt/dmqJkxL1lJLAUmqv\n\tZTks0alH5EaVQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660091983;\n\tbh=sCgThrc3SSJmIECrlUyCVv+827Mom0oB24bDgytGWfg=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UYHJ20Fg25G7S/5CP4zTCCdKkvE6KZe7OeepiVfHzgMjr1LqkmNoiKj4mwO+8Tr9q\n\t1y5qkDY8fjzMUN2jiKyyii/vYl15ma6rJh7WSbBh/Rn3SmgP4JncltJETfXTOOVSJc\n\tBpLNoKlYhZ1qpPj4U8Ep3cgoLDZBRTKSz1eHLi/I="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"UYHJ20Fg\"; dkim-atps=neutral","Date":"Wed, 10 Aug 2022 03:39:31 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220808124848.35258-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220808124848.35258-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] libcamera: formats: Search V4L2\n\tformat info on map","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]