[{"id":2284,"web_url":"https://patchwork.libcamera.org/comment/2284/","msgid":"<20190716073840.lqre54h636atevw5@uno.localdomain>","date":"2019-07-16T07:38:40","subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: message: Document\n\tMessage::SignalMessage","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n   thanks for the patch\n\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n\nOn Mon, Jul 15, 2019 at 12:29:38PM +0300, Laurent Pinchart wrote:\n> The SignalMessage type is undocumented. Fix it.\n>\n> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n> ---\n>  src/libcamera/message.cpp | 2 ++\n>  1 file changed, 2 insertions(+)\n>\n> diff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\n> index 0580c1051622..9f22ad7fc0b0 100644\n> --- a/src/libcamera/message.cpp\n> +++ b/src/libcamera/message.cpp\n> @@ -41,6 +41,8 @@ LOG_DEFINE_CATEGORY(Message)\n>   * \\brief The message type\n>   * \\var Message::None\n>   * \\brief Invalid message type\n> + * \\var Message::SignalMessage\n> + * \\brief Asynchronous signal delivery across threads\n>   */\n>\n>  /**\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3353060C23\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 16 Jul 2019 09:37:30 +0200 (CEST)","from uno.localdomain (unknown [104.132.146.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id D76294000A;\n\tTue, 16 Jul 2019 07:37:28 +0000 (UTC)"],"X-Originating-IP":"104.132.146.101","Date":"Tue, 16 Jul 2019 09:38:40 +0200","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190716073840.lqre54h636atevw5@uno.localdomain>","References":"<20190715092939.15349-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"mik6p7s63x7kgakj\"","Content-Disposition":"inline","In-Reply-To":"<20190715092939.15349-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH 1/2] libcamera: message: Document\n\tMessage::SignalMessage","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Tue, 16 Jul 2019 07:37:30 -0000"}}]