[{"id":24395,"web_url":"https://patchwork.libcamera.org/comment/24395/","msgid":"<165990176569.1706285.1930613565278715606@Monstersaurus>","date":"2022-08-07T19:49:25","subject":"Re: [libcamera-devel] [PATCH 1/3] cam: drm: Add support for\n\ttest-only commits","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-08-07 19:00:58)\n> Test-only commits are used to test a commit without applying any\n> modification to the device. This will be used by the KMS sink to test\n> feature support.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/drm.cpp | 2 ++\n> src/cam/drm.h | 1 +\n> 2 files changed, 3 insertions(+)\n> \n> diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\n> index fbfc0a595d36..b0602c942853 100644\n> --- a/src/cam/drm.cpp\n> +++ b/src/cam/drm.cpp\n> @@ -377,6 +377,8 @@ int AtomicRequest::commit(unsigned int flags)\n> drmFlags |= DRM_MODE_ATOMIC_ALLOW_MODESET;\n> if (flags & FlagAsync)\n> drmFlags |= DRM_MODE_PAGE_FLIP_EVENT | DRM_MODE_ATOMIC_NONBLOCK;\n> + if (flags & FlagTestOnly)\n> + drmFlags |= DRM_MODE_ATOMIC_TEST_ONLY;\n> \n> return drmModeAtomicCommit(dev_->fd(), request_, drmFlags, this);\n> }\n> diff --git a/src/cam/drm.h b/src/cam/drm.h\n> index 655a7509c001..ebaea04d3974 100644\n> --- a/src/cam/drm.h\n> +++ b/src/cam/drm.h\n> @@ -251,6 +251,7 @@ public:\n> enum Flags {\n> FlagAllowModeset = (1 << 0),\n> FlagAsync = (1 << 1),\n> + FlagTestOnly = (1 << 2),\n\nI still want BIT() :-D but perhaps here it should be FLAG() ...\n\nReviewed-by: Kieran Bingham \n\n> };\n> \n> AtomicRequest(Device *dev);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0B92FC3272\n\tfor ;\n\tSun, 7 Aug 2022 19:49:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BF54763327;\n\tSun, 7 Aug 2022 21:49:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AD5C863312\n\tfor ;\n\tSun, 7 Aug 2022 21:49:28 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D845749;\n\tSun, 7 Aug 2022 21:49:28 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659901770;\n\tbh=S4YZR+nYxqyZFz3vUUUwOvrG/kuvOb7/LhwYxPrShog=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=3PbcesKnW2frZjxiQow4xmq55/RjmQ4AJHBj5zJM+s38f8rUd52qp6UBvcVswXpWZ\n\ttl53QreYvC+YEXihqv0IEwl495t0wYHS/F/5ug5gwxACdObd4vuJ9A4o8Wzsii/vdP\n\tWYI4GYHKsLvcXUJ/FxCvfQA9YyJ+PIxKHekzmF/Ax9Ugan+lJ6EzjvTlr+PLkRffpO\n\tN/Q33jTFk4zXmN+rJHevk8HoSNQbRq5c2hoBoZuGqH0uIS3GydBRfIZVczjoEn9pke\n\tWMO9/2QrRi5m+NoVqLd8SIL6b/29YV1JZLVIohmmnUOtEq3r2tOerDHQrDt+qPz0xI\n\taUtVYJchszRcw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659901768;\n\tbh=S4YZR+nYxqyZFz3vUUUwOvrG/kuvOb7/LhwYxPrShog=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=gfZU+XsyP7/w5jKnHIYrzXi88erXMAYICEfER93VVpmtHl0q4s6VfYalJhT8npqYC\n\t9wU5p59Voenk6Nv4fBAp+ceohEkdFkRRdXXvCd9o0wUSROATTTn9uhIl5iKlTiwDDO\n\tEoyrgxT8uInihZK//MI/QuXi3RrCsI/r8QM4rLOM="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"gfZU+Xsy\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220807180100.396-2-laurent.pinchart@ideasonboard.com>","References":"<20220807180100.396-1-laurent.pinchart@ideasonboard.com>\n\t<20220807180100.396-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 07 Aug 2022 20:49:25 +0100","Message-ID":"<165990176569.1706285.1930613565278715606@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/3] cam: drm: Add support for\n\ttest-only commits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24426,"web_url":"https://patchwork.libcamera.org/comment/24426/","msgid":"","date":"2022-08-08T10:38:01","subject":"Re: [libcamera-devel] [PATCH 1/3] cam: drm: Add support for\n\ttest-only commits","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"Hi Laurent,\n\nOn Sun, 7 Aug 2022 at 19:01, Laurent Pinchart\n wrote:\n>\n> Test-only commits are used to test a commit without applying any\n> modification to the device. This will be used by the KMS sink to test\n> feature support.\n>\n> Signed-off-by: Laurent Pinchart \n\nLGTM, and also tested successfully.\n\nReviewed-by: Eric Curtin \n\n> ---\n> src/cam/drm.cpp | 2 ++\n> src/cam/drm.h | 1 +\n> 2 files changed, 3 insertions(+)\n>\n> diff --git a/src/cam/drm.cpp b/src/cam/drm.cpp\n> index fbfc0a595d36..b0602c942853 100644\n> --- a/src/cam/drm.cpp\n> +++ b/src/cam/drm.cpp\n> @@ -377,6 +377,8 @@ int AtomicRequest::commit(unsigned int flags)\n> drmFlags |= DRM_MODE_ATOMIC_ALLOW_MODESET;\n> if (flags & FlagAsync)\n> drmFlags |= DRM_MODE_PAGE_FLIP_EVENT | DRM_MODE_ATOMIC_NONBLOCK;\n> + if (flags & FlagTestOnly)\n> + drmFlags |= DRM_MODE_ATOMIC_TEST_ONLY;\n>\n> return drmModeAtomicCommit(dev_->fd(), request_, drmFlags, this);\n> }\n> diff --git a/src/cam/drm.h b/src/cam/drm.h\n> index 655a7509c001..ebaea04d3974 100644\n> --- a/src/cam/drm.h\n> +++ b/src/cam/drm.h\n> @@ -251,6 +251,7 @@ public:\n> enum Flags {\n> FlagAllowModeset = (1 << 0),\n> FlagAsync = (1 << 1),\n> + FlagTestOnly = (1 << 2),\n> };\n>\n> AtomicRequest(Device *dev);\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E1AAC3272\n\tfor ;\n\tMon, 8 Aug 2022 10:38:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D2CB163327;\n\tMon, 8 Aug 2022 12:38:22 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5293F63315\n\tfor ;\n\tMon, 8 Aug 2022 12:38:20 +0200 (CEST)","from mail-qk1-f199.google.com (mail-qk1-f199.google.com\n\t[209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-261-oxtw4SV4PcybvvcEvFX6dg-1; Mon, 08 Aug 2022 06:38:18 -0400","by mail-qk1-f199.google.com with SMTP id\n\ty17-20020a05620a25d100b006b66293d75aso7591015qko.17\n\tfor ;\n\tMon, 08 Aug 2022 03:38:18 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659955102;\n\tbh=CTYNZ73/cvBmmM9faYqg3MKh2Kvn/FBWBa76W0eWOgE=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=evcx9SFJAOQkX6MhoEtBSJ+zsGfLIjMDhDIHt50KLrfAR7XnQg2vmfeRp0r5zcR+j\n\t0QBSEP8C+XWlAhVqKXkG1kszAvNIdfCgKaV/iSLDuWjhAgdZxuv/q0MpxkCwSlN1xn\n\ttJSezuYLfo1d5oGiShkTgyGK23OFfH2E7d8qbwhjdz1mfLZ6jcnNQ9jP/UGE5FADdK\n\t55ll9MilIEWXN1u+KFkYy9x16JbcOqx9XekA3Fvu+MVaqPvqmKQr4EahglDHSSi85R\n\txNf0RsyYB+COJOnaM0gIkjou2SJfX4ieLPewQvMVLzZyaiLc15/fCXQNNt4gEhOZ7z\n\tz+svgAb2VXRBg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1659955099;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=BtnQYlccwnFm6jhnRahP1qQvLWMliX+LcqiQTSNpL4g=;\n\tb=hBD+WJP1cb+pLfiCH/9/hZnotIq3khg/o8c340dikQ/Ct6BgPZNzWIBtK1dA8n21eFV/55\n\tfMTV5d7o2UnvnUNgC98Um/FJISWgtVIWorHE8VMaBvsPCJ2zQHA1QJRkLU33pZ26M8lj6H\n\tyNW9JGHq+vUPjnXpi6j5WHfo9SsctW0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"hBD+WJP1\"; \n\tdkim-atps=neutral","X-MC-Unique":"oxtw4SV4PcybvvcEvFX6dg-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=BtnQYlccwnFm6jhnRahP1qQvLWMliX+LcqiQTSNpL4g=;\n\tb=0yfzVNagPmMvPyyof+PDj50faWepqmCNoEjdr39VzWpOBorrkM4p7jQK01dHcRQfbQ\n\tNdMBdg3kDKeOCWr+b9qwYMbBRW4eHQPD+k2o1XSXGq/2K9w6IP1ZosfgddesiQQL3tKP\n\tpNZsYUmatR6X6+wf9yl1/RQQqi2HRdYqFCC6X2LjaUSsvpqVPdf+Js4bz3XJZkibG6xa\n\t39dFtODANwohagwLSCMwPj4BM/eTkTLZbP1LameVqqJoCqz5MVhFXdb3tfYmfB0Aflw9\n\t0K59c6UMlgt+iawvKsVEZTpNaISRsAMqndocOgbKvtr/UOh8M9glB3ldVl4JtIOqdIYi\n\tPFeg==","X-Gm-Message-State":"ACgBeo28+Q+xSFME8F7SWnMKqMSiuKzS8XwWhMRe1GABv/cEC4gdsgj2\n\tZ0MtwElC3BYyOlMRnvm/1vABZwYuBF+AJ5LxbN+ritm2oyp7M8nfCyqxGRNYhG7EqnTqarXBFhM\n\t1OxJ2zAq/gZiEXhJLh1Irbz2mOXh1UBSGukxCQkFHqpz2K6p0fg==","X-Received":["by 2002:a05:620a:f10:b0:6aa:318e:55a9 with SMTP id\n\tv16-20020a05620a0f1000b006aa318e55a9mr13219539qkl.559.1659955097440; \n\tMon, 08 Aug 2022 03:38:17 -0700 (PDT)","by 2002:a05:620a:f10:b0:6aa:318e:55a9 with SMTP id\n\tv16-20020a05620a0f1000b006aa318e55a9mr13219533qkl.559.1659955097242;\n\tMon, 08 Aug 2022 03:38:17 -0700 (PDT)"],"X-Google-Smtp-Source":"AA6agR4mCm5vio5CnTjb05csQsAua2g5lXt+Lt6Vb6YPqmDDxfWZcvhGHNhtJ+VOQoIa/rupoBrg7yfS7xPpaoBZ544=","MIME-Version":"1.0","References":"<20220807180100.396-1-laurent.pinchart@ideasonboard.com>\n\t<20220807180100.396-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220807180100.396-2-laurent.pinchart@ideasonboard.com>","Date":"Mon, 8 Aug 2022 11:38:01 +0100","Message-ID":"","To":"Laurent Pinchart ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/3] cam: drm: Add support for\n\ttest-only commits","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]