{"id":1701,"url":"https://patchwork.libcamera.org/api/patches/1701/?format=json","web_url":"https://patchwork.libcamera.org/patch/1701/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190715055935.21233-4-jacopo@jmondi.org>","date":"2019-07-15T05:59:35","name":"[libcamera-devel,3/3] libcamera: message: Add user message types","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"85b6aca914763bf6159c93b928a7622e9e35d535","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1701/mbox/","series":[{"id":431,"url":"https://patchwork.libcamera.org/api/series/431/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=431","date":"2019-07-15T05:59:32","name":"libcamera: misc fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/431/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1701/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1701/checks/","tags":{},"headers":{"Return-Path":"<jacopo@jmondi.org>","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2C41261A74\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 15 Jul 2019 07:58:34 +0200 (CEST)","from uno.localdomain (unknown [104.132.146.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 053721C0003;\n\tMon, 15 Jul 2019 05:58:32 +0000 (UTC)"],"X-Originating-IP":"104.132.146.101","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 15 Jul 2019 07:59:35 +0200","Message-Id":"<20190715055935.21233-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190715055935.21233-1-jacopo@jmondi.org>","References":"<20190715055935.21233-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 3/3] libcamera: message: Add user message\n\ttypes","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 15 Jul 2019 05:58:34 -0000"},"content":"Add an operation to the Message class to create unique message type to\nbe used by derived classes to uniquely identify the messages they\nhandle.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/include/message.h |  8 ++++++++\n src/libcamera/message.cpp       | 20 ++++++++++++++++++++\n 2 files changed, 28 insertions(+)","diff":"diff --git a/src/libcamera/include/message.h b/src/libcamera/include/message.h\nindex db17d647c280..e7dd85a606a3 100644\n--- a/src/libcamera/include/message.h\n+++ b/src/libcamera/include/message.h\n@@ -7,6 +7,8 @@\n #ifndef __LIBCAMERA_MESSAGE_H__\n #define __LIBCAMERA_MESSAGE_H__\n \n+#include <mutex>\n+\n namespace libcamera {\n \n class Object;\n@@ -19,6 +21,7 @@ public:\n \tenum Type {\n \t\tNone = 0,\n \t\tSignalMessage = 1,\n+\t\tUserMessage = 1000,\n \t};\n \n \tMessage(Type type);\n@@ -27,11 +30,16 @@ public:\n \tType type() const { return type_; }\n \tObject *receiver() const { return receiver_; }\n \n+\tstatic Type registerUserMessageType();\n+\n private:\n \tfriend class Thread;\n \n \tType type_;\n \tObject *receiver_;\n+\n+\tstatic std::mutex mutex_;\n+\tstatic Type nextUserType_;\n };\n \n class SignalMessage : public Message\ndiff --git a/src/libcamera/message.cpp b/src/libcamera/message.cpp\nindex 0580c1051622..f82a3115595d 100644\n--- a/src/libcamera/message.cpp\n+++ b/src/libcamera/message.cpp\n@@ -6,6 +6,7 @@\n  */\n \n #include \"message.h\"\n+#include \"thread.h\"\n \n #include \"log.h\"\n \n@@ -31,6 +32,9 @@ namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Message)\n \n+std::mutex Message::mutex_;\n+Message::Type Message::nextUserType_ = Message::UserMessage;\n+\n /**\n  * \\class Message\n  * \\brief A message that can be posted to a Thread\n@@ -68,6 +72,22 @@ Message::~Message()\n  * \\return The message receiver\n  */\n \n+/**\n+ * \\brief Retrieve a unique identifier for user defined message types\n+ *\n+ * Derived classes can define their own message types and this method provides\n+ * them a unique identifier to use for that purpose.\n+ *\n+ * \\return A new unique message type\n+ */\n+Message::Type Message::registerUserMessageType()\n+{\n+\tMutexLocker locker(mutex_);\n+\n+\treturn nextUserType_ = static_cast<Type>\n+\t\t\t      (static_cast<unsigned int>(nextUserType_) + 1);\n+}\n+\n /**\n  * \\class SignalMessage\n  * \\brief A message carrying a Signal across threads\n","prefixes":["libcamera-devel","3/3"]}