[{"id":24398,"web_url":"https://patchwork.libcamera.org/comment/24398/","msgid":"<165991098814.1706285.13444739005166966834@Monstersaurus>","date":"2022-08-07T22:23:08","subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-08-07 03:17:16)\n> In preparation for the addition of NV12 support in the SDL sink, rename\n> the sdl_texture_yuyv.{cpp,h} files to just \"yuv\". Separate\n> sdl_texture_nv12.{cpp,h} files could be added instead, but given how\n> short the implementation will be, grouping all YUV formats in a single\n> file is better.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/cam/meson.build | 2 +-\n> src/cam/sdl_sink.cpp | 2 +-\n> src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} | 4 ++--\n> src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} | 0\n\nCan you also update the reference to 'yuyv' in sdl_texture_yuyv.h ?\n\n * sdl_texture_yuyv.h - SDL Texture YUYV\n\nWith that,\n\n\nReviewed-by: Kieran Bingham \n\n\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> rename src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} (83%)\n> rename src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} (100%)\n> \n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index 4dfa7b22aea9..8259239ff5a2 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -40,7 +40,7 @@ if libsdl2.found()\n> cam_sources += files([\n> 'sdl_sink.cpp',\n> 'sdl_texture.cpp',\n> - 'sdl_texture_yuyv.cpp'\n> + 'sdl_texture_yuv.cpp',\n> ])\n> \n> if libjpeg.found()\n> diff --git a/src/cam/sdl_sink.cpp b/src/cam/sdl_sink.cpp\n> index a59d07519e1f..04350bd5365b 100644\n> --- a/src/cam/sdl_sink.cpp\n> +++ b/src/cam/sdl_sink.cpp\n> @@ -24,7 +24,7 @@\n> #ifdef HAVE_LIBJPEG\n> #include \"sdl_texture_mjpg.h\"\n> #endif\n> -#include \"sdl_texture_yuyv.h\"\n> +#include \"sdl_texture_yuv.h\"\n> \n> using namespace libcamera;\n> \n> diff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuv.cpp\n> similarity index 83%\n> rename from src/cam/sdl_texture_yuyv.cpp\n> rename to src/cam/sdl_texture_yuv.cpp\n> index cb51fb0ef478..07df4961a1ab 100644\n> --- a/src/cam/sdl_texture_yuyv.cpp\n> +++ b/src/cam/sdl_texture_yuv.cpp\n> @@ -2,10 +2,10 @@\n> /*\n> * Copyright (C) 2022, Ideas on Board Oy\n> *\n> - * sdl_texture_yuyv.cpp - SDL Texture YUYV\n> + * sdl_texture_yuv.cpp - SDL Texture YUYV\n> */\n> \n> -#include \"sdl_texture_yuyv.h\"\n> +#include \"sdl_texture_yuv.h\"\n> \n> using namespace libcamera;\n> \n> diff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuv.h\n> similarity index 100%\n> rename from src/cam/sdl_texture_yuyv.h\n> rename to src/cam/sdl_texture_yuv.h\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0F36C3272\n\tfor ;\n\tSun, 7 Aug 2022 22:23:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28C6863327;\n\tMon, 8 Aug 2022 00:23:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9218B603EF\n\tfor ;\n\tMon, 8 Aug 2022 00:23:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3801F3F1;\n\tMon, 8 Aug 2022 00:23:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659910993;\n\tbh=QU2epL+BLLY9/su3vAHmUrBiQ2nqZsSJns6Z5eecQX4=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=b67uEUN1g/fZsbZQxbgZcaPlBcACEf5xVcR3kJRkLbjJgJOGxCfZTuzUjrfnJehWi\n\t9qr2MXKL07d4aheduSTbQCIeOldpVusXblVjizvSLBem50LMh50uvmgpWSyQGoy6M/\n\txXkM/2cAOsDEy1bru+AR2ErgEWul55UffLxc95GadgLYQmluSGGs3J/EDQXY/D3LAm\n\ttVHy9qL/Bm8YSNX2iqYHsmgkhwvO54tuKR8xk51qYGLt8FtfBMozlh5NlTX7zbW3q0\n\tVXO9hePs21dqlNY0gxli75XygOf3Ng1yUs+0W3CTq4UBxv2nrk/tWPC3BAEmvAPV9h\n\tgyVPgVHstug6Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659910991;\n\tbh=QU2epL+BLLY9/su3vAHmUrBiQ2nqZsSJns6Z5eecQX4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=suZAo7hJTYAyspt7DRKKgB1yRU2TIv6HYh+Y/igTMOZ2aTX6VQkVhyrpwWV8lnmUu\n\taLZw6cZuzrktmThKg1KJ3xaYFwBKfR6ejMGw3PtVNZW30V+mZvPX4sb8WnjF+peOYZ\n\t7oDavWONJUT3zP0WJe4PiZvPaxVOhprfjJHoZqeI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"suZAo7hJ\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>","References":"<20220807021718.9789-1-laurent.pinchart@ideasonboard.com>\n\t<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sun, 07 Aug 2022 23:23:08 +0100","Message-ID":"<165991098814.1706285.13444739005166966834@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24401,"web_url":"https://patchwork.libcamera.org/comment/24401/","msgid":"","date":"2022-08-07T22:41:54","subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nOn Sun, Aug 07, 2022 at 11:23:08PM +0100, Kieran Bingham wrote:\n> Quoting Laurent Pinchart via libcamera-devel (2022-08-07 03:17:16)\n> > In preparation for the addition of NV12 support in the SDL sink, rename\n> > the sdl_texture_yuyv.{cpp,h} files to just \"yuv\". Separate\n> > sdl_texture_nv12.{cpp,h} files could be added instead, but given how\n> > short the implementation will be, grouping all YUV formats in a single\n> > file is better.\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/cam/meson.build | 2 +-\n> > src/cam/sdl_sink.cpp | 2 +-\n> > src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} | 4 ++--\n> > src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} | 0\n> \n> Can you also update the reference to 'yuyv' in sdl_texture_yuyv.h ?\n> \n> * sdl_texture_yuyv.h - SDL Texture YUYV\n\nI've done so in 4/4, where I add support for a different YUV format\n(NV12). Is that OK ?\n\n> With that,\n> \n> \n> Reviewed-by: Kieran Bingham \n> \n> \n> > 4 files changed, 4 insertions(+), 4 deletions(-)\n> > rename src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} (83%)\n> > rename src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} (100%)\n> > \n> > diff --git a/src/cam/meson.build b/src/cam/meson.build\n> > index 4dfa7b22aea9..8259239ff5a2 100644\n> > --- a/src/cam/meson.build\n> > +++ b/src/cam/meson.build\n> > @@ -40,7 +40,7 @@ if libsdl2.found()\n> > cam_sources += files([\n> > 'sdl_sink.cpp',\n> > 'sdl_texture.cpp',\n> > - 'sdl_texture_yuyv.cpp'\n> > + 'sdl_texture_yuv.cpp',\n> > ])\n> > \n> > if libjpeg.found()\n> > diff --git a/src/cam/sdl_sink.cpp b/src/cam/sdl_sink.cpp\n> > index a59d07519e1f..04350bd5365b 100644\n> > --- a/src/cam/sdl_sink.cpp\n> > +++ b/src/cam/sdl_sink.cpp\n> > @@ -24,7 +24,7 @@\n> > #ifdef HAVE_LIBJPEG\n> > #include \"sdl_texture_mjpg.h\"\n> > #endif\n> > -#include \"sdl_texture_yuyv.h\"\n> > +#include \"sdl_texture_yuv.h\"\n> > \n> > using namespace libcamera;\n> > \n> > diff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuv.cpp\n> > similarity index 83%\n> > rename from src/cam/sdl_texture_yuyv.cpp\n> > rename to src/cam/sdl_texture_yuv.cpp\n> > index cb51fb0ef478..07df4961a1ab 100644\n> > --- a/src/cam/sdl_texture_yuyv.cpp\n> > +++ b/src/cam/sdl_texture_yuv.cpp\n> > @@ -2,10 +2,10 @@\n> > /*\n> > * Copyright (C) 2022, Ideas on Board Oy\n> > *\n> > - * sdl_texture_yuyv.cpp - SDL Texture YUYV\n> > + * sdl_texture_yuv.cpp - SDL Texture YUYV\n> > */\n> > \n> > -#include \"sdl_texture_yuyv.h\"\n> > +#include \"sdl_texture_yuv.h\"\n> > \n> > using namespace libcamera;\n> > \n> > diff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuv.h\n> > similarity index 100%\n> > rename from src/cam/sdl_texture_yuyv.h\n> > rename to src/cam/sdl_texture_yuv.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DC0BC3272\n\tfor ;\n\tSun, 7 Aug 2022 22:42:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C24956332B;\n\tMon, 8 Aug 2022 00:42:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 09F2C603EF\n\tfor ;\n\tMon, 8 Aug 2022 00:42:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 700DD3F1;\n\tMon, 8 Aug 2022 00:42:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659912127;\n\tbh=PfqRr4M6OPfOnDJMhIdo9etxS2SG5On7M2sd28AS6Os=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Xu2uJcvywV+yamf789S3hdosfeK4INKxUIAt6Pf9otnVaOzetdwep8pxaSKMKvAm7\n\tXRGJZIw/J6KhlewxmhiIFjMqv8BLXy4yuE0SygMxPAHnCdXS1OGvTO0MlzgKRpBIAP\n\tF+kTzCmYHI9FHSsYCNy1UEb4yqHHtZ3hZS/RJcgzLP2Db2NsqNIzTFCJzYCd4K1oOo\n\tXhoDxiTpc2tVo/Ryi7GmcaYNtrGbWiHf/ImPwBEo1PXYzmGX5PMVGsa6G2mzkebcFQ\n\t9yKp01k3VI7ytRse/j3nPrBa8dLRdqciiZq/el7ibORgMd1+/C+XquDFz9WGbxlReR\n\t8GcD1AzUB8jFQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659912124;\n\tbh=PfqRr4M6OPfOnDJMhIdo9etxS2SG5On7M2sd28AS6Os=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=FC5b65VbOpnQBxO6W5qjfHd+7SJfLgk91aAEX/rONeGeEHoPAYekfoGgY7XEwp6lD\n\te1F3J4rIiSKWMKFndUJXbwF/uhztaNiECIya5oMQWcTLHmWhJFbUnd7zm+kV/UVOKE\n\tRBTv033iUEHa1INl4YNv3+aOqUPOhZNE+o90DuIc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"FC5b65Vb\"; dkim-atps=neutral","Date":"Mon, 8 Aug 2022 01:41:54 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220807021718.9789-1-laurent.pinchart@ideasonboard.com>\n\t<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>\n\t<165991098814.1706285.13444739005166966834@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165991098814.1706285.13444739005166966834@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24402,"web_url":"https://patchwork.libcamera.org/comment/24402/","msgid":"","date":"2022-08-07T22:43:01","subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Mon, Aug 08, 2022 at 01:41:55AM +0300, Laurent Pinchart wrote:\n> Hi Kieran,\n> \n> On Sun, Aug 07, 2022 at 11:23:08PM +0100, Kieran Bingham wrote:\n> > Quoting Laurent Pinchart via libcamera-devel (2022-08-07 03:17:16)\n> > > In preparation for the addition of NV12 support in the SDL sink, rename\n> > > the sdl_texture_yuyv.{cpp,h} files to just \"yuv\". Separate\n> > > sdl_texture_nv12.{cpp,h} files could be added instead, but given how\n> > > short the implementation will be, grouping all YUV formats in a single\n> > > file is better.\n> > > \n> > > Signed-off-by: Laurent Pinchart \n> > > ---\n> > > src/cam/meson.build | 2 +-\n> > > src/cam/sdl_sink.cpp | 2 +-\n> > > src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} | 4 ++--\n> > > src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} | 0\n> > \n> > Can you also update the reference to 'yuyv' in sdl_texture_yuyv.h ?\n> > \n> > * sdl_texture_yuyv.h - SDL Texture YUYV\n> \n> I've done so in 4/4, where I add support for a different YUV format\n> (NV12). Is that OK ?\n\nAd you meant the file name. Yes, will fix it.\n\n> > With that,\n> > \n> > \n> > Reviewed-by: Kieran Bingham \n> > \n> > \n> > > 4 files changed, 4 insertions(+), 4 deletions(-)\n> > > rename src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} (83%)\n> > > rename src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} (100%)\n> > > \n> > > diff --git a/src/cam/meson.build b/src/cam/meson.build\n> > > index 4dfa7b22aea9..8259239ff5a2 100644\n> > > --- a/src/cam/meson.build\n> > > +++ b/src/cam/meson.build\n> > > @@ -40,7 +40,7 @@ if libsdl2.found()\n> > > cam_sources += files([\n> > > 'sdl_sink.cpp',\n> > > 'sdl_texture.cpp',\n> > > - 'sdl_texture_yuyv.cpp'\n> > > + 'sdl_texture_yuv.cpp',\n> > > ])\n> > > \n> > > if libjpeg.found()\n> > > diff --git a/src/cam/sdl_sink.cpp b/src/cam/sdl_sink.cpp\n> > > index a59d07519e1f..04350bd5365b 100644\n> > > --- a/src/cam/sdl_sink.cpp\n> > > +++ b/src/cam/sdl_sink.cpp\n> > > @@ -24,7 +24,7 @@\n> > > #ifdef HAVE_LIBJPEG\n> > > #include \"sdl_texture_mjpg.h\"\n> > > #endif\n> > > -#include \"sdl_texture_yuyv.h\"\n> > > +#include \"sdl_texture_yuv.h\"\n> > > \n> > > using namespace libcamera;\n> > > \n> > > diff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuv.cpp\n> > > similarity index 83%\n> > > rename from src/cam/sdl_texture_yuyv.cpp\n> > > rename to src/cam/sdl_texture_yuv.cpp\n> > > index cb51fb0ef478..07df4961a1ab 100644\n> > > --- a/src/cam/sdl_texture_yuyv.cpp\n> > > +++ b/src/cam/sdl_texture_yuv.cpp\n> > > @@ -2,10 +2,10 @@\n> > > /*\n> > > * Copyright (C) 2022, Ideas on Board Oy\n> > > *\n> > > - * sdl_texture_yuyv.cpp - SDL Texture YUYV\n> > > + * sdl_texture_yuv.cpp - SDL Texture YUYV\n> > > */\n> > > \n> > > -#include \"sdl_texture_yuyv.h\"\n> > > +#include \"sdl_texture_yuv.h\"\n> > > \n> > > using namespace libcamera;\n> > > \n> > > diff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuv.h\n> > > similarity index 100%\n> > > rename from src/cam/sdl_texture_yuyv.h\n> > > rename to src/cam/sdl_texture_yuv.h","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 436B2BE173\n\tfor ;\n\tSun, 7 Aug 2022 22:43:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E687B6332B;\n\tMon, 8 Aug 2022 00:43:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 73338603EF\n\tfor ;\n\tMon, 8 Aug 2022 00:43:12 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0C4AE3F1;\n\tMon, 8 Aug 2022 00:43:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659912193;\n\tbh=sOqEAtISJULuXInF+M68GPWNKychvWlpp5sKHD2cP+Y=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=fwB0r84qWg+bYFzpfFn/itm4cfPAR/uspko5d4RNv058lVY5ACxJ+UA7lFBqFEE77\n\tjb8W6/l1AchKkvy6Li8wtpOps6CDeU4fJuCESAyjEOUdhWgxk/G8Qq4xSbwefYKFVV\n\teV0laDrrUTptRjKIld2u1Xgr6EeqEI+d/CHjHA+c+4FMlrWxSn6e/HzUZDhudLKIQw\n\tbWzam0F359keiVpglpfci7Qe6pnRryuoV0AC4GOH8AsJGPuJ8x2bX7zvggjz+8XCK/\n\t7hI632uKYW0+ZhgPxCrtnC7Bz5dWIHFejHPAryWChrizC8jZMFgX4KbXWoJNm4mSZa\n\tULd4YEqp+DZ/g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659912192;\n\tbh=sOqEAtISJULuXInF+M68GPWNKychvWlpp5sKHD2cP+Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=swggwkS6nizDGcDpcZ28cckQnxHKjvw4xM9AybKGudTyxvNh7Jq1HLjy8jJsbkYiw\n\t3RmZ7ScC5P1OGJr4TJOdz32RGilYN8IARCHtrkagJMs0wvvDvJ2iV2yO6eC0IqHs+R\n\tcSa2F7padSaZGGDO3563LIB0ZOaAWOAQ6fPqjb4k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"swggwkS6\"; dkim-atps=neutral","Date":"Mon, 8 Aug 2022 01:43:01 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220807021718.9789-1-laurent.pinchart@ideasonboard.com>\n\t<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>\n\t<165991098814.1706285.13444739005166966834@Monstersaurus>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24409,"web_url":"https://patchwork.libcamera.org/comment/24409/","msgid":"<20220808082146.yd5cewl673u5gaoo@uno.localdomain>","date":"2022-08-08T08:21:46","subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Sun, Aug 07, 2022 at 05:17:16AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> In preparation for the addition of NV12 support in the SDL sink, rename\n> the sdl_texture_yuyv.{cpp,h} files to just \"yuv\". Separate\n> sdl_texture_nv12.{cpp,h} files could be added instead, but given how\n> short the implementation will be, grouping all YUV formats in a single\n> file is better.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n\nWith Kieran's comment addressed\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> src/cam/meson.build | 2 +-\n> src/cam/sdl_sink.cpp | 2 +-\n> src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} | 4 ++--\n> src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} | 0\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> rename src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} (83%)\n> rename src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} (100%)\n>\n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index 4dfa7b22aea9..8259239ff5a2 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -40,7 +40,7 @@ if libsdl2.found()\n> cam_sources += files([\n> 'sdl_sink.cpp',\n> 'sdl_texture.cpp',\n> - 'sdl_texture_yuyv.cpp'\n> + 'sdl_texture_yuv.cpp',\n> ])\n>\n> if libjpeg.found()\n> diff --git a/src/cam/sdl_sink.cpp b/src/cam/sdl_sink.cpp\n> index a59d07519e1f..04350bd5365b 100644\n> --- a/src/cam/sdl_sink.cpp\n> +++ b/src/cam/sdl_sink.cpp\n> @@ -24,7 +24,7 @@\n> #ifdef HAVE_LIBJPEG\n> #include \"sdl_texture_mjpg.h\"\n> #endif\n> -#include \"sdl_texture_yuyv.h\"\n> +#include \"sdl_texture_yuv.h\"\n>\n> using namespace libcamera;\n>\n> diff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuv.cpp\n> similarity index 83%\n> rename from src/cam/sdl_texture_yuyv.cpp\n> rename to src/cam/sdl_texture_yuv.cpp\n> index cb51fb0ef478..07df4961a1ab 100644\n> --- a/src/cam/sdl_texture_yuyv.cpp\n> +++ b/src/cam/sdl_texture_yuv.cpp\n> @@ -2,10 +2,10 @@\n> /*\n> * Copyright (C) 2022, Ideas on Board Oy\n> *\n> - * sdl_texture_yuyv.cpp - SDL Texture YUYV\n> + * sdl_texture_yuv.cpp - SDL Texture YUYV\n> */\n>\n> -#include \"sdl_texture_yuyv.h\"\n> +#include \"sdl_texture_yuv.h\"\n>\n> using namespace libcamera;\n>\n> diff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuv.h\n> similarity index 100%\n> rename from src/cam/sdl_texture_yuyv.h\n> rename to src/cam/sdl_texture_yuv.h\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06846C3272\n\tfor ;\n\tMon, 8 Aug 2022 08:21:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA2B263327;\n\tMon, 8 Aug 2022 10:21:52 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9939F63326\n\tfor ;\n\tMon, 8 Aug 2022 10:21:50 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5016AC0004;\n\tMon, 8 Aug 2022 08:21:48 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659946912;\n\tbh=NfPVvvLnsOptwjdMePQDt67jjQOqHp3pgo7VkMP3tis=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=iht7DqXoiF2stXrHlysM5FZLW0aOdnY6BeelritK0Z8n0bkrRB6spErU5wkaU8KIv\n\tz4iQGL1eeQWG5EtX+QaYHM1SoOVQ0l0gCLl4p4Zp9tvyYIa+m5Y8wiQQQry7BnABep\n\ttzHLE+/hJ9BE1m2t/KCDLxS1GDezYydqux/T5/t2KzFaCQEW0lEur06Ywmw0d5OAgP\n\taChbdC1G4T/Q5SnKmERLtJNDTnkk4CskCRxw+rUApDxnOKoad+Hkz0qw8hHBKkL01H\n\t8alWuorFxAO4IXX6xodAi8gxH0iIdc2mT2h7qr7X6TJVWWnCXQlh5DRW5AD5BqoVuc\n\tv2XdOWStOuJBg==","Date":"Mon, 8 Aug 2022 10:21:46 +0200","To":"Laurent Pinchart ","Message-ID":"<20220808082146.yd5cewl673u5gaoo@uno.localdomain>","References":"<20220807021718.9789-1-laurent.pinchart@ideasonboard.com>\n\t<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24420,"web_url":"https://patchwork.libcamera.org/comment/24420/","msgid":"","date":"2022-08-08T09:20:51","subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Sun, 7 Aug 2022 at 03:17, Laurent Pinchart\n wrote:\n>\n> In preparation for the addition of NV12 support in the SDL sink, rename\n> the sdl_texture_yuyv.{cpp,h} files to just \"yuv\". Separate\n> sdl_texture_nv12.{cpp,h} files could be added instead, but given how\n> short the implementation will be, grouping all YUV formats in a single\n> file is better.\n>\n> Signed-off-by: Laurent Pinchart \n\nLGTM\n\nReviewed-by: Eric Curtin \n\n> ---\n> src/cam/meson.build | 2 +-\n> src/cam/sdl_sink.cpp | 2 +-\n> src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} | 4 ++--\n> src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} | 0\n> 4 files changed, 4 insertions(+), 4 deletions(-)\n> rename src/cam/{sdl_texture_yuyv.cpp => sdl_texture_yuv.cpp} (83%)\n> rename src/cam/{sdl_texture_yuyv.h => sdl_texture_yuv.h} (100%)\n>\n> diff --git a/src/cam/meson.build b/src/cam/meson.build\n> index 4dfa7b22aea9..8259239ff5a2 100644\n> --- a/src/cam/meson.build\n> +++ b/src/cam/meson.build\n> @@ -40,7 +40,7 @@ if libsdl2.found()\n> cam_sources += files([\n> 'sdl_sink.cpp',\n> 'sdl_texture.cpp',\n> - 'sdl_texture_yuyv.cpp'\n> + 'sdl_texture_yuv.cpp',\n> ])\n>\n> if libjpeg.found()\n> diff --git a/src/cam/sdl_sink.cpp b/src/cam/sdl_sink.cpp\n> index a59d07519e1f..04350bd5365b 100644\n> --- a/src/cam/sdl_sink.cpp\n> +++ b/src/cam/sdl_sink.cpp\n> @@ -24,7 +24,7 @@\n> #ifdef HAVE_LIBJPEG\n> #include \"sdl_texture_mjpg.h\"\n> #endif\n> -#include \"sdl_texture_yuyv.h\"\n> +#include \"sdl_texture_yuv.h\"\n>\n> using namespace libcamera;\n>\n> diff --git a/src/cam/sdl_texture_yuyv.cpp b/src/cam/sdl_texture_yuv.cpp\n> similarity index 83%\n> rename from src/cam/sdl_texture_yuyv.cpp\n> rename to src/cam/sdl_texture_yuv.cpp\n> index cb51fb0ef478..07df4961a1ab 100644\n> --- a/src/cam/sdl_texture_yuyv.cpp\n> +++ b/src/cam/sdl_texture_yuv.cpp\n> @@ -2,10 +2,10 @@\n> /*\n> * Copyright (C) 2022, Ideas on Board Oy\n> *\n> - * sdl_texture_yuyv.cpp - SDL Texture YUYV\n> + * sdl_texture_yuv.cpp - SDL Texture YUYV\n> */\n>\n> -#include \"sdl_texture_yuyv.h\"\n> +#include \"sdl_texture_yuv.h\"\n>\n> using namespace libcamera;\n>\n> diff --git a/src/cam/sdl_texture_yuyv.h b/src/cam/sdl_texture_yuv.h\n> similarity index 100%\n> rename from src/cam/sdl_texture_yuyv.h\n> rename to src/cam/sdl_texture_yuv.h\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE0DFC3272\n\tfor ;\n\tMon, 8 Aug 2022 09:21:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 79AB163327;\n\tMon, 8 Aug 2022 11:21:12 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86AF563326\n\tfor ;\n\tMon, 8 Aug 2022 11:21:10 +0200 (CEST)","from mail-qk1-f198.google.com (mail-qk1-f198.google.com\n\t[209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-65-5Um8nH7IOQK6AmyDP-f8DQ-1; Mon, 08 Aug 2022 05:21:08 -0400","by mail-qk1-f198.google.com with SMTP id\n\tbi22-20020a05620a319600b006b92f4b2ebbso4501847qkb.22\n\tfor ;\n\tMon, 08 Aug 2022 02:21:08 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659950472;\n\tbh=NAMR8qKPdmOrYQZEf6Km5gx+0CiK/yRdbMnvc6woOJg=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=UzzJfLkPLHAZ1ZDCJ8/F5gMNR3tMRxM7K6YXxwMdP1Tbt0MJ6pePX74S1/Y6srcjs\n\tSeiXKPcpV0M/dJBk3tTjMfaQ9nrmBMzmYt1S3BeLv/DnoutW+lJ1NR5AIwY20kwxj1\n\tmtw1mYRFCIPKN53BmHruvGVvaO29k10c+4sEbL4NPQkDPHS6Z6AxO0fsAWlh68JBEf\n\tohS7/26ePHJLEVVK2HYtb9V3GIDW3LTrAEGXwapnQpCY4WvNQzHSEOmKvrMK9+iYb7\n\tKsXm1orUaEJh/AqIetRZCAkQPwpVGzMXAY3wBMeQZqv80U5nJ5CukTvexPl7MFmKxI\n\tqQQKVhWYsBK/g==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1659950469;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=ATdQ3W0wqkBtISyZSBBA61l+ZvuwV2JcUXIdErFJ10c=;\n\tb=BATmZcNuAiyi2vBhfZGLNNFXnt1gDn30V8aANy88fnnsz40SMTY9otumSqTBL92BLvPoUR\n\ty7rJ+dGXAadySKkdeYLku+upscvXoU21qoCcW7ussDroNYuom8ur1WF97pOEky6RzLdomy\n\tiXNwS1cw3CWsViYCSjEZDBMBtWV3chY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"BATmZcNu\"; \n\tdkim-atps=neutral","X-MC-Unique":"5Um8nH7IOQK6AmyDP-f8DQ-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=ATdQ3W0wqkBtISyZSBBA61l+ZvuwV2JcUXIdErFJ10c=;\n\tb=PnI964fDQiFy2FyPWMeBOWSCIQZ/0XwxvL2m2XMzri/A62IQ8hkBCwM3ivvNXHuIyF\n\t02xPHDCGL6M3mrtV4zZD1AgVYWY+QXiI4LK+SWRLnI6VxqZBgB5DRjrABs7w45f0FUjo\n\tgNfsWVSHg5LlU88J+i5J7/RuoQ+Khdvp++HTF+Yjoknu1i0FwRnM0aLXwRlX7GTFjlMB\n\tUBvnL1g96UhyToH4Lma8d/p0uB2HVsmtfdW4H7zB7WFWkvk3KNGditnQmk9Re8ZuRm31\n\t7Ww4mkSph+gDFAS7akC6tuPTuxG3Ub3OW0mKsldcRDJzRaDTO1a6aGFiwybfTVKvUU5i\n\tAUJw==","X-Gm-Message-State":"ACgBeo0kRbRlNiDosycJTG6xHPu2+Ilo651t5TQnUVmjTBF9/juW2lUC\n\tgz25uBz2ixlyhqR5hGV/3v5j8OWLdNr8jQH5urKGwlTFm5ZPP8GziZJXIsrbdGGrcQjwgWjXLZV\n\t+TOTF5FYRbw7TzDwcO0daQcSQ/wNb/nkHbqCTYG+A3qUMCaNExg==","X-Received":["by 2002:a37:88c3:0:b0:6b9:53c7:75e4 with SMTP id\n\tk186-20020a3788c3000000b006b953c775e4mr2574616qkd.532.1659950467686; \n\tMon, 08 Aug 2022 02:21:07 -0700 (PDT)","by 2002:a37:88c3:0:b0:6b9:53c7:75e4 with SMTP id\n\tk186-20020a3788c3000000b006b953c775e4mr2574611qkd.532.1659950467494;\n\tMon, 08 Aug 2022 02:21:07 -0700 (PDT)"],"X-Google-Smtp-Source":"AA6agR4ve9PlasBGal2o9QvK5/Jb2umK0QFKxZGva4OpndxeekRDO7uC6gk2E+7ML1LEFFvgMrWiZth3QOxxD7wKPqk=","MIME-Version":"1.0","References":"<20220807021718.9789-1-laurent.pinchart@ideasonboard.com>\n\t<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220807021718.9789-3-laurent.pinchart@ideasonboard.com>","Date":"Mon, 8 Aug 2022 10:20:51 +0100","Message-ID":"","To":"Laurent Pinchart ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 2/4] cam: Rename sdl_texture_yuyv.{cpp,\n\th} to sdl_texture_yuv.{cpp, h}","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]