{"id":17000,"url":"https://patchwork.libcamera.org/api/patches/17000/?format=json","web_url":"https://patchwork.libcamera.org/patch/17000/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220807021456.9578-3-laurent.pinchart@ideasonboard.com>","date":"2022-08-07T02:14:53","name":"[libcamera-devel,2/5] libcamera: Make openssl and gnutls dependencies recommended","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ee6071b96bdcd78bbe21ed2a74c64624a1d19c24","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17000/mbox/","series":[{"id":3380,"url":"https://patchwork.libcamera.org/api/series/3380/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3380","date":"2022-08-07T02:14:51","name":"libcamera: Support openssl as an alternative to gnutls","version":1,"mbox":"https://patchwork.libcamera.org/series/3380/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17000/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17000/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 846A3BE173\n\tfor ;\n\tSun, 7 Aug 2022 02:15:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3BC9863325;\n\tSun, 7 Aug 2022 04:15:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9573263325\n\tfor ;\n\tSun, 7 Aug 2022 04:15:08 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FEF356D\n\tfor ;\n\tSun, 7 Aug 2022 04:15:08 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659838511;\n\tbh=iIXeeXIsd33gPVe0oayvWNkGb8tVCGWRS4H28lKPXvo=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=wMl0DEx/KKfc5xjoG2vUOjevb5L+D7H7OK//Vu0g97ERSSGoMlz2zu52PjsfDrnRs\n\tHd5cLcR5gmv5asnA6V+AgudiBjl9klRBXKq2L+kcC/XtBp5HikIUXUXPpIs1igyU8L\n\tkFveworXWVie0LjJFO/vH9TXyJqaEcYZHPL5Wv3bAIbcOWwSFfvifVhUNh1fBTH0wa\n\t4Zm7Zcns2Hw8Y7KcW3wPVYhCpobIzfFFKPyoRKPJ7lnofJLewK9lnHABP6bI2a1dZf\n\tTyPX5tcZ5biod1FvZ6Eo4MMUJapF28f02DeV7QZhPCjeOGNlh7OxOkJlY7M+6s/84c\n\t2/JuQ834ZKFdQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659838508;\n\tbh=iIXeeXIsd33gPVe0oayvWNkGb8tVCGWRS4H28lKPXvo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Lx9yVZzbgtyDL7pS3EYDUSqBDI6xCRuKVlOx8JhHMaUkS1ZDlZhzkIzH5eXAP/X+5\n\t5QlTf0Tp8m15dwJ0stOFNJtKKSOjYFHA8WKTKwPshsOECWAO9XcyHqsySnLH+nlBaf\n\tJ1PLAUNVlbAYV8JEr+7pGHABftKz+3Bkoa1ZwX+o="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"Lx9yVZzb\"; dkim-atps=neutral","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 7 Aug 2022 05:14:53 +0300","Message-Id":"<20220807021456.9578-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.35.1","In-Reply-To":"<20220807021456.9578-1-laurent.pinchart@ideasonboard.com>","References":"<20220807021456.9578-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/5] libcamera: Make openssl and gnutls\n\tdependencies recommended","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"While gnutls and openssl are not strictly required, the overheard\nintroduced by isolating all IPA modules when signatures are not\navailable is better avoided. Document the dependencies as recommended,\nand warn at meson setup time if they are not found.\n\nSigned-off-by: Laurent Pinchart \n---\n README.rst | 5 ++++-\n src/libcamera/meson.build | 2 ++\n src/meson.build | 1 +\n 3 files changed, 7 insertions(+), 1 deletion(-)","diff":"diff --git a/README.rst b/README.rst\nindex ffecd5bc6552..3606057ff706 100644\n--- a/README.rst\n+++ b/README.rst\n@@ -60,9 +60,12 @@ Meson Build system: [required]\n for the libcamera core: [required]\n libyaml-dev python3-yaml python3-ply python3-jinja2\n \n-for IPA module signing: [optional]\n+for IPA module signing: [recommended]\n libgnutls28-dev openssl\n \n+ Without IPA module signing, all IPA modules will be isolated in a\n+ separate process. This adds an unnecessary extra overhead at runtime.\n+\n for improved debugging: [optional]\n libdw-dev libunwind-dev\n \ndiff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex ff0e31ebcb63..8580feed3846 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -71,6 +71,8 @@ libyaml = dependency('yaml-0.1', required : false)\n \n if libgnutls.found()\n config_h.set('HAVE_GNUTLS', 1)\n+else\n+ warning('gnutls not found, all IPA modules will be isolated')\n endif\n \n if liblttng.found()\ndiff --git a/src/meson.build b/src/meson.build\nindex 65276fc74606..f37c44ca9f60 100644\n--- a/src/meson.build\n+++ b/src/meson.build\n@@ -22,6 +22,7 @@ if openssl.found()\n config_h.set('HAVE_IPA_PUBKEY', 1)\n ipa_sign_module = true\n else\n+ warning('openssl not found, all IPA modules will be isolated')\n ipa_sign_module = false\n endif\n \n","prefixes":["libcamera-devel","2/5"]}