[{"id":2272,"web_url":"https://patchwork.libcamera.org/comment/2272/","msgid":"<3a3dde6c-425e-77f5-5d5b-744cb7cd2efd@ideasonboard.com>","date":"2019-07-15T07:10:37","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Do not re-queue\n\tfailed buffers","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 15/07/2019 06:59, Jacopo Mondi wrote:\n> When a video device is stopped all the buffers there queued are\n> released and their state is set to failure.\n> \n> Currently, on buffer completion, failed buffers are blindly re-queued to\n> the ImgU input or CIO2 output devices, preventing them to be re-started\n> succesfully in future capture sessions.\n\ns/succesfully/successfully/\n\n> \n> Fix that by inspecting the buffers status and skip re-queueing if\n> they're reported as failing. For the ImgU output buffers this is not\n> required, as failed buffes should be anyhow delivered to applications in\n\ns/buffes/buffers/\n\n> order to report their failure.\n> \n\nWill this patch lead to us 'leaking' buffers if they are failed for some\nreason (other than stopping the pipeline) - leading to a complete\npipeline stall?\n\n--\nKieran\n\n\n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 5204487684c2..11bf3af66ae6 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -916,6 +916,9 @@ int PipelineHandlerIPU3::registerCameras()\n> */\n> void IPU3CameraData::imguInputBufferReady(Buffer *buffer)\n> {\n> +\tif (buffer->status() != Buffer::BufferSuccess)\n> +\t\treturn;\n> +\n> \tcio2_.output_->queueBuffer(buffer);\n> }\n> \n> @@ -946,6 +949,9 @@ void IPU3CameraData::imguOutputBufferReady(Buffer *buffer)\n> */\n> void IPU3CameraData::cio2BufferReady(Buffer *buffer)\n> {\n> +\tif (buffer->status() != Buffer::BufferSuccess)\n> +\t\treturn;\n> +\n> \timgu_->input_->queueBuffer(buffer);\n> }\n> \n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CE7A960E3E\n\tfor ;\n\tMon, 15 Jul 2019 09:10:40 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 30BAB578;\n\tMon, 15 Jul 2019 09:10:40 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563174640;\n\tbh=98OPF36GIcOueX/Qm/+uDlEev7HP1UBVN61J1Jhbs3A=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=GM77SchWAZ5JqniURDKbFExQYnN4dxdWKuV0k1SR4ygI7zyMc3237zI55DgRbmVmJ\n\tHmj0Hm4QSW99Eq1oSWgV8pqQAF2bLfkxsOnULWLtGnMYdix/EY4NJxnEe3HKArUfKY\n\t8Hw1mGUQYn/H4IoCecEDbO8mJ87g4cykZI9MZ0rA=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20190715055935.21233-1-jacopo@jmondi.org>\n\t<20190715055935.21233-3-jacopo@jmondi.org>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAkAEEwEKACoCGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEFAlnDk/gFCQeA/YsACgkQoR5GchCkYf3X5w/9EaZ7\n\tcnUcT6dxjxrcmmMnfFPoQA1iQXr/MXQJBjFWfxRUWYzjvUJb2D/FpA8FY7y+vksoJP7pWDL7\n\tQTbksdwzagUEk7CU45iLWL/CZ/knYhj1I/+5LSLFmvZ/5Gf5xn2ZCsmg7C0MdW/GbJ8IjWA8\n\t/LKJSEYH8tefoiG6+9xSNp1p0Gesu3vhje/GdGX4wDsfAxx1rIYDYVoX4bDM+uBUQh7sQox/\n\tR1bS0AaVJzPNcjeC14MS226mQRUaUPc9250aj44WmDfcg44/kMsoLFEmQo2II9aOlxUDJ+x1\n\txohGbh9mgBoVawMO3RMBihcEjo/8ytW6v7xSF+xP4Oc+HOn7qebAkxhSWcRxQVaQYw3S9iZz\n\t2iA09AXAkbvPKuMSXi4uau5daXStfBnmOfalG0j+9Y6hOFjz5j0XzaoF6Pln0jisDtWltYhP\n\tX9LjFVhhLkTzPZB/xOeWGmsG4gv2V2ExbU3uAmb7t1VSD9+IO3Km4FtnYOKBWlxwEd8qOFpS\n\tjEqMXURKOiJvnw3OXe9MqG19XdeENA1KyhK5rqjpwdvPGfSn2V+SlsdJA0DFsobUScD9qXQw\n\tOvhapHe3XboK2+Rd7L+g/9Ud7ZKLQHAsMBXOVJbufA1AT+IaOt0ugMcFkAR5UbBg5+dZUYJj\n\t1QbPQcGmM3wfvuaWV5+SlJ+WeKIb8ta5Ag0EVgT9ZgEQAM4o5G/kmruIQJ3K9SYzmPishRHV\n\tDcUcvoakyXSX2mIoccmo9BHtD9MxIt+QmxOpYFNFM7YofX4lG0ld8H7FqoNVLd/+a0yru5Cx\n\tadeZBe3qr1eLns10Q90LuMo7/6zJhCW2w+HE7xgmCHejAwuNe3+7yt4QmwlSGUqdxl8cgtS1\n\tPlEK93xXDsgsJj/bw1EfSVdAUqhx8UQ3aVFxNug5OpoX9FdWJLKROUrfNeBE16RLrNrq2ROc\n\tiSFETpVjyC/oZtzRFnwD9Or7EFMi76/xrWzk+/b15RJ9WrpXGMrttHUUcYZEOoiC2lEXMSAF\n\tSSSj4vHbKDJ0vKQdEFtdgB1roqzxdIOg4rlHz5qwOTynueiBpaZI3PHDudZSMR5Fk6QjFooE\n\tXTw3sSl/km/lvUFiv9CYyHOLdygWohvDuMkV/Jpdkfq8XwFSjOle+vT/4VqERnYFDIGBxaRx\n\tkoBLfNDiiuR3lD8tnJ4A1F88K6ojOUs+jndKsOaQpDZV6iNFv8IaNIklTPvPkZsmNDhJMRHH\n\tIu60S7BpzNeQeT4yyY4dX9lC2JL/LOEpw8DGf5BNOP1KgjCvyp1/KcFxDAo89IeqljaRsCdP\n\t7WCIECWYem6pLwaw6IAL7oX+tEqIMPph/G/jwZcdS6Hkyt/esHPuHNwX4guqTbVEuRqbDzDI\n\t2DJO5FbxABEBAAGJAiUEGAEKAA8CGwwFAlnDlGsFCQeA/gIACgkQoR5GchCkYf1yYRAAq+Yo\n\tnbf9DGdK1kTAm2RTFg+w9oOp2Xjqfhds2PAhFFvrHQg1XfQR/UF/SjeUmaOmLSczM0s6XMeO\n\tVcE77UFtJ/+hLo4PRFKm5X1Pcar6g5m4xGqa+Xfzi9tRkwC29KMCoQOag1BhHChgqYaUH3yo\n\tUzaPwT/fY75iVI+yD0ih/e6j8qYvP8pvGwMQfrmN9YB0zB39YzCSdaUaNrWGD3iCBxg6lwSO\n\tLKeRhxxfiXCIYEf3vwOsP3YMx2JkD5doseXmWBGW1U0T/oJF+DVfKB6mv5UfsTzpVhJRgee7\n\t4jkjqFq4qsUGxcvF2xtRkfHFpZDbRgRlVmiWkqDkT4qMA+4q1y/dWwshSKi/uwVZNycuLsz+\n\t+OD8xPNCsMTqeUkAKfbD8xW4LCay3r/dD2ckoxRxtMD9eOAyu5wYzo/ydIPTh1QEj9SYyvp8\n\tO0g6CpxEwyHUQtF5oh15O018z3ZLztFJKR3RD42VKVsrnNDKnoY0f4U0z7eJv2NeF8xHMuiU\n\tRCIzqxX1GVYaNkKTnb/Qja8hnYnkUzY1Lc+OtwiGmXTwYsPZjjAaDX35J/RSKAoy5wGo/YFA\n\tJxB1gWThL4kOTbsqqXj9GLcyOImkW0lJGGR3o/fV91Zh63S5TKnf2YGGGzxki+ADdxVQAm+Q\n\tsbsRB8KNNvVXBOVNwko86rQqF9drZuw=","Organization":"Ideas on Board","Message-ID":"<3a3dde6c-425e-77f5-5d5b-744cb7cd2efd@ideasonboard.com>","Date":"Mon, 15 Jul 2019 08:10:37 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.7.2","MIME-Version":"1.0","In-Reply-To":"<20190715055935.21233-3-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Do not re-queue\n\tfailed buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Jul 2019 07:10:41 -0000"}},{"id":2273,"web_url":"https://patchwork.libcamera.org/comment/2273/","msgid":"<20190715075659.GB19114@pendragon.ideasonboard.com>","date":"2019-07-15T07:56:59","subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Do not re-queue\n\tfailed buffers","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Mon, Jul 15, 2019 at 07:59:34AM +0200, Jacopo Mondi wrote:\n> When a video device is stopped all the buffers there queued are\n> released and their state is set to failure.\n\nIsn't the state set to BufferCancelled, not BufferError ?\n\n> Currently, on buffer completion, failed buffers are blindly re-queued to\n> the ImgU input or CIO2 output devices, preventing them to be re-started\n> succesfully in future capture sessions.\n> \n> Fix that by inspecting the buffers status and skip re-queueing if\n> they're reported as failing. For the ImgU output buffers this is not\n> required, as failed buffes should be anyhow delivered to applications in\n\ns/buffes/buffers/\n\n> order to report their failure.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index 5204487684c2..11bf3af66ae6 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -916,6 +916,9 @@ int PipelineHandlerIPU3::registerCameras()\n> */\n> void IPU3CameraData::imguInputBufferReady(Buffer *buffer)\n> {\n> +\tif (buffer->status() != Buffer::BufferSuccess)\n> +\t\treturn;\n> +\n> \tcio2_.output_->queueBuffer(buffer);\n> }\n> \n> @@ -946,6 +949,9 @@ void IPU3CameraData::imguOutputBufferReady(Buffer *buffer)\n> */\n> void IPU3CameraData::cio2BufferReady(Buffer *buffer)\n> {\n> +\tif (buffer->status() != Buffer::BufferSuccess)\n> +\t\treturn;\n> +\n\nWe may need to differentiate between Buffer::BufferCancelled and\nBuffer::BufferError. The former clearly needs to return immediately,\nwhile the latter should probably retry one way or another, at least a\nfinite number of times. Should we already test ==\nBuffer::BufferCancelled, and ignore BufferError for now ?\n\nReviewed-by: Laurent Pinchart \n\n> \timgu_->input_->queueBuffer(buffer);\n> }","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0770960E3E\n\tfor ;\n\tMon, 15 Jul 2019 09:57:28 +0200 (CEST)","from pendragon.ideasonboard.com (unknown\n\t[IPv6:2a00:79e1:abc:3602:59ec:6c:1869:337])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9566A578;\n\tMon, 15 Jul 2019 09:57:26 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563177447;\n\tbh=cMNxJab4V91u0ifpxQEVhK6DAHtFmmZul879OTW3e5w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ocqGewotTUURnbXUUhYL50JkDTjFw4oII/UeJ/y3SPDr0QbI3TOAn8fY+EXYQUwvc\n\tzJfGmLyW5wMh/XpdLoZe/BCFvkLoT1OzzEeUsYY2PriIktsdOf5ISIsBGyoI0TXD0d\n\tsScaW2aj/E4xrWJb3KgEzGHD93l3AXWQH/4Y8fyc=","Date":"Mon, 15 Jul 2019 10:56:59 +0300","From":"Laurent Pinchart ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190715075659.GB19114@pendragon.ideasonboard.com>","References":"<20190715055935.21233-1-jacopo@jmondi.org>\n\t<20190715055935.21233-3-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190715055935.21233-3-jacopo@jmondi.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 2/3] libcamera: ipu3: Do not re-queue\n\tfailed buffers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 15 Jul 2019 07:57:28 -0000"}}]