[{"id":13,"web_url":"https://patchwork.libcamera.org/comment/13/","msgid":"<20181126162122.GQ1158@bigcity.dyn.berto.se>","date":"2018-11-26T16:21:22","subject":"Re: [libcamera-devel] [PATCH] build: Add project arguments","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Kieran,\n\nThanks for your work.\n\nOn 2018-11-26 14:26:35 +0000, Kieran Bingham wrote:\n> Add language specific project arguments and ensure that -Werror is\n> enabled, enforcing code to be as clean as possible.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Niklas Söderlund \n\n> \n> ---\n> \n> This should be kept for development as much as possible, but we may want\n> to have an automatic relaxation for package builds rather than developer\n> builds so that external compiler changes do not block users.\n> \n> meson.build | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 494193483079..f1fcb8e20e00 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -7,6 +7,18 @@ project('libcamera - supporting complex camera pipelines', 'c', 'cpp',\n> #\tgenerated from this too.\n> api_version = '0.1'\n> \n> +common_arguments = [\n> +\t'-Wall',\n> +\t'-Wextra',\n> +\t'-Werror',\n> +]\n> +\n> +c_arguments = common_arguments\n> +cpp_arguments = common_arguments\n> +\n> +add_project_arguments(c_arguments, language: 'c')\n> +add_project_arguments(cpp_arguments, language: 'cpp')\n> +\n> inc = include_directories('include')\n> \n> subdir('Documentation')\n> -- \n> 2.17.1\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D764560B0B\n\tfor ;\n\tMon, 26 Nov 2018 17:21:40 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id l15-v6so17154779lja.9\n\tfor ;\n\tMon, 26 Nov 2018 08:21:40 -0800 (PST)","from localhost (89-233-230-99.cust.bredband2.com. [89.233.230.99])\n\tby smtp.gmail.com with ESMTPSA id\n\tk3-v6sm127713lja.8.2018.11.26.08.21.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tMon, 26 Nov 2018 08:21:30 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=yiXL8zNMD1Oo7ghV2GTY3q/fVLXD95CsZMqEfeo4KAE=;\n\tb=aI36bDV5E4+V7o7nakNgfwqS+vIVw3a/jwboTueG9DsV3aRsuw9cvA27/oK388zar9\n\tAMQlPY6xsOsx9EHjaumc5rkNmtx8RMyZJjr0QUyqo3Uo7V03gDk8fonm0Kst81gFMkr0\n\t2Cy8ORGRuZHDx6oMMeYTu+U1LfVkay0OrJYOzf6sFgqz8+ySYetczQGSIcxI/0iOf7sF\n\toH69otAWcjz9zGtyIiAb3vZrWdRHYKn+CiHy58ZiT/5hZZPvMBqGFgrtGX+xpKgqWnrU\n\t0tOVuMjbUqVzFNa70MbtfaVGo5y662LQxCzo9R5FzO6O6c2KSSyhWtLtDBhWuQlz6ry3\n\tmdQA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=yiXL8zNMD1Oo7ghV2GTY3q/fVLXD95CsZMqEfeo4KAE=;\n\tb=aJvMXXqiR4mTn8DCA7JS7M53ONAO4VKefB7oGp9WYDcjujxqVO7sbgiGky7IBTG4dl\n\tZmUyD8KY7tr1/g8BL2rdsSmmjtY7hB8Nch8/DZOIyj0STiVPgNIgbkJmIVWVNwl+QaF7\n\tk3C6/qG+/xkCPy/s3rnn6x7Y9L7VyV+K0mNLKRSxw2zpHvkcJi75+LAeWTvJMb0s3w7L\n\tQ2etjwH9QkrI/1aX8cjHljIF9mHjqkmTOjepY4U4GjUivtxRij243xYNgcBcit13Mtrs\n\tYBd99tx96Mw9hqbxokNxLz2Edft6WiQ/CG476LGqhURFOTBVgvzjaHUJzaZT3rgGlp+R\n\tzcHg==","X-Gm-Message-State":"AA+aEWYhu/mdIwsvpHSxjCAncFsK/UdN3iBS5ArZA/1FHs3w02Yx6W9P\n\t81Ydjxk6RpDF1bfMJATDPSheqDrR/6A=","X-Google-Smtp-Source":"AFSGD/XWJCCF/Kl1lmUOuohkihItStZwkOxsTau8WSyDaebp0sqoGwLV/nV3soI9p0/5RiwpUmtb/A==","X-Received":"by 2002:a2e:80d3:: with SMTP id\n\tr19-v6mr17309593ljg.151.1543249300229; \n\tMon, 26 Nov 2018 08:21:40 -0800 (PST)","Date":"Mon, 26 Nov 2018 17:21:22 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Kieran Bingham ","Cc":"LibCamera Devel ","Message-ID":"<20181126162122.GQ1158@bigcity.dyn.berto.se>","References":"<20181126142635.14078-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20181126142635.14078-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] build: Add project arguments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 26 Nov 2018 16:21:41 -0000"}},{"id":14,"web_url":"https://patchwork.libcamera.org/comment/14/","msgid":"<1768000.XpYcVlKok4@avalon>","date":"2018-11-26T23:21:13","subject":"Re: [libcamera-devel] [PATCH] build: Add project arguments","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Monday, 26 November 2018 16:26:35 EET Kieran Bingham wrote:\n> Add language specific project arguments and ensure that -Werror is\n> enabled, enforcing code to be as clean as possible.\n> \n> Signed-off-by: Kieran Bingham \n> \n> ---\n> \n> This should be kept for development as much as possible, but we may want\n> to have an automatic relaxation for package builds rather than developer\n> builds so that external compiler changes do not block users.\n> \n> meson.build | 12 ++++++++++++\n> 1 file changed, 12 insertions(+)\n> \n> diff --git a/meson.build b/meson.build\n> index 494193483079..f1fcb8e20e00 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -7,6 +7,18 @@ project('libcamera - supporting complex camera pipelines',\n> 'c', 'cpp', #\tgenerated from this too.\n> api_version = '0.1'\n> \n> +common_arguments = [\n> +\t'-Wall',\n> +\t'-Wextra',\n> +\t'-Werror',\n\nI would already add -Wno-unused-parameter. This could also be done in a \nsubsequent patch.\n\nReviewed-by: Laurent Pinchart \n\n> +]\n> +\n> +c_arguments = common_arguments\n> +cpp_arguments = common_arguments\n> +\n> +add_project_arguments(c_arguments, language: 'c')\n> +add_project_arguments(cpp_arguments, language: 'cpp')\n> +\n> inc = include_directories('include')\n> \n> subdir('Documentation')","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7ACFA60B0B\n\tfor ;\n\tTue, 27 Nov 2018 00:20:50 +0100 (CET)","from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED9EB544;\n\tTue, 27 Nov 2018 00:20:49 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1543274450;\n\tbh=si4Zec+3llmyjDgV/PC1AJIjJ6k5dU7FP7Mmsu+RFwQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=djIoYmE2iDWM3JhRQbGm+VTF1u/hFBHH/virDctX087oGM1oFfgrBP3pY5MUtYO+9\n\tJ2e0w42/IpUrQGSxVApICBcWRi9O73NtAGQcvwfZVqHaxv7BKpPOisjMEm9lo++zfN\n\tfLavGQ5EBdeOYFHR4hqajqZPp3XY/maUj952m29U=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 27 Nov 2018 01:21:13 +0200","Message-ID":"<1768000.XpYcVlKok4@avalon>","Organization":"Ideas on Board Oy","In-Reply-To":"<20181126142635.14078-1-kieran.bingham@ideasonboard.com>","References":"<20181126142635.14078-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"7Bit","Content-Type":"text/plain; charset=\"us-ascii\"","Subject":"Re: [libcamera-devel] [PATCH] build: Add project arguments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 26 Nov 2018 23:20:50 -0000"}}]