{"id":17,"url":"https://patchwork.libcamera.org/api/patches/17/?format=json","web_url":"https://patchwork.libcamera.org/patch/17/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20181126142635.14078-1-kieran.bingham@ideasonboard.com>","date":"2018-11-26T14:26:35","name":"[libcamera-devel] build: Add project arguments","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"fc52bcef3e7bf8d62a2b4a0e0bbd04be2dee24f5","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/17/mbox/","series":[{"id":8,"url":"https://patchwork.libcamera.org/api/series/8/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=8","date":"2018-11-26T14:26:35","name":"[libcamera-devel] build: Add project arguments","version":1,"mbox":"https://patchwork.libcamera.org/series/8/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/17/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/17/checks/","tags":{},"headers":{"Return-Path":"<kieran.bingham@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C98D660004\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 Nov 2018 15:26:40 +0100 (CET)","from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 449AD544;\n\tMon, 26 Nov 2018 15:26:40 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1543242400;\n\tbh=akjZjaBXKiUpR5SSeGazhNYT2vg+pYqxEaUaao7UIWM=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=Tu/FcPwKfE7eFBLVJu3a6bdbrZav61fJCKQgcMJLpSREEvBGLvspxKhqoBTtRdLbn\n\t1FOTnhbYYVG6GXeuig2eRlu52GKKZAF++Gh25UX/swBBTUVFX/cmUsjQxNzSmGks/H\n\tx/uqPHnPlsla5+k9YBYLWY5sfny1EXs0qZhDKF9o=","From":"Kieran Bingham <kieran.bingham@ideasonboard.com>","To":"LibCamera Devel <libcamera-devel@lists.libcamera.org>","Date":"Mon, 26 Nov 2018 14:26:35 +0000","Message-Id":"<20181126142635.14078-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.17.1","Subject":"[libcamera-devel] [PATCH] build: Add project arguments","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Mon, 26 Nov 2018 14:26:40 -0000"},"content":"Add language specific project arguments and ensure that -Werror is\nenabled, enforcing code to be as clean as possible.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\n\nThis should be kept for development as much as possible, but we may want\nto have an automatic relaxation for package builds rather than developer\nbuilds so that external compiler changes do not block users.\n\n meson.build | 12 ++++++++++++\n 1 file changed, 12 insertions(+)","diff":"diff --git a/meson.build b/meson.build\nindex 494193483079..f1fcb8e20e00 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -7,6 +7,18 @@ project('libcamera - supporting complex camera pipelines', 'c', 'cpp',\n #\tgenerated from this too.\n api_version = '0.1'\n \n+common_arguments = [\n+\t'-Wall',\n+\t'-Wextra',\n+\t'-Werror',\n+]\n+\n+c_arguments = common_arguments\n+cpp_arguments = common_arguments\n+\n+add_project_arguments(c_arguments, language: 'c')\n+add_project_arguments(cpp_arguments, language: 'cpp')\n+\n inc = include_directories('include')\n \n subdir('Documentation')\n","prefixes":["libcamera-devel"]}