[{"id":24533,"web_url":"https://patchwork.libcamera.org/comment/24533/","msgid":"<210951ee-1076-14c6-5568-7f13c4ef568e@ideasonboard.com>","date":"2022-08-11T04:55:33","subject":"Re: [libcamera-devel] [PATCH v2 03/10] libcamera: request: Add\n\tPFCError flag","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the pathc.\n\nOn 8/5/22 19:23, Jacopo Mondi via libcamera-devel wrote:\n> From: Kieran Bingham via libcamera-devel \n>\n> Provide a new flag for the Request error state to indicate that a\n> per-frame control error has occurred. One or more controls set for this\n> request could not be guaranteed on this frame.\n>\n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Jacopo Mondi \n\n\nReviewed-by: Umang Jain \n\n> ---\n> include/libcamera/request.h | 1 +\n> src/libcamera/request.cpp | 4 ++++\n> 2 files changed, 5 insertions(+)\n>\n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 3304da31200d..9aee81922c91 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -47,6 +47,7 @@ public:\n> \tenum ErrorFlag {\n> \t\tNoError = 0,\n> \t\tControlError = (1 << 0),\n> +\t\tPFCError = (1 << 1),\n> \t};\n> \n> \tusing Errors = Flags;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 9a808f19fc03..b93eaac75880 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -346,6 +346,10 @@ void Request::Private::timeout()\n> * Control Error. At least one control was not applied correctly to the camera.\n> * The application should compare the metadata to the requested control values\n> * to check which controls weren't applied.\n> + *\n> + * \\var Request::PFCError\n> + * A per-frame-control error has occured. Controls that were expected to be set\n> + * during the processing of this request were not processed in time.\n> */\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 038AFC3272\n\tfor ;\n\tThu, 11 Aug 2022 04:55:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DC1C6332B;\n\tThu, 11 Aug 2022 06:55:40 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CC0FE61FA8\n\tfor ;\n\tThu, 11 Aug 2022 06:55:38 +0200 (CEST)","from [IPV6:2401:4900:1f3f:c7a1:27b3:9637:38a7:6084] (unknown\n\t[IPv6:2401:4900:1f3f:c7a1:27b3:9637:38a7:6084])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5EB63F1;\n\tThu, 11 Aug 2022 06:55:37 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660193740;\n\tbh=WPPO8dJ90D+tZM0KXPs0951RCYyQ3kJD1THDaqtXZyQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=z4wrGZktnzj2gN37pGv/XQPT4+6h/hpY46iKoW+O/fDH9OXbv6acMSr8+dGpluY5R\n\t+7iJu7JCWfiWhAmygXmwKzptjvR/ch3C92Vd96CaV+0Y9ykDA9Ue+vZ+9LKBRiWaYX\n\tZDqcM3izwexhMQda9BudD+6bdsa1mNACvyJJaMa0MiUje0mbXQiXmWmEEYreJNYASG\n\tJ6uNXu6CmILxoAQOaps8aDO6NQXp5HQN3qDCAgjpBtVnOEvSWf/JxyWSgGbMuAnoVz\n\tnhCsrnr4wVX9hfMhugIdSy6rdgWFdYXcGQJbyA8Ae9a9xkI9LXp3nxxrFiDoyNSVQX\n\twiLpanYlAoeTg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660193738;\n\tbh=WPPO8dJ90D+tZM0KXPs0951RCYyQ3kJD1THDaqtXZyQ=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=plwpgpDC5zlAm0lOZLWcnnMJy4KgkVSAm29e3iTawGNGlKPDsE0ZI84yRgjmXYTKX\n\tGIxVBodyozF0dchgnhyqzxitvYpd0VWRifMsREl/7MIv1r/65qKuzMbBddR3hPgNtb\n\tkNbaKva7l87CruTE74ImYl35bVtjDQ9upoFHEfnY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"plwpgpDC\"; dkim-atps=neutral","Message-ID":"<210951ee-1076-14c6-5568-7f13c4ef568e@ideasonboard.com>","Date":"Thu, 11 Aug 2022 10:25:33 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20220805135312.47497-1-jacopo@jmondi.org>\n\t<20220805135312.47497-4-jacopo@jmondi.org>","In-Reply-To":"<20220805135312.47497-4-jacopo@jmondi.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH v2 03/10] libcamera: request: Add\n\tPFCError flag","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24596,"web_url":"https://patchwork.libcamera.org/comment/24596/","msgid":"","date":"2022-08-16T03:27:18","subject":"Re: [libcamera-devel] [PATCH v2 03/10] libcamera: request: Add\n\tPFCError flag","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo and Kieran,\n\nThank you for the patch.\n\nOn Fri, Aug 05, 2022 at 03:53:05PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> From: Kieran Bingham via libcamera-devel \n\nWrong here too.\n\n> Provide a new flag for the Request error state to indicate that a\n> per-frame control error has occurred. One or more controls set for this\n> request could not be guaranteed on this frame.\n> \n> Signed-off-by: Kieran Bingham \n> Reviewed-by: Jacopo Mondi \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/request.h | 1 +\n> src/libcamera/request.cpp | 4 ++++\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/include/libcamera/request.h b/include/libcamera/request.h\n> index 3304da31200d..9aee81922c91 100644\n> --- a/include/libcamera/request.h\n> +++ b/include/libcamera/request.h\n> @@ -47,6 +47,7 @@ public:\n> \tenum ErrorFlag {\n> \t\tNoError = 0,\n> \t\tControlError = (1 << 0),\n> +\t\tPFCError = (1 << 1),\n\nThis answers the question in my review of 01/10 regarding whether we'll\nhave multiple flags.\n\n> \t};\n> \n> \tusing Errors = Flags;\n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 9a808f19fc03..b93eaac75880 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -346,6 +346,10 @@ void Request::Private::timeout()\n> * Control Error. At least one control was not applied correctly to the camera.\n> * The application should compare the metadata to the requested control values\n> * to check which controls weren't applied.\n> + *\n> + * \\var Request::PFCError\n> + * A per-frame-control error has occured. Controls that were expected to be set\n> + * during the processing of this request were not processed in time.\n\nThe documentation needs to clearly explain the difference between\nControlError and PFCError. Introducing PFCError by itself without a\nbroader per-frame control infrastructure and documentation make me\nreally uncomfortable.\n\n> */\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 50D1FC3272\n\tfor ;\n\tTue, 16 Aug 2022 03:27:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DA4261FC0;\n\tTue, 16 Aug 2022 05:27:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 84ACB603E3\n\tfor ;\n\tTue, 16 Aug 2022 05:27:32 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED54C496;\n\tTue, 16 Aug 2022 05:27:31 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660620454;\n\tbh=ckM1rOvpk7Qzd2FiivxYYtAWKR20EaQQw3Nj7bJqHmI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=igIoPdgxxZIOXDq8uOL/QPgA68M/wHRhXyf0Qf7xBpO876vCkgcM6UHPkl5RmS/+p\n\tBkq9GOhA3TTi1IaSPJZf5EKIvbRBk8FitiO4Xv6ZUSqyq1Jh12pdXfZLDj+u73jbKU\n\tWCgRZR4of1VH9pVC//ILZ5TZBgsZuGgchXpFVeAsItTz1z8/JqgWmlBK2dNMcfYubf\n\thgHywHDuBaxzCNkA1a9z6DQujQjyylchhIePIGuzxuaVQduStFVJiTTaBkedl2mhja\n\tcUd3TfeAPBMMo1TwpWr9A73zUZiWfwAyCwEfc/Vm4o4gzmkTT4NqgyNhMIRQVGVo1E\n\tXmKoI0sbeEaTg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660620452;\n\tbh=ckM1rOvpk7Qzd2FiivxYYtAWKR20EaQQw3Nj7bJqHmI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=O15xznG+8Ot4lJmec4ehMYmNrVMaJFIbaHnFXcFKg3AWgRvI0cLgIQ4srmQyAK7UD\n\tCUA/olGQ+v+uXzZTBy/u48cU7n0v6W+70D6Qyhp7EzX1PCcAdwsGGYWa/QYIihSJZb\n\tax/Et0vdTRDCB6fIp3EjzBGhnEIfkWXitSvrdy7k="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"O15xznG+\"; dkim-atps=neutral","Date":"Tue, 16 Aug 2022 06:27:18 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220805135312.47497-1-jacopo@jmondi.org>\n\t<20220805135312.47497-4-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220805135312.47497-4-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v2 03/10] libcamera: request: Add\n\tPFCError flag","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]