[{"id":24371,"web_url":"https://patchwork.libcamera.org/comment/24371/","msgid":"","date":"2022-08-04T14:14:37","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: rkisp1: Use YAML 1.1 for\n\ttuning data files","submitter":{"id":123,"url":"https://patchwork.libcamera.org/api/people/123/","name":"Florian Sylvestre","email":"fsylvestre@baylibre.com"},"content":"On Thu, 4 Aug 2022 at 15:21, Laurent Pinchart\n wrote:\n>\n> YAML 1.2 support has been added in libyaml in version 0.2.3. Debian\n> stable ships version 0.2.2 of libyaml, which causes parse errors of the\n> tuning tuning data files due to the YAML 1.2 directive at the beginning.\n> As we don't use any feature of YAML 1.2, downgrade the data files to\n> YAML 1.1.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> src/ipa/rkisp1/data/imx219.yaml | 2 +-\n> src/ipa/rkisp1/data/ov5640.yaml | 2 +-\n> src/ipa/rkisp1/data/uncalibrated.yaml | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\n> index 232d8ae8d58b..ce3d547f780c 100644\n> --- a/src/ipa/rkisp1/data/imx219.yaml\n> +++ b/src/ipa/rkisp1/data/imx219.yaml\n> @@ -1,5 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> -%YAML 1.2\n> +%YAML 1.1\n> ---\n> version: 1\n> algorithms:\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> index 93d7d1e709d3..45d4bb77f8ca 100644\n> --- a/src/ipa/rkisp1/data/ov5640.yaml\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -1,5 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> -%YAML 1.2\n> +%YAML 1.1\n> ---\n> version: 1\n> algorithms:\n> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml\n> index bdbd5fda7eaf..a7bbd8d84263 100644\n> --- a/src/ipa/rkisp1/data/uncalibrated.yaml\n> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml\n> @@ -1,5 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> -%YAML 1.2\n> +%YAML 1.1\n> ---\n> version: 1\n> algorithms:\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\nReviewed-by: Florian Sylvestre ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D0178C3272\n\tfor ;\n\tThu, 4 Aug 2022 14:14:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85AA46332B;\n\tThu, 4 Aug 2022 16:14:51 +0200 (CEST)","from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n\t[IPv6:2607:f8b0:4864:20::629])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52C8D6330D\n\tfor ;\n\tThu, 4 Aug 2022 16:14:50 +0200 (CEST)","by mail-pl1-x629.google.com with SMTP id p18so2123186plr.8\n\tfor ;\n\tThu, 04 Aug 2022 07:14:50 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659622491;\n\tbh=h0suTULPW4/swxcMyB+IjViKb2WSnil82WA7zguYsBM=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wzv0I6b0wVsaXp+mvoQaIFRmWgkYYnIJjEkDfgpyOHkLMpy7b9ZIL4V175vtQqaKQ\n\t5VsPXriAB1eR9K+VM7wElLHRdo2UyKUlC8/1THBvQ6GsqWzqmGobh12Ey+arOXHvpK\n\tsMHWASlthAO7RTuZwm8nNajZL9h87KVa+o23zi0/iHfo0dUiAn+F+AgZjP9f114qK+\n\tIcwbiCBUYTccFXPDy4sztFt8KGczDNNbLUpnBvF7vwA+94Hpx4Gn2HrEhjm/3esNYT\n\tJNhMcbDpBRMNNikF1EOdaZtPaGITyfgtvLLZu6U2vxCrNp9JYfY9fBh5EOMZ+3LKWh\n\t8A+DtFq1Kq0ew==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=baylibre-com.20210112.gappssmtp.com; s=20210112;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=qgmkdlbeuciDG3w0xEGFax6JeItzX4RRmyfZJJXDuBQ=;\n\tb=F1q4RqO3RTOhbG897fY6pKggOkJnrfkCORm6TDcIszKEJFUUNPs0XCSPHNQCSCIe1u\n\tvMFkoecLeBjmV/5P6SQ0IRL+IB2gBG+l6zHOtkQ671/qm5nwoZg2hh+vBPeWh3KUi2Za\n\tN3Kse5+mkedXAlWh6tuDSw0+H/DKyeb738qtpRXNSSNB5YRegS+ZwN+3EdvcL9ajqdFb\n\tSSZBF/xSD6w3SkJvGUkMUHMDwyMgnreWgIkCp0a5sRThdDUog9AypBYbyjUpvq6nNmIC\n\t3/63VctLY7QvAAzYnaWYCbXLPoVmfE3vh8QBEZkTOku2gvv8KOk8MAysDRFM9XQJEm1w\n\tYY3w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=baylibre-com.20210112.gappssmtp.com\n\theader.i=@baylibre-com.20210112.gappssmtp.com header.b=\"F1q4RqO3\"; \n\tdkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=qgmkdlbeuciDG3w0xEGFax6JeItzX4RRmyfZJJXDuBQ=;\n\tb=RxDjttQSrehdzFrhRi6PRsUlXUvBAKqLLL4U+EYtbMLshn9cliynPgNfwkHIcfMGgi\n\tFqxLHy5jeS1/A7oLETmpFPQVfeyACayAa9i2OKzOZm1gPIxUI6k1CGMiL81Kt+PbVqJb\n\tmOs6AyBIn7QmQ4yCxE5VXte8ivevawDjlqbUfM+NaYVx0MCVbUThpwy0n6fYlwJEmw+/\n\tDn7So89kvBjBGjONuBCOf9wc8IAZGcgmH/+iiiEZkBO5B6MiAhcJmcYshByTRhYEWh7u\n\tEY68EYFZeZtC5NzE3uuGfj9tJ1qxKVP+0b22eXog67IDMLo3+Q4RIXMUbPGwBprIw21u\n\tY3eg==","X-Gm-Message-State":"ACgBeo1bTkEo4q6imgXTFVn8MkZ95m7D8xEZEExlQI+7nAdxBS8MLhaW\n\t525h4g+qE5iTVXrhWRnYS7EwX5UxD1LXkSBN9QHTKlz0xyaSnIKJ","X-Google-Smtp-Source":"AA6agR4YPMUegdM67mZ5CiIqRPfAwicvQY5iAGgD2hHJW5rYdpeWKPRm5mIEj0YZaXqnEVZvkXvR50O/vPlDUziOMYc=","X-Received":"by 2002:a17:90b:4c0f:b0:1f5:179a:28df with SMTP id\n\tna15-20020a17090b4c0f00b001f5179a28dfmr2383229pjb.42.1659622488767;\n\tThu, 04 Aug 2022 07:14:48 -0700 (PDT)","MIME-Version":"1.0","References":"<20220804132112.17604-1-laurent.pinchart@ideasonboard.com>\n\t<20220804132112.17604-2-laurent.pinchart@ideasonboard.com>","In-Reply-To":"<20220804132112.17604-2-laurent.pinchart@ideasonboard.com>","Date":"Thu, 4 Aug 2022 16:14:37 +0200","Message-ID":"","To":"Laurent Pinchart ","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: rkisp1: Use YAML 1.1 for\n\ttuning data files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Florian Sylvestre via libcamera-devel\n\t","Reply-To":"Florian Sylvestre ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24373,"web_url":"https://patchwork.libcamera.org/comment/24373/","msgid":"<165962502356.1519432.5445303698221578372@Monstersaurus>","date":"2022-08-04T14:57:03","subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: rkisp1: Use YAML 1.1 for\n\ttuning data files","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart via libcamera-devel (2022-08-04 14:21:11)\n> YAML 1.2 support has been added in libyaml in version 0.2.3. Debian\n> stable ships version 0.2.2 of libyaml, which causes parse errors of the\n> tuning tuning data files due to the YAML 1.2 directive at the beginning.\n> As we don't use any feature of YAML 1.2, downgrade the data files to\n> YAML 1.1.\n> \n> Signed-off-by: Laurent Pinchart \n\nThis fixes my issues too. (albeit not in these files).\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rkisp1/data/imx219.yaml | 2 +-\n> src/ipa/rkisp1/data/ov5640.yaml | 2 +-\n> src/ipa/rkisp1/data/uncalibrated.yaml | 2 +-\n> 3 files changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml\n> index 232d8ae8d58b..ce3d547f780c 100644\n> --- a/src/ipa/rkisp1/data/imx219.yaml\n> +++ b/src/ipa/rkisp1/data/imx219.yaml\n> @@ -1,5 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> -%YAML 1.2\n> +%YAML 1.1\n> ---\n> version: 1\n> algorithms:\n> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml\n> index 93d7d1e709d3..45d4bb77f8ca 100644\n> --- a/src/ipa/rkisp1/data/ov5640.yaml\n> +++ b/src/ipa/rkisp1/data/ov5640.yaml\n> @@ -1,5 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> -%YAML 1.2\n> +%YAML 1.1\n> ---\n> version: 1\n> algorithms:\n> diff --git a/src/ipa/rkisp1/data/uncalibrated.yaml b/src/ipa/rkisp1/data/uncalibrated.yaml\n> index bdbd5fda7eaf..a7bbd8d84263 100644\n> --- a/src/ipa/rkisp1/data/uncalibrated.yaml\n> +++ b/src/ipa/rkisp1/data/uncalibrated.yaml\n> @@ -1,5 +1,5 @@\n> # SPDX-License-Identifier: CC0-1.0\n> -%YAML 1.2\n> +%YAML 1.1\n> ---\n> version: 1\n> algorithms:\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2A519BE173\n\tfor ;\n\tThu, 4 Aug 2022 14:57:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85B4663311;\n\tThu, 4 Aug 2022 16:57:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9AEF6330D\n\tfor ;\n\tThu, 4 Aug 2022 16:57:06 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34712481;\n\tThu, 4 Aug 2022 16:57:06 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659625028;\n\tbh=tsiDc80yrzFlzldXbQm9SQnl1Q3Q7n88I23hjxQDJOM=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=AWvAi/X8U/G7bTXxC1kDDzbpe/ml6J9va926ZyO+sRQ8/dpZyTrwEe/2QSAruAnQC\n\t0kJp9mazcaQnhWWQk4f4Mk18Gb8p5Wab7qbVhACnv71b0H12zpqcbZ4hIM6r/zbw3e\n\t3pkMpLYkqzWxNVO9g1azNnftF/HRBhawoUxjZ2ExlmD564kQLoaUgslADleEbfriCT\n\tMn826LZp0G1YkP476pmtx8YwREpyOKoocIe0F+/mJ+nlDpAU/c8Zy9Eq+Dq7KVSEEv\n\t82tdSaDN0OEyi8Sk331nLDf85xyT4zkjqg/QznyAxGJWN50ND/AKscncYJXhaKzBOT\n\tboIORVQ2tRY8w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659625026;\n\tbh=tsiDc80yrzFlzldXbQm9SQnl1Q3Q7n88I23hjxQDJOM=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=rAjOjUz7zO5hmEKMMbS3r7XpQEeCjpOKuAU06i+83I3qI7p12RiRQ6oBD67aA53sp\n\tLJbErZCQLLVGnUgvCBak61wTWqWPSUcw5nSitsJ/qVa2PO961fiV59ZUFzDXtuXAu5\n\tgpoUNcdOVZBg7YlFS5e2aNDphxVPLIaFjM6LdtW4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rAjOjUz7\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220804132112.17604-2-laurent.pinchart@ideasonboard.com>","References":"<20220804132112.17604-1-laurent.pinchart@ideasonboard.com>\n\t<20220804132112.17604-2-laurent.pinchart@ideasonboard.com>","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 04 Aug 2022 15:57:03 +0100","Message-ID":"<165962502356.1519432.5445303698221578372@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/2] ipa: rkisp1: Use YAML 1.1 for\n\ttuning data files","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]