[{"id":24381,"web_url":"https://patchwork.libcamera.org/comment/24381/","msgid":"","date":"2022-08-04T18:28:58","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Correct typos and\n\tomissions for packed 10-bit raw monochrome format","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Thu, Aug 04, 2022 at 11:45:50AM +0100, David Plowman via libcamera-devel wrote:\n> One typo is corrected, and this format is added to one further table\n> where it was missing entirely.\n> \n> Signed-off-by: David Plowman \n> ---\n> src/libcamera/formats.cpp | 2 +-\n> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 7b98fef2..cc8f652a 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -564,7 +564,7 @@ const std::map pixelFormatInfo{\n> \t} },\n> \t{ formats::R10_CSI2P, {\n> \t\t.name = \"R10_CSI2P\",\n> -\t\t.format = formats::R10,\n> +\t\t.format = formats::R10_CSI2P,\n\nOops indeed.\n\n> \t\t.v4l2Formats = {\n> \t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_Y10P),\n> \t\t\t.multi = V4L2PixelFormat(),\n> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n> index bdcdc3be..8d1fde5d 100644\n> --- a/src/libcamera/v4l2_pixelformat.cpp\n> +++ b/src/libcamera/v4l2_pixelformat.cpp\n> @@ -129,6 +129,8 @@ const std::map vpf2pf{\n> \t\t{ formats::R10, \"10-bit Greyscale\" } },\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_Y12),\n> \t\t{ formats::R12, \"12-bit Greyscale\" } },\n> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_Y10P),\n> +\t\t{ formats::R10_CSI2P, \"10-bit Greyscale Packed\" } },\n\nI'll move this right after R10, to match the sort order of the Bayer\nformats.\n\nReviewed-by: Laurent Pinchart \n\nAs the patch doesn't depend on the previous one, I'll apply it without\nwaiting for the outcome of the discussions in 1/2.\n\n> \n> \t/* Bayer formats. */\n> \t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3E028C3272\n\tfor ;\n\tThu, 4 Aug 2022 18:29:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A177963311;\n\tThu, 4 Aug 2022 20:29:07 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 40A006330D\n\tfor ;\n\tThu, 4 Aug 2022 20:29:06 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ACDC4481;\n\tThu, 4 Aug 2022 20:29:05 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659637747;\n\tbh=Ea/qqU2/8qB/OfcEQHfszXRQIcPmUrH/aOJmUOpHWFM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ifZvbOcV+alGqiHiGwdrzpl9J5jwcDXXwyE26j/S7Q0qQld+8WzrLYi663upz7n4z\n\tS7vlvq9VNq8exDGTfzAPuro5+WvrLOQhtFVnTd0nV3TpJUhmdrrbKQ1h0TERl325WS\n\teZ2IH2woDCjsdiRpMDxq/5RKPJmLtRpetzu04dJ9QzsdrHcnEFWVxD6OlZnzy/NRY+\n\tZPrByWrgmC4drX0OBgHBdYCeosQ3cMOUZgrpfEgC047t0loLVQGCXsniTwhf59xwaC\n\tZH5W+bVHo/4kfg/N2QDYFPBd8H+O5mO9ya7CCHt21bxLqTUipyZcXv6xGkIh/OYLV6\n\tNTXJTIGO/NXWQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659637745;\n\tbh=Ea/qqU2/8qB/OfcEQHfszXRQIcPmUrH/aOJmUOpHWFM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eP/r2r0IQia560nXo3vlOPGmslXKPqS5SJDz5Ia17JMfGrNLaGRtIzti6Ka8eo47o\n\tKgIBDXKV8w8uHPeLVelLryHeIUkLtY/HRuLpceX22E65uPgT2GfKP5lwUld6PpWb/X\n\tWIPQ/ddRlf+coRk9LhH8GsFSFlKIgcouqsTduw6U="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"eP/r2r0I\"; dkim-atps=neutral","Date":"Thu, 4 Aug 2022 21:28:58 +0300","To":"David Plowman ","Message-ID":"","References":"<20220804104550.4600-1-david.plowman@raspberrypi.com>\n\t<20220804104550.4600-3-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220804104550.4600-3-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Correct typos and\n\tomissions for packed 10-bit raw monochrome format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":25303,"web_url":"https://patchwork.libcamera.org/comment/25303/","msgid":"<6ff2e5b1-265d-9bb4-13e1-2704de20e505@ideasonboard.com>","date":"2022-10-05T11:34:24","subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Correct typos and\n\tomissions for packed 10-bit raw monochrome format","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hello\n\nOn 8/4/22 11:58 PM, Laurent Pinchart via libcamera-devel wrote:\n> Hi David,\n>\n> Thank you for the patch.\n>\n> On Thu, Aug 04, 2022 at 11:45:50AM +0100, David Plowman via libcamera-devel wrote:\n>> One typo is corrected, and this format is added to one further table\n>> where it was missing entirely.\n>>\n>> Signed-off-by: David Plowman \n>> ---\n>> src/libcamera/formats.cpp | 2 +-\n>> src/libcamera/v4l2_pixelformat.cpp | 2 ++\n>> 2 files changed, 3 insertions(+), 1 deletion(-)\n>>\n>> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n>> index 7b98fef2..cc8f652a 100644\n>> --- a/src/libcamera/formats.cpp\n>> +++ b/src/libcamera/formats.cpp\n>> @@ -564,7 +564,7 @@ const std::map pixelFormatInfo{\n>> \t} },\n>> \t{ formats::R10_CSI2P, {\n>> \t\t.name = \"R10_CSI2P\",\n>> -\t\t.format = formats::R10,\n>> +\t\t.format = formats::R10_CSI2P,\n> Oops indeed.\n>\n>> \t\t.v4l2Formats = {\n>> \t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_Y10P),\n>> \t\t\t.multi = V4L2PixelFormat(),\n>> diff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\n>> index bdcdc3be..8d1fde5d 100644\n>> --- a/src/libcamera/v4l2_pixelformat.cpp\n>> +++ b/src/libcamera/v4l2_pixelformat.cpp\n>> @@ -129,6 +129,8 @@ const std::map vpf2pf{\n>> \t\t{ formats::R10, \"10-bit Greyscale\" } },\n>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_Y12),\n>> \t\t{ formats::R12, \"12-bit Greyscale\" } },\n>> +\t{ V4L2PixelFormat(V4L2_PIX_FMT_Y10P),\n>> +\t\t{ formats::R10_CSI2P, \"10-bit Greyscale Packed\" } },\n> I'll move this right after R10, to match the sort order of the Bayer\n> formats.\n>\n> Reviewed-by: Laurent Pinchart \n>\n> As the patch doesn't depend on the previous one, I'll apply it without\n> waiting for the outcome of the discussions in 1/2.\n\nReviewed-by: Umang Jain \n\n>\n>> \n>> \t/* Bayer formats. */\n>> \t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8),","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FAB7C0DA4\n\tfor ;\n\tWed, 5 Oct 2022 11:34:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 904B8622F3;\n\tWed, 5 Oct 2022 13:34:33 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA772601C7\n\tfor ;\n\tWed, 5 Oct 2022 13:34:31 +0200 (CEST)","from [192.168.1.103] (unknown [103.86.18.245])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 51863415;\n\tWed, 5 Oct 2022 13:34:30 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1664969673;\n\tbh=L/UhigNxHic7WYg87cuFWFa5lgu2NaFQ+O1GtKCJl4w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=vIntb056GKbknbBPtBnO3mhVWCNo795Oeiq2ndPrnc6F+phhmBXi2LCe66BbALFHE\n\tCPx179BAmPkrOLDQN3JazsET93tH26Do/dG0/ECzhjOeE1ZAjgrsRSzNPoWfNukUmQ\n\tjG3xov/gIcgQSXm9lzzi7KLkP0I1oZW9nJ/XY7dEgVX9bpfoFtQhp+VE5g+u7IVsvj\n\tfyIZXtidCWUg4SHhcoNUQ5MbG7NcRWL/ETCktEUCY+yNFWZtJmjonhF0ZcEIs5uL5S\n\tp268/CRJhup69WhkJ1LVeLBPuuNh/L97LnsTkqH7Olpe0qD8HtxHf0uIwCtR7TdmlD\n\tN8Hpl4eZTb+xA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1664969671;\n\tbh=L/UhigNxHic7WYg87cuFWFa5lgu2NaFQ+O1GtKCJl4w=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=lShOZxW3cxDhMLreqD/Azo4mMBYYxLAvUdPscOa0oyVa86u8dlTwUWFTlcVW1Ijf/\n\t40DXjqMcbQfNf3/ud4S9GVFAnRcEoinRsgVA8zlDgnoRsE2nOiyjT7WdMtFVeAyoZe\n\tJnChpGeTLQPxHZY2oU9pCk6c5xsVGQtR/Pb2Gwh0="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lShOZxW3\"; dkim-atps=neutral","Message-ID":"<6ff2e5b1-265d-9bb4-13e1-2704de20e505@ideasonboard.com>","Date":"Wed, 5 Oct 2022 17:04:24 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101\n\tThunderbird/102.2.1","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tDavid Plowman ","References":"<20220804104550.4600-1-david.plowman@raspberrypi.com>\n\t<20220804104550.4600-3-david.plowman@raspberrypi.com>\n\t","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Subject":"Re: [libcamera-devel] [PATCH 2/2] libcamera: Correct typos and\n\tomissions for packed 10-bit raw monochrome format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]