{"id":16962,"url":"https://patchwork.libcamera.org/api/patches/16962/?format=json","web_url":"https://patchwork.libcamera.org/patch/16962/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220804104550.4600-3-david.plowman@raspberrypi.com>","date":"2022-08-04T10:45:50","name":"[libcamera-devel,2/2] libcamera: Correct typos and omissions for packed 10-bit raw monochrome format","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b7b8656b79718f2f397dad246439be3715fcb3ae","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16962/mbox/","series":[{"id":3371,"url":"https://patchwork.libcamera.org/api/series/3371/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3371","date":"2022-08-04T10:45:48","name":"Fixes for raw monochrome stream configurations","version":1,"mbox":"https://patchwork.libcamera.org/series/3371/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16962/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16962/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8F51BE173\n\tfor ;\n\tThu, 4 Aug 2022 10:45:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6210463329;\n\tThu, 4 Aug 2022 12:45:58 +0200 (CEST)","from mail-wr1-x433.google.com (mail-wr1-x433.google.com\n\t[IPv6:2a00:1450:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DC796332F\n\tfor ;\n\tThu, 4 Aug 2022 12:45:56 +0200 (CEST)","by mail-wr1-x433.google.com with SMTP id z12so14663681wrs.9\n\tfor ;\n\tThu, 04 Aug 2022 03:45:56 -0700 (PDT)","from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\te27-20020adfa45b000000b0021e519eba9bsm829695wra.42.2022.08.04.03.45.55\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Aug 2022 03:45:55 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659609958;\n\tbh=8TVRQSACYfmAjQJvvLgZt1+8mfS1qTQpkH9SddNi3rA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=aUPrgzWdye+60J1YxivqzJr6dl/+iNH3ogT410r7DSsgGdfDW32CwoyaAXpP1aQdf\n\tWvUEnPc7sTXKtXP6bmKbT52TZvbfYiWUl6B6Qt0K+8Ntwevm9Lh66ILct6fJYYSIeR\n\t62UETS9G+WiKRhpGDCRvOFBUp5mqJs9W9fSS5zV9rCN5TrpvoK4nYdyWG19O5jh5l2\n\tybdXVwyzlpXP/kMqjAvo1SP4fRVeM7dsy4bsC0x/ufEZP6qhAHcWTOB6yXyBjsFBKi\n\thJImwYN/WT0xQ1f+FslVJnFUJ0s7lJvvWsOU/Ur14NY3GJWdWtzbYmtxjxD86hD6X/\n\tYshOmyeWytH0g==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mCadCaPYG6Zx7Zz8FATk1GdedB7aA30sm4oz5MW/VNE=;\n\tb=C8BfLDZwRFxJxwRn8oeKVcqNgPyrGLQ3hBnbuGxbNeSOv32pKC4ii12s2NystzxSFp\n\tHsPeHolvm/2dLeVUCyZpDA4TZM7AdHoGP1LhUYAFWmqIrVrhq/3KsZRUZcWRhZGjskEv\n\tlvgbN0ju6aqLg0aZ+nN9Wk+Xl7JPtHy1E6tSwjtdqfxtIX9HxmGHZfi1CswyCERxOwPj\n\tor425RY8dPJB7pRWMCYTtOOhV2L5m1PMfb9Gwf1pJkXg8YuUPLCXGWqkE5TyJKKOaUbT\n\tiub249ZgneppXH1sOGEe6Rdyyod+GK0z9uEMy5qQChI+x1EIkRRLRrOuLBFGFv9Ps2km\n\tdtTw=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"C8BfLDZw\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mCadCaPYG6Zx7Zz8FATk1GdedB7aA30sm4oz5MW/VNE=;\n\tb=hYnPmkw05wcmlO4oycwr+DYBUdbidvFuKVtLXD+VnNcY43TJWx2NXGnXwGV2trMbO7\n\tXo6/TOga8OVOL9M7iocyaHPS19U3FMFbbNDDNo/6H9sP10Sl38PLtCoF+xbM3hxrteoW\n\tj3h/ws6TWduxfdl2+orTyspxLYh3dUsW1cXg/f8D7TTC0bcB/Ge7bGbdOx5Ep6jOotZ0\n\tVFatNAYzUFjNEBXrlxrbP4V6qoQzliKglfIPz3QINFUlOmDLzwgOX5nJkz5HWYAAIH1l\n\tl06AeZ0LWuraodZ8a2/UF5o4X/sEEadmv3FKQzzV1lVaDZFZxGpd1QfCmwEqLseOeWJY\n\tHIBw==","X-Gm-Message-State":"ACgBeo0lGFIktCvhHJHCVScv0TFMK4G2qoEfilxDRm7q06wR8TK//0Tg\n\tmhlfWQ6fS9vj785Znw/RZdJwA2VhZUNehZkH","X-Google-Smtp-Source":"AA6agR7rlm/wSztKuWYR0Vluzewrzm5D3jg7WDOAmKI06TeEeF63aM5A99MmXIlIInjpyBKz3l6vdA==","X-Received":"by 2002:adf:db8e:0:b0:21e:3fff:6bae with SMTP id\n\tu14-20020adfdb8e000000b0021e3fff6baemr970182wri.184.1659609955818; \n\tThu, 04 Aug 2022 03:45:55 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 4 Aug 2022 11:45:50 +0100","Message-Id":"<20220804104550.4600-3-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.30.2","In-Reply-To":"<20220804104550.4600-1-david.plowman@raspberrypi.com>","References":"<20220804104550.4600-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: Correct typos and\n\tomissions for packed 10-bit raw monochrome format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"David Plowman via libcamera-devel ","Reply-To":"David Plowman ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"One typo is corrected, and this format is added to one further table\nwhere it was missing entirely.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/formats.cpp | 2 +-\n src/libcamera/v4l2_pixelformat.cpp | 2 ++\n 2 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex 7b98fef2..cc8f652a 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -564,7 +564,7 @@ const std::map pixelFormatInfo{\n \t} },\n \t{ formats::R10_CSI2P, {\n \t\t.name = \"R10_CSI2P\",\n-\t\t.format = formats::R10,\n+\t\t.format = formats::R10_CSI2P,\n \t\t.v4l2Formats = {\n \t\t\t.single = V4L2PixelFormat(V4L2_PIX_FMT_Y10P),\n \t\t\t.multi = V4L2PixelFormat(),\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex bdcdc3be..8d1fde5d 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -129,6 +129,8 @@ const std::map vpf2pf{\n \t\t{ formats::R10, \"10-bit Greyscale\" } },\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_Y12),\n \t\t{ formats::R12, \"12-bit Greyscale\" } },\n+\t{ V4L2PixelFormat(V4L2_PIX_FMT_Y10P),\n+\t\t{ formats::R10_CSI2P, \"10-bit Greyscale Packed\" } },\n \n \t/* Bayer formats. */\n \t{ V4L2PixelFormat(V4L2_PIX_FMT_SBGGR8),\n","prefixes":["libcamera-devel","2/2"]}