[{"id":24454,"web_url":"https://patchwork.libcamera.org/comment/24454/","msgid":"","date":"2022-08-09T01:45:58","subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: ipa_interface: Include\n\tflags.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Aug 03, 2022 at 08:21:46PM +0900, Paul Elder via libcamera-devel wrote:\n> Since we will soon be adding support for Flags in IPA interfaces, the\n> header for Flags needs to be included in ipa_interface.h. Do so.\n\nWhile I'm all for the \"one change, one patch\" philosophy, we're reaching\nthe limits of what's reasonable :-) Please squash this with the patch\nthat uses it.\n\n> Signed-off-by: Paul Elder \n> ---\n> include/libcamera/ipa/ipa_interface.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/include/libcamera/ipa/ipa_interface.h b/include/libcamera/ipa/ipa_interface.h\n> index 50ca0e7b..8afcfe21 100644\n> --- a/include/libcamera/ipa/ipa_interface.h\n> +++ b/include/libcamera/ipa/ipa_interface.h\n> @@ -13,6 +13,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> \n> #include ","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E281C3272\n\tfor ;\n\tTue, 9 Aug 2022 01:46:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C6A576332B;\n\tTue, 9 Aug 2022 03:46:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D06296330E\n\tfor ;\n\tTue, 9 Aug 2022 03:46:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C9E4481;\n\tTue, 9 Aug 2022 03:46:09 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660009571;\n\tbh=235rbwIdP72MN4tNYi+tHp3dUOnS1sgbAOqvVAgSFis=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=uTcFY8SdSN/KsGvBn9ImMUMCN5+IRVW0GBNhDgV39dMXzycyo1usSGHSRYHQ1oBnQ\n\tjuQbtirxDc1FOgWqQgtIOvxms9CSCyzjZk47vKdTIA7XmK2jm0joNkSIIpBvh6JzDe\n\tHVnTwqo4zn8NvfaKL2xevzcJL+Mwko40lhltrbsu0xB2YALJSlOAjjDyW3kquosMnP\n\t1R0uc1F86VRo2io3w3v86K0Hf1T2uVdDqrX0hFT02PFoVoaOJGQh+LhvEcroTPW18A\n\tliUaEb30uSLoxOqWq2tK5wZdVIMNvzJ3V6Gi6JakzABI2hm4O8/gIHRpDDAt+xcSe0\n\tejSXB5q1TBE8g==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660009569;\n\tbh=235rbwIdP72MN4tNYi+tHp3dUOnS1sgbAOqvVAgSFis=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ibm3pgo8ZU8Y+XaVkkF0njqC/WtEK9jkwJfnzQNn66P4Z25NbU8QznKhg32PKt32O\n\tNKQXJ+TbvkgmnBZ/aP4o1jdGrOxMVHs582U8FKoar2m3P/lR2jTFaZSi5mlQKHAHNz\n\tTA2akoQRVqb0nkj0TYW62Kz9XgWvzOONHRLh37p8="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ibm3pgo8\"; dkim-atps=neutral","Date":"Tue, 9 Aug 2022 04:45:58 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220803112150.3040287-1-paul.elder@ideasonboard.com>\n\t<20220803112150.3040287-6-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220803112150.3040287-6-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 5/9] libcamera: ipa_interface: Include\n\tflags.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]