[{"id":24453,"web_url":"https://patchwork.libcamera.org/comment/24453/","msgid":"","date":"2022-08-09T01:35:49","subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: ipa_data_serializer:\n\tAdd serializer for Flags","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Aug 03, 2022 at 08:21:45PM +0900, Paul Elder via libcamera-devel wrote:\n> Implement an IPADataSerializer for Flags.\n> \n> Signed-off-by: Paul Elder \n> ---\n> .../libcamera/internal/ipa_data_serializer.h | 48 +++++++++++++++++++\n> 1 file changed, 48 insertions(+)\n> \n> diff --git a/include/libcamera/internal/ipa_data_serializer.h b/include/libcamera/internal/ipa_data_serializer.h\n> index 30bdaebc..3645da4c 100644\n> --- a/include/libcamera/internal/ipa_data_serializer.h\n> +++ b/include/libcamera/internal/ipa_data_serializer.h\n> @@ -14,6 +14,7 @@\n> #include \n> #include \n> \n> +#include \n> #include \n> \n> #include \n> @@ -301,6 +302,53 @@ public:\n> \t}\n> };\n> \n> +/* Serialization format for Flags is same as for PODs */\n> +template\n> +class IPADataSerializer>\n> +{\n> +public:\n> +\tstatic std::tuple, std::vector>\n> +\tserialize(const Flags &data, [[maybe_unused]] ControlSerializer *cs = nullptr)\n> +\t{\n> +\t\tstd::vector dataVec;\n> +\t\tdataVec.reserve(sizeof(Flags));\n> +\t\tappendPOD(dataVec, data.value_);\n\n\t\tappendPOD(dataVec, static_cast::Type>(data));\n\n> +\n> +\t\treturn { dataVec, {} };\n> +\t}\n> +\n> +\tstatic Flags deserialize(std::vector &data,\n> +\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n> +\t{\n> +\t\treturn deserialize(data.cbegin(), data.end());\n> +\t}\n> +\n> +\tstatic Flags deserialize(std::vector::const_iterator dataBegin,\n> +\t\t\t\t std::vector::const_iterator dataEnd,\n> +\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n> +\t{\n> +\t\tFlags ret;\n> +\t\tret.value_ = readPOD(dataBegin, 0, dataEnd);\n> +\t\treturn ret;\n\nAnd here,\n\n\t\treturn Flags{ static_cast(readPOD(dataBegin, 0, dataEnd)) };\n\nThat should take care of the friends statement hopefully.\n\nReviewed-by: Laurent Pinchart \n\n> +\t}\n> +\n> +\tstatic Flags deserialize(std::vector &data,\n> +\t\t\t\t [[maybe_unused]] std::vector &fds,\n> +\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n> +\t{\n> +\t\treturn deserialize(data.cbegin(), data.end());\n> +\t}\n> +\n> +\tstatic Flags deserialize(std::vector::const_iterator dataBegin,\n> +\t\t\t\t std::vector::const_iterator dataEnd,\n> +\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsBegin,\n> +\t\t\t\t [[maybe_unused]] std::vector::const_iterator fdsEnd,\n> +\t\t\t\t [[maybe_unused]] ControlSerializer *cs = nullptr)\n> +\t{\n> +\t\treturn deserialize(dataBegin, dataEnd);\n> +\t}\n> +};\n> +\n> #endif /* __DOXYGEN__ */\n> \n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3825FBE173\n\tfor ;\n\tTue, 9 Aug 2022 01:36:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 92E156332B;\n\tTue, 9 Aug 2022 03:36:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7DBA46330E\n\tfor ;\n\tTue, 9 Aug 2022 03:36:00 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E1E6A481;\n\tTue, 9 Aug 2022 03:35:59 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660008961;\n\tbh=qB+WmrfJ+FGhDokcxDruBIKQRVr2p8emmUEpepXgdbM=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ylnMoIBYHxX3llra6ur3tAoC8fGQIqZmwfn4xR7T8SOJUlllhY2tKD4VrToVQXaNn\n\tv1Pb3ZQTQHMhsctzVupcEai5T57XR6Om/VUqTsQavUbjdHpNVx6ocXWz4m3jy1AJ9+\n\tMTJfvSvA8PhZnl9TapdlU6vfUV4WW2AV4lcrnmveJmvuoiOJt3BRZ06fBMu6URTQPX\n\tNfjsj0CMmt3adKYbNVjdX13rJXO2spnJ8R69XOWQEJziHFGSZz1v2MtWET0CkSdojQ\n\tIGzTbd5LBlgXkQvpiGAu2638yaEH11zqD9bK5enj5HA2CldggVu9rlI0m/wwsCBfuO\n\tz0Szgf4KOB9RQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660008960;\n\tbh=qB+WmrfJ+FGhDokcxDruBIKQRVr2p8emmUEpepXgdbM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=v72WYHVa7KrI1K6e/erzmpsrk8qbhzohLRmY9stAcobsWTqjZApZwnk/tomxIzP/s\n\tmgLnMJUTDC0Z5UQ05qoVIhjkrcUzzE7W+aHyK9z43f/1a5UF/V6e3KP1ivf/7D/Gjh\n\trOU8cpo2GUbVLpIOaCmAWWw3i8juHdW07AwcWu08="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"v72WYHVa\"; dkim-atps=neutral","Date":"Tue, 9 Aug 2022 04:35:49 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220803112150.3040287-1-paul.elder@ideasonboard.com>\n\t<20220803112150.3040287-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220803112150.3040287-5-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 4/9] libcamera: ipa_data_serializer:\n\tAdd serializer for Flags","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]