[{"id":24450,"web_url":"https://patchwork.libcamera.org/comment/24450/","msgid":"","date":"2022-08-09T00:24:07","subject":"Re: [libcamera-devel] [PATCH 1/9] test: generated_serializer: Test\n\tenum that is struct member","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Wed, Aug 03, 2022 at 08:21:42PM +0900, Paul Elder via libcamera-devel wrote:\n> Add an enum field to the test struct member to test\n> serialization/deserialization of enums that are struct members.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> .../generated_serializer/generated_serializer_test.cpp | 4 ++++\n> .../generated_serializer/include/libcamera/ipa/test.mojom | 1 +\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> index 698c81d6..a4639a80 100644\n> --- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n> +++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> @@ -51,6 +51,7 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n> \t\tt.s2 = \"goodbye\";\n> \t\tt.s3 = \"lorem ipsum\";\n> \t\tt.i = 58527;\n> +\t\tt.c = ipa::test::IPAOperationInit;\n> \n> \t\tstd::vector serialized;\n> \n> @@ -69,6 +70,7 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n> \t\tTEST_FIELD_EQUALITY(t, u, s2);\n> \t\tTEST_FIELD_EQUALITY(t, u, s3);\n> \t\tTEST_FIELD_EQUALITY(t, u, i);\n> +\t\tTEST_FIELD_EQUALITY(t, u, c);\n> \n> \n> \t\t/* Test vector of generated structs */\n> @@ -92,11 +94,13 @@ if (struct1.field != struct2.field) {\t\t\t\t\\\n> \t\tTEST_FIELD_EQUALITY(v[0], w[0], s2);\n> \t\tTEST_FIELD_EQUALITY(v[0], w[0], s3);\n> \t\tTEST_FIELD_EQUALITY(v[0], w[0], i);\n> +\t\tTEST_FIELD_EQUALITY(v[0], w[0], c);\n> \n> \t\tTEST_FIELD_EQUALITY(v[1], w[1], s1);\n> \t\tTEST_FIELD_EQUALITY(v[1], w[1], s2);\n> \t\tTEST_FIELD_EQUALITY(v[1], w[1], s3);\n> \t\tTEST_FIELD_EQUALITY(v[1], w[1], i);\n> +\t\tTEST_FIELD_EQUALITY(v[1], w[1], c);\n> \n> \t\treturn TestPass;\n> \t}\n> diff --git a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n> index 5f200885..73081b40 100644\n> --- a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n> +++ b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n> @@ -18,6 +18,7 @@ struct TestStruct {\n> \tstring s2;\n> \tint32 i;\n> \tstring s3;\n> +\tIPAOperationCode c;\n> };\n> \n> interface IPATestInterface {","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFB35C3272\n\tfor ;\n\tTue, 9 Aug 2022 00:24:20 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4B4C66332B;\n\tTue, 9 Aug 2022 02:24:20 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EFF626330E\n\tfor ;\n\tTue, 9 Aug 2022 02:24:18 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6955F481;\n\tTue, 9 Aug 2022 02:24:18 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660004660;\n\tbh=FUqgJ5KM17SivWAByyVIjbFbqLAgctgGz5d9SFNwceA=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=tG1v2xnYnbvWXQlpNIl88REnVoPKk64ujRot0Nx3CrxNfShWOWc+pzT3fudZDjgu9\n\t8LxkUN/lkfPhqDceUV2z9rldMaZS2hN7YzNd4qInAyzrY4hoTM6cvgJUKOjGPhAvnw\n\tgi9HMcwTLAmG8KJ3PtpmXiCvPnTAisQLu6q7bhIjbaos4eK1RNxcnbfirk1Nv+LHEP\n\t1iqXIrNno9zLsKBh+RIKCH8M8xSmYh1Qnf4gYlPZLZDUKd2emvmfZ6Qs0j2tqL40//\n\tVRuKRJJMdo4qVUMM1uRT7dZynvjlIJtK4n3E6CXozhlwTxGTQsiItSyQ0etUk340cl\n\taNZvb31rQVVLg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660004658;\n\tbh=FUqgJ5KM17SivWAByyVIjbFbqLAgctgGz5d9SFNwceA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=hpdUg3VB4ZsfcUubmVLSqt/fkJb++zeMdbpnhar1yHwze/Ivqv8buaQnjPtx+J+XG\n\tu1rSE+I3hyzrY2RSxmYf6hyAzabc/3tql355z0hxKadpTqx9h7o1LI3ZScHokhH3Vn\n\tKf5zqWHhQq4pvJc0oDj5FK2zpLrlCAlB/IoxRPDY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hpdUg3VB\"; dkim-atps=neutral","Date":"Tue, 9 Aug 2022 03:24:07 +0300","To":"Paul Elder ","Message-ID":"","References":"<20220803112150.3040287-1-paul.elder@ideasonboard.com>\n\t<20220803112150.3040287-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220803112150.3040287-2-paul.elder@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 1/9] test: generated_serializer: Test\n\tenum that is struct member","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24457,"web_url":"https://patchwork.libcamera.org/comment/24457/","msgid":"<166003630742.2190824.13827697464227434292@Monstersaurus>","date":"2022-08-09T09:11:47","subject":"Re: [libcamera-devel] [PATCH 1/9] test: generated_serializer: Test\n\tenum that is struct member","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Paul Elder via libcamera-devel (2022-08-03 12:21:42)\n> Add an enum field to the test struct member to test\n> serialization/deserialization of enums that are struct members.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Kieran Bingham \n\n> ---\n> .../generated_serializer/generated_serializer_test.cpp | 4 ++++\n> .../generated_serializer/include/libcamera/ipa/test.mojom | 1 +\n> 2 files changed, 5 insertions(+)\n> \n> diff --git a/test/serialization/generated_serializer/generated_serializer_test.cpp b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> index 698c81d6..a4639a80 100644\n> --- a/test/serialization/generated_serializer/generated_serializer_test.cpp\n> +++ b/test/serialization/generated_serializer/generated_serializer_test.cpp\n> @@ -51,6 +51,7 @@ if (struct1.field != struct2.field) { \\\n> t.s2 = \"goodbye\";\n> t.s3 = \"lorem ipsum\";\n> t.i = 58527;\n> + t.c = ipa::test::IPAOperationInit;\n> \n> std::vector serialized;\n> \n> @@ -69,6 +70,7 @@ if (struct1.field != struct2.field) { \\\n> TEST_FIELD_EQUALITY(t, u, s2);\n> TEST_FIELD_EQUALITY(t, u, s3);\n> TEST_FIELD_EQUALITY(t, u, i);\n> + TEST_FIELD_EQUALITY(t, u, c);\n> \n> \n> /* Test vector of generated structs */\n> @@ -92,11 +94,13 @@ if (struct1.field != struct2.field) { \\\n> TEST_FIELD_EQUALITY(v[0], w[0], s2);\n> TEST_FIELD_EQUALITY(v[0], w[0], s3);\n> TEST_FIELD_EQUALITY(v[0], w[0], i);\n> + TEST_FIELD_EQUALITY(v[0], w[0], c);\n> \n> TEST_FIELD_EQUALITY(v[1], w[1], s1);\n> TEST_FIELD_EQUALITY(v[1], w[1], s2);\n> TEST_FIELD_EQUALITY(v[1], w[1], s3);\n> TEST_FIELD_EQUALITY(v[1], w[1], i);\n> + TEST_FIELD_EQUALITY(v[1], w[1], c);\n> \n> return TestPass;\n> }\n> diff --git a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n> index 5f200885..73081b40 100644\n> --- a/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n> +++ b/test/serialization/generated_serializer/include/libcamera/ipa/test.mojom\n> @@ -18,6 +18,7 @@ struct TestStruct {\n> string s2;\n> int32 i;\n> string s3;\n> + IPAOperationCode c;\n> };\n> \n> interface IPATestInterface {\n> -- \n> 2.30.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 63997C3272\n\tfor ;\n\tTue, 9 Aug 2022 09:11:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B24816332C;\n\tTue, 9 Aug 2022 11:11:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1945063325\n\tfor ;\n\tTue, 9 Aug 2022 11:11:50 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8E4E78B;\n\tTue, 9 Aug 2022 11:11:49 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1660036311;\n\tbh=Bo1Cv+eYoppWRTDBSVyXrOfxr4G6CrPv9RD+hvSbohA=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=VEyEEf/YFGhEzWTfitDI77zBFKwsDzehehvTUx/87BThnym2aAU5RU04yeYhiEG4S\n\tJjnkJtu0xR1CxWxgFuuN3HybGIFPYQ4ePhoXLCcyrmclTZykfk/PVkfY+p+X+hUlgp\n\tzSxxHT3BfTOHbX7rE+WuJ/swjsw+N1i5RDBp6rn/OaeloOn2u0LrtVr+pC4VHCh0KM\n\tPB3QOejE31riDy3Hubv4Ob2bYxq5M/+97JLPJCH9JkTR1ferE7z6AwR0yFVZtbWvqe\n\tH9C6CT9H7n23g9ypkaju7+7XdUlBmuN7zEGRDWIxalWmZsPjGPKYCHMz4psD4YEAyc\n\txNUD6frU9ZiOw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1660036309;\n\tbh=Bo1Cv+eYoppWRTDBSVyXrOfxr4G6CrPv9RD+hvSbohA=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=CmzDdCZyR8aR06/+J4xbnooeZaks4yL6KS6lpS1ZffR8IPb+smSleB0J8CTYI/9sP\n\tVQgpqWSylRz7doAuqM09xSYAZP3oLiFV0kCKp1FNkK1pw9jvCInJtPEWnytCebac1F\n\tzHFaSIb1F6NE4xTpjzxw0L1SNM9xFJwCXvYbGBHs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"CmzDdCZy\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220803112150.3040287-2-paul.elder@ideasonboard.com>","References":"<20220803112150.3040287-1-paul.elder@ideasonboard.com>\n\t<20220803112150.3040287-2-paul.elder@ideasonboard.com>","To":"Paul Elder ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 09 Aug 2022 10:11:47 +0100","Message-ID":"<166003630742.2190824.13827697464227434292@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH 1/9] test: generated_serializer: Test\n\tenum that is struct member","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]