[{"id":24312,"web_url":"https://patchwork.libcamera.org/comment/24312/","msgid":"","date":"2022-08-02T16:31:30","subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: formats:\n\tReimplement V4L2 PixelFormatInfo::info()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Tue, Aug 02, 2022 at 06:01:31PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> The PixelFormatInfo::info(const V4L2PixelFormat &format) function\n> returns the PixelFormatInfo associated with a V4L2 pixel format.\n> \n> As the pixelFormatInfo map is indexed using PixelFormat and a V4L2\n> format can easily be converted to a PixelFormat, simply return\n> the info() function overload instead of maintaining two similar\n> implementations of the same function.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/formats.cpp | 12 ++----------\n> 1 file changed, 2 insertions(+), 10 deletions(-)\n> \n> diff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\n> index 283ecb3d89d8..53207b734143 100644\n> --- a/src/libcamera/formats.cpp\n> +++ b/src/libcamera/formats.cpp\n> @@ -987,22 +987,14 @@ const PixelFormatInfo &PixelFormatInfo::info(const PixelFormat &format)\n> }\n> \n> /**\n> - * \\brief Retrieve information about a pixel format\n> + * \\brief Retrieve information about a V4L2 pixel format\n> * \\param[in] format The V4L2 pixel format\n> * \\return The PixelFormatInfo describing the V4L2 \\a format if known, or an\n> * invalid PixelFormatInfo otherwise\n> */\n> const PixelFormatInfo &PixelFormatInfo::info(const V4L2PixelFormat &format)\n> {\n> -\tconst auto &info = std::find_if(pixelFormatInfo.begin(), pixelFormatInfo.end(),\n> -\t\t\t\t\t[format](auto pair) {\n> -\t\t\t\t\t\treturn pair.second.v4l2Formats.single == format ||\n> -\t\t\t\t\t\t pair.second.v4l2Formats.multi == format;\n> -\t\t\t\t\t});\n> -\tif (info == pixelFormatInfo.end())\n> -\t\treturn pixelFormatInfoInvalid;\n> -\n> -\treturn info->second;\n> +\treturn info(format.toPixelFormat());\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 569E6C3275\n\tfor ;\n\tTue, 2 Aug 2022 16:31:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B57C663313;\n\tTue, 2 Aug 2022 18:31:36 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 833BB603E7\n\tfor ;\n\tTue, 2 Aug 2022 18:31:35 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED62825B;\n\tTue, 2 Aug 2022 18:31:34 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659457896;\n\tbh=zg+Pvw+iPjMoN4w3SF8ZS0PWhG1BlH0toCWamCIsWpE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=zVHFCkT9hZD+ktlPvYKtcz8NJ6PaB9p5o03NbTHua6Jp/4ri4fqlBLn/2ndm9vloZ\n\tnPvBFtNk2ubqAJpFQuKU1SnhAZp1zyrP4pT3TiUesTcKlHYfNQlfwVv4ymF494vRRe\n\tVgeHB92lwFFdY6qwI2ufl2U1cKfApcqZFSv0uABwFA+kNFCtgAK8rsKhZNc4m0l2bH\n\tPavpa/rv6imslo1eKiIEZY9ivW9q8ix1mkJe73g31tCEVV6M5ZRavkxFdFYK9+nqkJ\n\t8cg2s9DAkv6rkTdWZUbqhsdwJp5UaEvv7E9nvj5ViXLKbMpt8rZuHRlWQ6pSNTbL2+\n\t9YyD9bhfWQk+w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659457895;\n\tbh=zg+Pvw+iPjMoN4w3SF8ZS0PWhG1BlH0toCWamCIsWpE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=R/jgokNg3lYdAZIvSWabmjv0o9a/Q73eLN5nynFP6Br/dN7E2E8Hjo2btFTTo6vKk\n\tzzuu7Ewi4PKdR5nUi0uJk6bCG2zE1IF4oAVio2ZeGzmiCWW295lpqOEsDIKNDi+Z7A\n\t/pZPIXf36dJQ3W9KQoBa7QqgzUb+tz2UNV4+niKI="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"R/jgokNg\"; dkim-atps=neutral","Date":"Tue, 2 Aug 2022 19:31:30 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220802160136.63075-1-jacopo@jmondi.org>\n\t<20220802160136.63075-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220802160136.63075-2-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH v4 1/6] libcamera: formats:\n\tReimplement V4L2 PixelFormatInfo::info()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org, jozef@mlich.cz,\n\tPavel Machek ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]