[{"id":24292,"web_url":"https://patchwork.libcamera.org/comment/24292/","msgid":"","date":"2022-08-02T09:45:47","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Reset embedded data\n\tparser on configure","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi David,\n\n\nOn Tue, 2 Aug 2022 at 09:45, David Plowman via libcamera-devel <\nlibcamera-devel@lists.libcamera.org> wrote:\n\n> When we switch camera mode following a pipeline reconfiguration, the\n> embedded data parser should be \"reset\" to discard any data that it may\n> have cached and that might now be invalid.\n>\n> Signed-off-by: David Plowman \n>\n\nReviewed-by: Naushir Patuck \n\n\n> ---\n> src/ipa/raspberrypi/cam_helper.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/raspberrypi/cam_helper.cpp\n> b/src/ipa/raspberrypi/cam_helper.cpp\n> index 37b66198..cac8f39e 100644\n> --- a/src/ipa/raspberrypi/cam_helper.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper.cpp\n> @@ -106,6 +106,7 @@ void CamHelper::setCameraMode(const CameraMode &mode)\n> {\n> mode_ = mode;\n> if (parser_) {\n> + parser_->reset();\n> parser_->setBitsPerPixel(mode.bitdepth);\n> parser_->setLineLengthBytes(0); /* We use SetBufferSize. */\n> }\n> --\n> 2.30.2\n>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4199BE173\n\tfor ;\n\tTue, 2 Aug 2022 09:46:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 28E836330D;\n\tTue, 2 Aug 2022 11:46:05 +0200 (CEST)","from mail-lf1-x133.google.com (mail-lf1-x133.google.com\n\t[IPv6:2a00:1450:4864:20::133])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A07616330D\n\tfor ;\n\tTue, 2 Aug 2022 11:46:03 +0200 (CEST)","by mail-lf1-x133.google.com with SMTP id c17so2661662lfb.3\n\tfor ;\n\tTue, 02 Aug 2022 02:46:03 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659433565;\n\tbh=Fg3eQu8WSRWRACDzmpwYm39FujpvPEjz9k9KYKZ4SyA=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=Q3fblMELGFRF0BU7qNSiUJwCi7HOPbhwW2r4DANYH7UaKaKeHb34ZDG3B/YsPK/Yk\n\tJpxmDWE2/Z/odHZ66gzH7HWIEiDQZ6azQjpsW6fLl2/w60WyRpRNKjNsCqtGDM/hBF\n\twM11gP20Xsi7Vs4i4xIdRpzqzSMuFW7gHdQvRijzeLQEvgcWvjzXXtWtT84F6DMVug\n\t9sxNPJepJ2eucouPaPuOOsjkjyTBLWNphIve6noWws057wRdiuOnCyPWYfTJyQq/bJ\n\tn7ZFwOTgnFzgfe2cay0f+X3DrArY2IibZkUs2lS4ChouTFsAT1OwSKzB9Op/jVa4nY\n\thfdxmaL2U8Vpg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=eO7RuJsLUxS1eNUPdF2e43x/WuqGE2NnmT52g9Szy7I=;\n\tb=EbkNl+Jvn1AREckE+Tm+WjE/xuCcgNIXJmPxvn/EausENAHjekQW1RgkkdarqMpeXB\n\twK0bgDBAm+gA/8PTH/NoUPrKD8wzg7aNoMBx9Xr+skpQIQZyUDHEXW5twxdsqK8oaYMk\n\tsWDdlzlvJr71OKO1M2dr6AzJlLGq/+UirWxdO/KAZuXog2E4nhn8cTIVa4zVqAhEOGli\n\t73RS+k8xlfVZVLErS0as5S5eeXUvw/DMf/BrxXVENhiGVjU151OrvDp6ZjiONZvNm1SY\n\tXXt56zTCodHzNdcaBUzjOdWb3ikcEWW2HLR3NWdAEUqcY6LV6ziTKLqpW7sMhCJl9Sbx\n\tLVoQ=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"EbkNl+Jv\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=eO7RuJsLUxS1eNUPdF2e43x/WuqGE2NnmT52g9Szy7I=;\n\tb=7ssaJ36kFjhWNkWvoeSwLlX7/DG2s8nVPlKLIQH3/Ei3k+9D2AYCOXKfLEveRpz0LS\n\tUj/wMqiR3CJ3X2EEvxXK6Z+gLtWwcSZOXyVJJnJbg+h83NiNIXeIpKuvZVLx0kmgiKSz\n\truuw080veRPoplNeWGtCsXpXG7NgQReHUxuifplElAX6ZkZVcXhu8VC3WOJkADICVtIi\n\tkUGeh2/SAuipr8kWV0bp8/FzlVSvGcLdA5PdoOud1otHt0IeMHULhlGBnGWcVWrnZ/Ev\n\td6PPfkG+bU2bKl4pYWaY+VfVvF75YsAo2DuQS8yPrpxrzmn4KLDSPYtcwcyeJ3a/QA4T\n\t4twQ==","X-Gm-Message-State":"AJIora/FJhWi0zrZi//5bVfqP6ppf23yGDtpAcLfcWQYtlVm7fgIkaLD\n\tPHg2oQUe1V00M8559gZ35/pwpQyIfmCO0UvC8suUhA==","X-Google-Smtp-Source":"AGRyM1uRgBt+uzfBwQbl7kBdrWRqrQ1diUE+sH1613RwME68qFmZrS3wQNTOmejT96y1MzNaugy8Ci20dxha0HyPGnI=","X-Received":"by 2002:a05:6512:3f13:b0:48a:a89e:3ccb with SMTP id\n\ty19-20020a0565123f1300b0048aa89e3ccbmr6607605lfa.245.1659433562905;\n\tTue, 02 Aug 2022 02:46:02 -0700 (PDT)","MIME-Version":"1.0","References":"<20220802084526.4786-1-david.plowman@raspberrypi.com>","In-Reply-To":"<20220802084526.4786-1-david.plowman@raspberrypi.com>","Date":"Tue, 2 Aug 2022 10:45:47 +0100","Message-ID":"","To":"David Plowman ","Content-Type":"multipart/alternative; boundary=\"0000000000000bb3ce05e53efc1a\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Reset embedded data\n\tparser on configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Naushir Patuck via libcamera-devel\n\t","Reply-To":"Naushir Patuck ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24302,"web_url":"https://patchwork.libcamera.org/comment/24302/","msgid":"","date":"2022-08-02T10:47:49","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Reset embedded data\n\tparser on configure","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi David,\n\nThank you for the patch.\n\nOn Tue, Aug 02, 2022 at 09:45:26AM +0100, David Plowman via libcamera-devel wrote:\n> When we switch camera mode following a pipeline reconfiguration, the\n> embedded data parser should be \"reset\" to discard any data that it may\n> have cached and that might now be invalid.\n> \n> Signed-off-by: David Plowman \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/cam_helper.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/raspberrypi/cam_helper.cpp b/src/ipa/raspberrypi/cam_helper.cpp\n> index 37b66198..cac8f39e 100644\n> --- a/src/ipa/raspberrypi/cam_helper.cpp\n> +++ b/src/ipa/raspberrypi/cam_helper.cpp\n> @@ -106,6 +106,7 @@ void CamHelper::setCameraMode(const CameraMode &mode)\n> {\n> \tmode_ = mode;\n> \tif (parser_) {\n> +\t\tparser_->reset();\n> \t\tparser_->setBitsPerPixel(mode.bitdepth);\n> \t\tparser_->setLineLengthBytes(0); /* We use SetBufferSize. */\n> \t}","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id F001AC3275\n\tfor ;\n\tTue, 2 Aug 2022 10:47:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C2CA63313;\n\tTue, 2 Aug 2022 12:47:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 527AC603E6\n\tfor ;\n\tTue, 2 Aug 2022 12:47:54 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C35EC593;\n\tTue, 2 Aug 2022 12:47:53 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659437275;\n\tbh=7l8BKW0TRUl3RlD0pXazvA/nqDzFc9K6y7hrvL4flnw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=B3GqIPMrvDO/8QhaFEqGEtRcuHrF+vj8aS9jpDHGPFYb0mlia0hZBZY1wJ7rZ33uO\n\tDgxyheMUHMAf26vtPkcOOrVYXl/yDkKKYdRVyjVRJ8e4q9e8mQ9bFvhfYKWzDPAko6\n\tJ5FHpGJaJ1JgOskeFEahzSZKgzuE6av1y5/l6NKxu8jCAH5h/GjpemNzWMx+q2QQ62\n\tiNwxjku0QdiaTayLPoeuA+o9+Ed+8c3ZJnl/VLPIB0L7Me3sqh5L88XQMHL9F/QasT\n\t+aSRjvsy6OPtpKVg3GRT1RpyYkRdLrlXdCsHMiv5+03hgKlGJG+AiBHyipFXLOgiW1\n\tbT1ve5FUfsKMw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659437274;\n\tbh=7l8BKW0TRUl3RlD0pXazvA/nqDzFc9K6y7hrvL4flnw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=oxMexOCkr5KR2H4ukFR2NSnLPkHWMm0UIwzsG/k6Ee5qldu+TeWpCV1sQm/IS943d\n\t5Cmvonm7lLNhkLCDWJRrj5Mk2hqipbDSI3zOoS6KJweWTPXx4lTHdhRytGVMdQ5HwJ\n\t5chdWgtivcTrd5IkN0xtG7mEBdTueAjXPUx1uyPY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oxMexOCk\"; dkim-atps=neutral","Date":"Tue, 2 Aug 2022 13:47:49 +0300","To":"David Plowman ","Message-ID":"","References":"<20220802084526.4786-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220802084526.4786-1-david.plowman@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Reset embedded data\n\tparser on configure","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]