[{"id":24275,"web_url":"https://patchwork.libcamera.org/comment/24275/","msgid":"<20220801162631.weudgr33z4ii5fe5@uno.localdomain>","date":"2022-08-01T16:26:31","subject":"Re: [libcamera-devel] [PATCH 13/13] libcamera: pipeline: simple:\n\tAdd support for NXP ISI","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent\n\nOn Mon, Aug 01, 2022 at 03:05:43AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> Several NXP i.MX8 SoCs (such as the i.MX8MN and i.MX8MP) contain a\n> camera pipeline made of sensor interfaces (with parallel and/or CSI-2\n> receivers) and an image processing engine named ISI. The ISI contains an\n> input crossbar switch and one or more processing pipelines capable of\n> format conversion and scaling.\n>\n> This is a good candidate for the simple pipeline handler as a first\n> step. The i.MX8MP should eventually graduate to having its own pipeline\n> handler as it also contains two ISP instances.\n\nOr this can already be updated to mention rkisp1 ?\n\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/pipeline/simple/simple.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> index c80e462bc449..d7b1c9de93b5 100644\n> --- a/src/libcamera/pipeline/simple/simple.cpp\n> +++ b/src/libcamera/pipeline/simple/simple.cpp\n> @@ -191,6 +191,7 @@ namespace {\n>\n> static const SimplePipelineInfo supportedDevices[] = {\n> \t{ \"imx7-csi\", { { \"pxp\", 1 } } },\n> +\t{ \"mxc-isi\", {} },\n> \t{ \"qcom-camss\", {} },\n> \t{ \"sun6i-csi\", {} },\n> };\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 24D81C3275\n\tfor ;\n\tMon, 1 Aug 2022 16:26:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E618463312;\n\tMon, 1 Aug 2022 18:26:34 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 29627603E8\n\tfor ;\n\tMon, 1 Aug 2022 18:26:34 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 5C61160005;\n\tMon, 1 Aug 2022 16:26:33 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659371194;\n\tbh=RcC96G4rQ/cHm+iFpd6JjgroshdWq7/Lh6vUweLcdnI=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2duTrCzzXz3P4bAj8Che7wKTKVOwMpMo7tl1FYzRuN1eqXDuNtxEAqCFZA9V+4w3v\n\tfEQPHuTSHLkFzd0r+eNWAc4zuVOZatx6hlfxsAOVsVKk9h1BQhccMD2+iHxLEuKv7d\n\ta1eGPgMIhCkcKUXsgxbyNsFUkyEXPW/Lntf2jf1AUtmJV7NLba1+gN4ADm4MGRDCbd\n\tfz4vI+EMF+qQu5q+O0Uqrd+tShV/nvxxuMgXQr4g0KjhF/ACwXe53WKniHN13Wjgoz\n\tjPPrOjzrRMaZzqnP3cxE11SMk1wZI020lwUsQEaIS9IkfX6T+7nOht0WJ72Ptp0uEz\n\tSvyuzi1HRPI2w==","Date":"Mon, 1 Aug 2022 18:26:31 +0200","To":"Laurent Pinchart ","Message-ID":"<20220801162631.weudgr33z4ii5fe5@uno.localdomain>","References":"<20220801000543.3501-1-laurent.pinchart@ideasonboard.com>\n\t<20220801000543.3501-14-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220801000543.3501-14-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 13/13] libcamera: pipeline: simple:\n\tAdd support for NXP ISI","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24282,"web_url":"https://patchwork.libcamera.org/comment/24282/","msgid":"","date":"2022-08-01T21:08:06","subject":"Re: [libcamera-devel] [PATCH 13/13] libcamera: pipeline: simple:\n\tAdd support for NXP ISI","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn Mon, Aug 01, 2022 at 06:26:31PM +0200, Jacopo Mondi wrote:\n> On Mon, Aug 01, 2022 at 03:05:43AM +0300, Laurent Pinchart via libcamera-devel wrote:\n> > Several NXP i.MX8 SoCs (such as the i.MX8MN and i.MX8MP) contain a\n> > camera pipeline made of sensor interfaces (with parallel and/or CSI-2\n> > receivers) and an image processing engine named ISI. The ISI contains an\n> > input crossbar switch and one or more processing pipelines capable of\n> > format conversion and scaling.\n> >\n> > This is a good candidate for the simple pipeline handler as a first\n> > step. The i.MX8MP should eventually graduate to having its own pipeline\n> > handler as it also contains two ISP instances.\n> \n> Or this can already be updated to mention rkisp1 ?\n\nI'll add \"... two ISP instances (supported by the rkisp1 driver).\".\n\n> > Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Jacopo Mondi \n> \n> > ---\n> > src/libcamera/pipeline/simple/simple.cpp | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\n> > index c80e462bc449..d7b1c9de93b5 100644\n> > --- a/src/libcamera/pipeline/simple/simple.cpp\n> > +++ b/src/libcamera/pipeline/simple/simple.cpp\n> > @@ -191,6 +191,7 @@ namespace {\n> >\n> > static const SimplePipelineInfo supportedDevices[] = {\n> > \t{ \"imx7-csi\", { { \"pxp\", 1 } } },\n> > +\t{ \"mxc-isi\", {} },\n> > \t{ \"qcom-camss\", {} },\n> > \t{ \"sun6i-csi\", {} },\n> > };","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A5BAEBE173\n\tfor ;\n\tMon, 1 Aug 2022 21:08:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 079376330F;\n\tMon, 1 Aug 2022 23:08:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B6B12603E8\n\tfor ;\n\tMon, 1 Aug 2022 23:08:11 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B4F648F;\n\tMon, 1 Aug 2022 23:08:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659388094;\n\tbh=BGEhaLRYjNC+zxbB7v84j4Z3cEe/s9lGY/hRyvo5iCQ=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=yK2OBSmWfajFlYth3jRg2ga5Gj2IgfDO3lC1LBNhBlmO3mXSEtmoW5CewZJwhZLBD\n\tMduOOdDfORtndYik9oe0rQ3mlU1mrh8seZ9SYHLx7Ou7uPUCW9LL7BDPFQka+Nh0N7\n\tabKbqHI1ZwnNDExtONHShRYQF4qzVYBs5tUNb8Z4ugjSKLC7qN34GecLwK/HSHGjWJ\n\tlXGVIJzXkaCIcwvhVcAaAWQKrvec3F63rshPehbRLrHyzgqJ2jppL7dc2D8uuXK0WV\n\tZiFAOCCkc94XUY0YqbNgkGVLsn/5rD2Wh4uNsyaEqhcfPUpiDIpOOI4cy64i73pRXz\n\t/UAWAFG/Ydj8w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659388091;\n\tbh=BGEhaLRYjNC+zxbB7v84j4Z3cEe/s9lGY/hRyvo5iCQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=jUvuBU3N8+tyKXP4/1N+IilnPpi6UrRZUaGJ0yXdVZAe8sphZEL97L4GhQQydu09j\n\t4309JLNqJ1ri46X9bLuUjH6eOa1i3idU/ry/M8rDmY1vOIVgKvPq2Ia3b79OrqENPg\n\t3WMBl6pWgEKXzShY42wYgtk4QvlbCyW1N8jY8JVo="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"jUvuBU3N\"; dkim-atps=neutral","Date":"Tue, 2 Aug 2022 00:08:06 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220801000543.3501-1-laurent.pinchart@ideasonboard.com>\n\t<20220801000543.3501-14-laurent.pinchart@ideasonboard.com>\n\t<20220801162631.weudgr33z4ii5fe5@uno.localdomain>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220801162631.weudgr33z4ii5fe5@uno.localdomain>","Subject":"Re: [libcamera-devel] [PATCH 13/13] libcamera: pipeline: simple:\n\tAdd support for NXP ISI","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]