[{"id":2262,"web_url":"https://patchwork.libcamera.org/comment/2262/","msgid":"<20190714104656.GG31102@wyvern>","date":"2019-07-14T10:46:56","subject":"Re: [libcamera-devel] [PATCH v2 08/16] libcamera: pipeline: ipu3:\n\tUse stream configuration to get buffers count","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-07-13 20:23:43 +0300, Laurent Pinchart wrote:\n> Access the number of allocated buffer for the streams through the stream\n> configuration instead of the stream's buffers pool.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/libcamera/pipeline/ipu3/ipu3.cpp | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> index ffc066a15ae9..488e89f25c5e 100644\n> --- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n> +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n> @@ -635,7 +635,7 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera,\n> \t * of buffers as the active ones.\n> \t */\n> \tif (!outStream->active_) {\n> -\t\tbufferCount = vfStream->bufferPool().count();\n> +\t\tbufferCount = vfStream->configuration().bufferCount;\n> \t\toutStream->device_->pool->createBuffers(bufferCount);\n> \t\tret = imgu->exportBuffers(outStream->device_,\n> \t\t\t\t\t outStream->device_->pool);\n> @@ -644,7 +644,7 @@ int PipelineHandlerIPU3::allocateBuffers(Camera *camera,\n> \t}\n> \n> \tif (!vfStream->active_) {\n> -\t\tbufferCount = outStream->bufferPool().count();\n> +\t\tbufferCount = outStream->configuration().bufferCount;\n> \t\tvfStream->device_->pool->createBuffers(bufferCount);\n> \t\tret = imgu->exportBuffers(vfStream->device_,\n> \t\t\t\t\t vfStream->device_->pool);\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-pf1-x444.google.com (mail-pf1-x444.google.com\n\t[IPv6:2607:f8b0:4864:20::444])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16EB961572\n\tfor ;\n\tSun, 14 Jul 2019 12:47:02 +0200 (CEST)","by mail-pf1-x444.google.com with SMTP id t16so6133078pfe.11\n\tfor ;\n\tSun, 14 Jul 2019 03:47:02 -0700 (PDT)","from localhost (softbank126159224182.bbtec.net. [126.159.224.182])\n\tby smtp.gmail.com with ESMTPSA id\n\ta6sm6246665pfa.162.2019.07.14.03.46.59\n\t(version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256);\n\tSun, 14 Jul 2019 03:47:00 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=D3lptEIolXjoineGFk1kBfMTUe62ntWmQqRLty6KJak=;\n\tb=KalzH3DuNl9Bkjnhw/dqIR04Q+d9YzQ6t6HudWwOMmlT6zreNbJdZy3/sZdZfOLHiB\n\tGnMgzKrDMEL2m9FvT2cdCYIKBYnrwI+wezOK6EMavjcXmkgRHhHtXo8jG/Bl9kLnp+67\n\t19NCzhkld7OeLhanuO0bCyhEUGzBBSPYMNHUPXb4HE28kdiBClM4glQkTNM6Bz3u5Hsk\n\tgDORFtSEvf1TL0ydsIaAhw3YsCKgyq2zXMFyselNy2CwcYaZadzalQ7J7dSCW6oa1y+S\n\tt4tfaFVCu2jFbIQcLTRygoYhP4Qq6BrpKVQmrtznHli5KG3ETtQhOOKP+C7U41e+NlSj\n\t00UQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=D3lptEIolXjoineGFk1kBfMTUe62ntWmQqRLty6KJak=;\n\tb=Fy2xwvCnyrGxxWNTfHer0Mj+G/c5N3U32GEkK3pUHF2+d3jgZQ9UcWqEZULX8luaUf\n\t2tkCfXRSANB5Ghx0Eeha7dsL5HqdmOQd8dL9RcHvgte1wSg1//Cd+Y9vcSEy5pXdeczM\n\tYnb9toQlpvZ4S0lYba3f6JZ3pmoQ8Kug6nQL4jNX7zGw/NAn89G+f6ydbSw+Jyb+afr4\n\tAE9jJsomxqzo19mmO7lHBiQ0fk/Z1aSa4nFPAWOfQGGzgOFgpOEwp/ycqcSOe63sca7x\n\tlruX4XoIUVeGerXobMjQYtLStGDseYeqDBPXYq+cPebuET9r6QyimMT4ufkbgKDEwGx7\n\tPtFw==","X-Gm-Message-State":"APjAAAVVEcw8K87Lm7zW0gvXFgi69FPzBsg6DHASY0lQzY7i4B5Ip6Fx\n\t5RxKURqyYSpjuf9FOAbNLnc=","X-Google-Smtp-Source":"APXvYqxB8a/QxjNujVoyvVQVaF6agk7owzNNTPsXw4IqU6qo/5KuOkNEOt4igcVCgQ8konJuCX6idQ==","X-Received":"by 2002:a65:504c:: with SMTP id\n\tk12mr21422135pgo.252.1563101220777; \n\tSun, 14 Jul 2019 03:47:00 -0700 (PDT)","Date":"Sun, 14 Jul 2019 19:46:56 +0900","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190714104656.GG31102@wyvern>","References":"<20190713172351.25452-1-laurent.pinchart@ideasonboard.com>\n\t<20190713172351.25452-9-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190713172351.25452-9-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH v2 08/16] libcamera: pipeline: ipu3:\n\tUse stream configuration to get buffers count","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 14 Jul 2019 10:47:02 -0000"}}]