[{"id":24241,"web_url":"https://patchwork.libcamera.org/comment/24241/","msgid":"","date":"2022-07-29T12:02:36","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix compiler error, \n\tadd functional include","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Eric,\n\nOn Fri, Jul 29, 2022 at 10:56:26AM +0100, Eric Curtin wrote:\n> gcc version '12.1.1 20220507 (Red Hat 12.1.1-1)' fails with the\n> following error on Fedora 36. This file should include the functional\n> header as it uses std::function.\n> \n> In file included from ../src/ipa/raspberrypi/controller/rpi/ccm.h:12,\n> from ../src/ipa/raspberrypi/controller/rpi/ccm.cpp:15:\n> ../src/ipa/raspberrypi/controller/rpi/../pwl.h:97:18: error: ‘std::function’ has not been declared\n> 97 | void map(std::function f) const;\n> \n> Signed-off-by: Eric Curtin \n\nI've merged the previous version of the fix already, with an updated\ncommit message.\n\n> ---\n> src/ipa/raspberrypi/controller/pwl.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h\n> index 546482cd..aacf6039 100644\n> --- a/src/ipa/raspberrypi/controller/pwl.h\n> +++ b/src/ipa/raspberrypi/controller/pwl.h\n> @@ -6,6 +6,7 @@\n> */\n> #pragma once\n> \n> +#include \n> #include \n> #include \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B8BCAC3275\n\tfor ;\n\tFri, 29 Jul 2022 12:02:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EB99A63312;\n\tFri, 29 Jul 2022 14:02:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D821603EC\n\tfor ;\n\tFri, 29 Jul 2022 14:02:40 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8F8D652F;\n\tFri, 29 Jul 2022 14:02:39 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659096162;\n\tbh=XVaUeB5r2wXgOEvxWrGXguAiXXtQ1SOJjadzWut6AD0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=2TjcIS8jSuV7nKebMM9i8wPRkFAW65ZTMrSBynizSGkep+2oU0kSV+6x5D8dMLLrR\n\tfWzMQOlsYI3Rv/x5AYuSLbo+h//WSYGRPAXfhoa6MU6BSD21xQ2B3r6qijjW9cd2bf\n\tW/IYgKAgRDAvjkl9vgrRUTIkC5X6O5L5gOU26ig4TGMEP8sagi7KmwWmDfq/bGj+an\n\tfahCdTf/E1/qpdvO78KodkDTr3fAocUN1qUbckbyeAUZ4/rnUMEmJNftpC4/6/XYzK\n\tCYKtCI/J0HFhwX0+kc7OWaNC5g35z85NtEKPWc4+JKZxGdXjkPPF5eUxCEUdsCEYfd\n\tR0CS8t08SvuGw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659096159;\n\tbh=XVaUeB5r2wXgOEvxWrGXguAiXXtQ1SOJjadzWut6AD0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=WFzGnsn0EKk50JGss072p1gKkMwDj8K+3aPNJPuAE+vTCg5YpiAfiPdXd0j+QjpeP\n\thLFpUhs3CG6sAM4ckdRPnR8M2qwP6mqEyJs1Wg5Ydo64REweVx6U7u9Qqx8M32qzHm\n\tnHfqm3SIkMt1gQwzUp85MduhPmVr9mXw+1VAmTHg="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"WFzGnsn0\"; dkim-atps=neutral","Date":"Fri, 29 Jul 2022 15:02:36 +0300","To":"Eric Curtin ","Message-ID":"","References":"<20220729095625.5831-1-ecurtin@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20220729095625.5831-1-ecurtin@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Fix compiler error, \n\tadd functional include","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]