[{"id":24240,"web_url":"https://patchwork.libcamera.org/comment/24240/","msgid":"<08409690-0264-b4ac-91dd-f6decd818101@ideasonboard.com>","date":"2022-07-29T10:53:47","subject":"Re: [libcamera-devel] [PATCH v2] rpi: controller: awb: Include\n\t","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 7/29/22 14:10, Jacopo Mondi via libcamera-devel wrote:\n> Building on gcc8 on Debian 10 fails with\n>\n> asyncThread_ = std::thread(std::bind(&Awb::asyncFunc, this));\n> ../src/ipa/raspberrypi/controller/rpi/awb.cpp:177:34: note: ‘std::bind’\n> is defined in header ‘’; did you forget to ‘#include\n> ’?\n>\n> Fix that by including in awb.cpp.\n>\n> Fixes: c1597f989654 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\n> Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/414\n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Umang Jain \n\n>\n> ---\n> v1->v2:\n> - Rebased on latest changes and addded tags\n>\n> One more review and I'll push.\n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index a16e04a07ff8..2b88c3b0141b 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -6,6 +6,7 @@\n> */\n>\n> #include \n> +#include \n>\n> #include \n>\n> --\n> 2.37.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90A25BE173\n\tfor ;\n\tFri, 29 Jul 2022 10:53:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0EE4863312;\n\tFri, 29 Jul 2022 12:53:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B02A3603EC\n\tfor ;\n\tFri, 29 Jul 2022 12:53:55 +0200 (CEST)","from [IPV6:2401:4900:1f3e:f7a:bc8f:12ed:b45f:c35d] (unknown\n\t[IPv6:2401:4900:1f3e:f7a:bc8f:12ed:b45f:c35d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 53DDC52F;\n\tFri, 29 Jul 2022 12:53:54 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659092038;\n\tbh=ZLoPhTjERNRvN7pvpGQq7nhGbCXn7xRCv+vZDmvGde0=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=tDvcth/OzIQ7/3JfhKaTz0U6D7TkG2s4PlO6zPYNE5o6FiOGkr6oZWluRn/OFFK6Z\n\t9iy8yF2LNfgivd3DHLAeJeSv/exOn/HrLT825HWFwqt0B1njCqCsdHsAPI+ILjC5sj\n\tArdlw+AfeK63JqVhRRs5duCIh/Z4PuWFzUyEZQ7MZTheQcdIUGahWL4khHNot9PxZY\n\tjEAcMApHUAs41N8+tmsq789bMImSgH/yB3VHwYKZMKHamyX7brg2GDXFTGdkTZoIuB\n\t5zqduqoKGZp6gcwXdHrR5sfeuDEh/Mixn8O2yovzsvbo0Wyi0z2tOfCKmZ3AM8rddy\n\tv1ZXz3MPqrPOg==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659092035;\n\tbh=ZLoPhTjERNRvN7pvpGQq7nhGbCXn7xRCv+vZDmvGde0=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=iHqrX0xLrmLjVuy0Rzt0+Nx5eLEi9qkC+LY+6IG/vLZzoX+SMYy0ovC37H75KDc8K\n\tDP9h2riwu8kmXLYWs94olfJsWScDnZwmNPTbS+tq38hxYd82wpQvefOBcpZ+cVaM/U\n\tq4w2i4s3iAKUy51LtSypvgcg82c2tsT5OpH3OwZc="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"iHqrX0xL\"; dkim-atps=neutral","Message-ID":"<08409690-0264-b4ac-91dd-f6decd818101@ideasonboard.com>","Date":"Fri, 29 Jul 2022 16:23:47 +0530","MIME-Version":"1.0","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101\n\tThunderbird/91.4.1","Content-Language":"en-US","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20220729084033.5435-1-jacopo@jmondi.org>","In-Reply-To":"<20220729084033.5435-1-jacopo@jmondi.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2] rpi: controller: awb: Include\n\t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Umang Jain via libcamera-devel ","Reply-To":"Umang Jain ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]