[{"id":24229,"web_url":"https://patchwork.libcamera.org/comment/24229/","msgid":"","date":"2022-07-28T15:59:55","subject":"Re: [libcamera-devel] [PATCH] rpi: controller: awb: Include\n\t","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Jacopo,\n\nThank you for the patch.\n\nOn Thu, Jul 28, 2022 at 05:54:33PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> Building on gcc8 on Debian 10 fails with:\n> \n> asyncThread_ = std::thread(std::bind(&Awb::asyncFunc, this));\n> ../src/ipa/raspberrypi/controller/rpi/awb.cpp:177:34: note: ‘std::bind’\n> is defined in header ‘’; did you forget to ‘#include\n> ’?\n> \n> Fix that by including in awb.cpp.\n> \n> Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/414\n> Signed-off-by: Jacopo Mondi \n> \n> ---\n> I diff-ed to check if std::bind() was introduced in the last great refactor,\n> but it seems to be there since 0db2c8dc75e466e7648dc1b95380495c6a126349 from\n> May 2020. Can't tell why it didn't fail so far, nor why it only fails on gcc8.\n> \n> But it does anyway fix the build:\n> https://buildbot.libcamera.org/#/builders/6/builds/421\n\nCould it come from commit c1597f989654 that dropped the dependency on\nboost, changing the indirect inclusion chains ?\n\nReviewed-by: Laurent Pinchart \n\npossibly with a fixes tag.\n\n> ---\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 ++\n> 1 file changed, 2 insertions(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> index 6c2b627d234b..94629b121eb0 100644\n> --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> @@ -5,6 +5,8 @@\n> * awb.cpp - AWB control algorithm\n> */\n> \n> +#include \n> +\n> #include \n> \n> #include \"../lux_status.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 026A6BE173\n\tfor ;\n\tThu, 28 Jul 2022 16:00:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 553F763312;\n\tThu, 28 Jul 2022 18:00:01 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89EE56330D\n\tfor ;\n\tThu, 28 Jul 2022 17:59:59 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F13D556D;\n\tThu, 28 Jul 2022 17:59:58 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659024001;\n\tbh=uqC8xikBVz2LLcYFONQVj6NnAVyoMMqaFupSaGwDh8w=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XsU7xrRdVNftuh9PdEirvEoDIC3FGrswjegs07itirLRCdpnaxPOUYX8XW4tfEMvy\n\tdmtH40fjg6x7KPP5Dd7laTPHexPvI62FFA4ZjObgX5oCl/t80M5uQBnUNJKKtPDC9n\n\tpwvCapZRoBobuQJGo2nkaZtMyuFzv6joaDwaodedFvgk+AeBjFpjRwOwRysj+cfN/f\n\txlMmz6agpV0Wu/siKPt56ZyODpKJnp2aWCRvUeMgLpogquIzJJUrFVJvNyVUdYc9IE\n\tBmmM8dyd1qRdfsP9AdkS2G/tuuqxwIpzlWCd66guaMmfimT/i4aiC+9LrUsdDSDo74\n\tvxwegR4gpK88w==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659023999;\n\tbh=uqC8xikBVz2LLcYFONQVj6NnAVyoMMqaFupSaGwDh8w=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BBdGFAKmHpntNRQx8zYI16M/8zX833nEpwQbYiQXDK3tAPMn5U/HsvqbVk27keKub\n\tyzAf3RQ+hI9jK30M+bAse7++UPgeUv3cRZ8fjGHhD5vsv37rAmrJge8eXBuoQpAdRB\n\tKTSq3TcyyM6AelURJ5eLSSrN2gZMrsaBvzPqK+q4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"BBdGFAKm\"; dkim-atps=neutral","Date":"Thu, 28 Jul 2022 18:59:55 +0300","To":"Jacopo Mondi ","Message-ID":"","References":"<20220728155433.11579-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20220728155433.11579-1-jacopo@jmondi.org>","Subject":"Re: [libcamera-devel] [PATCH] rpi: controller: awb: Include\n\t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24230,"web_url":"https://patchwork.libcamera.org/comment/24230/","msgid":"<20220728160848.a55vh3ow53oiirjt@uno.localdomain>","date":"2022-07-28T16:08:48","subject":"Re: [libcamera-devel] [PATCH] rpi: controller: awb: Include\n\t","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Thu, Jul 28, 2022 at 06:59:55PM +0300, Laurent Pinchart wrote:\n> Hi Jacopo,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 28, 2022 at 05:54:33PM +0200, Jacopo Mondi via libcamera-devel wrote:\n> > Building on gcc8 on Debian 10 fails with:\n> >\n> > asyncThread_ = std::thread(std::bind(&Awb::asyncFunc, this));\n> > ../src/ipa/raspberrypi/controller/rpi/awb.cpp:177:34: note: ‘std::bind’\n> > is defined in header ‘’; did you forget to ‘#include\n> > ’?\n> >\n> > Fix that by including in awb.cpp.\n> >\n> > Reported-by: https://buildbot.libcamera.org/#/builders/6/builds/414\n> > Signed-off-by: Jacopo Mondi \n> >\n> > ---\n> > I diff-ed to check if std::bind() was introduced in the last great refactor,\n> > but it seems to be there since 0db2c8dc75e466e7648dc1b95380495c6a126349 from\n> > May 2020. Can't tell why it didn't fail so far, nor why it only fails on gcc8.\n> >\n> > But it does anyway fix the build:\n> > https://buildbot.libcamera.org/#/builders/6/builds/421\n>\n> Could it come from commit c1597f989654 that dropped the dependency on\n> boost, changing the indirect inclusion chains ?\n>\n\nAh yes\n\n> Reviewed-by: Laurent Pinchart \n>\n> possibly with a fixes tag.\n>\n\nWill add when applying!\n\n> > ---\n> > src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 ++\n> > 1 file changed, 2 insertions(+)\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/rpi/awb.cpp b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> > index 6c2b627d234b..94629b121eb0 100644\n> > --- a/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> > +++ b/src/ipa/raspberrypi/controller/rpi/awb.cpp\n> > @@ -5,6 +5,8 @@\n> > * awb.cpp - AWB control algorithm\n> > */\n> >\n> > +#include \n> > +\n> > #include \n> >\n> > #include \"../lux_status.h\"\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9DD71C3275\n\tfor ;\n\tThu, 28 Jul 2022 16:08:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5C6263312;\n\tThu, 28 Jul 2022 18:08:51 +0200 (CEST)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D5326330D\n\tfor ;\n\tThu, 28 Jul 2022 18:08:50 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id B701420000A;\n\tThu, 28 Jul 2022 16:08:49 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659024531;\n\tbh=3kw37OAO51hGNkpt4juE9hV2hnkOLaq0rXwqfcva1lc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=wC7d0Wm2UwsjN9gQo1y/y4QEYjTt4q3Bxmyftyxy2k6GpF4hgiHEpxcXTzYFgu0HN\n\tkpBPkg1WZgRg9Y7mczGfL9R1LgqRHhDfvegVQAOPvOhhtMcQU4tjQ/qF/pCtcIAiE5\n\t2wJBy4vrscxNNsAdma3PkSIk3Be6XkgO33BeVYL7GRpJMKUt0aNMvSN3a6wJH3kWX8\n\tPEkjhMyCqze/ebLXpYZtsKLIrQdc8BhQ61By9ufdzs4KKbxXlMi+O7LnueazMsJJQo\n\trRSuVZEfwrcrCWVSNbrjczwyx2ZJVscD9McHIrUUKsiQfjSdILxznYIzKdtCT/8wK+\n\trtaQbbKXdl74g==","Date":"Thu, 28 Jul 2022 18:08:48 +0200","To":"Laurent Pinchart ","Message-ID":"<20220728160848.a55vh3ow53oiirjt@uno.localdomain>","References":"<20220728155433.11579-1-jacopo@jmondi.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] rpi: controller: awb: Include\n\t","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]