[{"id":24222,"web_url":"https://patchwork.libcamera.org/comment/24222/","msgid":"<165901206888.1871694.4238833425469962044@Monstersaurus>","date":"2022-07-28T12:41:08","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tController constructor","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck via libcamera-devel (2022-07-28 13:05:30)\n> The Controller(char const *jsonFilename) is not valid anymore since\n> Controller::read() can now return an error on a failure. Additionally, this\n> constructor is not actually used, so remove it.\n> \n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/raspberrypi/controller/controller.cpp | 7 -------\n> src/ipa/raspberrypi/controller/controller.h | 1 -\n> 2 files changed, 8 deletions(-)\n> \n> diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp\n> index bbd382bce3ab..f489278668ef 100644\n> --- a/src/ipa/raspberrypi/controller/controller.cpp\n> +++ b/src/ipa/raspberrypi/controller/controller.cpp\n> @@ -25,13 +25,6 @@ Controller::Controller()\n> {\n> }\n> \n> -Controller::Controller(char const *jsonFilename)\n> - : switchModeCalled_(false)\n> -{\n> - read(jsonFilename);\n> - initialise();\n> -}\n> -\n> Controller::~Controller() {}\n> \n> int Controller::read(char const *filename)\n> diff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h\n> index 6be1e3cfa156..3e1e051703b3 100644\n> --- a/src/ipa/raspberrypi/controller/controller.h\n> +++ b/src/ipa/raspberrypi/controller/controller.h\n> @@ -40,7 +40,6 @@ class Controller\n> {\n> public:\n> Controller();\n> - Controller(char const *jsonFilename);\n> ~Controller();\n> int read(char const *filename);\n> void initialise();\n> -- \n> 2.25.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD31DBE173\n\tfor ;\n\tThu, 28 Jul 2022 12:41:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 652476330E;\n\tThu, 28 Jul 2022 14:41:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A78D56330D\n\tfor ;\n\tThu, 28 Jul 2022 14:41:11 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3B3DA56D;\n\tThu, 28 Jul 2022 14:41:11 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659012073;\n\tbh=7MypZTIWfioBEQ3Q4NnJBxQLY2r+/rCCri51Ci+DCmc=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=PadhpF2eQomNKnKMgbLNPfVWssT0GrvFz5xNm7wgpPiD0Oz6qY+0jU5RWvcgURS3b\n\tsqEMNUOQqznqomht/OkdyzKeM+l6q8pVEZVYmIiB3LCEnsIhKh8NmUljGgUQWUaLDg\n\t3oteVD9rWtBqB3NwckP9m5ZDMT5xZLSubJ1M2JjV42Xl9s+zJZ5kU++Zak7EgeOoxN\n\tb55yjxW02YNxODKdqUSaW8Z6QmxidV/AGJW5Y0y4WHMXutk6+LLFzUOX/A2qUmnhD0\n\tWD5TdHGO6T7HCo2vfP1Dv49tnenq+wFOSE1U00tmBl4hMQx9AltufcfxsThyF7BTAt\n\tdoIA26y2kTHpA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659012071;\n\tbh=7MypZTIWfioBEQ3Q4NnJBxQLY2r+/rCCri51Ci+DCmc=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=tUqRmqIYocCCXbfZ5aiRvkYl/2/QRlDgLSnWzjeVigbEHJbAb6xM1ktUk4nxGrUfy\n\tBfx6KQYj1DYNyfMrbcd/EkWOKc4XkplhzXwbP0aEgxvWz7mJvA+vgoP4Km6+ADdaeR\n\tWafzmZ+QooXfooc+HbI0pocQPRkz25McRHfbw2uY="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"tUqRmqIY\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220728120530.4381-1-naush@raspberrypi.com>","References":"<20220728120439.4109-1-naush@raspberrypi.com>\n\t<20220728120530.4381-1-naush@raspberrypi.com>","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 28 Jul 2022 13:41:08 +0100","Message-ID":"<165901206888.1871694.4238833425469962044@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tController constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24223,"web_url":"https://patchwork.libcamera.org/comment/24223/","msgid":"","date":"2022-07-28T13:18:01","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tController constructor","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Jul 28, 2022 at 01:41:08PM +0100, Kieran Bingham via libcamera-devel wrote:\n> Quoting Naushir Patuck via libcamera-devel (2022-07-28 13:05:30)\n> > The Controller(char const *jsonFilename) is not valid anymore since\n> > Controller::read() can now return an error on a failure. Additionally, this\n> > constructor is not actually used, so remove it.\n> \n> Reviewed-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/raspberrypi/controller/controller.cpp | 7 -------\n> > src/ipa/raspberrypi/controller/controller.h | 1 -\n> > 2 files changed, 8 deletions(-)\n> > \n> > diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp\n> > index bbd382bce3ab..f489278668ef 100644\n> > --- a/src/ipa/raspberrypi/controller/controller.cpp\n> > +++ b/src/ipa/raspberrypi/controller/controller.cpp\n> > @@ -25,13 +25,6 @@ Controller::Controller()\n> > {\n> > }\n> > \n> > -Controller::Controller(char const *jsonFilename)\n> > - : switchModeCalled_(false)\n> > -{\n> > - read(jsonFilename);\n> > - initialise();\n> > -}\n> > -\n> > Controller::~Controller() {}\n> > \n> > int Controller::read(char const *filename)\n> > diff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h\n> > index 6be1e3cfa156..3e1e051703b3 100644\n> > --- a/src/ipa/raspberrypi/controller/controller.h\n> > +++ b/src/ipa/raspberrypi/controller/controller.h\n> > @@ -40,7 +40,6 @@ class Controller\n> > {\n> > public:\n> > Controller();\n> > - Controller(char const *jsonFilename);\n> > ~Controller();\n> > int read(char const *filename);\n> > void initialise();","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23B26C3275\n\tfor ;\n\tThu, 28 Jul 2022 13:18:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6CEE163312;\n\tThu, 28 Jul 2022 15:18:06 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E58B26330D\n\tfor ;\n\tThu, 28 Jul 2022 15:18:04 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5023F56D;\n\tThu, 28 Jul 2022 15:18:04 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659014286;\n\tbh=p0rvAWS+Hbo5b/b2Lpz+EguYSuZeH1AlvnZ4+p0h74s=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=XW5I3T+XR+0FNBwOXCU+lOP3/eXuEIDtuljlLy2FKzMv2mRlV4Cj74piGvvqNKzJF\n\t4JJ1MbeI75OXgahEPTCb2l+teph34OuUeqIuecVAhksMLKpNQUHElat3ZaHnDRjVmm\n\tDEusfCRvLV+Qe+TbfRrOMXl5LOhPuubyrwbU+ExCrx5E00brOGFV+gSS/1lp0Yl69+\n\tH5njYPmylekwZxCbytCEEHENj3V22rtdOMG5Te+bvzKe8bH7hb9TfeWl2Oc6VUxteA\n\tx3NyYeo/0sTdjYhO0hxf3enLZG61FXwzYXBXYfRBSgyJR7dlEXCycotu15WwMoOMpE\n\tJgFztNqwoUMbw==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659014284;\n\tbh=p0rvAWS+Hbo5b/b2Lpz+EguYSuZeH1AlvnZ4+p0h74s=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=lz9h6SupnoKevLrdvlgkdwG0eJtFeAHLLcRrJwSZGOYEmYN0JUX1gcYK6PBy1Kcuk\n\t/PNEKHlnn3eJ3zFBB6x7c3pemCp7/P8t73yXwSOMX3mLryulLZXnj8tGX4I/v4G7uH\n\t2Ovp89u5Go9Da+zKrby9sG3HXr2waQXC5SpmyxtA="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"lz9h6Sup\"; dkim-atps=neutral","Date":"Thu, 28 Jul 2022 16:18:01 +0300","To":"Kieran Bingham ","Message-ID":"","References":"<20220728120439.4109-1-naush@raspberrypi.com>\n\t<20220728120530.4381-1-naush@raspberrypi.com>\n\t<165901206888.1871694.4238833425469962044@Monstersaurus>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<165901206888.1871694.4238833425469962044@Monstersaurus>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused\n\tController constructor","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]