[{"id":24224,"web_url":"https://patchwork.libcamera.org/comment/24224/","msgid":"","date":"2022-07-28T13:27:18","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Add functional\n\tinclude to pwl.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Eric,\n\nThank you for the patch.\n\nOn Thu, Jul 28, 2022 at 01:01:30PM +0100, Eric Curtin wrote:\n> Was failing without this include on Fedora 36 compiler toolchain.\n\nCould you tell what compiler and compiler version that is ? Could you\nalso please share the error message ?\n\n> Signed-off-by: Eric Curtin \n> ---\n> src/ipa/raspberrypi/controller/pwl.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h\n> index 546482cd..691c4700 100644\n> --- a/src/ipa/raspberrypi/controller/pwl.h\n> +++ b/src/ipa/raspberrypi/controller/pwl.h\n> @@ -7,6 +7,7 @@\n> #pragma once\n> \n> #include \n> +#include \n\nAlphabetical order please. I can fix that when applying, no need to send\na v2 just for this.\n\n> #include \n> \n> #include \"libcamera/internal/yaml_parser.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55F70BE173\n\tfor ;\n\tThu, 28 Jul 2022 13:27:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 87C8363312;\n\tThu, 28 Jul 2022 15:27:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F10096330D\n\tfor ;\n\tThu, 28 Jul 2022 15:27:21 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 486C356D;\n\tThu, 28 Jul 2022 15:27:21 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659014843;\n\tbh=oEiOKoq4wi+pQ5iWf9Oybs2EUTuA1g5qPzgDTpzsZfY=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=g3rLrcUV7dymLKKprZwRG3rEFlswTLOD8brtyPPVPXylZeuOc1YswXDmPhPUStr06\n\toDReIxjkQJ1j0U4+jBJ69Hlv/WK1E0zRGGcS/zGN0J1OvKb6w7zWtI37prF95DoFAT\n\twmv8H53urDpcXpffev6SSuYdwKy6+Jl8NHcY1/2oQ1Bl8xL+mEVyCktarvs+a77lkW\n\tvDodnwP8pV4fh8Ik57Zbj9gLwzeJSih3sP50BMNYU7UNhT6gxomzhlC7xsfr/7/O2B\n\tsJ1FYzxnfljiFByxwEfbjv8rlbGl8Q61yRdaOm+k9amsj7UQRRPacFgkLYm+6xTFFn\n\tP8wUeXSPUZOQQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659014841;\n\tbh=oEiOKoq4wi+pQ5iWf9Oybs2EUTuA1g5qPzgDTpzsZfY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=GDm+TebAbWcVb8irF1t3a0qPcJuLKM8dtdlQO3vnIfA/NbtDYmqlml8/P2gFj3Aua\n\tN1Bj9H5hZGJJD8TUhU75R3A08kJgibGvZf1+0dxkkrdfZ/f8x07lHKl4NwxNi3s8JH\n\tNo10mElX97PUtgxe69P08/vq6QWaCkC6Ag/7h0nE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"GDm+TebA\"; dkim-atps=neutral","Date":"Thu, 28 Jul 2022 16:27:18 +0300","To":"Eric Curtin ","Message-ID":"","References":"<20220728120128.283524-1-ecurtin@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220728120128.283524-1-ecurtin@redhat.com>","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Add functional\n\tinclude to pwl.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24226,"web_url":"https://patchwork.libcamera.org/comment/24226/","msgid":"","date":"2022-07-28T14:37:01","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Add functional\n\tinclude to pwl.h","submitter":{"id":101,"url":"https://patchwork.libcamera.org/api/people/101/","name":"Eric Curtin","email":"ecurtin@redhat.com"},"content":"On Thu, 28 Jul 2022 at 14:27, Laurent Pinchart\n wrote:\n>\n> Hi Eric,\n>\n> Thank you for the patch.\n>\n> On Thu, Jul 28, 2022 at 01:01:30PM +0100, Eric Curtin wrote:\n> > Was failing without this include on Fedora 36 compiler toolchain.\n>\n> Could you tell what compiler and compiler version that is ? Could you\n> also please share the error message ?\n\nFedora 36\n\ngcc --version\ngcc (GCC) 12.1.1 20220507 (Red Hat 12.1.1-1)\nCopyright (C) 2022 Free Software Foundation, Inc.\nThis is free software; see the source for copying conditions. There is NO\nwarranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n\nYou can see the compiler error here:\n\nhttps://github.com/ericcurtin/twincam/runs/7558719653\n\n>\n> > Signed-off-by: Eric Curtin \n> > ---\n> > src/ipa/raspberrypi/controller/pwl.h | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h\n> > index 546482cd..691c4700 100644\n> > --- a/src/ipa/raspberrypi/controller/pwl.h\n> > +++ b/src/ipa/raspberrypi/controller/pwl.h\n> > @@ -7,6 +7,7 @@\n> > #pragma once\n> >\n> > #include \n> > +#include \n>\n> Alphabetical order please. I can fix that when applying, no need to send\n> a v2 just for this.\n\nSorry I wasn't sure if you liked to split the C and C++ ones, took the\nwrong guess and just sorted the C++ ones\n\n>\n> > #include \n> >\n> > #include \"libcamera/internal/yaml_parser.h\"\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9C312BE173\n\tfor ;\n\tThu, 28 Jul 2022 14:37:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0380163312;\n\tThu, 28 Jul 2022 16:37:24 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3E1766330D\n\tfor ;\n\tThu, 28 Jul 2022 16:37:22 +0200 (CEST)","from mail-qt1-f199.google.com (mail-qt1-f199.google.com\n\t[209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\tus-mta-256-XwwC7by7Pr-MkNARTbVGLA-1; Thu, 28 Jul 2022 10:37:19 -0400","by mail-qt1-f199.google.com with SMTP id\n\ta18-20020a05622a02d200b0031ed7ae9abeso1125497qtx.8\n\tfor ;\n\tThu, 28 Jul 2022 07:37:18 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659019044;\n\tbh=iLbYtjcBoUQ6cR6OVtk9eEKhq776hGSarlWnVXVNE8w=;\n\th=References:In-Reply-To:Date:To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=lGIBb2j0R4yQRcx4dAOImBX787k3aqZvRMskk0ZKMX9RhzglbAyCqPZDGppg97li0\n\tQwwtmIHpf4WtiaebkDVJBkhRyXw3qoKhash65ByDNgS4wk79sKapr1Ql/UjtnC48+G\n\t1u8k5B0BHH122awD/W4fHshdejwB9Q/US05KFHlOX0/8SOADuAT4w5uZcrPpJbmhhx\n\txAbfYO4gn+98pGaQPj/abvfZW6Rx+Ew4nBu+U9dXGE96fIlmeZJwRjLOl13v/D1FsA\n\tWKdPwE5fz3VzgqQKlaa9PKe1nonklhpzK5easPUKaxaUx1wT2HfZ+o6NdE/71br9h/\n\tRwr8U1ktsJPEg==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1659019040;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=rQX0M+GxBOwbCCeRdNWL9L3eNMPguSZrQbK21bGeElU=;\n\tb=bPYy9oNRqUbOC8P6Hc3+EuujqwXI+CMeynFzOmoywbGLY9iEigz4Bk6NoBXFSb4u2rZs0V\n\tocTWQ3NNwKP0NXNrNRC5W8dl3z9X0PUfQP6fGC0ysDiMP/jl5wgSWDg9950N5Dr3xi7dIf\n\t5aOdJoGlEuB+y4VJJ+rQ5eAWTIn69VQ="],"Authentication-Results":["lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=redhat.com\n\theader.i=@redhat.com header.b=\"bPYy9oNR\"; \n\tdkim-atps=neutral","relay.mimecast.com;\n\tauth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ecurtin@redhat.com"],"X-MC-Unique":"XwwC7by7Pr-MkNARTbVGLA-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=rQX0M+GxBOwbCCeRdNWL9L3eNMPguSZrQbK21bGeElU=;\n\tb=yEOfKpE1SwZI42JXGfbzNYESNvul690eC1WSEaCXgeTQZSgrOasbZubje0eHE4bp6k\n\tGJtmsHlZr5GcpZfxjiS1V4bZ6n+iRiK8C9CrYn3kNVsoaTp3F+uGUhpFpygFO4PUclWz\n\tmMMHnJOF952ZqIL7o5OX3J0JwCKJ0Ks5VivQtOspzcqfjf1K4SAm4hoK9vK8jADiNi4+\n\t8ZiATpo6+R/V8h164VC8TiYIdGZK/cwXQCx6iA7dJuZbBpSYHPs8C3vhVl0foaKWx3qE\n\tuKmBZwAzHw/ncEsDYjArNMwbDgOj8QT2LberZRNzWH5vEJcvK8GXQOTYVJkk/RXAPVfo\n\tOhlw==","X-Gm-Message-State":"AJIora8+H3hQfEPB5DtimjX6AfESqlmeqtLau25WZlYrmLw+rpam+nbA\n\tZHEgBOzDpPLTSZv7IknY6i5jZknIgy+oPvwBxgjqAwBZ2CGCQaOoCbD+Mwu27XpjJK7RPPHZP4L\n\tEjLLASVUSABHYOYxLoBppb1oTovi8fABi46XUrrTADzvZWeUU1w==","X-Received":["by 2002:a37:4549:0:b0:69f:556c:4e38 with SMTP id\n\ts70-20020a374549000000b0069f556c4e38mr19331876qka.202.1659019038192; \n\tThu, 28 Jul 2022 07:37:18 -0700 (PDT)","by 2002:a37:4549:0:b0:69f:556c:4e38 with SMTP id\n\ts70-20020a374549000000b0069f556c4e38mr19331856qka.202.1659019037905;\n\tThu, 28 Jul 2022 07:37:17 -0700 (PDT)"],"X-Google-Smtp-Source":"AGRyM1t02XhLSSi0tGUkZEZEY0fxdIY8l45xNsuY7UfMsUM3huU4crEixH8M5Z7uVlFqd+zCINA5IwvaRNpypDHeT7M=","MIME-Version":"1.0","References":"<20220728120128.283524-1-ecurtin@redhat.com>\n\t","In-Reply-To":"","Date":"Thu, 28 Jul 2022 15:37:01 +0100","Message-ID":"","To":"Laurent Pinchart ","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=\"UTF-8\"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Add functional\n\tinclude to pwl.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Eric Curtin via libcamera-devel ","Reply-To":"Eric Curtin ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24227,"web_url":"https://patchwork.libcamera.org/comment/24227/","msgid":"","date":"2022-07-28T15:37:43","subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Add functional\n\tinclude to pwl.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Eric,\n\nOn Thu, Jul 28, 2022 at 03:37:01PM +0100, Eric Curtin wrote:\n> On Thu, 28 Jul 2022 at 14:27, Laurent Pinchart wrote:\n> > On Thu, Jul 28, 2022 at 01:01:30PM +0100, Eric Curtin wrote:\n> > > Was failing without this include on Fedora 36 compiler toolchain.\n> >\n> > Could you tell what compiler and compiler version that is ? Could you\n> > also please share the error message ?\n> \n> Fedora 36\n> \n> gcc --version\n> gcc (GCC) 12.1.1 20220507 (Red Hat 12.1.1-1)\n> Copyright (C) 2022 Free Software Foundation, Inc.\n> This is free software; see the source for copying conditions. There is NO\n> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.\n> \n> You can see the compiler error here:\n> \n> https://github.com/ericcurtin/twincam/runs/7558719653\n\nThank you. I've updated the commit message to\n\n\n--------\nipa: raspberrypi: Add functional include to pwl.h\n\nThe Pwl class uses std::function, defined in , without\nincluding the header directly. This results in a compilation error with\nthe Fedora 36 compiler toolchain (gcc 12.1.1):\n\nIn file included from ../src/ipa/raspberrypi/controller/rpi/awb.h:14,\n from ../src/ipa/raspberrypi/controller/rpi/awb.cpp:14:\n../src/ipa/raspberrypi/controller/rpi/../pwl.h:97:18: error: 'std::function' has not been declared\n 97 | void map(std::function f) const;\n | ^~~\n\nFix it by including .\n\nFixes: c1597f989654 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\nSigned-off-by: Eric Curtin \n--------\n\n> > > Signed-off-by: Eric Curtin \n> > > ---\n> > > src/ipa/raspberrypi/controller/pwl.h | 1 +\n> > > 1 file changed, 1 insertion(+)\n> > >\n> > > diff --git a/src/ipa/raspberrypi/controller/pwl.h b/src/ipa/raspberrypi/controller/pwl.h\n> > > index 546482cd..691c4700 100644\n> > > --- a/src/ipa/raspberrypi/controller/pwl.h\n> > > +++ b/src/ipa/raspberrypi/controller/pwl.h\n> > > @@ -7,6 +7,7 @@\n> > > #pragma once\n> > >\n> > > #include \n> > > +#include \n> >\n> > Alphabetical order please. I can fix that when applying, no need to send\n> > a v2 just for this.\n> \n> Sorry I wasn't sure if you liked to split the C and C++ ones, took the\n> wrong guess and just sorted the C++ ones\n\nNo worries :-)\n\n> > > #include \n> > >\n> > > #include \"libcamera/internal/yaml_parser.h\"","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE477BE173\n\tfor ;\n\tThu, 28 Jul 2022 15:37:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CF9B263312;\n\tThu, 28 Jul 2022 17:37:47 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5DD1F6330D\n\tfor ;\n\tThu, 28 Jul 2022 17:37:46 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C01D86D4;\n\tThu, 28 Jul 2022 17:37:45 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1659022667;\n\tbh=Yr6afD459exB2/dOwuvypMpMJNckyeDcPYVDRVoaBEk=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=CPBj06hHdmwMk5tKPeZ1EnjwlO+FvcsCMCzDt+rqF28JubDLe6ZTKOE9uPR3US7Cp\n\t3PxJMAcpjpEYvdlY3Hy7c8cEsp4CKiuwwXatoYHw72cK7BOxM+ahuc3GBKz1QMXi+Y\n\tcPp2DJP+seNDo8CW1/6GeMV+EUgl+aR1gJlA1N4++W/R1xsesxg7YYIHCRtGygfsfo\n\tKkv7LooMOSkRoY7SoVHjWjp1zVRjrNQSueb/A3b1cB/pz5GHKiUej8s/5adVDsoPGD\n\tmOws1omXHGCX1O4hfrkjyqddiVDxe0tqjhMX+xgGf3rR70lFXxf/VYUXRLFAMzonVY\n\tdehtxwfO3i5HQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1659022666;\n\tbh=Yr6afD459exB2/dOwuvypMpMJNckyeDcPYVDRVoaBEk=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=W4x/AAc1BMqyivD4fqXJlaihi3vRHd1pofHTr9S5fsSmS8dUMvxF4FLaadckg7S6h\n\tXrCOBBbiR+06p3fbnPI5cckM5dRABIMYr/ADPKB+8xSkTMiKWLO862cSgTPlG64g7V\n\tiyg/IZzOI3I/fT4rftvbn7Nl5DTom4u8H3Co4GkQ="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"W4x/AAc1\"; dkim-atps=neutral","Date":"Thu, 28 Jul 2022 18:37:43 +0300","To":"Eric Curtin ","Message-ID":"","References":"<20220728120128.283524-1-ecurtin@redhat.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","Subject":"Re: [libcamera-devel] [PATCH] ipa: raspberrypi: Add functional\n\tinclude to pwl.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera devel ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]