[{"id":24147,"web_url":"https://patchwork.libcamera.org/comment/24147/","msgid":"<165884426465.503585.16677806199630415376@Monstersaurus>","date":"2022-07-26T14:04:24","subject":"Re: [libcamera-devel] [PATCH] correctly report enabled ipa modules","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Quentin Schulz via libcamera-devel (2022-07-26 14:20:51)\n> From: Quentin Schulz \n> \n> \"ipa_modules\" stores the value of the ipas meson build option. IPAs are\n> enabled if and only if there is an enabled pipeline for an IPA listed in\n> \"ipa_modules\" array. It is basically the intersection of pipelines and\n> ipa_modules array.\n> \n> In order to correctly report which IPAs get enabled, let's create a new\n> array storing this intersection.\n> \n\nOh excellent, I think I've seen this issue in the past too and ignored\nit ;-)\n\n\nSeems reasonable to me so:\n\n\nReviewed-by: Kieran Bingham \n\n> Cc: Quentin Schulz \n> Reported-by: Daniel Semkowicz \n> Signed-off-by: Quentin Schulz \n> ---\n> meson.build | 2 +-\n> src/ipa/meson.build | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 3f7a3f56..e8b81ad8 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -173,7 +173,7 @@ py_mod.find_installation('python3', modules: py_modules)\n> ## Summarise Configurations\n> summary({\n> 'Enabled pipelines': pipelines,\n> - 'Enabled IPA modules': ipa_modules,\n> + 'Enabled IPA modules': enabled_ipa_modules,\n> 'Tracing support': tracing_enabled,\n> 'Android support': android_enabled,\n> 'GStreamer support': gst_enabled,\n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index e15a8a06..849bb372 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -27,6 +27,7 @@ ipa_sign = files('ipa-sign.sh')\n> ipa_names = []\n> \n> ipa_modules = get_option('ipas')\n> +enabled_ipa_modules = []\n> \n> # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n> # prepend MESON_INSTALL_DESTDIR_PREFIX to each ipa module name, therefore we\n> @@ -35,6 +36,7 @@ foreach pipeline : pipelines\n> if ipa_modules.contains(pipeline)\n> subdir(pipeline)\n> ipa_names += ipa_install_dir / ipa_name + '.so'\n> + enabled_ipa_modules += pipeline\n> endif\n> endforeach\n> \n> -- \n> 2.37.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD9EBC3275\n\tfor ;\n\tTue, 26 Jul 2022 14:04:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E323E63312;\n\tTue, 26 Jul 2022 16:04:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F331360487\n\tfor ;\n\tTue, 26 Jul 2022 16:04:27 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7F7EE735;\n\tTue, 26 Jul 2022 16:04:27 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658844270;\n\tbh=qGXyE6npuQupjvcFLuEfGVw2dU733Zst0ej1+pwViEk=;\n\th=In-Reply-To:References:To:Date:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=rBNgUjiZEGCwXx7yO/HQQ3OHSDI1kyxJvhMEyCppAkDQ+QDY1Pg/AGgajy68h5D68\n\tHsGSwp2dMyv7TViSzx6BdUtuypSO66ImS4j7byn2DlawnMVL4nALVocEOdGkI2Dyr2\n\t0N3Y7ly03rXKdu/RnoeRBoKzN1LxackYbq4MAA1awkmC3a9eoRgfzXdMsUGJRyYM8f\n\tcFR2F99N5m1UzJeMHRlvc+6RIsbi+54s4dqpVpBiVMxO4uanQrRRgh++vmiQFj7v5f\n\tKesuu4DmvPTYL5qcOV1vv3wiTXTSzyRAVnAsOJxYqK/+kDZXY00qgS0QmnQurl/T3w\n\t+2/PKv3l0cFhA==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658844267;\n\tbh=qGXyE6npuQupjvcFLuEfGVw2dU733Zst0ej1+pwViEk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=hoQMlfP5A68qlL/vWKTmZJp+iuW86zaeDKt3JxReMWHzm3f8dSPANAUTROTtRHsZn\n\t/EePPeN21r+63saDsEST+KPqizNHVpxaMKJkjiZExRgR2zOhoU0aDBqtxGVOrAhUHg\n\thbJ2ASsGtPrgTAkZIepAT3U7Pm9dMD6X6YyrC0+4="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"hoQMlfP5\"; dkim-atps=neutral","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20220726132051.228019-1-foss+libcamera@0leil.net>","References":"<20220726132051.228019-1-foss+libcamera@0leil.net>","To":"Quentin Schulz ,\n\tQuentin Schulz via libcamera-devel ","Date":"Tue, 26 Jul 2022 15:04:24 +0100","Message-ID":"<165884426465.503585.16677806199630415376@Monstersaurus>","User-Agent":"alot/0.10","Subject":"Re: [libcamera-devel] [PATCH] correctly report enabled ipa modules","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Kieran Bingham via libcamera-devel\n\t","Reply-To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org,\n\tQuentin Schulz ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24148,"web_url":"https://patchwork.libcamera.org/comment/24148/","msgid":"<20220726144001.szeletem6373oxap@uno.localdomain>","date":"2022-07-26T14:40:01","subject":"Re: [libcamera-devel] [PATCH] correctly report enabled ipa modules","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Quentin,\n\nOn Tue, Jul 26, 2022 at 03:20:51PM +0200, Quentin Schulz via libcamera-devel wrote:\n> From: Quentin Schulz \n>\n> \"ipa_modules\" stores the value of the ipas meson build option. IPAs are\n> enabled if and only if there is an enabled pipeline for an IPA listed in\n> \"ipa_modules\" array. It is basically the intersection of pipelines and\n> ipa_modules array.\n>\n> In order to correctly report which IPAs get enabled, let's create a new\n> array storing this intersection.\n\nIndeed I've ignored it for quite a while too!\n\n>\n> Cc: Quentin Schulz \n> Reported-by: Daniel Semkowicz \n> Signed-off-by: Quentin Schulz \n\nReviewed-by: Jacopo Mondi \n\n\n> ---\n> meson.build | 2 +-\n> src/ipa/meson.build | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/meson.build b/meson.build\n> index 3f7a3f56..e8b81ad8 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -173,7 +173,7 @@ py_mod.find_installation('python3', modules: py_modules)\n> ## Summarise Configurations\n> summary({\n> 'Enabled pipelines': pipelines,\n> - 'Enabled IPA modules': ipa_modules,\n> + 'Enabled IPA modules': enabled_ipa_modules,\n> 'Tracing support': tracing_enabled,\n> 'Android support': android_enabled,\n> 'GStreamer support': gst_enabled,\n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index e15a8a06..849bb372 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -27,6 +27,7 @@ ipa_sign = files('ipa-sign.sh')\n> ipa_names = []\n>\n> ipa_modules = get_option('ipas')\n> +enabled_ipa_modules = []\n>\n> # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n> # prepend MESON_INSTALL_DESTDIR_PREFIX to each ipa module name, therefore we\n> @@ -35,6 +36,7 @@ foreach pipeline : pipelines\n> if ipa_modules.contains(pipeline)\n> subdir(pipeline)\n> ipa_names += ipa_install_dir / ipa_name + '.so'\n> + enabled_ipa_modules += pipeline\n> endif\n> endforeach\n>\n> --\n> 2.37.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C8B80BE173\n\tfor ;\n\tTue, 26 Jul 2022 14:40:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2C79663312;\n\tTue, 26 Jul 2022 16:40:05 +0200 (CEST)","from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net\n\t[217.70.183.195])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6F3E60487\n\tfor ;\n\tTue, 26 Jul 2022 16:40:03 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id 79C006000E;\n\tTue, 26 Jul 2022 14:40:03 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658846405;\n\tbh=IpOthSXtFfDixTBCOQqQdDaPBtbW48A4fEnzWFAl1No=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=krJKJEHDdGlDkgB7CTERqM33zzYdnpcv/FnDfoTm9P+7EBhqxpkOKewd4PhUzEg4V\n\tMPquhpigqwAk5g2UC5CgfkBfNGH1MdjLijtXMlZ++1bCvMEwpYgAfgcxJpPqt0Soxz\n\tT1cb/AELLW/NoPppuSrHFJ+fJuqKJUKKHWmwjQbugbPc2PkewNhPJpqllsm5paBgTw\n\tFOhRzhHFUXB4MGtOFWGzO7TrfjUGcnk6N/gRL4Z7/pi2+Ob8NmKk96/iPtNkx0i2Ld\n\tlfNRJXF9earsKd1yiprSL/FQjlWgZWhJwa0Gs69zuCUAG3p221vzvot/N59g5cyodh\n\tTpJKtr/CLcbWg==","Date":"Tue, 26 Jul 2022 16:40:01 +0200","To":"Quentin Schulz ","Message-ID":"<20220726144001.szeletem6373oxap@uno.localdomain>","References":"<20220726132051.228019-1-foss+libcamera@0leil.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220726132051.228019-1-foss+libcamera@0leil.net>","Subject":"Re: [libcamera-devel] [PATCH] correctly report enabled ipa modules","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":24149,"web_url":"https://patchwork.libcamera.org/comment/24149/","msgid":"<20220726151051.j57axqg6rexhltyc@uno.localdomain>","date":"2022-07-26T15:10:51","subject":"Re: [libcamera-devel] [PATCH] correctly report enabled ipa modules","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello\n\nPushed with the subject line changed to\n\nlibcamera: Correctly report enabled ipa modules\n\nOn Tue, Jul 26, 2022 at 03:20:51PM +0200, Quentin Schulz via libcamera-devel wrote:\n> From: Quentin Schulz \n>\n> \"ipa_modules\" stores the value of the ipas meson build option. IPAs are\n> enabled if and only if there is an enabled pipeline for an IPA listed in\n> \"ipa_modules\" array. It is basically the intersection of pipelines and\n> ipa_modules array.\n>\n> In order to correctly report which IPAs get enabled, let's create a new\n> array storing this intersection.\n>\n> Cc: Quentin Schulz \n> Reported-by: Daniel Semkowicz \n> Signed-off-by: Quentin Schulz \n> ---\n> meson.build | 2 +-\n> src/ipa/meson.build | 2 ++\n> 2 files changed, 3 insertions(+), 1 deletion(-)\n>\n> diff --git a/meson.build b/meson.build\n> index 3f7a3f56..e8b81ad8 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -173,7 +173,7 @@ py_mod.find_installation('python3', modules: py_modules)\n> ## Summarise Configurations\n> summary({\n> 'Enabled pipelines': pipelines,\n> - 'Enabled IPA modules': ipa_modules,\n> + 'Enabled IPA modules': enabled_ipa_modules,\n> 'Tracing support': tracing_enabled,\n> 'Android support': android_enabled,\n> 'GStreamer support': gst_enabled,\n> diff --git a/src/ipa/meson.build b/src/ipa/meson.build\n> index e15a8a06..849bb372 100644\n> --- a/src/ipa/meson.build\n> +++ b/src/ipa/meson.build\n> @@ -27,6 +27,7 @@ ipa_sign = files('ipa-sign.sh')\n> ipa_names = []\n>\n> ipa_modules = get_option('ipas')\n> +enabled_ipa_modules = []\n>\n> # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n> # prepend MESON_INSTALL_DESTDIR_PREFIX to each ipa module name, therefore we\n> @@ -35,6 +36,7 @@ foreach pipeline : pipelines\n> if ipa_modules.contains(pipeline)\n> subdir(pipeline)\n> ipa_names += ipa_install_dir / ipa_name + '.so'\n> + enabled_ipa_modules += pipeline\n> endif\n> endforeach\n>\n> --\n> 2.37.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12F7BC3275\n\tfor ;\n\tTue, 26 Jul 2022 15:10:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 46BC263312;\n\tTue, 26 Jul 2022 17:10:55 +0200 (CEST)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5A5DD60487\n\tfor ;\n\tTue, 26 Jul 2022 17:10:54 +0200 (CEST)","(Authenticated sender: jacopo@jmondi.org)\n\tby mail.gandi.net (Postfix) with ESMTPSA id B2E02240007;\n\tTue, 26 Jul 2022 15:10:53 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658848255;\n\tbh=uBKImQ37piJZbkOObyqm8E8qmWAY2nQumk8DUa9e+gc=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=pPvte4eyNuQWEmuI6gj0fkut73NBbzyDdLhEeKDGrjBJrJQ1Cf9skJRd7BH9PUpmm\n\tDk3JRPQCeYkutKLY8jQAuyF7IM3nB/t0LtI86lG2Q3ml8ncoxKIbSAKGxm4DgkQUHj\n\tOYfAELWjgGeJSShIXdYYarmr6IIb5k3yvXkCxehhBw23OgNW+/7flefVvw4jzzZ1W1\n\t4m6S4/K1FQhHndN69M0pFN3eGJ8suuXQN270UWZAc+kG44WRspP45li4OyC7q4fp0k\n\t+tACT+bbfNdgUhRmZdtkEvcmjpWHoUIrQtibBFX4oyqS2UR5Y3gbVgkXBvEEXrif3o\n\teCVHZRNukqbQw==","Date":"Tue, 26 Jul 2022 17:10:51 +0200","To":"Quentin Schulz ","Message-ID":"<20220726151051.j57axqg6rexhltyc@uno.localdomain>","References":"<20220726132051.228019-1-foss+libcamera@0leil.net>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220726132051.228019-1-foss+libcamera@0leil.net>","Subject":"Re: [libcamera-devel] [PATCH] correctly report enabled ipa modules","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Jacopo Mondi via libcamera-devel ","Reply-To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]