{"id":16791,"url":"https://patchwork.libcamera.org/api/patches/16791/?format=json","web_url":"https://patchwork.libcamera.org/patch/16791/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220726132051.228019-1-foss+libcamera@0leil.net>","date":"2022-07-26T13:20:51","name":"[libcamera-devel] correctly report enabled ipa modules","commit_ref":"c698473440abee7330c76d2370c3c01ecc48b8e3","pull_url":null,"state":"accepted","archived":false,"hash":"da72d4b5e315cad4b26858adc4a1455da33c9b08","submitter":{"id":120,"url":"https://patchwork.libcamera.org/api/people/120/?format=json","name":"Quentin Schulz","email":"foss+libcamera@0leil.net"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16791/mbox/","series":[{"id":3326,"url":"https://patchwork.libcamera.org/api/series/3326/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3326","date":"2022-07-26T13:20:51","name":"[libcamera-devel] correctly report enabled ipa modules","version":1,"mbox":"https://patchwork.libcamera.org/series/3326/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16791/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16791/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C437C3275\n\tfor ;\n\tTue, 26 Jul 2022 13:21:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8BE563312;\n\tTue, 26 Jul 2022 15:21:16 +0200 (CEST)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[IPv6:2001:4b98:dc4:8::222])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC46660487\n\tfor ;\n\tTue, 26 Jul 2022 15:21:14 +0200 (CEST)","(Authenticated sender: foss@0leil.net)\n\tby mail.gandi.net (Postfix) with ESMTPSA id A2BA740003;\n\tTue, 26 Jul 2022 13:21:13 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658841676;\n\tbh=nghVSCmStzo+SVcJc3FL205lUIBPTzWdWNiS26OwrME=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=icmqCmRJyV3RITXhKpEiaErWj/N6Xq0ICE6pTFxx+Jm7hd6/guqFc/KvepCFuAKk6\n\t/UlYBy4DdOjiAAnDTP8RYRZQ09MmIQDqp3fzDoPSaH9HyKvx23EjsV1JpTGg95Uo+B\n\tYedq7cyyLVIa+tWu+WcSuaTArwCFsvdwu6vPyTw/iXxM1CUzpEpmR4eicKUtsxcckH\n\ttRlvLk7FN7mNMvK160xXrd/ZdVx3P2Lfc1cVaadLMQbaCa6kXiI3bj6V0TGvzApmIp\n\t46uDNAIbinLLYaPDgfSNOWUQkuThK74uLBX9Ff2kyhAP6GsoIm4ZVWXNiWZ3ZfLuy6\n\tXMf5fImcChfBw==","To":"","Date":"Tue, 26 Jul 2022 15:20:51 +0200","Message-Id":"<20220726132051.228019-1-foss+libcamera@0leil.net>","X-Mailer":"git-send-email 2.37.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH] correctly report enabled ipa modules","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Quentin Schulz via libcamera-devel\n\t","Reply-To":"Quentin Schulz ","Cc":"libcamera-devel@lists.libcamera.org,\n\tQuentin Schulz ","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Quentin Schulz \n\n\"ipa_modules\" stores the value of the ipas meson build option. IPAs are\nenabled if and only if there is an enabled pipeline for an IPA listed in\n\"ipa_modules\" array. It is basically the intersection of pipelines and\nipa_modules array.\n\nIn order to correctly report which IPAs get enabled, let's create a new\narray storing this intersection.\n\nCc: Quentin Schulz \nReported-by: Daniel Semkowicz \nSigned-off-by: Quentin Schulz \n---\n meson.build | 2 +-\n src/ipa/meson.build | 2 ++\n 2 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/meson.build b/meson.build\nindex 3f7a3f56..e8b81ad8 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -173,7 +173,7 @@ py_mod.find_installation('python3', modules: py_modules)\n ## Summarise Configurations\n summary({\n 'Enabled pipelines': pipelines,\n- 'Enabled IPA modules': ipa_modules,\n+ 'Enabled IPA modules': enabled_ipa_modules,\n 'Tracing support': tracing_enabled,\n 'Android support': android_enabled,\n 'GStreamer support': gst_enabled,\ndiff --git a/src/ipa/meson.build b/src/ipa/meson.build\nindex e15a8a06..849bb372 100644\n--- a/src/ipa/meson.build\n+++ b/src/ipa/meson.build\n@@ -27,6 +27,7 @@ ipa_sign = files('ipa-sign.sh')\n ipa_names = []\n \n ipa_modules = get_option('ipas')\n+enabled_ipa_modules = []\n \n # The ipa-sign-install.sh script which uses the ipa_names variable will itself\n # prepend MESON_INSTALL_DESTDIR_PREFIX to each ipa module name, therefore we\n@@ -35,6 +36,7 @@ foreach pipeline : pipelines\n if ipa_modules.contains(pipeline)\n subdir(pipeline)\n ipa_names += ipa_install_dir / ipa_name + '.so'\n+ enabled_ipa_modules += pipeline\n endif\n endforeach\n \n","prefixes":["libcamera-devel"]}