[{"id":2257,"web_url":"https://patchwork.libcamera.org/comment/2257/","msgid":"<20190714103410.GE6043@pendragon.ideasonboard.com>","date":"2019-07-14T10:34:10","subject":"Re: [libcamera-devel] [PATCH 4/4] test: logging: move logging tests\n\tto a subdirectory","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Sat, Jul 13, 2019 at 05:16:20AM +0900, Paul Elder wrote:\n> Since there are two logging tests now, move them to their own\n> subdirectory. Update meson as necessary.\n> \n> Signed-off-by: Paul Elder \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> test/{log.cpp => log/log_api.cpp} | 0\n> test/{ => log}/log_process.cpp | 0\n> test/log/meson.build | 13 +++++++++++++\n> test/meson.build | 3 +--\n> 4 files changed, 14 insertions(+), 2 deletions(-)\n> rename test/{log.cpp => log/log_api.cpp} (100%)\n> rename test/{ => log}/log_process.cpp (100%)\n> create mode 100644 test/log/meson.build\n> \n> diff --git a/test/log.cpp b/test/log/log_api.cpp\n> similarity index 100%\n> rename from test/log.cpp\n> rename to test/log/log_api.cpp\n> diff --git a/test/log_process.cpp b/test/log/log_process.cpp\n> similarity index 100%\n> rename from test/log_process.cpp\n> rename to test/log/log_process.cpp\n> diff --git a/test/log/meson.build b/test/log/meson.build\n> new file mode 100644\n> index 0000000..95f6c1a\n> --- /dev/null\n> +++ b/test/log/meson.build\n> @@ -0,0 +1,13 @@\n> +log_test = [\n> + ['log_api', 'log_api.cpp'],\n> + ['log_process', 'log_process.cpp'],\n> +]\n> +\n> +foreach t : log_test\n> + exe = executable(t[0], t[1],\n> + dependencies : libcamera_dep,\n> + link_with : test_libraries,\n> + include_directories : test_includes_internal)\n> +\n> + test(t[0], exe, suite : 'log')\n> +endforeach\n> diff --git a/test/meson.build b/test/meson.build\n> index 658f283..b2f809e 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -4,6 +4,7 @@ subdir('camera')\n> subdir('controls')\n> subdir('ipa')\n> subdir('ipc')\n> +subdir('log')\n> subdir('media_device')\n> subdir('pipeline')\n> subdir('process')\n> @@ -22,8 +23,6 @@ public_tests = [\n> \n> internal_tests = [\n> ['camera-sensor', 'camera-sensor.cpp'],\n> - ['log', 'log.cpp'],\n> - ['log_process', 'log_process.cpp'],\n> ['message', 'message.cpp'],\n> ['signal-threads', 'signal-threads.cpp'],\n> ['threads', 'threads.cpp'],","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B591261572\n\tfor ;\n\tSun, 14 Jul 2019 12:34:38 +0200 (CEST)","from pendragon.ideasonboard.com (softbank126159224182.bbtec.net\n\t[126.159.224.182])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9E6CF2B2;\n\tSun, 14 Jul 2019 12:34:37 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1563100478;\n\tbh=09Mlgn7yKHipBtUF5MSZIlA7FSOFMtkU10dUxcmqLOE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CrOttfAMhsyTgaU1Uw7YzvBwkbdjFEb0nIX6KpklaoH6QRcxaae+GZ9deGJDfPaeh\n\t+Py/4/cbFhGbN8QV2C7YNQka8H9ABAWcFqK1XOxLC3z3qCUyqW9/ANg3Cl5Z2xnks9\n\twjSn9M3nNuDEItVIZY1H2KPj7YtHICzTOc2DJ254=","Date":"Sun, 14 Jul 2019 13:34:10 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190714103410.GE6043@pendragon.ideasonboard.com>","References":"<20190712201620.30457-1-paul.elder@ideasonboard.com>\n\t<20190712201620.30457-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190712201620.30457-4-paul.elder@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH 4/4] test: logging: move logging tests\n\tto a subdirectory","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sun, 14 Jul 2019 10:34:38 -0000"}}]