[{"id":24129,"web_url":"https://patchwork.libcamera.org/comment/24129/","msgid":"","date":"2022-07-25T21:03:05","subject":"Re: [libcamera-devel] [PATCH 13/15] ipa: raspberrypi: Rename header\n\tfiles from *.hpp to *.h","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 25, 2022 at 02:46:37PM +0100, Naushir Patuck via libcamera-devel wrote:\n> As per the libcamera coding guidelines, rename all .hpp header files to .h.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/cam_helper.cpp | 4 ++--\n> .../{cam_helper.hpp => cam_helper.h} | 8 ++++----\n> src/ipa/raspberrypi/cam_helper_imx219.cpp | 4 ++--\n> src/ipa/raspberrypi/cam_helper_imx290.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_imx296.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_imx477.cpp | 4 ++--\n> src/ipa/raspberrypi/cam_helper_imx519.cpp | 4 ++--\n> src/ipa/raspberrypi/cam_helper_ov5647.cpp | 2 +-\n> src/ipa/raspberrypi/cam_helper_ov9281.cpp | 2 +-\n> .../{agc_algorithm.hpp => agc_algorithm.h} | 4 ++--\n> src/ipa/raspberrypi/controller/algorithm.cpp | 2 +-\n> .../controller/{algorithm.hpp => algorithm.h} | 4 ++--\n> .../{awb_algorithm.hpp => awb_algorithm.h} | 4 ++--\n> .../{ccm_algorithm.hpp => ccm_algorithm.h} | 4 ++--\n> ...rast_algorithm.hpp => contrast_algorithm.h} | 4 ++--\n> src/ipa/raspberrypi/controller/controller.cpp | 4 ++--\n> .../{controller.hpp => controller.h} | 4 ++--\n> ...noise_algorithm.hpp => denoise_algorithm.h} | 4 ++--\n> src/ipa/raspberrypi/controller/histogram.cpp | 2 +-\n> .../controller/{histogram.hpp => histogram.h} | 2 +-\n> .../controller/{metadata.hpp => metadata.h} | 2 +-\n> src/ipa/raspberrypi/controller/pwl.cpp | 2 +-\n> .../raspberrypi/controller/{pwl.hpp => pwl.h} | 2 +-\n> src/ipa/raspberrypi/controller/rpi/agc.cpp | 6 +++---\n> .../controller/rpi/{agc.hpp => agc.h} | 6 +++---\n> src/ipa/raspberrypi/controller/rpi/alsc.cpp | 2 +-\n> .../controller/rpi/{alsc.hpp => alsc.h} | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/awb.cpp | 2 +-\n> .../controller/rpi/{awb.hpp => awb.h} | 6 +++---\n> .../raspberrypi/controller/rpi/black_level.cpp | 2 +-\n> .../rpi/{black_level.hpp => black_level.h} | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/ccm.cpp | 4 ++--\n> .../controller/rpi/{ccm.hpp => ccm.h} | 6 +++---\n> .../raspberrypi/controller/rpi/contrast.cpp | 4 ++--\n> .../rpi/{contrast.hpp => contrast.h} | 6 +++---\n> src/ipa/raspberrypi/controller/rpi/dpc.cpp | 2 +-\n> .../controller/rpi/{dpc.hpp => dpc.h} | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/focus.cpp | 2 +-\n> .../controller/rpi/{focus.hpp => focus.h} | 6 +++---\n> src/ipa/raspberrypi/controller/rpi/geq.cpp | 4 ++--\n> .../controller/rpi/{geq.hpp => geq.h} | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/lux.cpp | 2 +-\n> .../controller/rpi/{lux.hpp => lux.h} | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/noise.cpp | 2 +-\n> .../controller/rpi/{noise.hpp => noise.h} | 4 ++--\n> src/ipa/raspberrypi/controller/rpi/sdn.cpp | 2 +-\n> .../controller/rpi/{sdn.hpp => sdn.h} | 6 +++---\n> src/ipa/raspberrypi/controller/rpi/sharpen.cpp | 2 +-\n> .../controller/rpi/{sharpen.hpp => sharpen.h} | 4 ++--\n> ...arpen_algorithm.hpp => sharpen_algorithm.h} | 4 ++--\n> .../raspberrypi/{md_parser.hpp => md_parser.h} | 2 +-\n> src/ipa/raspberrypi/md_parser_smia.cpp | 2 +-\n> src/ipa/raspberrypi/raspberrypi.cpp | 18 +++++++++---------\n> 53 files changed, 101 insertions(+), 101 deletions(-)\n> rename src/ipa/raspberrypi/{cam_helper.hpp => cam_helper.h} (96%)\n> rename src/ipa/raspberrypi/controller/{agc_algorithm.hpp => agc_algorithm.h} (92%)\n> rename src/ipa/raspberrypi/controller/{algorithm.hpp => algorithm.h} (95%)\n> rename src/ipa/raspberrypi/controller/{awb_algorithm.hpp => awb_algorithm.h} (86%)\n> rename src/ipa/raspberrypi/controller/{ccm_algorithm.hpp => ccm_algorithm.h} (78%)\n> rename src/ipa/raspberrypi/controller/{contrast_algorithm.hpp => contrast_algorithm.h} (82%)\n> rename src/ipa/raspberrypi/controller/{controller.hpp => controller.h} (95%)\n> rename src/ipa/raspberrypi/controller/{denoise_algorithm.hpp => denoise_algorithm.h} (86%)\n> rename src/ipa/raspberrypi/controller/{histogram.hpp => histogram.h} (96%)\n> rename src/ipa/raspberrypi/controller/{metadata.hpp => metadata.h} (98%)\n> rename src/ipa/raspberrypi/controller/{pwl.hpp => pwl.h} (98%)\n> rename src/ipa/raspberrypi/controller/rpi/{agc.hpp => agc.h} (97%)\n> rename src/ipa/raspberrypi/controller/rpi/{alsc.hpp => alsc.h} (97%)\n> rename src/ipa/raspberrypi/controller/rpi/{awb.hpp => awb.h} (98%)\n> rename src/ipa/raspberrypi/controller/rpi/{black_level.hpp => black_level.h} (88%)\n> rename src/ipa/raspberrypi/controller/rpi/{ccm.hpp => ccm.h} (93%)\n> rename src/ipa/raspberrypi/controller/rpi/{contrast.hpp => contrast.h} (90%)\n> rename src/ipa/raspberrypi/controller/rpi/{dpc.hpp => dpc.h} (85%)\n> rename src/ipa/raspberrypi/controller/rpi/{focus.hpp => focus.h} (85%)\n> rename src/ipa/raspberrypi/controller/rpi/{geq.hpp => geq.h} (88%)\n> rename src/ipa/raspberrypi/controller/rpi/{lux.hpp => lux.h} (94%)\n> rename src/ipa/raspberrypi/controller/rpi/{noise.hpp => noise.h} (91%)\n> rename src/ipa/raspberrypi/controller/rpi/{sdn.hpp => sdn.h} (84%)\n> rename src/ipa/raspberrypi/controller/rpi/{sharpen.hpp => sharpen.h} (90%)\n> rename src/ipa/raspberrypi/controller/{sharpen_algorithm.hpp => sharpen_algorithm.h} (82%)\n> rename src/ipa/raspberrypi/{md_parser.hpp => md_parser.h} (98%)\n\n[snip]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3B1D7BE173\n\tfor ;\n\tMon, 25 Jul 2022 21:03:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 88E1463312;\n\tMon, 25 Jul 2022 23:03:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F2E986330A\n\tfor ;\n\tMon, 25 Jul 2022 23:03:09 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7593C6D1;\n\tMon, 25 Jul 2022 23:03:09 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658782991;\n\tbh=me2Nm/wV3ujP7YFOaNAdRn0NZdnY1CD9T1G2fxZbhRw=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=KSiZoE/n3/D4sjj1CGLHbiGHusX2uaX45BLQRPbXdS66RGNWGI9xkwplWJ6R+JqB+\n\tSCbjS2bCB008xrtKnUkLG1Gk6U10FkWEr/wwPLtg1W+R4UwSFZI8vd3IgwfqHTATrG\n\tIDlzner1Gk9as+ZlvLf0lVWiNgKK62nJ/1Vk/e5w9Ifl72GCacGeuGA8fbeoH8bvQ+\n\tYeGZbuEwfHASHM+u0GEhWN1ScG2wFqWmZf96hcXNNYBL25RrBAh6ZIA0iurouGtm82\n\tBzRSoXeGs1GotXSRgXJTa9JNyO/U7E8+jZWsGWnPUVse8ICZv54oTaqlzcAxyNTYmf\n\tBw97dYpDB8aqQ==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658782989;\n\tbh=me2Nm/wV3ujP7YFOaNAdRn0NZdnY1CD9T1G2fxZbhRw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=rNphhhzljqt4+zFA2llJyzgww9TERfp54wSV87IPzJhT2s8oiLwKu44qCZ1M+SVs+\n\t64MH++kdn7QMcrMl6nADMMvVa4L1gfscJZ/6QUZAnEMBuuZQ5iYZHoihypiBYgxwkY\n\ty47915GabS6Cp7xZ/u/2uB6eCgZwJnizUX0LcuNs="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"rNphhhzl\"; dkim-atps=neutral","Date":"Tue, 26 Jul 2022 00:03:05 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220725134639.4572-1-naush@raspberrypi.com>\n\t<20220725134639.4572-14-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220725134639.4572-14-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 13/15] ipa: raspberrypi: Rename header\n\tfiles from *.hpp to *.h","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]