[{"id":24128,"web_url":"https://patchwork.libcamera.org/comment/24128/","msgid":"","date":"2022-07-25T20:59:48","subject":"Re: [libcamera-devel] [PATCH 12/15] ipa: raspberrypi: Remove extern\n\t\"C\" declarations","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Mon, Jul 25, 2022 at 02:46:36PM +0100, Naushir Patuck via libcamera-devel wrote:\n> Since the controller header files are now C++ specific, remove the extern \"C\"\n> declarations.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/ipa/raspberrypi/controller/agc_status.h | 8 --------\n> src/ipa/raspberrypi/controller/alsc_status.h | 8 --------\n> src/ipa/raspberrypi/controller/awb_status.h | 8 --------\n> src/ipa/raspberrypi/controller/black_level_status.h | 8 --------\n> src/ipa/raspberrypi/controller/camera_mode.h | 8 --------\n> src/ipa/raspberrypi/controller/ccm_status.h | 8 --------\n> src/ipa/raspberrypi/controller/contrast_status.h | 8 --------\n> src/ipa/raspberrypi/controller/denoise_status.h | 8 --------\n> src/ipa/raspberrypi/controller/dpc_status.h | 8 --------\n> src/ipa/raspberrypi/controller/focus_status.h | 8 --------\n> src/ipa/raspberrypi/controller/geq_status.h | 8 --------\n> src/ipa/raspberrypi/controller/lux_status.h | 8 --------\n> src/ipa/raspberrypi/controller/noise_status.h | 8 --------\n> src/ipa/raspberrypi/controller/sharpen_status.h | 8 --------\n> 14 files changed, 112 deletions(-)\n\n[snip]","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DFF40C3275\n\tfor ;\n\tMon, 25 Jul 2022 20:59:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9F3B263312;\n\tMon, 25 Jul 2022 22:59:54 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E3F806330A\n\tfor ;\n\tMon, 25 Jul 2022 22:59:52 +0200 (CEST)","from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8051E6D1;\n\tMon, 25 Jul 2022 22:59:52 +0200 (CEST)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658782794;\n\tbh=TQA9IspxRYUwOYzsPiskwLxyMn85xYk/lCYrSrXL+AE=;\n\th=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=DYVGnmYwDGNlyiCY2siC101mYtnKUEdD+bWTztAHlSIJkwP7DabtYpGGFHhGvh1mZ\n\tYlI3cS8EmFRTUFWRsOU+NqoY54P9h+syrND7t8n3hZ2Nq2vc0hWD2kJeNY6bOlFGT7\n\tnK1ZJ3Ms43bAB3l1KNOpXNZvu0ZZKROqs//X13Caib5e8mIrx4YPwxD7JsHsEBZ3Io\n\tnvnaedja2ILEVjBbSqBrM3TZNl93g3oeo52mRdu5x0jYWcXvtTP5Mc15pbsGpie81R\n\t/LNhG7FTUq4zyyGIYXpzIskuuXv79OakNku4gb8/2GeUBvZBg0SKYReerEog+9/hOb\n\tX7Y/PXYNXhW4Q==","v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1658782792;\n\tbh=TQA9IspxRYUwOYzsPiskwLxyMn85xYk/lCYrSrXL+AE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ZvShnLW/RnFjq94BCQnX+z5yL7ojIMl1VMvc5/lAf5Ue+jCRx8v+SaOPikZNPNVNm\n\t+jZUHtZzzNDPNTos4Cl0Ym37C07tbW7b2GhDcTinir48YKklT8bB7rfstZhIJbHsNo\n\tN4kuY0eZQwxxlJSuGLA6P8cwYk4MR0FhBXIm7UpE="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ZvShnLW/\"; dkim-atps=neutral","Date":"Mon, 25 Jul 2022 23:59:48 +0300","To":"Naushir Patuck ","Message-ID":"","References":"<20220725134639.4572-1-naush@raspberrypi.com>\n\t<20220725134639.4572-13-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20220725134639.4572-13-naush@raspberrypi.com>","Subject":"Re: [libcamera-devel] [PATCH 12/15] ipa: raspberrypi: Remove extern\n\t\"C\" declarations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","From":"Laurent Pinchart via libcamera-devel\n\t","Reply-To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]