{"id":16761,"url":"https://patchwork.libcamera.org/api/patches/16761/?format=json","web_url":"https://patchwork.libcamera.org/patch/16761/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20220725134639.4572-10-naush@raspberrypi.com>","date":"2022-07-25T13:46:33","name":"[libcamera-devel,09/15] DNI: ipa: raspberrypi: Code refactoring to match style guidelines","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"279be70b3ddc9a5e11187bf7321e7698737e80cc","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/16761/mbox/","series":[{"id":3323,"url":"https://patchwork.libcamera.org/api/series/3323/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=3323","date":"2022-07-25T13:46:24","name":"Raspberry Pi IPA code refactor","version":1,"mbox":"https://patchwork.libcamera.org/series/3323/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/16761/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/16761/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 19A7AC3275\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 25 Jul 2022 13:46:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CBF2263337;\n\tMon, 25 Jul 2022 15:46:57 +0200 (CEST)","from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com\n\t[IPv6:2a00:1450:4864:20::32f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB1D963312\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Jul 2022 15:46:50 +0200 (CEST)","by mail-wm1-x32f.google.com with SMTP id c22so6845293wmr.2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 25 Jul 2022 06:46:50 -0700 (PDT)","from naush-laptop.localdomain ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\ta20-20020a05600c225400b003a32167b8d4sm18054320wmm.13.2022.07.25.06.46.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 25 Jul 2022 06:46:49 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1658756817;\n\tbh=WHnM8TPLzraBE43FpWqrh7uVJNUI/so3kLJP5VUTziw=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=Kvlpi0qa0EV5Xnwas8GnsLcKHJ+CuuyubbdnuFZEjb9nYUi1y+iTFrWyqjKOFHiFT\n\tvugOdEpx9mkzJ7niMU7LXaQ2gfJRrCIv1PbTU3g40edvxS//r5paUg+gnu/0RgpZO3\n\trFHltLUh3h8ClxQH8h0Uj8JRL3sO1h96BJ6c1dV83gl0y8LhTVYpRkT9a9bAETpIRQ\n\tNWGUeOflCz4vTwRXarkSYGBSMYUZzyX7n8ZF5G0yd9084E42cSB6PAP+5BZ3dVNIHV\n\tQQY2uTo6uMLn7UfvTtVLpbyES3bFs2PZH+4Ik1+273XhjOeJkoLES30jwm0mtASRnk\n\t9ahv5ynIsJauA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=mRuHQylAIUqDyu1vrkwOYAhAxvgWIUxwRbLiL3bvAI8=;\n\tb=NEOZjNGHMFoz6TiYEpTgNrOx0Vik+5lZMa00R2Leqfwk0ykv03CNcVXVfCHwNeP8p1\n\tlRDdGKqBxD1t9dn4TGl1FVqH2Rx1lpXg2bWBVWv1KfZmTcw3aXdUU9CsKV21PTtu6uQl\n\tIe8M7bYgWvnn7vuPSXDDj0sYqDSIWFTQC3bHI3llE5NC8mKsE0Fr9AyTHDLEzIbcEWt9\n\tm31qDyj5Xg2lbdSdW6//w5gHgMMhTzC7hh3+YwXo8hBvOQIkGtKPQLGlcBaWFgELEAQH\n\ttckHDHxz66esbQgPWs7cx0VuVbKKL1svGkgGo/5Z03pUe1/J/RvATjzxdbVK1eMXWjvb\n\tFK+w=="],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"NEOZjNGH\"; dkim-atps=neutral","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=mRuHQylAIUqDyu1vrkwOYAhAxvgWIUxwRbLiL3bvAI8=;\n\tb=fvf5IajvisystJEF2NEyKami6jMr/q+v5ZaJFBKnGc6iZjcCj7/BD5XL9f/rziz2UV\n\tQ4rlNXXK5kV869rlWxlOcWP9X2O8tkYgfyzjQtJRGTeL4ba3k70pniNZ5y3YovofR3dJ\n\tyKQ1dS7FQ6+Bamx/1/2qH9VtQ/I46f2NBnNs4pjkESQrr/LhyoguKCpN3Ad2zxFzkv0s\n\t8SlXQx8gEAJGLfRkm1JdNT0xGdItUQ+mFQju/CD1sV45IWcaThG/VB1+35n/1F249Jac\n\tVkPKRvtVbjKw+Ar5rq0gXpyApSZiLn1RLg8lkqDjodaq7+vXXMZ7Hd2NcT7Ca+uRxavZ\n\tJp3w==","X-Gm-Message-State":"AJIora9Zcg1oEVKSsEuYHr98TQAOhyjqiQ0viEaeEVpcXRbazAZT0kmA\n\txvbrrKZSD01jWu0OD9bqfllRrBniUAhLtA==","X-Google-Smtp-Source":"AGRyM1u3lcLEwK6iLhV0e6baSc1lNAFSq9ZISY4FH7VviGQCWVQC/XLjUK2zJhFsga/RdsRjlH1MlA==","X-Received":"by 2002:a05:600c:17d5:b0:3a3:576:21ba with SMTP id\n\ty21-20020a05600c17d500b003a3057621bamr8390541wmo.176.1658756810036; \n\tMon, 25 Jul 2022 06:46:50 -0700 (PDT)","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 25 Jul 2022 14:46:33 +0100","Message-Id":"<20220725134639.4572-10-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20220725134639.4572-1-naush@raspberrypi.com>","References":"<20220725134639.4572-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 09/15] DNI: ipa: raspberrypi: Code\n\trefactoring to match style guidelines","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","From":"Naushir Patuck via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>","Reply-To":"Naushir Patuck <naush@raspberrypi.com>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Refactor the source files src/ipa/raspberrypi/controller/rps/[f|g|l]* to match the\nrecommended formatting guidelines for the libcamera project. The vast majority\nof changes in this commit comprise of switching from snake_case to CamelCase,\nand starting class member functions with a lower case character.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/focus.cpp | 14 ++--\n src/ipa/raspberrypi/controller/rpi/focus.hpp |  4 +-\n src/ipa/raspberrypi/controller/rpi/geq.cpp   | 48 +++++++-------\n src/ipa/raspberrypi/controller/rpi/geq.hpp   |  6 +-\n src/ipa/raspberrypi/controller/rpi/lux.cpp   | 70 ++++++++++----------\n src/ipa/raspberrypi/controller/rpi/lux.hpp   | 22 +++---\n 6 files changed, 81 insertions(+), 83 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/focus.cpp b/src/ipa/raspberrypi/controller/rpi/focus.cpp\nindex a87ec802b964..90f36e58f28c 100644\n--- a/src/ipa/raspberrypi/controller/rpi/focus.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/focus.cpp\n@@ -23,28 +23,28 @@ Focus::Focus(Controller *controller)\n {\n }\n \n-char const *Focus::Name() const\n+char const *Focus::name() const\n {\n \treturn NAME;\n }\n \n-void Focus::Process(StatisticsPtr &stats, Metadata *image_metadata)\n+void Focus::process(StatisticsPtr &stats, Metadata *imageMetadata)\n {\n \tFocusStatus status;\n \tunsigned int i;\n \tfor (i = 0; i < FOCUS_REGIONS; i++)\n-\t\tstatus.focus_measures[i] = stats->focus_stats[i].contrast_val[1][1] / 1000;\n+\t\tstatus.focusMeasures[i] = stats->focus_stats[i].contrast_val[1][1] / 1000;\n \tstatus.num = i;\n-\timage_metadata->Set(\"focus.status\", status);\n+\timageMetadata->set(\"focus.status\", status);\n \n \tLOG(RPiFocus, Debug)\n \t\t<< \"Focus contrast measure: \"\n-\t\t<< (status.focus_measures[5] + status.focus_measures[6]) / 10;\n+\t\t<< (status.focusMeasures[5] + status.focusMeasures[6]) / 10;\n }\n \n /* Register algorithm with the system. */\n-static Algorithm *Create(Controller *controller)\n+static Algorithm *create(Controller *controller)\n {\n \treturn new Focus(controller);\n }\n-static RegisterAlgorithm reg(NAME, &Create);\n+static RegisterAlgorithm reg(NAME, &create);\ndiff --git a/src/ipa/raspberrypi/controller/rpi/focus.hpp b/src/ipa/raspberrypi/controller/rpi/focus.hpp\nindex 131b1d0f2fbf..a9207eb3cc23 100644\n--- a/src/ipa/raspberrypi/controller/rpi/focus.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/focus.hpp\n@@ -21,8 +21,8 @@ class Focus : public Algorithm\n {\n public:\n \tFocus(Controller *controller);\n-\tchar const *Name() const override;\n-\tvoid Process(StatisticsPtr &stats, Metadata *image_metadata) override;\n+\tchar const *name() const override;\n+\tvoid process(StatisticsPtr &stats, Metadata *imageMetadata) override;\n };\n \n } /* namespace RPiController */\ndiff --git a/src/ipa/raspberrypi/controller/rpi/geq.cpp b/src/ipa/raspberrypi/controller/rpi/geq.cpp\nindex 4530cb75792c..0da5efdf3d3d 100644\n--- a/src/ipa/raspberrypi/controller/rpi/geq.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/geq.cpp\n@@ -28,54 +28,52 @@ Geq::Geq(Controller *controller)\n {\n }\n \n-char const *Geq::Name() const\n+char const *Geq::name() const\n {\n \treturn NAME;\n }\n \n-void Geq::Read(boost::property_tree::ptree const &params)\n+void Geq::read(boost::property_tree::ptree const &params)\n {\n \tconfig_.offset = params.get<uint16_t>(\"offset\", 0);\n \tconfig_.slope = params.get<double>(\"slope\", 0.0);\n \tif (config_.slope < 0.0 || config_.slope >= 1.0)\n \t\tthrow std::runtime_error(\"Geq: bad slope value\");\n \tif (params.get_child_optional(\"strength\"))\n-\t\tconfig_.strength.Read(params.get_child(\"strength\"));\n+\t\tconfig_.strength.read(params.get_child(\"strength\"));\n }\n \n-void Geq::Prepare(Metadata *image_metadata)\n+void Geq::prepare(Metadata *imageMetadata)\n {\n-\tLuxStatus lux_status = {};\n-\tlux_status.lux = 400;\n-\tif (image_metadata->Get(\"lux.status\", lux_status))\n+\tLuxStatus luxStatus = {};\n+\tluxStatus.lux = 400;\n+\tif (imageMetadata->get(\"lux.status\", luxStatus))\n \t\tLOG(RPiGeq, Warning) << \"no lux data found\";\n-\tDeviceStatus device_status;\n-\tdevice_status.analogue_gain = 1.0; // in case not found\n-\tif (image_metadata->Get(\"device.status\", device_status))\n+\tDeviceStatus deviceStatus;\n+\tdeviceStatus.analogueGain = 1.0; // in case not found\n+\tif (imageMetadata->get(\"device.status\", deviceStatus))\n \t\tLOG(RPiGeq, Warning)\n \t\t\t<< \"no device metadata - use analogue gain of 1x\";\n-\tGeqStatus geq_status = {};\n-\tdouble strength =\n-\t\tconfig_.strength.Empty()\n+\tGeqStatus geqStatus = {};\n+\tdouble strength = config_.strength.empty()\n \t\t\t? 1.0\n-\t\t\t: config_.strength.Eval(config_.strength.Domain().Clip(\n-\t\t\t\t  lux_status.lux));\n-\tstrength *= device_status.analogue_gain;\n+\t\t\t: config_.strength.eval(config_.strength.domain().clip(luxStatus.lux));\n+\tstrength *= deviceStatus.analogueGain;\n \tdouble offset = config_.offset * strength;\n \tdouble slope = config_.slope * strength;\n-\tgeq_status.offset = std::min(65535.0, std::max(0.0, offset));\n-\tgeq_status.slope = std::min(.99999, std::max(0.0, slope));\n+\tgeqStatus.offset = std::min(65535.0, std::max(0.0, offset));\n+\tgeqStatus.slope = std::min(.99999, std::max(0.0, slope));\n \tLOG(RPiGeq, Debug)\n-\t\t<< \"offset \" << geq_status.offset << \" slope \"\n-\t\t<< geq_status.slope << \" (analogue gain \"\n-\t\t<< device_status.analogue_gain << \" lux \"\n-\t\t<< lux_status.lux << \")\";\n-\timage_metadata->Set(\"geq.status\", geq_status);\n+\t\t<< \"offset \" << geqStatus.offset << \" slope \"\n+\t\t<< geqStatus.slope << \" (analogue gain \"\n+\t\t<< deviceStatus.analogueGain << \" lux \"\n+\t\t<< luxStatus.lux << \")\";\n+\timageMetadata->set(\"geq.status\", geqStatus);\n }\n \n // Register algorithm with the system.\n-static Algorithm *Create(Controller *controller)\n+static Algorithm *create(Controller *controller)\n {\n \treturn (Algorithm *)new Geq(controller);\n }\n-static RegisterAlgorithm reg(NAME, &Create);\n+static RegisterAlgorithm reg(NAME, &create);\ndiff --git a/src/ipa/raspberrypi/controller/rpi/geq.hpp b/src/ipa/raspberrypi/controller/rpi/geq.hpp\nindex 8ba3046b2a2b..bdbc55b2e2d9 100644\n--- a/src/ipa/raspberrypi/controller/rpi/geq.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/geq.hpp\n@@ -23,9 +23,9 @@ class Geq : public Algorithm\n {\n public:\n \tGeq(Controller *controller);\n-\tchar const *Name() const override;\n-\tvoid Read(boost::property_tree::ptree const &params) override;\n-\tvoid Prepare(Metadata *image_metadata) override;\n+\tchar const *name() const override;\n+\tvoid read(boost::property_tree::ptree const &params) override;\n+\tvoid prepare(Metadata *imageMetadata) override;\n \n private:\n \tGeqConfig config_;\ndiff --git a/src/ipa/raspberrypi/controller/rpi/lux.cpp b/src/ipa/raspberrypi/controller/rpi/lux.cpp\nindex 4d145b6ff0e9..10654fbba94a 100644\n--- a/src/ipa/raspberrypi/controller/rpi/lux.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/lux.cpp\n@@ -31,74 +31,74 @@ Lux::Lux(Controller *controller)\n \tstatus_.lux = 400;\n }\n \n-char const *Lux::Name() const\n+char const *Lux::name() const\n {\n \treturn NAME;\n }\n \n-void Lux::Read(boost::property_tree::ptree const &params)\n+void Lux::read(boost::property_tree::ptree const &params)\n {\n-\treference_shutter_speed_ =\n+\treferenceshutterSpeed_ =\n \t\tparams.get<double>(\"reference_shutter_speed\") * 1.0us;\n-\treference_gain_ = params.get<double>(\"reference_gain\");\n-\treference_aperture_ = params.get<double>(\"reference_aperture\", 1.0);\n-\treference_Y_ = params.get<double>(\"reference_Y\");\n-\treference_lux_ = params.get<double>(\"reference_lux\");\n-\tcurrent_aperture_ = reference_aperture_;\n+\treferenceGain_ = params.get<double>(\"reference_gain\");\n+\treferenceAperture_ = params.get<double>(\"reference_aperture\", 1.0);\n+\treferenceY_ = params.get<double>(\"reference_Y\");\n+\treferenceLux_ = params.get<double>(\"reference_lux\");\n+\tcurrentAperture_ = referenceAperture_;\n }\n \n-void Lux::SetCurrentAperture(double aperture)\n+void Lux::setCurrentAperture(double aperture)\n {\n-\tcurrent_aperture_ = aperture;\n+\tcurrentAperture_ = aperture;\n }\n \n-void Lux::Prepare(Metadata *image_metadata)\n+void Lux::prepare(Metadata *imageMetadata)\n {\n \tstd::unique_lock<std::mutex> lock(mutex_);\n-\timage_metadata->Set(\"lux.status\", status_);\n+\timageMetadata->set(\"lux.status\", status_);\n }\n \n-void Lux::Process(StatisticsPtr &stats, Metadata *image_metadata)\n+void Lux::process(StatisticsPtr &stats, Metadata *imageMetadata)\n {\n-\tDeviceStatus device_status;\n-\tif (image_metadata->Get(\"device.status\", device_status) == 0) {\n-\t\tdouble current_gain = device_status.analogue_gain;\n-\t\tdouble current_aperture = device_status.aperture.value_or(current_aperture_);\n+\tDeviceStatus deviceStatus;\n+\tif (imageMetadata->get(\"device.status\", deviceStatus) == 0) {\n+\t\tdouble currentGain = deviceStatus.analogueGain;\n+\t\tdouble currentAperture = deviceStatus.aperture.value_or(currentAperture_);\n \t\tuint64_t sum = 0;\n \t\tuint32_t num = 0;\n \t\tuint32_t *bin = stats->hist[0].g_hist;\n-\t\tconst int num_bins = sizeof(stats->hist[0].g_hist) /\n-\t\t\t\t     sizeof(stats->hist[0].g_hist[0]);\n-\t\tfor (int i = 0; i < num_bins; i++)\n+\t\tconst int numBins = sizeof(stats->hist[0].g_hist) /\n+\t\t\t\t    sizeof(stats->hist[0].g_hist[0]);\n+\t\tfor (int i = 0; i < numBins; i++)\n \t\t\tsum += bin[i] * (uint64_t)i, num += bin[i];\n \t\t// add .5 to reflect the mid-points of bins\n-\t\tdouble current_Y = sum / (double)num + .5;\n-\t\tdouble gain_ratio = reference_gain_ / current_gain;\n-\t\tdouble shutter_speed_ratio =\n-\t\t\treference_shutter_speed_ / device_status.shutter_speed;\n-\t\tdouble aperture_ratio = reference_aperture_ / current_aperture;\n-\t\tdouble Y_ratio = current_Y * (65536 / num_bins) / reference_Y_;\n-\t\tdouble estimated_lux = shutter_speed_ratio * gain_ratio *\n-\t\t\t\t       aperture_ratio * aperture_ratio *\n-\t\t\t\t       Y_ratio * reference_lux_;\n+\t\tdouble currentY = sum / (double)num + .5;\n+\t\tdouble gainRatio = referenceGain_ / currentGain;\n+\t\tdouble shutterSpeedRatio =\n+\t\t\treferenceshutterSpeed_ / deviceStatus.shutterSpeed;\n+\t\tdouble apertureRatio = referenceAperture_ / currentAperture;\n+\t\tdouble yRatio = currentY * (65536 / numBins) / referenceY_;\n+\t\tdouble estimatedLux = shutterSpeedRatio * gainRatio *\n+\t\t\t\t      apertureRatio * apertureRatio *\n+\t\t\t\t      yRatio * referenceLux_;\n \t\tLuxStatus status;\n-\t\tstatus.lux = estimated_lux;\n-\t\tstatus.aperture = current_aperture;\n-\t\tLOG(RPiLux, Debug) << \": estimated lux \" << estimated_lux;\n+\t\tstatus.lux = estimatedLux;\n+\t\tstatus.aperture = currentAperture;\n+\t\tLOG(RPiLux, Debug) << \": estimated lux \" << estimatedLux;\n \t\t{\n \t\t\tstd::unique_lock<std::mutex> lock(mutex_);\n \t\t\tstatus_ = status;\n \t\t}\n \t\t// Overwrite the metadata here as well, so that downstream\n \t\t// algorithms get the latest value.\n-\t\timage_metadata->Set(\"lux.status\", status);\n+\t\timageMetadata->set(\"lux.status\", status);\n \t} else\n \t\tLOG(RPiLux, Warning) << \": no device metadata\";\n }\n \n // Register algorithm with the system.\n-static Algorithm *Create(Controller *controller)\n+static Algorithm *create(Controller *controller)\n {\n \treturn (Algorithm *)new Lux(controller);\n }\n-static RegisterAlgorithm reg(NAME, &Create);\n+static RegisterAlgorithm reg(NAME, &create);\ndiff --git a/src/ipa/raspberrypi/controller/rpi/lux.hpp b/src/ipa/raspberrypi/controller/rpi/lux.hpp\nindex 3ebd35d1e382..98cfd0ac8bd0 100644\n--- a/src/ipa/raspberrypi/controller/rpi/lux.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/lux.hpp\n@@ -21,21 +21,21 @@ class Lux : public Algorithm\n {\n public:\n \tLux(Controller *controller);\n-\tchar const *Name() const override;\n-\tvoid Read(boost::property_tree::ptree const &params) override;\n-\tvoid Prepare(Metadata *image_metadata) override;\n-\tvoid Process(StatisticsPtr &stats, Metadata *image_metadata) override;\n-\tvoid SetCurrentAperture(double aperture);\n+\tchar const *name() const override;\n+\tvoid read(boost::property_tree::ptree const &params) override;\n+\tvoid prepare(Metadata *imageMetadata) override;\n+\tvoid process(StatisticsPtr &stats, Metadata *imageMetadata) override;\n+\tvoid setCurrentAperture(double aperture);\n \n private:\n \t// These values define the conditions of the reference image, against\n \t// which we compare the new image.\n-\tlibcamera::utils::Duration reference_shutter_speed_;\n-\tdouble reference_gain_;\n-\tdouble reference_aperture_; // units of 1/f\n-\tdouble reference_Y_; // out of 65536\n-\tdouble reference_lux_;\n-\tdouble current_aperture_;\n+\tlibcamera::utils::Duration referenceshutterSpeed_;\n+\tdouble referenceGain_;\n+\tdouble referenceAperture_; // units of 1/f\n+\tdouble referenceY_; // out of 65536\n+\tdouble referenceLux_;\n+\tdouble currentAperture_;\n \tLuxStatus status_;\n \tstd::mutex mutex_;\n };\n","prefixes":["libcamera-devel","09/15"]}